[PR] KAFKA-10199: Remove lost tasks in state updater with new remove [kafka]

2024-05-06 Thread via GitHub
cadonna opened a new pull request, #15867: URL: https://github.com/apache/kafka/pull/15867 Uses the new remove operation of the state updater that returns a future to remove lost tasks from the state udpater. *More detailed description of your change, if necessary. The PR title an

Re: [PR] KAFKA-16484: Support to define per broker/controller property by ClusterConfigProperty [kafka]

2024-05-06 Thread via GitHub
chia7712 commented on code in PR #15715: URL: https://github.com/apache/kafka/pull/15715#discussion_r1590605162 ## core/src/test/java/kafka/test/junit/ClusterTestExtensions.java: ## @@ -143,11 +143,12 @@ private void processClusterTest(ExtensionContext context, ClusterTest anno

Re: [PR] MINOR: Replaced Utils.join() with JDK API. [kafka]

2024-05-06 Thread via GitHub
chia7712 commented on PR #15823: URL: https://github.com/apache/kafka/pull/15823#issuecomment-2095332052 ``` ./gradlew cleanTest :tools:test --tests MetadataQuorumCommandTest.testDescribeQuorumReplicationSuccessful :storage:test --tests TransactionsWithTieredStoreTest.testFailureToFenceE

Re: [PR] MINOR: Replaced Utils.join() with JDK API. [kafka]

2024-05-06 Thread via GitHub
chia7712 merged PR #15823: URL: https://github.com/apache/kafka/pull/15823 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[jira] [Created] (KAFKA-16671) Revisit SessionedProtocolIntegrationTest.ensureInternalEndpointIsSecured

2024-05-06 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-16671: -- Summary: Revisit SessionedProtocolIntegrationTest.ensureInternalEndpointIsSecured Key: KAFKA-16671 URL: https://issues.apache.org/jira/browse/KAFKA-16671 Project:

[PR] MINOR: enable test for ensureInternalEndpointIsSecured [kafka]

2024-05-06 Thread via GitHub
FrankYang0529 opened a new pull request, #15868: URL: https://github.com/apache/kafka/pull/15868 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of t

Re: [PR] [1/N] ConfigCommandTest rewritten in java [kafka]

2024-05-06 Thread via GitHub
nizhikov commented on PR #15850: URL: https://github.com/apache/kafka/pull/15850#issuecomment-2095407751 CI looks OK @chia7712 Do you have any other comments? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[jira] [Created] (KAFKA-16672) Fix flaky DedicatedMirrorIntegrationTest.testMultiNodeCluster

2024-05-06 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-16672: -- Summary: Fix flaky DedicatedMirrorIntegrationTest.testMultiNodeCluster Key: KAFKA-16672 URL: https://issues.apache.org/jira/browse/KAFKA-16672 Project: Kafka

[jira] [Updated] (KAFKA-16672) Fix flaky DedicatedMirrorIntegrationTest.testMultiNodeCluster

2024-05-06 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16672?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated KAFKA-16672: --- Description: It is flaky on my jenkins, and sometimes it fails in Kafka CI[0] The error hap

Re: [PR] [1/N] ConfigCommandTest rewritten in java [kafka]

2024-05-06 Thread via GitHub
chia7712 commented on code in PR #15850: URL: https://github.com/apache/kafka/pull/15850#discussion_r1590709330 ## core/src/test/java/kafka/admin/ConfigCommandUnitTest.java: ## @@ -0,0 +1,421 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contr

[PR] added logic to avoid unneeded subscription regex check [kafka]

2024-05-06 Thread via GitHub
Phuc-Hong-Tran opened a new pull request, #15869: URL: https://github.com/apache/kafka/pull/15869 *Added `mirroredMetadataUpdateVersion` field to AsyncKafkaConsumer to act as reference to check whether metadata has been updated or not. -- This is an automated message from the Apache G

Re: [PR] [1/N] ConfigCommandTest rewritten in java [kafka]

2024-05-06 Thread via GitHub
nizhikov commented on code in PR #15850: URL: https://github.com/apache/kafka/pull/15850#discussion_r1590734676 ## core/src/test/java/kafka/admin/ConfigCommandUnitTest.java: ## @@ -0,0 +1,421 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contr

Re: [PR] [1/N] ConfigCommandTest rewritten in java [kafka]

2024-05-06 Thread via GitHub
nizhikov commented on code in PR #15850: URL: https://github.com/apache/kafka/pull/15850#discussion_r1590734676 ## core/src/test/java/kafka/admin/ConfigCommandUnitTest.java: ## @@ -0,0 +1,421 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contr

Re: [PR] KAFKA-16399: Add JBOD support in tiered storage [kafka]

2024-05-06 Thread via GitHub
kamalcph commented on code in PR #15690: URL: https://github.com/apache/kafka/pull/15690#discussion_r1590749298 ## storage/src/test/java/org/apache/kafka/tiered/storage/utils/TieredStorageTestUtils.java: ## @@ -55,7 +57,7 @@ public class TieredStorageTestUtils { // Log cl

Re: [PR] KAFKA-10199: Add remove operation with future to state updater [kafka]

2024-05-06 Thread via GitHub
lucasbru commented on code in PR #15852: URL: https://github.com/apache/kafka/pull/15852#discussion_r1590751522 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/StateUpdater.java: ## @@ -103,6 +149,17 @@ public String toString() { */ void remove(f

Re: [PR] KAFKA-10199: Add remove operation with future to state updater [kafka]

2024-05-06 Thread via GitHub
lucasbru commented on code in PR #15852: URL: https://github.com/apache/kafka/pull/15852#discussion_r1590752878 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/DefaultStateUpdater.java: ## @@ -506,16 +506,14 @@ private void addTask(final Task task) {

Re: [PR] KAFKA-10199: Add remove operation with future to state updater [kafka]

2024-05-06 Thread via GitHub
cadonna commented on code in PR #15852: URL: https://github.com/apache/kafka/pull/15852#discussion_r1590755586 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/DefaultStateUpdater.java: ## @@ -506,16 +506,14 @@ private void addTask(final Task task) {

Re: [PR] KAFKA-10199: Add remove operation with future to state updater [kafka]

2024-05-06 Thread via GitHub
cadonna merged PR #15852: URL: https://github.com/apache/kafka/pull/15852 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

Re: [PR] KAFKA-16399: Add JBOD support in tiered storage [kafka]

2024-05-06 Thread via GitHub
kamalcph commented on code in PR #15690: URL: https://github.com/apache/kafka/pull/15690#discussion_r1590762158 ## storage/src/test/java/org/apache/kafka/tiered/storage/integration/AlterLogDirTest.java: ## @@ -0,0 +1,73 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] KAFKA-16399: Add JBOD support in tiered storage [kafka]

2024-05-06 Thread via GitHub
kamalcph commented on code in PR #15690: URL: https://github.com/apache/kafka/pull/15690#discussion_r1590764089 ## storage/src/test/java/org/apache/kafka/tiered/storage/utils/TieredStorageTestUtils.java: ## @@ -55,7 +57,7 @@ public class TieredStorageTestUtils { // Log cl

[PR] KAFKA-10199: Remove lost tasks in state updater with new remove [kafka]

2024-05-06 Thread via GitHub
cadonna opened a new pull request, #15870: URL: https://github.com/apache/kafka/pull/15870 Uses the new remove operation of the state updater that returns a future to remove lost tasks from the state udpater. ### Committer Checklist (excluded from commit message) - [ ] Verify desig

Re: [PR] KAFKA-16399: Add JBOD support in tiered storage [kafka]

2024-05-06 Thread via GitHub
kamalcph commented on code in PR #15690: URL: https://github.com/apache/kafka/pull/15690#discussion_r1590764089 ## storage/src/test/java/org/apache/kafka/tiered/storage/utils/TieredStorageTestUtils.java: ## @@ -55,7 +57,7 @@ public class TieredStorageTestUtils { // Log cl

Re: [PR] KAFKA-16399: Add JBOD support in tiered storage [kafka]

2024-05-06 Thread via GitHub
kamalcph commented on code in PR #15690: URL: https://github.com/apache/kafka/pull/15690#discussion_r1590764089 ## storage/src/test/java/org/apache/kafka/tiered/storage/utils/TieredStorageTestUtils.java: ## @@ -55,7 +57,7 @@ public class TieredStorageTestUtils { // Log cl

[PR] KAFKA-10199: Revoke tasks from state updater with new remove [kafka]

2024-05-06 Thread via GitHub
cadonna opened a new pull request, #15871: URL: https://github.com/apache/kafka/pull/15871 Uses the new remove operation of the state updater that returns a future to remove revoked tasks from the state udpater. ### Committer Checklist (excluded from commit message) - [ ] Verify

Re: [PR] KAFKA-10199: Remove lost tasks in state updater with new remove [kafka]

2024-05-06 Thread via GitHub
cadonna closed pull request #15867: KAFKA-10199: Remove lost tasks in state updater with new remove URL: https://github.com/apache/kafka/pull/15867 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

Re: [PR] [1/N] ConfigCommandTest rewritten in java [kafka]

2024-05-06 Thread via GitHub
chia7712 commented on code in PR #15850: URL: https://github.com/apache/kafka/pull/15850#discussion_r1590791878 ## core/src/test/java/kafka/admin/ConfigCommandUnitTest.java: ## @@ -0,0 +1,421 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contr

Re: [PR] MINOR: enable test for ensureInternalEndpointIsSecured [kafka]

2024-05-06 Thread via GitHub
chia7712 commented on PR #15868: URL: https://github.com/apache/kafka/pull/15868#issuecomment-2095618948 @FrankYang0529 please fix the build error -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] [1/N] ConfigCommandTest rewritten in java [kafka]

2024-05-06 Thread via GitHub
nizhikov commented on code in PR #15850: URL: https://github.com/apache/kafka/pull/15850#discussion_r1590805333 ## core/src/test/java/kafka/admin/ConfigCommandUnitTest.java: ## @@ -0,0 +1,421 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contr

[PR] MINOR: use classic consumer with ZK mode for DeleteOffsetsConsumerGroupCommandIntegrationTest [kafka]

2024-05-06 Thread via GitHub
FrankYang0529 opened a new pull request, #15872: URL: https://github.com/apache/kafka/pull/15872 Ref: https://github.com/apache/kafka/pull/15766#discussion_r1585460093 Add ZK mode with classic consumer back to DeleteOffsetsConsumerGroupCommandIntegrationTest. ### Committer Chec

Re: [PR] [1/N] ConfigCommandTest rewritten in java [kafka]

2024-05-06 Thread via GitHub
chia7712 merged PR #15850: URL: https://github.com/apache/kafka/pull/15850 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-16399: Add JBOD support in tiered storage [kafka]

2024-05-06 Thread via GitHub
satishd commented on code in PR #15690: URL: https://github.com/apache/kafka/pull/15690#discussion_r1590586656 ## storage/src/test/java/org/apache/kafka/tiered/storage/utils/TieredStorageTestUtils.java: ## @@ -55,7 +57,7 @@ public class TieredStorageTestUtils { // Log cle

Re: [PR] KAFKA-16399: Add JBOD support in tiered storage [kafka]

2024-05-06 Thread via GitHub
satishd commented on code in PR #15690: URL: https://github.com/apache/kafka/pull/15690#discussion_r1590586656 ## storage/src/test/java/org/apache/kafka/tiered/storage/utils/TieredStorageTestUtils.java: ## @@ -55,7 +57,7 @@ public class TieredStorageTestUtils { // Log cle

Re: [PR] KAFKA-8721: Kafka metrics improvements [kafka]

2024-05-06 Thread via GitHub
jsto commented on PR #7121: URL: https://github.com/apache/kafka/pull/7121#issuecomment-2095734292 Hello. We are also being flagged with metrics-core EOL. Do we have any update on this task? -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] MINOR: use classic consumer with ZK mode for DeleteOffsetsConsumerGroupCommandIntegrationTest [kafka]

2024-05-06 Thread via GitHub
chia7712 commented on PR #15872: URL: https://github.com/apache/kafka/pull/15872#issuecomment-2095735857 Maybe we should merge `DeleteOffsetsConsumerGroupCommandIntegrationTest` and `DeleteConsumerGroupsTest`. They are used to test delete-related commands. -- This is an automated message

Re: [PR] MINOR: use classic consumer with ZK mode for DeleteOffsetsConsumerGroupCommandIntegrationTest [kafka]

2024-05-06 Thread via GitHub
chia7712 commented on code in PR #15872: URL: https://github.com/apache/kafka/pull/15872#discussion_r1590841207 ## tools/src/test/java/org/apache/kafka/tools/consumer/group/DeleteOffsetsConsumerGroupCommandIntegrationTest.java: ## @@ -88,7 +113,7 @@ public void testDeleteOffsets

Re: [PR] KAFKA-16393 read/write sequence of buffers correctly [kafka]

2024-05-06 Thread via GitHub
chia7712 merged PR #15571: URL: https://github.com/apache/kafka/pull/15571 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[jira] [Resolved] (KAFKA-16393) SslTransportLayer doesn't implement write(ByteBuffer[], int, int) correctly

2024-05-06 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16393?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-16393. Fix Version/s: 3.8.0 Resolution: Fixed > SslTransportLayer doesn't implement write(

[PR] KAFKA-14588 [2/N] ConfigCommandTest rewritten in java [kafka]

2024-05-06 Thread via GitHub
nizhikov opened a new pull request, #15873: URL: https://github.com/apache/kafka/pull/15873 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of testin

Re: [PR] KAFKA-16593: Rewrite DeleteConsumerGroupsTest by ClusterTestExtensions [kafka]

2024-05-06 Thread via GitHub
chia7712 commented on code in PR #15766: URL: https://github.com/apache/kafka/pull/15766#discussion_r1590911279 ## core/src/test/java/kafka/test/ClusterTestExtensionsTest.java: ## @@ -108,12 +117,12 @@ public void testClusterTests() { } @ClusterTests({ -@Clus

Re: [PR] MINOR: Remove `ConsumerGroupPartitionMetadataValue.Epoch` field [kafka]

2024-05-06 Thread via GitHub
dajac merged PR #15854: URL: https://github.com/apache/kafka/pull/15854 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

Re: [PR] Kafka-16668: improve cluster test [kafka]

2024-05-06 Thread via GitHub
johnnychhsu commented on code in PR #15861: URL: https://github.com/apache/kafka/pull/15861#discussion_r1590940053 ## core/src/test/java/kafka/test/ClusterConfig.java: ## @@ -83,6 +81,7 @@ private ClusterConfig(Type type, int brokers, int controllers, int disksPerBroke

Re: [PR] Kafka-16668: improve cluster test [kafka]

2024-05-06 Thread via GitHub
johnnychhsu commented on code in PR #15861: URL: https://github.com/apache/kafka/pull/15861#discussion_r1590943709 ## core/src/test/java/kafka/test/annotation/ClusterTest.java: ## @@ -44,4 +44,5 @@ String listener() default ""; MetadataVersion metadataVersion() default

[PR] MINOR: Remove dev_version parameter from streams tests [kafka]

2024-05-06 Thread via GitHub
lucasbru opened a new pull request, #15874: URL: https://github.com/apache/kafka/pull/15874 In two streams tests, we are using the current snapshot version as a test parameter `to_version`, but as the only option. We can hardcode it. This simplifies testing downstream, since the test parame

[PR] MINOR: Correct connector scheduled rebalance logs [kafka]

2024-05-06 Thread via GitHub
yuz10 opened a new pull request, #15875: URL: https://github.com/apache/kafka/pull/15875 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of testing s

Re: [PR] John confluent unclean recovery elect leader request [kafka]

2024-05-06 Thread via GitHub
mannoopj commented on PR #15876: URL: https://github.com/apache/kafka/pull/15876#issuecomment-2096008537 WIP -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] KAFKA-16615: JoinGroup API for upgrading ConsumerGroup [kafka]

2024-05-06 Thread via GitHub
dajac commented on code in PR #15798: URL: https://github.com/apache/kafka/pull/15798#discussion_r1590935155 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/CurrentAssignmentBuilder.java: ## @@ -203,6 +189,22 @@ public ConsumerGroupMember build() {

Re: [PR] Kafka-16668: improve cluster test [kafka]

2024-05-06 Thread via GitHub
johnnychhsu commented on PR #15861: URL: https://github.com/apache/kafka/pull/15861#issuecomment-2096037200 updated and `./gradlew clean core:test --tests ClusterTestExtensionsTest --tests ClusterConfigTest` passed -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] KAFKA-16637: AsyncKafkaConsumer removes offset fetch responses from cache too aggressively [kafka]

2024-05-06 Thread via GitHub
lianetm commented on code in PR #15844: URL: https://github.com/apache/kafka/pull/15844#discussion_r1591065112 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java: ## @@ -1145,14 +1141,42 @@ private CompletableFuture> addOffsetFetch

[jira] [Created] (KAFKA-16673) Optimize toTopicPartitions with ConsumerProtocolSubscription

2024-05-06 Thread Dongnuo Lyu (Jira)
Dongnuo Lyu created KAFKA-16673: --- Summary: Optimize toTopicPartitions with ConsumerProtocolSubscription Key: KAFKA-16673 URL: https://issues.apache.org/jira/browse/KAFKA-16673 Project: Kafka I

Re: [PR] KAFKA-16637: AsyncKafkaConsumer removes offset fetch responses from cache too aggressively [kafka]

2024-05-06 Thread via GitHub
lianetm commented on PR #15844: URL: https://github.com/apache/kafka/pull/15844#issuecomment-2096155474 One concern on [comment](https://github.com/apache/kafka/pull/15844#discussion_r1591065112) above about how we identify this situation (inflight fetch requests that we shouldn't delete t

[jira] [Created] (KAFKA-16674) Adjust classicGroupJoinToConsumerGroup to add subscription model

2024-05-06 Thread Dongnuo Lyu (Jira)
Dongnuo Lyu created KAFKA-16674: --- Summary: Adjust classicGroupJoinToConsumerGroup to add subscription model Key: KAFKA-16674 URL: https://issues.apache.org/jira/browse/KAFKA-16674 Project: Kafka

[jira] [Assigned] (KAFKA-16674) Adjust classicGroupJoinToConsumerGroup to add subscription model

2024-05-06 Thread Dongnuo Lyu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16674?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dongnuo Lyu reassigned KAFKA-16674: --- Assignee: Dongnuo Lyu > Adjust classicGroupJoinToConsumerGroup to add subscription model >

[jira] [Assigned] (KAFKA-16673) Optimize toTopicPartitions with ConsumerProtocolSubscription

2024-05-06 Thread Dongnuo Lyu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16673?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dongnuo Lyu reassigned KAFKA-16673: --- Assignee: Dongnuo Lyu > Optimize toTopicPartitions with ConsumerProtocolSubscription >

Re: [PR] John confluent unclean recovery elect leader request [kafka]

2024-05-06 Thread via GitHub
mannoopj commented on PR #15876: URL: https://github.com/apache/kafka/pull/15876#issuecomment-2096185204 WIP -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] KAFKA-14588 [2/N] ConfigCommandTest rewritten in java [kafka]

2024-05-06 Thread via GitHub
nizhikov commented on PR #15873: URL: https://github.com/apache/kafka/pull/15873#issuecomment-2096190310 Hello @chia7712 Second part of `ConfigCommandTest` refactoring ready for review. Please, take a look. -- This is an automated message from the Apache Git Service. To respond

Re: [PR] KAFKA-16539 Fix IncrementalAlterConfigs during ZK migration [kafka]

2024-05-06 Thread via GitHub
mumrah commented on code in PR #15744: URL: https://github.com/apache/kafka/pull/15744#discussion_r1591110984 ## core/src/test/scala/integration/kafka/zk/ZkMigrationIntegrationTest.scala: ## @@ -1037,24 +1104,35 @@ class ZkMigrationIntegrationTest { admin.alterUserScramCred

Re: [PR] KAFKA-14405: Log a warning when users attempt to set a config controlled by Streams [kafka]

2024-05-06 Thread via GitHub
ashmeet13 commented on PR #12988: URL: https://github.com/apache/kafka/pull/12988#issuecomment-2096203457 Fixing the failing build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

Re: [PR] [KAFKA-16646] Don't run cve scan job on forks [kafka]

2024-05-06 Thread via GitHub
omkreddy merged PR #15831: URL: https://github.com/apache/kafka/pull/15831 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-10199: Remove lost tasks in state updater with new remove [kafka]

2024-05-06 Thread via GitHub
lucasbru commented on code in PR #15870: URL: https://github.com/apache/kafka/pull/15870#discussion_r1591121181 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java: ## @@ -602,6 +608,47 @@ private void removeUnusedTaskFromStateUpdater(final Tas

[PR] MINOR: Various cleanups in clients tests [kafka]

2024-05-06 Thread via GitHub
mimaison opened a new pull request, #15877: URL: https://github.com/apache/kafka/pull/15877 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgr

Re: [PR] KAFKA-16539 Fix IncrementalAlterConfigs during ZK migration [kafka]

2024-05-06 Thread via GitHub
mumrah commented on code in PR #15744: URL: https://github.com/apache/kafka/pull/15744#discussion_r1591129328 ## core/src/main/scala/kafka/zk/KafkaZkClient.scala: ## @@ -467,13 +474,48 @@ class KafkaZkClient private[zk] (zooKeeperClient: ZooKeeperClient, isSecure: Boo * @pa

Re: [PR] KAFKA-16539 Fix IncrementalAlterConfigs during ZK migration [kafka]

2024-05-06 Thread via GitHub
mumrah commented on code in PR #15744: URL: https://github.com/apache/kafka/pull/15744#discussion_r1591129328 ## core/src/main/scala/kafka/zk/KafkaZkClient.scala: ## @@ -467,13 +474,48 @@ class KafkaZkClient private[zk] (zooKeeperClient: ZooKeeperClient, isSecure: Boo * @pa

Re: [PR] KAFKA-16637: AsyncKafkaConsumer removes offset fetch responses from cache too aggressively [kafka]

2024-05-06 Thread via GitHub
lianetm commented on PR #15844: URL: https://github.com/apache/kafka/pull/15844#issuecomment-2096232639 Did we consider the approach of simply decoupling the request timeout from the application event timeout? We could issue the fetch request without a time boundary (max value probably), an

Re: [PR] KAFKA-16665: Allow to initialize newly assigned partition's positions without allowing fetching while callback runs [kafka]

2024-05-06 Thread via GitHub
lucasbru commented on PR #15856: URL: https://github.com/apache/kafka/pull/15856#issuecomment-2096266336 @lianetm some conflicts need to be resolved -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[jira] [Created] (KAFKA-16675) Move rebalance callback test for positions to callbacks test file

2024-05-06 Thread Lianet Magrans (Jira)
Lianet Magrans created KAFKA-16675: -- Summary: Move rebalance callback test for positions to callbacks test file Key: KAFKA-16675 URL: https://issues.apache.org/jira/browse/KAFKA-16675 Project: Kafka

Re: [PR] KAFKA-16665: Allow to initialize newly assigned partition's positions without allowing fetching while callback runs [kafka]

2024-05-06 Thread via GitHub
lianetm commented on PR #15856: URL: https://github.com/apache/kafka/pull/15856#issuecomment-2096322959 Thanks @lucasbru, conflicts solved. Good pointer about the new file for callback tests, I created https://issues.apache.org/jira/browse/KAFKA-16675 assigned to me to make sure I move the

Re: [PR] KAFKA-16307: fix coordinator thread idle ratio [kafka]

2024-05-06 Thread via GitHub
jeffkbkim commented on code in PR #15835: URL: https://github.com/apache/kafka/pull/15835#discussion_r1591194245 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/metrics/GroupCoordinatorRuntimeMetrics.java: ## @@ -208,8 +209,8 @@ public void recordEventQueue

Re: [PR] KAFKA-15804: Close SocketServer channels when calling shutdown before enableRequestProcessing [kafka]

2024-05-06 Thread via GitHub
gharris1727 commented on PR #14729: URL: https://github.com/apache/kafka/pull/14729#issuecomment-2096338791 Hi @C0urante could you take another pass on this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

Re: [PR] KAFKA-10199: Remove lost tasks in state updater with new remove [kafka]

2024-05-06 Thread via GitHub
cadonna commented on code in PR #15870: URL: https://github.com/apache/kafka/pull/15870#discussion_r1591198311 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java: ## @@ -71,6 +73,10 @@ import static org.apache.kafka.streams.processor.interna

Re: [PR] KAFKA-10199: Remove lost tasks in state updater with new remove [kafka]

2024-05-06 Thread via GitHub
cadonna commented on code in PR #15870: URL: https://github.com/apache/kafka/pull/15870#discussion_r1591204373 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java: ## @@ -602,6 +608,47 @@ private void removeUnusedTaskFromStateUpdater(final Task

Re: [PR] KAFKA-10199: Remove lost tasks in state updater with new remove [kafka]

2024-05-06 Thread via GitHub
cadonna commented on code in PR #15870: URL: https://github.com/apache/kafka/pull/15870#discussion_r1591204696 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java: ## @@ -602,6 +608,47 @@ private void removeUnusedTaskFromStateUpdater(final Task

Re: [PR] KAFKA-13328, KAFKA-13329 (2): Add custom preflight validation support for connector header, key, and value converters [kafka]

2024-05-06 Thread via GitHub
gharris1727 commented on code in PR #14309: URL: https://github.com/apache/kafka/pull/14309#discussion_r1591196797 ## clients/src/main/java/org/apache/kafka/common/utils/Utils.java: ## @@ -16,6 +16,15 @@ */ package org.apache.kafka.common.utils; +import java.lang.reflect.Mo

Re: [PR] KAFKA-10199: Remove lost tasks in state updater with new remove [kafka]

2024-05-06 Thread via GitHub
lucasbru commented on code in PR #15870: URL: https://github.com/apache/kafka/pull/15870#discussion_r1591216607 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java: ## @@ -602,6 +608,47 @@ private void removeUnusedTaskFromStateUpdater(final Tas

Re: [PR] KAFKA-9401: Reduce contention for Fetch requests [kafka]

2024-05-06 Thread via GitHub
gaurav-narula commented on PR #15836: URL: https://github.com/apache/kafka/pull/15836#issuecomment-2096392283 Resolved conflict with `trunk` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

Re: [PR] KAFKA-10199: Remove lost tasks in state updater with new remove [kafka]

2024-05-06 Thread via GitHub
cadonna commented on code in PR #15870: URL: https://github.com/apache/kafka/pull/15870#discussion_r1591223152 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java: ## @@ -602,6 +608,47 @@ private void removeUnusedTaskFromStateUpdater(final Task

Re: [PR] KAFKA-16539 Fix IncrementalAlterConfigs during ZK migration [kafka]

2024-05-06 Thread via GitHub
mumrah commented on PR #15744: URL: https://github.com/apache/kafka/pull/15744#issuecomment-2096415182 Thanks for continued reviews @chia7712 👍, I've addressed your latest feedback. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[jira] [Updated] (KAFKA-16619) Unnecessary controller warning : "Loaded ZK migration state of NONE"

2024-05-06 Thread David Arthur (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Arthur updated KAFKA-16619: - Labels: good-first-issue (was: ) > Unnecessary controller warning : "Loaded ZK migration state

Re: [PR] KAFKA-10199: Remove lost tasks in state updater with new remove [kafka]

2024-05-06 Thread via GitHub
cadonna commented on code in PR #15870: URL: https://github.com/apache/kafka/pull/15870#discussion_r1591261680 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java: ## @@ -602,6 +608,47 @@ private void removeUnusedTaskFromStateUpdater(final Task

Re: [PR] KAFKA-10199: Remove lost tasks in state updater with new remove [kafka]

2024-05-06 Thread via GitHub
cadonna commented on code in PR #15870: URL: https://github.com/apache/kafka/pull/15870#discussion_r1591262531 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskManagerTest.java: ## @@ -1421,15 +1422,20 @@ public void shouldRemoveAllActiveTasksFromStateU

Re: [PR] KAFKA-10199: Remove lost tasks in state updater with new remove [kafka]

2024-05-06 Thread via GitHub
cadonna commented on code in PR #15870: URL: https://github.com/apache/kafka/pull/15870#discussion_r1591277510 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java: ## @@ -602,6 +608,47 @@ private void removeUnusedTaskFromStateUpdater(final Task

Re: [PR] KAFKA-16197: Print Connect worker specific logs on poll timeout expiry [kafka]

2024-05-06 Thread via GitHub
gharris1727 commented on code in PR #15305: URL: https://github.com/apache/kafka/pull/15305#discussion_r1591278453 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/WorkerCoordinator.java: ## @@ -267,6 +267,18 @@ public String memberId() { re

Re: [PR] KAFKA-14226: feat(connect:transform): Introduce FieldPath abstraction [kafka]

2024-05-06 Thread via GitHub
jeqo commented on code in PR #15379: URL: https://github.com/apache/kafka/pull/15379#discussion_r1591285305 ## connect/transforms/src/test/java/org/apache/kafka/connect/transforms/field/SingleFieldPathTest.java: ## @@ -0,0 +1,113 @@ +/* + * Licensed to the Apache Software Founda

Re: [PR] KAFKA-14226: feat(connect:transform): Introduce FieldPath abstraction [kafka]

2024-05-06 Thread via GitHub
jeqo commented on PR #15379: URL: https://github.com/apache/kafka/pull/15379#issuecomment-2096481453 Thanks @C0urante! I've applied most suggestions, PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

Re: [PR] KAFKA-16287: Implement example tests for common rebalance callback [kafka]

2024-05-06 Thread via GitHub
lianetm commented on code in PR #15408: URL: https://github.com/apache/kafka/pull/15408#discussion_r1591300734 ## core/src/test/scala/integration/kafka/api/PlaintextConsumerCallbackTest.scala: ## @@ -0,0 +1,138 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under o

Re: [PR] KAFKA-16526; Quorum state data version 1 [kafka]

2024-05-06 Thread via GitHub
jsancio commented on code in PR #15859: URL: https://github.com/apache/kafka/pull/15859#discussion_r1591319255 ## raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java: ## @@ -1700,16 +1710,16 @@ private void handleResponse(RaftResponse.Inbound response, long currentTim

Re: [PR] KAFKA-16287: Implement example tests for common rebalance callback [kafka]

2024-05-06 Thread via GitHub
lianetm commented on code in PR #15408: URL: https://github.com/apache/kafka/pull/15408#discussion_r1591377060 ## core/src/test/scala/integration/kafka/api/PlaintextConsumerCallbackTest.scala: ## @@ -0,0 +1,138 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under o

Re: [PR] KAFKA-16287: Implement example tests for common rebalance callback [kafka]

2024-05-06 Thread via GitHub
lianetm commented on code in PR #15408: URL: https://github.com/apache/kafka/pull/15408#discussion_r1591377324 ## core/src/test/scala/integration/kafka/api/PlaintextConsumerCallbackTest.scala: ## @@ -0,0 +1,138 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under o

[jira] [Created] (KAFKA-16676) Security docs missing RPCs from KIP-714 and KIP-1000

2024-05-06 Thread Andrew Schofield (Jira)
Andrew Schofield created KAFKA-16676: Summary: Security docs missing RPCs from KIP-714 and KIP-1000 Key: KAFKA-16676 URL: https://issues.apache.org/jira/browse/KAFKA-16676 Project: Kafka

[jira] [Updated] (KAFKA-16530) Fix high-watermark calculation to not assume the leader is in the voter set

2024-05-06 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-16530?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] José Armando García Sancio updated KAFKA-16530: --- Summary: Fix high-watermark calculation to not assume the leader is i

[jira] [Updated] (KAFKA-16531) Fix check-quorum calculation to not assume that the leader is in the voter set

2024-05-06 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-16531?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] José Armando García Sancio updated KAFKA-16531: --- Summary: Fix check-quorum calculation to not assume that the leader i

[jira] [Commented] (KAFKA-14237) Kafka TLS Doesn't Present Intermediary Certificates when using PEM

2024-05-06 Thread Gaurav Narula (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17843869#comment-17843869 ] Gaurav Narula commented on KAFKA-14237: --- Hi [~soxcks]  I'm unable to reproduce th

Re: [PR] KAFKA-16539 Fix IncrementalAlterConfigs during ZK migration [kafka]

2024-05-06 Thread via GitHub
mumrah commented on PR #15744: URL: https://github.com/apache/kafka/pull/15744#issuecomment-2096872249 [Latest test run](https://ci-builds.apache.org/blue/organizations/jenkins/Kafka%2Fkafka-pr/detail/PR-15744/13/tests) looks pretty reasonable. The failures all look unrelated --

[jira] [Commented] (KAFKA-16670) KIP-848 : Consumer will not receive assignment forever because of concurrent issue.

2024-05-06 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17843887#comment-17843887 ] Lianet Magrans commented on KAFKA-16670: Hey [~chickenchickenlove], thanks for t

[jira] [Comment Edited] (KAFKA-16670) KIP-848 : Consumer will not receive assignment forever because of concurrent issue.

2024-05-06 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17843887#comment-17843887 ] Lianet Magrans edited comment on KAFKA-16670 at 5/6/24 9:01 PM: --

Re: [PR] KAFKA-16356 RemoteLogMetadataSerde: Serializer via class-name dispatch removed and replaced with if-elseif-else conditions [kafka]

2024-05-06 Thread via GitHub
linu-shibu commented on PR #15620: URL: https://github.com/apache/kafka/pull/15620#issuecomment-2096976398 @gharris1727 any update on this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

Re: [PR] KAFKA-16207; KRaft's internal log listener to update voter set [kafka]

2024-05-06 Thread via GitHub
junrao commented on code in PR #15671: URL: https://github.com/apache/kafka/pull/15671#discussion_r1589798416 ## raft/src/main/java/org/apache/kafka/raft/internals/KRaftControlRecordStateMachine.java: ## @@ -0,0 +1,261 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] MINOR: Refactor Values class to fix checkstyle, add benchmark, optimize exceptions [kafka]

2024-05-06 Thread via GitHub
gharris1727 commented on code in PR #15469: URL: https://github.com/apache/kafka/pull/15469#discussion_r1591616004 ## connect/api/src/main/java/org/apache/kafka/connect/data/Values.java: ## @@ -177,7 +213,12 @@ public static Long convertToLong(Schema schema, Object value) throw

Re: [PR] KAFKA-16652: add unit test for ClusterTemplate offering zero ClusterConfig [kafka]

2024-05-06 Thread via GitHub
TaiJuWu commented on code in PR #15862: URL: https://github.com/apache/kafka/pull/15862#discussion_r1591630803 ## core/src/test/java/kafka/test/junit/ClusterTestExtensionsUnitTest.java: ## @@ -33,16 +31,22 @@ public class ClusterTestExtensionsUnitTest { void testProcessClus

Re: [PR] MINOR: Refactor Values class to fix checkstyle, add benchmark, optimize exceptions [kafka]

2024-05-06 Thread via GitHub
gharris1727 commented on code in PR #15469: URL: https://github.com/apache/kafka/pull/15469#discussion_r1591636980 ## connect/api/src/main/java/org/apache/kafka/connect/data/Values.java: ## @@ -766,135 +852,23 @@ protected static boolean canParseSingleTokenLiteral(Parser parser

[jira] [Updated] (KAFKA-16670) KIP-848 : Consumer will not receive assignment forever because of concurrent issue.

2024-05-06 Thread sanghyeok An (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16670?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] sanghyeok An updated KAFKA-16670: - Attachment: image-2024-05-07-08-34-06-855.png > KIP-848 : Consumer will not receive assignment f

  1   2   >