chia7712 commented on PR #16280:
URL: https://github.com/apache/kafka/pull/16280#issuecomment-2172345147
@harryfallows thanks for your contribution!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
chia7712 merged PR #16280:
URL: https://github.com/apache/kafka/pull/16280
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
gongxuanzhang closed pull request #16362: KAFKA-10787: Apply spotless to all
`:streams:upgrade-system-tests-xxx`
URL: https://github.com/apache/kafka/pull/16362
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
[
https://issues.apache.org/jira/browse/KAFKA-16972?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai reassigned KAFKA-16972:
--
Assignee: PoAn Yang (was: Chia-Ping Tsai)
> Move `BrokerTopicStats` and
lemessdavi opened a new pull request, #16365:
URL: https://github.com/apache/kafka/pull/16365
According to the PMD code smell analysis "LooseCoupling" and
"ControlStatementBraces"
Excessive coupling to implementation types (e.g., HashSet) limits your
ability to use alternate
lemessdavi opened a new pull request, #16364:
URL: https://github.com/apache/kafka/pull/16364
According to the PMD code smell analysis "FinalParameterInAbstractMethod"
Declaring a method parameter as final for an interface method is useless
because the implementation may choose to
lemessdavi opened a new pull request, #16363:
URL: https://github.com/apache/kafka/pull/16363
According to the GuardLogStatement: Logger calls should be surrounded by log
level guards and ClassWithOnlyPrivateConstructorsShouldBeFinal: This class has
only private constructors and may be
m1a2st commented on code in PR #16317:
URL: https://github.com/apache/kafka/pull/16317#discussion_r1642099195
##
core/src/test/java/kafka/admin/ConfigCommandIntegrationTest.java:
##
@@ -493,36 +496,48 @@ private void alterConfigWithKraft(Admin client,
Optional brokerId, Map
dujian0068 commented on code in PR #16348:
URL: https://github.com/apache/kafka/pull/16348#discussion_r1642096794
##
streams/streams-scala/src/test/scala/org/apache/kafka/streams/scala/TopologyTest.scala:
##
@@ -21,30 +21,18 @@ import java.util
import java.util.{Locale,
gongxuanzhang opened a new pull request, #16362:
URL: https://github.com/apache/kafka/pull/16362
This PR is sub PR from https://github.com/apache/kafka/pull/16097.
It is part of a series of changes to progressively apply [spotless
plugin(import-order)] across all modules. In this step,
[
https://issues.apache.org/jira/browse/KAFKA-16972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17855471#comment-17855471
]
PoAn Yang commented on KAFKA-16972:
---
Hi [~chia7712], I'm interested in this. If you're not working on
[
https://issues.apache.org/jira/browse/KAFKA-16972?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai updated KAFKA-16972:
---
Description:
KAFKA-15852 says `kafka.server` should be moved to server module.
However,
[
https://issues.apache.org/jira/browse/KAFKA-16972?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai updated KAFKA-16972:
---
Summary: Move `BrokerTopicStats` and `BrokerTopicMetrics` to
[
https://issues.apache.org/jira/browse/KAFKA-16972?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai updated KAFKA-16972:
---
Summary: Move `BrokerTopicStats`, `BrokerTopicMetrics`, and
`BrokerTopicStats` to
Chia-Ping Tsai created KAFKA-16972:
--
Summary: Move `BrokerTopicStats`, `BrokerTopicMetrics`, and
`BrokerTopicStats` to `org.apache.kafka.storage.log.metrics`
Key: KAFKA-16972
URL:
gongxuanzhang commented on PR #16351:
URL: https://github.com/apache/kafka/pull/16351#issuecomment-2172045859
plz take a look @chia7712
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
[
https://issues.apache.org/jira/browse/KAFKA-16969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17855463#comment-17855463
]
Luke Chen commented on KAFKA-16969:
---
> I think then we should change the behavior to just log an error
brandboat commented on code in PR #16360:
URL: https://github.com/apache/kafka/pull/16360#discussion_r1642064678
##
streams/src/test/java/org/apache/kafka/streams/integration/EOSUncleanShutdownIntegrationTest.java:
##
@@ -59,59 +56,52 @@
import static
brandboat commented on code in PR #16360:
URL: https://github.com/apache/kafka/pull/16360#discussion_r1642056129
##
streams/src/test/java/org/apache/kafka/streams/integration/EOSUncleanShutdownIntegrationTest.java:
##
@@ -59,59 +56,52 @@
import static
chia7712 commented on code in PR #16351:
URL: https://github.com/apache/kafka/pull/16351#discussion_r1642052004
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/ErrorHandlingTaskTest.java:
##
@@ -179,19 +176,15 @@ public class ErrorHandlingTaskTest {
chia7712 commented on PR #16323:
URL: https://github.com/apache/kafka/pull/16323#issuecomment-2171991567
@TaiJuWu please fix the build error
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
[
https://issues.apache.org/jira/browse/KAFKA-16898?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai resolved KAFKA-16898.
Fix Version/s: 3.9.0
Resolution: Fixed
> move TimeIndexTest and
chia7712 merged PR #16341:
URL: https://github.com/apache/kafka/pull/16341
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
chia7712 commented on code in PR #16360:
URL: https://github.com/apache/kafka/pull/16360#discussion_r1642020103
##
streams/src/test/java/org/apache/kafka/streams/integration/AbstractJoinIntegrationTest.java:
##
@@ -61,33 +59,27 @@
/**
* Tests all available joins of Kafka
[
https://issues.apache.org/jira/browse/KAFKA-16052?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Divij Vaidya reassigned KAFKA-16052:
Assignee: Divij Vaidya
Resolution: Fixed
> OOM in Kafka test suite
>
chia7712 commented on code in PR #16317:
URL: https://github.com/apache/kafka/pull/16317#discussion_r1642019830
##
core/src/test/java/kafka/admin/ConfigCommandIntegrationTest.java:
##
@@ -493,36 +496,48 @@ private void alterConfigWithKraft(Admin client,
Optional brokerId, Map
chia7712 commented on code in PR #16355:
URL: https://github.com/apache/kafka/pull/16355#discussion_r1642017586
##
core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala:
##
@@ -1001,6 +1001,29 @@ class PlaintextAdminIntegrationTest extends
[
https://issues.apache.org/jira/browse/KAFKA-16971?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai resolved KAFKA-16971.
Fix Version/s: 3.9.0
Resolution: Fixed
> Fix the incorrect format string in
chia7712 merged PR #16358:
URL: https://github.com/apache/kafka/pull/16358
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
ardada2468 commented on PR #16259:
URL: https://github.com/apache/kafka/pull/16259#issuecomment-2171821142
@chia7712 do you know why I am getting the the following error:
[2024-06-14T23:21:59.290Z] [Checks API] No suitable checks publisher found.
on Jenkins? I would
handfreezer opened a new pull request, #16361:
URL: https://github.com/apache/kafka/pull/16361
Default StandardAuthorizer in Kraft mode is defining a KafkaPrincpal as
type=User and a name, and a special wildcard eventually.
The difficulty with this solution is that we can't define
[
https://issues.apache.org/jira/browse/KAFKA-16707?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Franck LEDAY updated KAFKA-16707:
-
Affects Version/s: 3.8.0
> Kafka Kraft : adding Principal Type in StandardACL for matching with
brandboat opened a new pull request, #16360:
URL: https://github.com/apache/kafka/pull/16360
related to https://issues.apache.org/jira/browse/KAFKA-15623
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and
gaurav-narula commented on code in PR #16354:
URL: https://github.com/apache/kafka/pull/16354#discussion_r1641912898
##
clients/src/test/java/org/apache/kafka/common/network/EchoServer.java:
##
@@ -38,6 +38,11 @@
* A simple server that takes size delimited byte arrays and
[
https://issues.apache.org/jira/browse/KAFKA-16219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17855427#comment-17855427
]
Gaurav Narula commented on KAFKA-16219:
---
Thread dump revealed that the test runner was blocked
frankvicky opened a new pull request, #16359:
URL: https://github.com/apache/kafka/pull/16359
All of them derive the hash code from the reference of Array rather than the
content of Array, which does not adhere to best practices. If `equals` returns
true, they should have the same hash
chiacyu commented on code in PR #15924:
URL: https://github.com/apache/kafka/pull/15924#discussion_r1641899702
##
core/src/main/scala/kafka/server/AclApis.scala:
##
@@ -69,7 +69,7 @@ class AclApis(authHelper: AuthHelper,
case Some(auth) =>
val filter =
chiacyu commented on PR #15924:
URL: https://github.com/apache/kafka/pull/15924#issuecomment-2171689757
Hi, @chia7712
Thanks for the reminder. Since we change the parameter of `aclsResources()`
then we can modify it into `aclsResources(auth.acls(filter))`. Then we can
remove the
TaiJuWu commented on code in PR #16167:
URL: https://github.com/apache/kafka/pull/16167#discussion_r1641871063
##
storage/src/test/java/org/apache/kafka/storage/internals/log/LogValidatorTest.java:
##
@@ -0,0 +1,2100 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
[
https://issues.apache.org/jira/browse/KAFKA-16969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17855401#comment-17855401
]
Igor Soarez commented on KAFKA-16969:
-
This was discussed in KAFKA-16606, the reasoning was that
harryfallows commented on PR #16280:
URL: https://github.com/apache/kafka/pull/16280#issuecomment-2171472423
thanks for the review, I have addressed the comments!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
frankvicky commented on PR #16355:
URL: https://github.com/apache/kafka/pull/16355#issuecomment-2171469766
Hi @chia7712, I have make a change based on your comment, PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
chia7712 commented on code in PR #16280:
URL: https://github.com/apache/kafka/pull/16280#discussion_r1641801668
##
core/src/test/scala/unit/kafka/server/DynamicConfigChangeTest.scala:
##
@@ -472,6 +472,131 @@ class DynamicConfigChangeTest extends
KafkaServerTestHarness {
FrankYang0529 opened a new pull request, #16358:
URL: https://github.com/apache/kafka/pull/16358
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of
[
https://issues.apache.org/jira/browse/KAFKA-16971?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai reassigned KAFKA-16971:
--
Assignee: PoAn Yang (was: Chia-Ping Tsai)
> Fix the incorrect format string in
[
https://issues.apache.org/jira/browse/KAFKA-16971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17855398#comment-17855398
]
PoAn Yang commented on KAFKA-16971:
---
Hi [~chia7712], may I take this issue? Thank you.
> Fix the
Chia-Ping Tsai created KAFKA-16971:
--
Summary: Fix the incorrect format string in
QuorumConfigs#parseBootstrapServer
Key: KAFKA-16971
URL: https://issues.apache.org/jira/browse/KAFKA-16971
Project:
pasharik commented on PR #15830:
URL: https://github.com/apache/kafka/pull/15830#issuecomment-2171435063
Test seems to be more stable now after recent update. I'm also running it in
a loop in IntelliJ, and so far can't reproduce flakyness :crossed_fingers:
--
This is an automated
pasharik commented on code in PR #15830:
URL: https://github.com/apache/kafka/pull/15830#discussion_r1641784154
##
core/src/test/scala/unit/kafka/admin/AclCommandTest.scala:
##
@@ -325,11 +349,15 @@ class AclCommandTest extends QuorumTestHarness with
Logging {
private def
FrankYang0529 commented on PR #16341:
URL: https://github.com/apache/kafka/pull/16341#issuecomment-2171409206
Hi @chia7712, I addressed all comments. May you take a look? Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
chia7712 commented on code in PR #16353:
URL: https://github.com/apache/kafka/pull/16353#discussion_r1641770712
##
core/src/main/java/kafka/log/remote/RemoteLogManager.java:
##
@@ -226,7 +227,8 @@ public RemoteLogManager(RemoteLogManagerConfig rlmConfig,
chia7712 commented on code in PR #16345:
URL: https://github.com/apache/kafka/pull/16345#discussion_r1641765619
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java:
##
@@ -680,6 +694,7 @@ public NetworkClientDelegate.UnsentRequest
jlprat commented on PR #16338:
URL: https://github.com/apache/kafka/pull/16338#issuecomment-2171361601
Go ahead and back-port it. Thanks @omkreddy
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
Chuckame commented on code in PR #16218:
URL: https://github.com/apache/kafka/pull/16218#discussion_r1641769333
##
streams/src/main/java/org/apache/kafka/streams/kstream/internals/foreignkeyjoin/CombinedKeySchema.java:
##
@@ -60,7 +60,7 @@ public void init(final
kamalcph commented on code in PR #16353:
URL: https://github.com/apache/kafka/pull/16353#discussion_r1641757420
##
core/src/main/java/kafka/log/remote/RemoteLogManager.java:
##
@@ -412,7 +418,7 @@ public void onLeadershipChange(Set
partitionsBecomeLeader,
kamalcph commented on code in PR #16353:
URL: https://github.com/apache/kafka/pull/16353#discussion_r1641760409
##
core/src/main/java/kafka/log/remote/RemoteLogManager.java:
##
@@ -226,7 +227,8 @@ public RemoteLogManager(RemoteLogManagerConfig rlmConfig,
kamalcph commented on code in PR #16353:
URL: https://github.com/apache/kafka/pull/16353#discussion_r1641760409
##
core/src/main/java/kafka/log/remote/RemoteLogManager.java:
##
@@ -226,7 +227,8 @@ public RemoteLogManager(RemoteLogManagerConfig rlmConfig,
kamalcph commented on code in PR #16353:
URL: https://github.com/apache/kafka/pull/16353#discussion_r1641757420
##
core/src/main/java/kafka/log/remote/RemoteLogManager.java:
##
@@ -412,7 +418,7 @@ public void onLeadershipChange(Set
partitionsBecomeLeader,
kamalcph commented on code in PR #16353:
URL: https://github.com/apache/kafka/pull/16353#discussion_r1641757420
##
core/src/main/java/kafka/log/remote/RemoteLogManager.java:
##
@@ -412,7 +418,7 @@ public void onLeadershipChange(Set
partitionsBecomeLeader,
[
https://issues.apache.org/jira/browse/KAFKA-16970?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai reassigned KAFKA-16970:
--
Assignee: TengYao Chi (was: Chia-Ping Tsai)
> Fix hash implementation of
[
https://issues.apache.org/jira/browse/KAFKA-16970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17855387#comment-17855387
]
TengYao Chi commented on KAFKA-16970:
-
Gentle ping [~chia7712] , if you are not start working this
[
https://issues.apache.org/jira/browse/KAFKA-16970?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai updated KAFKA-16970:
---
Summary: Fix hash implementation of `ScramCredentialValue`,
`ScramCredentialData`, and
Chia-Ping Tsai created KAFKA-16970:
--
Summary: `ScramCredentialValue`, `ScramCredentialData`, and
`ContextualRecord` has incorrect hash implementation
Key: KAFKA-16970
URL:
gongxuanzhang commented on code in PR #16357:
URL: https://github.com/apache/kafka/pull/16357#discussion_r1641734700
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/AbstractHerderTest.java:
##
@@ -98,7 +99,8 @@
import static org.mockito.Mockito.when;
import
chia7712 commented on code in PR #16341:
URL: https://github.com/apache/kafka/pull/16341#discussion_r1641733994
##
storage/src/test/java/org/apache/kafka/storage/internals/log/TransactionIndexTest.java:
##
@@ -0,0 +1,207 @@
+/*
+ * Licensed to the Apache Software Foundation
chia7712 commented on code in PR #16341:
URL: https://github.com/apache/kafka/pull/16341#discussion_r1641733405
##
storage/src/test/java/org/apache/kafka/storage/internals/log/TimeIndexTest.java:
##
@@ -0,0 +1,205 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
chia7712 commented on code in PR #16341:
URL: https://github.com/apache/kafka/pull/16341#discussion_r1641732520
##
storage/src/test/java/org/apache/kafka/storage/internals/log/TransactionIndexTest.java:
##
@@ -0,0 +1,207 @@
+/*
+ * Licensed to the Apache Software Foundation
chia7712 commented on code in PR #16355:
URL: https://github.com/apache/kafka/pull/16355#discussion_r1641728889
##
core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala:
##
@@ -1001,6 +1001,30 @@ class PlaintextAdminIntegrationTest extends
omkreddy commented on PR #16338:
URL: https://github.com/apache/kafka/pull/16338#issuecomment-2171243146
@jlprat This is docs PR related to KIP-974. We need to backport to 3.8
branch. Let me know any concerns.
--
This is an automated message from the Apache Git Service.
To respond to
omkreddy merged PR #16338:
URL: https://github.com/apache/kafka/pull/16338
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
kagarwal06 commented on code in PR #16338:
URL: https://github.com/apache/kafka/pull/16338#discussion_r1641602857
##
tests/README.md:
##
@@ -51,6 +51,19 @@ bash tests/docker/ducker-ak up -j 'openjdk:11';
tests/docker/run_tests.sh
```
REBUILD="t" bash
kagarwal06 commented on code in PR #16338:
URL: https://github.com/apache/kafka/pull/16338#discussion_r1641602857
##
tests/README.md:
##
@@ -51,6 +51,19 @@ bash tests/docker/ducker-ak up -j 'openjdk:11';
tests/docker/run_tests.sh
```
REBUILD="t" bash
kagarwal06 commented on code in PR #16338:
URL: https://github.com/apache/kafka/pull/16338#discussion_r1641602857
##
tests/README.md:
##
@@ -51,6 +51,19 @@ bash tests/docker/ducker-ak up -j 'openjdk:11';
tests/docker/run_tests.sh
```
REBUILD="t" bash
chia7712 commented on code in PR #16357:
URL: https://github.com/apache/kafka/pull/16357#discussion_r1641664041
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/AbstractHerderTest.java:
##
@@ -98,7 +99,8 @@
import static org.mockito.Mockito.when;
import
chia7712 commented on code in PR #16353:
URL: https://github.com/apache/kafka/pull/16353#discussion_r1641654171
##
core/src/main/java/kafka/log/remote/RemoteLogManager.java:
##
@@ -226,7 +227,8 @@ public RemoteLogManager(RemoteLogManagerConfig rlmConfig,
VedarthConfluent commented on PR #16338:
URL: https://github.com/apache/kafka/pull/16338#issuecomment-2171124540
The pipeline run for native image will be different for native and jvm
image. We need to add native image run separately in the voting template
--
This is an automated message
frankvicky commented on PR #16350:
URL: https://github.com/apache/kafka/pull/16350#issuecomment-2171124111
Hi @chia7712, I have make some changes based on your example to keep
`StandaloneHerderTest` has minimum changes during migration, PTAL
--
This is an automated message from the
kagarwal06 commented on PR #16338:
URL: https://github.com/apache/kafka/pull/16338#issuecomment-2171122277
> Can we also update
https://github.com/apache/kafka/blob/trunk/release.py#L794
https://github.com/apache/kafka/blob/trunk/release.py#L817
Updated "Can we also update
gongxuanzhang commented on PR #16351:
URL: https://github.com/apache/kafka/pull/16351#issuecomment-2171121243
@chia7712 I update it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
chia7712 commented on PR #16019:
URL: https://github.com/apache/kafka/pull/16019#issuecomment-2171118271
> If we mark core Formatter to deprecate, should It need to delete at next
Kafka version?
yep if we push the code to deprecate them in 3.9.0
--
This is an automated message
omkreddy commented on PR #16338:
URL: https://github.com/apache/kafka/pull/16338#issuecomment-2171087359
Can we also update https://github.com/apache/kafka/blob/trunk/release.py#L794
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
81 matches
Mail list logo
