Re: [PR] KAFKA-18105 Fix flaky PlaintextAdminIntegrationTest#testElectPreferredLeaders [kafka]

2025-07-10 Thread via GitHub
TaiJuWu commented on code in PR #20068: URL: https://github.com/apache/kafka/pull/20068#discussion_r2199668697 ## core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala: ## @@ -2850,6 +2851,21 @@ class PlaintextAdminIntegrationTest extends BaseAdminIntegr

Re: [PR] KAFKA-19842: Fix flaky KafkaStreamsTelemetryIntegrationTest [kafka]

2025-07-10 Thread via GitHub
lucasbru commented on code in PR #20147: URL: https://github.com/apache/kafka/pull/20147#discussion_r2199779001 ## streams/integration-tests/src/test/java/org/apache/kafka/streams/integration/KafkaStreamsTelemetryIntegrationTest.java: ## @@ -279,18 +281,28 @@ public void shouldP

Re: [PR] KAFKA-19476: Improve state transition handling in SharePartition [kafka]

2025-07-10 Thread via GitHub
adixitconfluent commented on code in PR #20124: URL: https://github.com/apache/kafka/pull/20124#discussion_r2199764435 ## core/src/main/java/kafka/server/share/SharePartition.java: ## @@ -2054,7 +2054,15 @@ void rollbackOrProcessStateUpdates( // Log in DEBUG to

Re: [PR] KAFKA-18105 Fix flaky PlaintextAdminIntegrationTest#testElectPreferredLeaders [kafka]

2025-07-10 Thread via GitHub
TaiJuWu commented on code in PR #20068: URL: https://github.com/apache/kafka/pull/20068#discussion_r2199668697 ## core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala: ## @@ -2850,6 +2851,21 @@ class PlaintextAdminIntegrationTest extends BaseAdminIntegr

Re: [PR] KAFKA-18105 Fix flaky PlaintextAdminIntegrationTest#testElectPreferredLeaders [kafka]

2025-07-10 Thread via GitHub
TaiJuWu commented on code in PR #20068: URL: https://github.com/apache/kafka/pull/20068#discussion_r2199668697 ## core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala: ## @@ -2850,6 +2851,21 @@ class PlaintextAdminIntegrationTest extends BaseAdminIntegr

Re: [PR] KAFKA-18105 Fix flaky PlaintextAdminIntegrationTest#testElectPreferredLeaders [kafka]

2025-07-10 Thread via GitHub
TaiJuWu commented on code in PR #20068: URL: https://github.com/apache/kafka/pull/20068#discussion_r2199668697 ## core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala: ## @@ -2850,6 +2851,21 @@ class PlaintextAdminIntegrationTest extends BaseAdminIntegr

Re: [PR] KAFKA-18105 Fix flaky PlaintextAdminIntegrationTest#testElectPreferredLeaders [kafka]

2025-07-10 Thread via GitHub
TaiJuWu commented on code in PR #20068: URL: https://github.com/apache/kafka/pull/20068#discussion_r2199668697 ## core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala: ## @@ -2850,6 +2851,21 @@ class PlaintextAdminIntegrationTest extends BaseAdminIntegr

[PR] KAFKA-14405: Log a warning when users attempt to set a config controlled by Streams [kafka]

2025-07-10 Thread via GitHub
shashankhs11 opened a new pull request, #20149: URL: https://github.com/apache/kafka/pull/20149 This PR addresses [KAFKA-14405 JIRA](https://issues.apache.org/jira/browse/KAFKA-14405) and builds upon significant work done from #12988. ### Initial Problem It's too easy for users to

Re: [PR] KAFKA-18105 Fix flaky PlaintextAdminIntegrationTest#testElectPreferredLeaders [kafka]

2025-07-10 Thread via GitHub
TaiJuWu commented on code in PR #20068: URL: https://github.com/apache/kafka/pull/20068#discussion_r2199668697 ## core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala: ## @@ -2850,6 +2851,21 @@ class PlaintextAdminIntegrationTest extends BaseAdminIntegr

Re: [PR] MINOR: Cleanup Tools Module (2/n) [kafka]

2025-07-10 Thread via GitHub
github-actions[bot] commented on PR #20096: URL: https://github.com/apache/kafka/pull/20096#issuecomment-3060257695 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

Re: [PR] KAFKA-19461: Add share group admin integration tests to PlaintextAdminIntegrationTest [kafka]

2025-07-10 Thread via GitHub
github-actions[bot] commented on PR #20103: URL: https://github.com/apache/kafka/pull/20103#issuecomment-3060257665 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

[PR] KAFKA-19471: Enable acknowledgement for a record which could not be deserialized [kafka]

2025-07-10 Thread via GitHub
DL1231 opened a new pull request, #20148: URL: https://github.com/apache/kafka/pull/20148 This patch mainly includes two improvements: 1. Update currentFetch when `pollForFetches()` throws an exception. 2. Add an override `KafkaShareConsumer.acknowledge(String topic, int partition,

[jira] [Assigned] (KAFKA-19493) Incorrect rate metric with larger window size

2025-07-10 Thread Lan Ding (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19493?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lan Ding reassigned KAFKA-19493: Assignee: Lan Ding > Incorrect rate metric with larger window size >

Re: [PR] KAFKA-19254: Add generic feature level metrics [kafka]

2025-07-10 Thread via GitHub
chia7712 commented on code in PR #20021: URL: https://github.com/apache/kafka/pull/20021#discussion_r2199017407 ## metadata/src/main/java/org/apache/kafka/image/loader/metrics/MetadataLoaderMetrics.java: ## @@ -142,16 +176,85 @@ public long handleLoadSnapshotCount() { r

Re: [PR] KAFKA-19452: Fix flaky test LogRecoveryTest.testHWCheckpointWithFailuresMultipleLogSegments [kafka]

2025-07-10 Thread via GitHub
junrao commented on code in PR #20121: URL: https://github.com/apache/kafka/pull/20121#discussion_r2198952441 ## core/src/test/scala/unit/kafka/server/LogRecoveryTest.scala: ## @@ -215,7 +215,7 @@ class LogRecoveryTest extends QuorumTestHarness { server2.startup() upda

Re: [PR] KAFKA-19213 Client ignores default properties [kafka]

2025-07-10 Thread via GitHub
ezhou413 commented on PR #20134: URL: https://github.com/apache/kafka/pull/20134#issuecomment-3059361507 I've decided to push a code change since this bug report was made by a user. We can discuss opening a KIP for the usage of `Properties` as its own separate thing. -- This is an autom

Re: [PR] KAFKA-19842: Fix flaky KafkaStreamsTelemetryIntegrationTest [kafka]

2025-07-10 Thread via GitHub
mjsax commented on code in PR #20147: URL: https://github.com/apache/kafka/pull/20147#discussion_r2198869297 ## streams/integration-tests/src/test/java/org/apache/kafka/streams/integration/KafkaStreamsTelemetryIntegrationTest.java: ## @@ -279,18 +281,28 @@ public void shouldPass

Re: [PR] KAFKA-19842: Fix flaky KafkaStreamsTelemetryIntegrationTest [kafka]

2025-07-10 Thread via GitHub
mjsax commented on code in PR #20147: URL: https://github.com/apache/kafka/pull/20147#discussion_r2198869297 ## streams/integration-tests/src/test/java/org/apache/kafka/streams/integration/KafkaStreamsTelemetryIntegrationTest.java: ## @@ -279,18 +281,28 @@ public void shouldPass

[PR] KAFKA-19842: Fix flaky KafkaStreamsTelemetryIntegrationTest [kafka]

2025-07-10 Thread via GitHub
mjsax opened a new pull request, #20147: URL: https://github.com/apache/kafka/pull/20147 The new "streams" protocol behaves slightly different to the "classic" protocol, and thus we need to update the test to avoid race conditions. In particular, the first call to `poll()` won't "block" and

Re: [PR] KAFKA-19489: storage tool should check controller.quorum.voters is not set alongside a dynamic quorum flag when formatting [kafka]

2025-07-10 Thread via GitHub
ahuang98 commented on code in PR #20136: URL: https://github.com/apache/kafka/pull/20136#discussion_r2198758987 ## core/src/test/scala/unit/kafka/tools/StorageToolTest.scala: ## @@ -387,22 +387,32 @@ Found problem: } @Test - def testFormatWithStandaloneAndInitialControl

Re: [PR] KAFKA-19489: storage tool should check controller.quorum.voters is not set alongside a dynamic quorum flag when formatting [kafka]

2025-07-10 Thread via GitHub
ahuang98 commented on code in PR #20136: URL: https://github.com/apache/kafka/pull/20136#discussion_r2198753693 ## core/src/test/scala/unit/kafka/tools/StorageToolTest.scala: ## @@ -376,6 +376,8 @@ Found problem: val availableDirs = Seq(TestUtils.tempDir()) val propert

Re: [PR] Minor : Use specific error in compression catch handle [kafka]

2025-07-10 Thread via GitHub
apoorvmittal10 commented on code in PR #20144: URL: https://github.com/apache/kafka/pull/20144#discussion_r2198617405 ## clients/src/main/java/org/apache/kafka/common/telemetry/internals/ClientTelemetryReporter.java: ## @@ -717,7 +718,7 @@ private Optional> createPushRequest(Cl

Re: [PR] Minor : Use specific error in compression catch handle [kafka]

2025-07-10 Thread via GitHub
apoorvmittal10 commented on code in PR #20144: URL: https://github.com/apache/kafka/pull/20144#discussion_r2198617405 ## clients/src/main/java/org/apache/kafka/common/telemetry/internals/ClientTelemetryReporter.java: ## @@ -717,7 +718,7 @@ private Optional> createPushRequest(Cl

Re: [PR] KAFKA-19476: Improve state transition handling in SharePartition [kafka]

2025-07-10 Thread via GitHub
apoorvmittal10 commented on code in PR #20124: URL: https://github.com/apache/kafka/pull/20124#discussion_r2198603871 ## core/src/main/java/kafka/server/share/SharePartition.java: ## @@ -2054,7 +2054,15 @@ void rollbackOrProcessStateUpdates( // Log in DEBUG to a

[PR] [WIP] KAFKA-19012: Messages ending up on the wrong topic [kafka]

2025-07-10 Thread via GitHub
kirktrue opened a new pull request, #20146: URL: https://github.com/apache/kafka/pull/20146 Adding instrumentation for `KafkaProducer` to detect when the topic a message was written to changes after it's enqueued. -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] [WIP] KAFKA-19012: Messages ending up on the wrong topic [kafka]

2025-07-10 Thread via GitHub
kirktrue closed pull request #20138: [WIP] KAFKA-19012: Messages ending up on the wrong topic URL: https://github.com/apache/kafka/pull/20138 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

Re: [PR] MINOR: Add tests on TxnOffsetCommit and EndTxnMarker protection against invalid producer epoch when TV2 is used [kafka]

2025-07-10 Thread via GitHub
dongnuo123 commented on PR #20024: URL: https://github.com/apache/kafka/pull/20024#issuecomment-3058796452 @FrankYang0529 For EndTxnRequest we already have some integration tests in TransactionTest.scala but I guess we should have one for WriteTxnMarkersRequest to test the protection on the

Re: [PR] MINOR : Handle error for client telemetry push [kafka]

2025-07-10 Thread via GitHub
ijuma commented on code in PR #19881: URL: https://github.com/apache/kafka/pull/19881#discussion_r2198543449 ## clients/src/main/java/org/apache/kafka/common/telemetry/internals/ClientTelemetryReporter.java: ## @@ -718,8 +717,8 @@ private Optional> createPushRequest(ClientTelem

Re: [PR] KAFKA-19377:Update /streams/developer-guide/security.html for KIP-1071 [kafka]

2025-07-10 Thread via GitHub
lucasbru commented on PR #20084: URL: https://github.com/apache/kafka/pull/20084#issuecomment-3058639838 https://github.com/user-attachments/assets/79a4674e-fcb6-4d8e-9650-616978064bac"; /> Link to rendering, removed from PR descritpipn -- This is an automated message from the

Re: [PR] MINOR: fix e2e docs for unrunnable test [kafka]

2025-07-10 Thread via GitHub
Yunyung commented on PR #20145: URL: https://github.com/apache/kafka/pull/20145#issuecomment-3058631112 Many assume that the files under tests/kafkatest/services can be run directly, but this is not the case. We should consider adding a note to clarify this. -- This is an automated messa

Re: [PR] KAFKA-18336: Improve jmh tests on ACL in AuthorizerBenchmark and StandardAuthorizerUpdateBenchmark [kafka]

2025-07-10 Thread via GitHub
lucasbru commented on PR #18293: URL: https://github.com/apache/kafka/pull/18293#issuecomment-3058610629 Adding some details as comments and removing from PR description so that they don't end up in commit message: Test results doesn't change dramatically Before Benchm

[PR] MINOR: fix e2e docs for unrunnable test [kafka]

2025-07-10 Thread via GitHub
Yunyung opened a new pull request, #20145: URL: https://github.com/apache/kafka/pull/20145 `tests/kafkatest/services/console_consumer.py` cannot be run directly. The correct way is to run `tests/kafkatest/sanity_checks/test_console_consumer.py`. -- This is an automated message from the Ap

[jira] [Commented] (KAFKA-14405) Log a warning when users attempt to set a config controlled by Streams

2025-07-10 Thread Shashank (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18004517#comment-18004517 ] Shashank commented on KAFKA-14405: -- Hi [~ableegoldman], I would like to start working o

Re: [PR] KAFKA-19489: storage tool should check controller.quorum.voters is not set alongside a dynamic quorum flag when formatting [kafka]

2025-07-10 Thread via GitHub
kevin-wu24 commented on code in PR #20136: URL: https://github.com/apache/kafka/pull/20136#discussion_r2198390326 ## core/src/test/scala/unit/kafka/tools/StorageToolTest.scala: ## @@ -376,6 +376,8 @@ Found problem: val availableDirs = Seq(TestUtils.tempDir()) val prope

Re: [PR] KAFKA-18105 Fix flaky PlaintextAdminIntegrationTest#testElectPreferredLeaders [kafka]

2025-07-10 Thread via GitHub
jim0987795064 commented on code in PR #20068: URL: https://github.com/apache/kafka/pull/20068#discussion_r2198412169 ## core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala: ## @@ -2850,6 +2851,20 @@ class PlaintextAdminIntegrationTest extends BaseAdmin

Re: [PR] KAFKA-18105 Fix flaky PlaintextAdminIntegrationTest#testElectPreferredLeaders [kafka]

2025-07-10 Thread via GitHub
jim0987795064 commented on code in PR #20068: URL: https://github.com/apache/kafka/pull/20068#discussion_r2198405354 ## core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala: ## @@ -2850,6 +2851,20 @@ class PlaintextAdminIntegrationTest extends BaseAdmin

Re: [PR] KAFKA-19489: storage tool should check controller.quorum.voters is not set alongside a dynamic quorum flag when formatting [kafka]

2025-07-10 Thread via GitHub
kevin-wu24 commented on code in PR #20136: URL: https://github.com/apache/kafka/pull/20136#discussion_r2198390326 ## core/src/test/scala/unit/kafka/tools/StorageToolTest.scala: ## @@ -376,6 +376,8 @@ Found problem: val availableDirs = Seq(TestUtils.tempDir()) val prope

Re: [PR] KAFKA-19489: storage tool should check controller.quorum.voters is not set alongside a dynamic quorum flag when formatting [kafka]

2025-07-10 Thread via GitHub
kevin-wu24 commented on code in PR #20136: URL: https://github.com/apache/kafka/pull/20136#discussion_r2198387770 ## core/src/main/scala/kafka/tools/StorageTool.scala: ## @@ -135,6 +135,15 @@ object StorageTool extends Logging { featureNamesAndLevels(_).foreachEntry {

Re: [PR] KAFKA-19489: storage tool should check controller.quorum.voters is not set alongside a dynamic quorum flag when formatting [kafka]

2025-07-10 Thread via GitHub
ahuang98 commented on code in PR #20136: URL: https://github.com/apache/kafka/pull/20136#discussion_r2198338634 ## core/src/main/scala/kafka/tools/StorageTool.scala: ## @@ -135,6 +135,15 @@ object StorageTool extends Logging { featureNamesAndLevels(_).foreachEntry {

Re: [PR] KAFKA-19400: Update AddRaftVoterRequest RPC to version 1 [kafka]

2025-07-10 Thread via GitHub
kevin-wu24 commented on code in PR #19982: URL: https://github.com/apache/kafka/pull/19982#discussion_r2198365307 ## raft/src/test/java/org/apache/kafka/raft/KafkaRaftClientReconfigTest.java: ## @@ -374,26 +428,104 @@ public void testAddVoter() throws Exception { ap

Re: [PR] KAFKA-19400: Update AddRaftVoterRequest RPC to version 1 [kafka]

2025-07-10 Thread via GitHub
kevin-wu24 commented on code in PR #19982: URL: https://github.com/apache/kafka/pull/19982#discussion_r2198357341 ## raft/src/test/java/org/apache/kafka/raft/KafkaRaftClientReconfigTest.java: ## @@ -374,26 +428,104 @@ public void testAddVoter() throws Exception { ap

Re: [PR] KAFKA-19400: Update AddRaftVoterRequest RPC to version 1 [kafka]

2025-07-10 Thread via GitHub
kevin-wu24 commented on code in PR #19982: URL: https://github.com/apache/kafka/pull/19982#discussion_r2198336453 ## raft/src/test/java/org/apache/kafka/raft/KafkaRaftClientReconfigTest.java: ## @@ -374,26 +428,104 @@ public void testAddVoter() throws Exception { ap

Re: [PR] KAFKA-19306: Migrate LogCompactionTester to tools module [kafka]

2025-07-10 Thread via GitHub
Yunyung commented on code in PR #19905: URL: https://github.com/apache/kafka/pull/19905#discussion_r2198282302 ## tools/src/main/java/org/apache/kafka/tools/LogCompactionTester.java: ## @@ -0,0 +1,529 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more

Re: [PR] KAFKA-19400: Update AddRaftVoterRequest RPC to version 1 [kafka]

2025-07-10 Thread via GitHub
kevin-wu24 commented on code in PR #19982: URL: https://github.com/apache/kafka/pull/19982#discussion_r2198357341 ## raft/src/test/java/org/apache/kafka/raft/KafkaRaftClientReconfigTest.java: ## @@ -374,26 +428,104 @@ public void testAddVoter() throws Exception { ap

Re: [PR] KAFKA-19306: Migrate LogCompactionTester to tools module [kafka]

2025-07-10 Thread via GitHub
Yunyung commented on code in PR #19905: URL: https://github.com/apache/kafka/pull/19905#discussion_r2198339311 ## tools/src/main/java/org/apache/kafka/tools/LogCompactionTester.java: ## @@ -0,0 +1,529 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more

Re: [PR] [WIP] KAFKA-19012: Messages ending up on the wrong topic [kafka]

2025-07-10 Thread via GitHub
junrao commented on code in PR #20138: URL: https://github.com/apache/kafka/pull/20138#discussion_r2198336561 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java: ## @@ -884,6 +897,8 @@ private void sendProduceRequest(long now, int destination, shor

Re: [PR] KAFKA-19400: Update AddRaftVoterRequest RPC to version 1 [kafka]

2025-07-10 Thread via GitHub
kevin-wu24 commented on code in PR #19982: URL: https://github.com/apache/kafka/pull/19982#discussion_r2198341063 ## raft/src/test/java/org/apache/kafka/raft/KafkaRaftClientReconfigTest.java: ## @@ -339,27 +340,80 @@ public void testAddVoter() throws Exception { Map

Re: [PR] KAFKA-19400: Update AddRaftVoterRequest RPC to version 1 [kafka]

2025-07-10 Thread via GitHub
kevin-wu24 commented on code in PR #19982: URL: https://github.com/apache/kafka/pull/19982#discussion_r2198336453 ## raft/src/test/java/org/apache/kafka/raft/KafkaRaftClientReconfigTest.java: ## @@ -374,26 +428,104 @@ public void testAddVoter() throws Exception { ap

Re: [PR] KAFKA-18336: Improve jmh tests on ACL in AuthorizerBenchmark and StandardAuthorizerUpdateBenchmark [kafka]

2025-07-10 Thread via GitHub
ekuvardin commented on code in PR #18293: URL: https://github.com/apache/kafka/pull/18293#discussion_r2198335513 ## jmh-benchmarks/src/main/java/org/apache/kafka/jmh/acl/AuthorizerBenchmark.java: ## @@ -89,13 +90,19 @@ public class AuthorizerBenchmark { private List actions

Re: [PR] KAFKA-19400: Update AddRaftVoterRequest RPC to version 1 [kafka]

2025-07-10 Thread via GitHub
ahuang98 commented on code in PR #19982: URL: https://github.com/apache/kafka/pull/19982#discussion_r2198334121 ## raft/src/test/java/org/apache/kafka/raft/KafkaRaftClientReconfigTest.java: ## @@ -374,26 +428,104 @@ public void testAddVoter() throws Exception { apiV

Re: [PR] KAFKA-19400: Update AddRaftVoterRequest RPC to version 1 [kafka]

2025-07-10 Thread via GitHub
ahuang98 commented on code in PR #19982: URL: https://github.com/apache/kafka/pull/19982#discussion_r2198332477 ## raft/src/test/java/org/apache/kafka/raft/KafkaRaftClientReconfigTest.java: ## @@ -374,26 +428,104 @@ public void testAddVoter() throws Exception { apiV

Re: [PR] KAFKA-19400: Update AddRaftVoterRequest RPC to version 1 [kafka]

2025-07-10 Thread via GitHub
kevin-wu24 commented on code in PR #19982: URL: https://github.com/apache/kafka/pull/19982#discussion_r2198329004 ## raft/src/test/java/org/apache/kafka/raft/KafkaRaftClientReconfigTest.java: ## @@ -339,27 +340,80 @@ public void testAddVoter() throws Exception { Map

Re: [PR] KAFKA-18336: Improve jmh tests on ACL in AuthorizerBenchmark and StandardAuthorizerUpdateBenchmark [kafka]

2025-07-10 Thread via GitHub
ekuvardin commented on code in PR #18293: URL: https://github.com/apache/kafka/pull/18293#discussion_r2198319395 ## jmh-benchmarks/src/main/java/org/apache/kafka/jmh/acl/StandardAuthorizerUpdateBenchmark.java: ## @@ -55,8 +55,8 @@ @State(Scope.Benchmark) @Fork(value = 1) -@W

Re: [PR] KAFKA-19400: Update AddRaftVoterRequest RPC to version 1 [kafka]

2025-07-10 Thread via GitHub
kevin-wu24 commented on code in PR #19982: URL: https://github.com/apache/kafka/pull/19982#discussion_r2198315211 ## raft/src/test/java/org/apache/kafka/raft/KafkaRaftClientReconfigTest.java: ## @@ -374,26 +428,104 @@ public void testAddVoter() throws Exception { ap

Re: [PR] KAFKA-19306: Migrate LogCompactionTester to tools module [kafka]

2025-07-10 Thread via GitHub
Yunyung commented on code in PR #19905: URL: https://github.com/apache/kafka/pull/19905#discussion_r2198269571 ## tools/src/main/java/org/apache/kafka/tools/LogCompactionTester.java: ## @@ -0,0 +1,529 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more

Re: [PR] KAFKA-19400: Update AddRaftVoterRequest RPC to version 1 [kafka]

2025-07-10 Thread via GitHub
ahuang98 commented on code in PR #19982: URL: https://github.com/apache/kafka/pull/19982#discussion_r2198305883 ## raft/src/test/java/org/apache/kafka/raft/KafkaRaftClientReconfigTest.java: ## @@ -374,26 +428,104 @@ public void testAddVoter() throws Exception { apiV

Re: [PR] KAFKA-19306: Migrate LogCompactionTester to tools module [kafka]

2025-07-10 Thread via GitHub
Yunyung commented on code in PR #19905: URL: https://github.com/apache/kafka/pull/19905#discussion_r2198247187 ## tools/src/main/java/org/apache/kafka/tools/LogCompactionTester.java: ## @@ -0,0 +1,529 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more

Re: [PR] KAFKA-19400: Update AddRaftVoterRequest RPC to version 1 [kafka]

2025-07-10 Thread via GitHub
ahuang98 commented on code in PR #19982: URL: https://github.com/apache/kafka/pull/19982#discussion_r2198308763 ## raft/src/test/java/org/apache/kafka/raft/KafkaRaftClientReconfigTest.java: ## @@ -339,27 +340,80 @@ public void testAddVoter() throws Exception { Map.o

Re: [PR] KAFKA-19306: Migrate LogCompactionTester to tools module [kafka]

2025-07-10 Thread via GitHub
Yunyung commented on code in PR #19905: URL: https://github.com/apache/kafka/pull/19905#discussion_r2198269571 ## tools/src/main/java/org/apache/kafka/tools/LogCompactionTester.java: ## @@ -0,0 +1,529 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more

Re: [PR] KAFKA-19213 Client ignores default properties [kafka]

2025-07-10 Thread via GitHub
ezhou413 commented on PR #20134: URL: https://github.com/apache/kafka/pull/20134#issuecomment-3058284500 Sounds good to me. In this case, should we continue work on this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] KAFKA-19254: Add generic feature level metrics [kafka]

2025-07-10 Thread via GitHub
kevin-wu24 commented on PR #20021: URL: https://github.com/apache/kafka/pull/20021#issuecomment-3058292121 @chia7712 Are you able to take another look? If there is anything else let me know. Thanks for the reviews. -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] Minor : Use specific error in compression catch handle [kafka]

2025-07-10 Thread via GitHub
chia7712 commented on code in PR #20144: URL: https://github.com/apache/kafka/pull/20144#discussion_r2198274135 ## clients/src/main/java/org/apache/kafka/common/telemetry/internals/ClientTelemetryReporter.java: ## @@ -717,7 +718,7 @@ private Optional> createPushRequest(ClientTe

Re: [PR] MINOR : Handle error for client telemetry push [kafka]

2025-07-10 Thread via GitHub
k-raina commented on code in PR #19881: URL: https://github.com/apache/kafka/pull/19881#discussion_r2198266270 ## clients/src/main/java/org/apache/kafka/common/telemetry/internals/ClientTelemetryReporter.java: ## @@ -718,8 +717,8 @@ private Optional> createPushRequest(ClientTel

Re: [PR] MINOR : Handle error for client telemetry push [kafka]

2025-07-10 Thread via GitHub
k-raina commented on code in PR #19881: URL: https://github.com/apache/kafka/pull/19881#discussion_r2198266270 ## clients/src/main/java/org/apache/kafka/common/telemetry/internals/ClientTelemetryReporter.java: ## @@ -718,8 +717,8 @@ private Optional> createPushRequest(ClientTel

Re: [PR] MINOR : Handle error for client telemetry push [kafka]

2025-07-10 Thread via GitHub
k-raina commented on code in PR #19881: URL: https://github.com/apache/kafka/pull/19881#discussion_r2198254154 ## clients/src/main/java/org/apache/kafka/common/telemetry/internals/ClientTelemetryReporter.java: ## @@ -718,8 +717,8 @@ private Optional> createPushRequest(ClientTel

[PR] Minor : Use specific error in compression catch handle [kafka]

2025-07-10 Thread via GitHub
k-raina opened a new pull request, #20144: URL: https://github.com/apache/kafka/pull/20144 Instead of throwable, use specific error in compression catch handle -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

Re: [PR] MINOR: Cleanup Connect Module (1/n) [kafka]

2025-07-10 Thread via GitHub
chia7712 merged PR #19869: URL: https://github.com/apache/kafka/pull/19869 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] MINOR : Handle error for client telemetry push [kafka]

2025-07-10 Thread via GitHub
chia7712 commented on code in PR #19881: URL: https://github.com/apache/kafka/pull/19881#discussion_r2198189309 ## clients/src/main/java/org/apache/kafka/common/telemetry/internals/ClientTelemetryReporter.java: ## @@ -718,8 +717,8 @@ private Optional> createPushRequest(ClientTe

[jira] [Comment Edited] (KAFKA-19493) Incorrect rate metric with larger window size

2025-07-10 Thread Apoorv Mittal (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18004473#comment-18004473 ] Apoorv Mittal edited comment on KAFKA-19493 at 7/10/25 3:59 PM: --

[jira] [Commented] (KAFKA-19493) Incorrect rate metric with larger window size

2025-07-10 Thread Apoorv Mittal (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18004473#comment-18004473 ] Apoorv Mittal commented on KAFKA-19493: --- [~isding_l] Please go ahead. > Incorrect

[jira] [Updated] (KAFKA-19493) Incorrect rate metric with larger window size

2025-07-10 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19493?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-19493: Component/s: clients metrics > Incorrect rate metric with larger window s

[jira] [Updated] (KAFKA-19495) DefaultJwtRetriever could not be found with Docker native image

2025-07-10 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19495?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison updated KAFKA-19495: --- Description: I built a native image for 4.1.0-rc0 (https://github.com/apache/kafka/actions/

Re: [PR] KAFKA-18105 Fix flaky PlaintextAdminIntegrationTest#testElectPreferredLeaders [kafka]

2025-07-10 Thread via GitHub
m1a2st commented on code in PR #20068: URL: https://github.com/apache/kafka/pull/20068#discussion_r2198067365 ## core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala: ## @@ -2850,6 +2851,20 @@ class PlaintextAdminIntegrationTest extends BaseAdminIntegra

[jira] [Created] (KAFKA-19495) DefaultJwtRetriever could not be found with Docker native image

2025-07-10 Thread Mickael Maison (Jira)
Mickael Maison created KAFKA-19495: -- Summary: DefaultJwtRetriever could not be found with Docker native image Key: KAFKA-19495 URL: https://issues.apache.org/jira/browse/KAFKA-19495 Project: Kafka

Re: [PR] MINOR : Handle error for client telemetry push [kafka]

2025-07-10 Thread via GitHub
ijuma commented on code in PR #19881: URL: https://github.com/apache/kafka/pull/19881#discussion_r2198051840 ## clients/src/main/java/org/apache/kafka/common/telemetry/internals/ClientTelemetryReporter.java: ## @@ -718,8 +717,8 @@ private Optional> createPushRequest(ClientTelem

[PR] KAFKA-19332: Fix flaky test : testAlterReadCommittedToReadUncommittedIsolationLevelWithReleaseAck and testAlterReadCommittedToReadUncommittedIsolationLevelWithRejectAck [kafka]

2025-07-10 Thread via GitHub
adixitconfluent opened a new pull request, #20143: URL: https://github.com/apache/kafka/pull/20143 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscri

Re: [PR] KAFKA-19377:Update /streams/developer-guide/security.html for KIP-1071 [kafka]

2025-07-10 Thread via GitHub
KTKTK-HZ commented on PR #20084: URL: https://github.com/apache/kafka/pull/20084#issuecomment-3057729468 @lucasbru Thanks for your suggestions. The document has been revised, and the rendered results of the document have also been updated. -- This is an automated message from the Apache G

Re: [PR] KAFKA-19213 Client ignores default properties [kafka]

2025-07-10 Thread via GitHub
Yunyung commented on PR #20134: URL: https://github.com/apache/kafka/pull/20134#issuecomment-3057714702 > The usage of `Properties` should be deprecated in the public APIs. Documentation should be added to suggest users use `Map` instead. Perhaps we could add warning messages to remind user

Re: [PR] KAFKA-19431: Ensure consumer and share assignment consistency with subscriptions [kafka]

2025-07-10 Thread via GitHub
squah-confluent commented on code in PR #20055: URL: https://github.com/apache/kafka/pull/20055#discussion_r2197791218 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -3073,7 +3095,7 @@ private static boolean isNotEmpty(Stri

[jira] [Commented] (KAFKA-19444) SASL GSSAPI not working with librdkafka and AK 4.x

2025-07-10 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18004433#comment-18004433 ] Ismael Juma commented on KAFKA-19444: - Filed KAFKA-19494 for undeprecating these ver

[jira] [Commented] (KAFKA-19493) Incorrect rate metric with larger window size

2025-07-10 Thread Lan Ding (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18004427#comment-18004427 ] Lan Ding commented on KAFKA-19493: -- Hi [~apoorvmittal10], if you're not working on this

[PR] KAFKA-19494: Undeprecate JoinGroup V0 & V1 [kafka]

2025-07-10 Thread via GitHub
ijuma opened a new pull request, #20142: URL: https://github.com/apache/kafka/pull/20142 We added back support for JoinGroup v0 & v1 in Kafka 4.0.1 and 4.1.0 due to KAFKA-19444. Given that, we should undeprecate these protocol api versions in 3.x. -- This is an automated message from the

[jira] [Updated] (KAFKA-19494) Undeprecate JoinGroup V0 & V1 in 3.x

2025-07-10 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19494?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma updated KAFKA-19494: Fix Version/s: 3.7.3 3.8.2 3.9.2 > Undeprecate JoinGroup V0

[jira] [Created] (KAFKA-19494) Undeprecate JoinGroup V0 & V1 in 3.x

2025-07-10 Thread Ismael Juma (Jira)
Ismael Juma created KAFKA-19494: --- Summary: Undeprecate JoinGroup V0 & V1 in 3.x Key: KAFKA-19494 URL: https://issues.apache.org/jira/browse/KAFKA-19494 Project: Kafka Issue Type: Improvement

Re: [PR] KAFKA-19478 [2/N]: Remove task pairs [kafka]

2025-07-10 Thread via GitHub
lucasbru commented on PR #20127: URL: https://github.com/apache/kafka/pull/20127#issuecomment-3057467823 > It’s likely these tests pass because such a closed-loop scenario is rare. However, if that scenario does occur, the tests may fail, leading to flakiness. To avoid introducing flaky tes

Re: [PR] KAFKA-19444: Add back JoinGroup v0 & v1 [kafka]

2025-07-10 Thread via GitHub
ijuma commented on PR #20116: URL: https://github.com/apache/kafka/pull/20116#issuecomment-3057460501 Thanks @mimaison - that's correct. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[jira] [Created] (KAFKA-19493) Incorrect rate metric with larger window size

2025-07-10 Thread Apoorv Mittal (Jira)
Apoorv Mittal created KAFKA-19493: - Summary: Incorrect rate metric with larger window size Key: KAFKA-19493 URL: https://issues.apache.org/jira/browse/KAFKA-19493 Project: Kafka Issue Type: B

Re: [PR] KAFKA-19213 Client ignores default properties [kafka]

2025-07-10 Thread via GitHub
chia7712 commented on PR #20134: URL: https://github.com/apache/kafka/pull/20134#issuecomment-3057145239 > Yes, this is also a good alternative for me, but even if we use Map instead of Properties, as far as I know, we still can’t prevent the user app from passing in a Properties (unless we

Re: [PR] KAFKA-19213 Client ignores default properties [kafka]

2025-07-10 Thread via GitHub
Yunyung commented on PR #20134: URL: https://github.com/apache/kafka/pull/20134#issuecomment-3057109935 Yes, this is also a good alternative for me, but even if we use Map instead of Properties, as far as I know, we still can’t prevent the user from passing in a Properties object (unless we

Re: [PR] KAFKA-19306: Migrate LogCompactionTester to tools module [kafka]

2025-07-10 Thread via GitHub
chia7712 commented on code in PR #19905: URL: https://github.com/apache/kafka/pull/19905#discussion_r2197479627 ## tools/src/main/java/org/apache/kafka/tools/LogCompactionTester.java: ## @@ -0,0 +1,529 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more

Re: [PR] KAFKA-18404: Remove partitionMaxBytes usage from DelayedShareFetch [kafka]

2025-07-10 Thread via GitHub
chia7712 commented on PR #17870: URL: https://github.com/apache/kafka/pull/17870#issuecomment-3057081487 > Yes, I do. It could control the amount of pre-fetching based on how quickly it is processing the buffered records. @kirktrue WDYT? it seems #18795 has similar discussion. Howeve

Re: [PR] KAFKA-19213 Client ignores default properties [kafka]

2025-07-10 Thread via GitHub
chia7712 commented on PR #20134: URL: https://github.com/apache/kafka/pull/20134#issuecomment-3057031438 Just an idea: we should avoid using `Properties` in codebase. The `Properties`'s defaults mechanism has not been used correctly for a while. I opened https://issues.apache.org/jira/brow

Re: [PR] MINOR:Add a description document to batchlength [kafka]

2025-07-10 Thread via GitHub
gongxuanzhang commented on code in PR #20140: URL: https://github.com/apache/kafka/pull/20140#discussion_r2197428759 ## docs/implementation.html: ## @@ -59,11 +59,14 @@

Re: [PR] KAFKA-18404: Remove partitionMaxBytes usage from DelayedShareFetch [kafka]

2025-07-10 Thread via GitHub
chia7712 commented on PR #17870: URL: https://github.com/apache/kafka/pull/17870#issuecomment-3056920837 > Today, it just looks to see whether it has any buffered data rather than looking at how much buffered data it has. There's a nice KIP in this area one day I think. Excuse me, do

Re: [PR] KAFKA-18404: Remove partitionMaxBytes usage from DelayedShareFetch [kafka]

2025-07-10 Thread via GitHub
AndrewJSchofield commented on PR #17870: URL: https://github.com/apache/kafka/pull/17870#issuecomment-3056940390 > > Today, it just looks to see whether it has any buffered data rather than looking at how much buffered data it has. There's a nice KIP in this area one day I think. > >

[PR] KAFKA-19492: Add logging in deleteRecordsOnLocalLog for out of range … [kafka]

2025-07-10 Thread via GitHub
srdo opened a new pull request, #20141: URL: https://github.com/apache/kafka/pull/20141 …errors This exception can occur for a few different reasons, and the exception message will say exactly why it happened. Debug logging it makes it easier for people to debug OFFSET_OUT_OF_RANGE e

[jira] [Created] (KAFKA-19492) ReplicaManager.deleteRecordsOnLocalLog should debug log the exception message when OffsetOutOfRangeException occurs

2025-07-10 Thread Jira
Stig Rohde Døssing created KAFKA-19492: -- Summary: ReplicaManager.deleteRecordsOnLocalLog should debug log the exception message when OffsetOutOfRangeException occurs Key: KAFKA-19492 URL: https://issues.apach

Re: [PR] MINOR:Add a description document to batchlength [kafka]

2025-07-10 Thread via GitHub
Yunyung commented on code in PR #20140: URL: https://github.com/apache/kafka/pull/20140#discussion_r2197359132 ## docs/implementation.html: ## @@ -59,11 +59,14 @@

Re: [PR] KAFKA-18404: Remove partitionMaxBytes usage from DelayedShareFetch [kafka]

2025-07-10 Thread via GitHub
AndrewJSchofield commented on PR #17870: URL: https://github.com/apache/kafka/pull/17870#issuecomment-3056862881 I think there's quite a lot of scope for improving this area in the regular fetch. For example, the consumer could and currently does not adjust the `PartitionMaxBytes` to contro

Re: [PR] KAFKA-18404: Remove partitionMaxBytes usage from DelayedShareFetch [kafka]

2025-07-10 Thread via GitHub
chia7712 commented on PR #17870: URL: https://github.com/apache/kafka/pull/17870#issuecomment-3056839932 > Having said that, maybe we can think of a logic to perform a retry in both fetch and share fetch in case the fetchable partitions are not returning enough data from replica manager.

  1   2   >