lucasbru commented on code in PR #20470:
URL: https://github.com/apache/kafka/pull/20470#discussion_r2320275918
##
streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamImpl.java:
##
@@ -1350,7 +1355,11 @@ public KStream processValues(
final Processor
kirktrue commented on code in PR #19980:
URL: https://github.com/apache/kafka/pull/19980#discussion_r2320217963
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/FetchBuffer.java:
##
@@ -98,7 +98,8 @@ void add(CompletedFetch completedFetch) {
try {
chia7712 commented on code in PR #20283:
URL: https://github.com/apache/kafka/pull/20283#discussion_r2319988221
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ShareConsumerImpl.java:
##
@@ -1116,19 +1116,23 @@ private boolean processBackgroundEvents() {
kirktrue commented on code in PR #19980:
URL: https://github.com/apache/kafka/pull/19980#discussion_r2320220634
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractFetch.java:
##
@@ -222,6 +222,10 @@ protected void handleFetchSuccess(final Node fetchTarg
kirktrue commented on code in PR #19980:
URL: https://github.com/apache/kafka/pull/19980#discussion_r2320188205
##
clients/clients-integration-tests/src/test/java/org/apache/kafka/clients/consumer/PlaintextConsumerTest.java:
##
@@ -1588,6 +1590,75 @@ private void sendCompressedM
Yunyung commented on PR #20469:
URL: https://github.com/apache/kafka/pull/20469#issuecomment-3250577602
Great. LGTM, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
chia7712 commented on code in PR #20471:
URL: https://github.com/apache/kafka/pull/20471#discussion_r2319940997
##
tests/kafkatest/services/verifiable_producer.py:
##
@@ -249,7 +249,14 @@ def start_cmd(self, node, idx):
if self.repeating_keys is not None:
c
chia7712 commented on code in PR #20451:
URL: https://github.com/apache/kafka/pull/20451#discussion_r2320005613
##
clients/clients-integration-tests/src/test/java/org/apache/kafka/clients/consumer/PlaintextConsumerTest.java:
##
@@ -553,14 +553,18 @@ private void testInterceptors
MahsaSeifikar commented on code in PR #20422:
URL: https://github.com/apache/kafka/pull/20422#discussion_r2319986360
##
metadata/src/main/java/org/apache/kafka/controller/QuorumController.java:
##
@@ -549,6 +550,7 @@ private Throwable handleEventException(
} else {
chia7712 commented on code in PR #20472:
URL: https://github.com/apache/kafka/pull/20472#discussion_r2320011286
##
clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java:
##
@@ -1833,6 +1838,9 @@ public void close(Duration timeout) {
* {@link ConsumerCo
bbejeck commented on code in PR #20470:
URL: https://github.com/apache/kafka/pull/20470#discussion_r2319992952
##
streams/src/test/java/org/apache/kafka/streams/kstream/internals/graph/StreamsGraphTest.java:
##
@@ -386,20 +392,20 @@ private int getCountOfRepartitionTopicsFound(f
mjsax commented on code in PR #20470:
URL: https://github.com/apache/kafka/pull/20470#discussion_r2319983417
##
streams/src/main/java/org/apache/kafka/streams/TopologyConfig.java:
##
@@ -86,6 +87,28 @@
*/
@SuppressWarnings("deprecation")
public final class TopologyConfig ext
mjsax commented on code in PR #20470:
URL: https://github.com/apache/kafka/pull/20470#discussion_r2319982525
##
streams/src/main/java/org/apache/kafka/streams/TopologyConfig.java:
##
@@ -86,6 +87,28 @@
*/
@SuppressWarnings("deprecation")
public final class TopologyConfig ext
lianetm opened a new pull request, #20472:
URL: https://github.com/apache/kafka/pull/20472
Add to the consumer.close java doc to describe the error handling behaviour.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use th
bbejeck commented on code in PR #20470:
URL: https://github.com/apache/kafka/pull/20470#discussion_r2319932841
##
streams/src/main/java/org/apache/kafka/streams/TopologyConfig.java:
##
@@ -86,6 +87,28 @@
*/
@SuppressWarnings("deprecation")
public final class TopologyConfig e
mjsax commented on code in PR #20470:
URL: https://github.com/apache/kafka/pull/20470#discussion_r2319958062
##
streams/src/test/java/org/apache/kafka/streams/kstream/internals/graph/StreamsGraphTest.java:
##
@@ -386,20 +392,20 @@ private int getCountOfRepartitionTopicsFound(fin
chia7712 merged PR #20420:
URL: https://github.com/apache/kafka/pull/20420
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
JimmyWang6 opened a new pull request, #20471:
URL: https://github.com/apache/kafka/pull/20471
#20390 Replace the -`-producer.config` for the verifiable producer and
`--consumer.config` option by `--command-config` for the verifiable consumer.
However, for e2e tests targeting older broker v
mjsax opened a new pull request, #20470:
URL: https://github.com/apache/kafka/pull/20470
With "merge.repartition.topic" optimization enabled, Kafka Streams tries to
push repartition topics upstream, to be able to merge multiple repartition
topics from different downstream branches together.
Yunyung commented on PR #20469:
URL: https://github.com/apache/kafka/pull/20469#issuecomment-3250370171
Thanks for the PR. I see the same pattern in ReplicaVerificationTool.java;
could you update it as well?
Also, it would be great if you could provide the before and after output
results
ahuang98 commented on code in PR #20422:
URL: https://github.com/apache/kafka/pull/20422#discussion_r2319808559
##
metadata/src/main/java/org/apache/kafka/controller/QuorumController.java:
##
@@ -549,6 +550,7 @@ private Throwable handleEventException(
} else {
chia7712 merged PR #20301:
URL: https://github.com/apache/kafka/pull/20301
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
apalan60 opened a new pull request, #20469:
URL: https://github.com/apache/kafka/pull/20469
Refactor help and version handling in command-line tools by replacing
duplicate code with `CommandLineUtils#maybePrintHelpOrVersion`.
--
This is an automated message from the Apache Git Service.
To
Yunyung commented on code in PR #20438:
URL: https://github.com/apache/kafka/pull/20438#discussion_r2319771084
##
tools/src/main/java/org/apache/kafka/tools/VerifiableShareConsumer.java:
##
@@ -547,14 +548,15 @@ private static ArgumentParser argParser() {
.setDefaul
Yunyung commented on code in PR #20438:
URL: https://github.com/apache/kafka/pull/20438#discussion_r2319771084
##
tools/src/main/java/org/apache/kafka/tools/VerifiableShareConsumer.java:
##
@@ -547,14 +548,15 @@ private static ArgumentParser argParser() {
.setDefaul
Yunyung commented on code in PR #20438:
URL: https://github.com/apache/kafka/pull/20438#discussion_r2319771084
##
tools/src/main/java/org/apache/kafka/tools/VerifiableShareConsumer.java:
##
@@ -547,14 +548,15 @@ private static ArgumentParser argParser() {
.setDefaul
chia7712 commented on code in PR #20334:
URL: https://github.com/apache/kafka/pull/20334#discussion_r2319744748
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/rest/RestServerConfig.java:
##
@@ -139,12 +139,12 @@ public abstract class RestServerConfig extends
chia7712 merged PR #20435:
URL: https://github.com/apache/kafka/pull/20435
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
chia7712 commented on PR #19498:
URL: https://github.com/apache/kafka/pull/19498#issuecomment-3250160433
the successor is #20435
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comme
chia7712 commented on code in PR #20393:
URL: https://github.com/apache/kafka/pull/20393#discussion_r2319705983
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/rest/entities/PluginInfo.java:
##
@@ -19,85 +19,30 @@
import org.apache.kafka.connect.runtime.isolat
chia7712 commented on code in PR #20438:
URL: https://github.com/apache/kafka/pull/20438#discussion_r2319682177
##
tools/src/main/java/org/apache/kafka/tools/VerifiableShareConsumer.java:
##
@@ -547,14 +548,15 @@ private static ArgumentParser argParser() {
.setDefau
AndrewJSchofield commented on code in PR #20390:
URL: https://github.com/apache/kafka/pull/20390#discussion_r2319525684
##
tests/kafkatest/services/verifiable_producer.py:
##
@@ -249,7 +249,7 @@ def start_cmd(self, node, idx):
if self.repeating_keys is not None:
aheev commented on code in PR #20256:
URL: https://github.com/apache/kafka/pull/20256#discussion_r2319418482
##
storage/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteLogManager.java:
##
@@ -490,8 +479,8 @@ public void onLeadershipChange(Set
partitionsBecomeLead
omkreddy commented on code in PR #20390:
URL: https://github.com/apache/kafka/pull/20390#discussion_r2319391162
##
tests/kafkatest/services/verifiable_producer.py:
##
@@ -249,7 +249,7 @@ def start_cmd(self, node, idx):
if self.repeating_keys is not None:
cm
lucasbru merged PR #20172:
URL: https://github.com/apache/kafka/pull/20172
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
frankvicky commented on code in PR #20383:
URL: https://github.com/apache/kafka/pull/20383#discussion_r2319276289
##
server/src/main/java/org/apache/kafka/server/DefaultAutoTopicCreationManager.java:
##
@@ -0,0 +1,255 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) u
AndrewJSchofield commented on PR #20466:
URL: https://github.com/apache/kafka/pull/20466#issuecomment-3249561868
@elmoctarebnou There are some build failures. Please check the logs and
resolve. For example:
```
Error:
/home/runner/work/kafka/kafka/core/src/test/scala/unit/kafka/s
AndrewJSchofield commented on PR #20385:
URL: https://github.com/apache/kafka/pull/20385#issuecomment-3249552935
> > Thanks for the PR. Once we have a green build, I'm ready to merge this.
>
> Shouldn't we wait for this? I am trying to run the tests, but running into
some issues
>
AndrewJSchofield merged PR #20438:
URL: https://github.com/apache/kafka/pull/20438
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafk
lucasbru commented on code in PR #20458:
URL: https://github.com/apache/kafka/pull/20458#discussion_r2315959967
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/streams/assignor/StickyTaskAssignor.java:
##
@@ -185,11 +195,13 @@ private void assignActive(fina
elmoctarebnou commented on code in PR #20466:
URL: https://github.com/apache/kafka/pull/20466#discussion_r2319107607
##
.gitignore:
##
@@ -31,6 +31,8 @@ TAGS
Vagrantfile.local
/logs
.DS_Store
+.bloop/
Review Comment:
Thanks for the review, @AndrewJSchofield. I’ve reverted
see-quick opened a new pull request, #20468:
URL: https://github.com/apache/kafka/pull/20468
This PR moves the ScramPublisher class from the server metadata package to
the dedicated metadata module. During refactoring, I found out that I also need
to move the CredentialProvider interface to
MahsaSeifikar commented on PR #20422:
URL: https://github.com/apache/kafka/pull/20422#issuecomment-3249255423
@chia7712 Could you please review this metric KIP when you get a chance?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Gi
lianetm commented on code in PR #19980:
URL: https://github.com/apache/kafka/pull/19980#discussion_r2318963044
##
clients/clients-integration-tests/src/test/java/org/apache/kafka/clients/consumer/PlaintextConsumerTest.java:
##
@@ -1588,6 +1590,75 @@ private void sendCompressedMe
Copilot commented on code in PR #20458:
URL: https://github.com/apache/kafka/pull/20458#discussion_r2318899271
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/streams/assignor/StickyTaskAssignor.java:
##
@@ -103,19 +113,19 @@ private void initialize(final G
dajac commented on code in PR #20055:
URL: https://github.com/apache/kafka/pull/20055#discussion_r2318877931
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -3089,9 +3111,9 @@ private static boolean isNotEmpty(String value)
shashankhs11 commented on code in PR #20462:
URL: https://github.com/apache/kafka/pull/20462#discussion_r2318872382
##
streams/integration-tests/src/test/java/org/apache/kafka/streams/integration/KafkaStreamsTelemetryIntegrationTest.java:
##
@@ -303,16 +304,15 @@ public void sho
lucasbru commented on code in PR #20462:
URL: https://github.com/apache/kafka/pull/20462#discussion_r2318823100
##
streams/integration-tests/src/test/java/org/apache/kafka/streams/integration/KafkaStreamsTelemetryIntegrationTest.java:
##
@@ -303,16 +304,15 @@ public void shouldP
AndrewJSchofield commented on code in PR #19980:
URL: https://github.com/apache/kafka/pull/19980#discussion_r2318806420
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractFetch.java:
##
@@ -222,6 +222,10 @@ protected void handleFetchSuccess(final Node f
Copilot commented on code in PR #20464:
URL: https://github.com/apache/kafka/pull/20464#discussion_r2318793769
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/DefaultStreamsRebalanceListener.java:
##
@@ -91,16 +107,21 @@ public Optional onTasksAssigned(fina
aheev commented on PR #20385:
URL: https://github.com/apache/kafka/pull/20385#issuecomment-3248992064
> Thanks for the PR. Once we have a green build, I'm ready to merge this.
Shouldn't we wait for this? I am trying to run the tests, but running into
some issues
> Since you hav
AndrewJSchofield commented on code in PR #19980:
URL: https://github.com/apache/kafka/pull/19980#discussion_r2318715441
##
clients/clients-integration-tests/src/test/java/org/apache/kafka/clients/consumer/PlaintextConsumerTest.java:
##
@@ -1588,6 +1590,75 @@ private void sendCom
AndrewJSchofield merged PR #20283:
URL: https://github.com/apache/kafka/pull/20283
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafk
ShivsundarR commented on PR #20283:
URL: https://github.com/apache/kafka/pull/20283#issuecomment-3248851776
Thanks @AndrewJSchofield, I used the `consumer-perf-test.sh` and
`share-consumer-perf-test.sh` tools to print the metrics before and after the
changes.
- For `ClassicKafkaConsu
Yunyung commented on code in PR #20399:
URL: https://github.com/apache/kafka/pull/20399#discussion_r2318573502
##
core/src/main/scala/kafka/server/AbstractFetcherManager.scala:
##
@@ -30,7 +30,9 @@ import scala.jdk.OptionConverters._
abstract class AbstractFetcherManager[T <:
mimaison commented on PR #20178:
URL: https://github.com/apache/kafka/pull/20178#issuecomment-3248674398
Can you also resolve the conflict? Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
mimaison merged PR #19940:
URL: https://github.com/apache/kafka/pull/19940
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
kuoche1712003 commented on code in PR #20399:
URL: https://github.com/apache/kafka/pull/20399#discussion_r2318536120
##
core/src/main/scala/kafka/server/AbstractFetcherManager.scala:
##
@@ -30,7 +30,9 @@ import scala.jdk.OptionConverters._
abstract class AbstractFetcherManage
mimaison commented on PR #19845:
URL: https://github.com/apache/kafka/pull/19845#issuecomment-3248596607
Thanks for the PR!
This modifies the Kafka Connect public API, so in order to accept this
change we need to have a Kafka Improvement Proposal (KIP). See the process on
https://cwi
sjhajharia commented on code in PR #20393:
URL: https://github.com/apache/kafka/pull/20393#discussion_r2318467236
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/rest/entities/PluginInfo.java:
##
@@ -45,59 +46,23 @@ public PluginInfo(PluginDesc plugin) {
AndrewJSchofield commented on PR #20385:
URL: https://github.com/apache/kafka/pull/20385#issuecomment-3248580711
@aheev Please resolve conflicts
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
mimaison commented on PR #17554:
URL: https://github.com/apache/kafka/pull/17554#issuecomment-3248561958
@chia7712 Did you have other comments?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
mimaison commented on PR #20408:
URL: https://github.com/apache/kafka/pull/20408#issuecomment-3248423413
> Will hold of merging until 4.1 went out, and I can cherry-pick to AK 4.1
branch
Feel free to merge and backport to 4.1. I've bumped 4.1 to 4.1.1-SNAPSHOT,
it's open to commits
dejan2609 commented on PR #20450:
URL: https://github.com/apache/kafka/pull/20450#issuecomment-3248401370
Much obliged Ken @m1a2st :ok_hand: !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
AndrewJSchofield opened a new pull request, #20467:
URL: https://github.com/apache/kafka/pull/20467
Ensure that metrics are retrieved and displayed (when requested) before
ShareConsumer.close() is called. This is important because metrics are
technically supposed to be removed on ShareC
mimaison merged PR #20077:
URL: https://github.com/apache/kafka/pull/20077
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
chia7712 commented on code in PR #20267:
URL: https://github.com/apache/kafka/pull/20267#discussion_r2318289086
##
tools/src/main/java/org/apache/kafka/tools/ConsumerPerformance.java:
##
@@ -66,45 +69,42 @@ public static void main(String[] args) {
if (!options.hideH
lucasbru commented on PR #19400:
URL: https://github.com/apache/kafka/pull/19400#issuecomment-3242118581
@frankvicky It looks like that integration test was broken by
https://github.com/apache/kafka/pull/20284 . I can see that it passes on CI
only because it is first run with the old protoc
AndrewJSchofield commented on code in PR #20267:
URL: https://github.com/apache/kafka/pull/20267#discussion_r2318287119
##
tools/src/main/java/org/apache/kafka/tools/ConsumerPerformance.java:
##
@@ -66,45 +69,42 @@ public static void main(String[] args) {
if (!optio
kamalcph commented on code in PR #20428:
URL: https://github.com/apache/kafka/pull/20428#discussion_r2317900129
##
core/src/main/scala/kafka/server/LocalLeaderEndPoint.scala:
##
@@ -135,6 +135,35 @@ class LocalLeaderEndPoint(sourceBroker: BrokerEndPoint,
new OffsetAndEpoch(
chia7712 commented on code in PR #20267:
URL: https://github.com/apache/kafka/pull/20267#discussion_r2318276501
##
tools/src/main/java/org/apache/kafka/tools/ConsumerPerformance.java:
##
@@ -66,45 +69,42 @@ public static void main(String[] args) {
if (!options.hideH
lucasbru commented on code in PR #20244:
URL: https://github.com/apache/kafka/pull/20244#discussion_r2318251588
##
core/src/test/scala/integration/kafka/api/IntegrationTestHarness.scala:
##
@@ -22,23 +22,26 @@ import org.apache.kafka.clients.consumer.{Consumer,
ConsumerConfig,
mimaison commented on code in PR #20077:
URL: https://github.com/apache/kafka/pull/20077#discussion_r2318247211
##
connect/json/src/main/java/org/apache/kafka/connect/json/JsonConverter.java:
##
@@ -152,8 +152,6 @@ public JsonNode toJson(final Schema schema, final Object
value,
lucasbru commented on code in PR #20244:
URL: https://github.com/apache/kafka/pull/20244#discussion_r2318241369
##
core/src/test/scala/integration/kafka/api/IntegrationTestHarness.scala:
##
@@ -152,12 +155,11 @@ abstract class IntegrationTestHarness extends
KafkaServerTestHarne
chia7712 commented on code in PR #20390:
URL: https://github.com/apache/kafka/pull/20390#discussion_r2318235635
##
tests/kafkatest/services/verifiable_consumer.py:
##
@@ -424,7 +424,7 @@ def start_cmd(self, node):
if self.max_messages > 0:
cmd += " --max-me
AndrewJSchofield merged PR #20267:
URL: https://github.com/apache/kafka/pull/20267
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafk
lucasbru commented on code in PR #20455:
URL: https://github.com/apache/kafka/pull/20455#discussion_r2318171288
##
clients/clients-integration-tests/src/test/java/org/apache/kafka/clients/admin/ClientTelemetryTest.java:
##
@@ -123,13 +123,12 @@ public void testClientInstanceId(C
Copilot commented on code in PR #20244:
URL: https://github.com/apache/kafka/pull/20244#discussion_r2317179080
##
core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala:
##
@@ -2589,13 +2590,14 @@ class PlaintextAdminIntegrationTest extends
BaseAdminInteg
chia7712 commented on code in PR #18611:
URL: https://github.com/apache/kafka/pull/18611#discussion_r2318146619
##
connect/api/src/test/java/org/apache/kafka/connect/data/ValuesTest.java:
##
@@ -901,8 +903,10 @@ public void shouldConvertDateValues() {
assertEquals(curre
aliehsaeedii commented on code in PR #20320:
URL: https://github.com/apache/kafka/pull/20320#discussion_r2315502617
##
tools/src/test/java/org/apache/kafka/tools/streams/DescribeStreamsGroupTest.java:
##
@@ -252,10 +255,17 @@ public void testDescribeNonExistingStreamsGroup() {
jack2012aa opened a new pull request, #20461:
URL: https://github.com/apache/kafka/pull/20461
# Description
Admin#desceibeReplicaLogDirs fails all futures when any error happens,
regardless of the exception type or the failed directory. Especially, required
by the issue, CLUSTER_AUTHORIZ
mimaison commented on PR #19762:
URL: https://github.com/apache/kafka/pull/19762#issuecomment-3245965884
Rebased on trunk, @jsancio @junrao can you take another look? Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
shashankhs11 commented on PR #20392:
URL: https://github.com/apache/kafka/pull/20392#issuecomment-3246764959
I created a new subtask
[KAFKA-19666](https://issues.apache.org/jira/browse/KAFKA-19666) to this parent
issue to track the cleanup of all related integration tests.
Clean up o
AndrewJSchofield commented on code in PR #20466:
URL: https://github.com/apache/kafka/pull/20466#discussion_r2318107859
##
.gitignore:
##
@@ -31,6 +31,8 @@ TAGS
Vagrantfile.local
/logs
.DS_Store
+.bloop/
Review Comment:
Please revert this change.
--
This is an automat
dejan2609 opened a new pull request, #20450:
URL: https://github.com/apache/kafka/pull/20450
Blocks this PR:
- #19513
**Rationale:** GitHub Actions build breaks (with a different errors) when
trying to upgrade plugins mentioned below.
**Scenario:** test plugin upgrades for
chia7712 commented on code in PR #20393:
URL: https://github.com/apache/kafka/pull/20393#discussion_r2318100347
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/rest/entities/PluginInfo.java:
##
@@ -45,59 +46,23 @@ public PluginInfo(PluginDesc plugin) {
github-actions[bot] commented on PR #20392:
URL: https://github.com/apache/kafka/pull/20392#issuecomment-3243660066
A label of 'needs-attention' was automatically added to this PR in order to
raise the
attention of the committers. Once this issue has been triaged, the `triage`
label
s
github-actions[bot] commented on PR #20402:
URL: https://github.com/apache/kafka/pull/20402#issuecomment-3243660045
A label of 'needs-attention' was automatically added to this PR in order to
raise the
attention of the committers. Once this issue has been triaged, the `triage`
label
s
RaidenE1 opened a new pull request, #20464:
URL: https://github.com/apache/kafka/pull/20464
- Background
Add new metrics for TasksLost, TasksAssigned and TasksRevoked in
`StreamsRebalanceListener`.
- Features Implemented
Added three rebalance latency metrics to Defau
shashankhs11 opened a new pull request, #20463:
URL: https://github.com/apache/kafka/pull/20463
Clean up `PauseResumeIntegrationTest`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
lianetm commented on code in PR #20324:
URL: https://github.com/apache/kafka/pull/20324#discussion_r2316969099
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ThreadSafeAsyncConsumerState.java:
##
@@ -0,0 +1,160 @@
+/*
+ * Licensed to the Apache Software Fou
lucasbru commented on PR #19400:
URL: https://github.com/apache/kafka/pull/19400#issuecomment-3241614781
@frankvicky What I actually meant to ask in my previous comment: Are you
planning to implement these changes also for KIP-1071? While static membership
isn't fully implemented yet for KI
shashankhs11 commented on code in PR #20462:
URL: https://github.com/apache/kafka/pull/20462#discussion_r2317221468
##
streams/integration-tests/src/test/java/org/apache/kafka/streams/integration/KafkaStreamsTelemetryIntegrationTest.java:
##
@@ -444,7 +444,7 @@ private List getT
elmoctarebnou opened a new pull request, #20466:
URL: https://github.com/apache/kafka/pull/20466
Cleanup 'share' from group.coordinator.rebalance.protocols as a valid value.
Share Groups should instead be enabled through the share.version
Reviewers: Christo
Lolov[christolo...@gmail.com](
skrcode commented on PR #20454:
URL: https://github.com/apache/kafka/pull/20454#issuecomment-3243720720
Reviewers: @kirktrue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
shashankhs11 opened a new pull request, #20465:
URL: https://github.com/apache/kafka/pull/20465
clean up `SmokeTestDriverIntegrationTest`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the speci
lucliu1108 commented on code in PR #20244:
URL: https://github.com/apache/kafka/pull/20244#discussion_r2317283715
##
core/src/test/scala/integration/kafka/api/IntegrationTestHarness.scala:
##
@@ -56,6 +59,7 @@ abstract class IntegrationTestHarness extends
KafkaServerTestHarness
lianetm commented on code in PR #19980:
URL: https://github.com/apache/kafka/pull/19980#discussion_r2298653648
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractFetch.java:
##
@@ -222,6 +222,10 @@ protected void handleFetchSuccess(final Node fetchTarge
mimaison opened a new pull request, #20459:
URL: https://github.com/apache/kafka/pull/20459
Update the supported tags for the 4.1.0 release
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
showuon commented on code in PR #20077:
URL: https://github.com/apache/kafka/pull/20077#discussion_r2317632328
##
connect/json/src/main/java/org/apache/kafka/connect/json/JsonConverter.java:
##
@@ -152,8 +152,6 @@ public JsonNode toJson(final Schema schema, final Object
value,
1 - 100 of 18455 matches
Mail list logo
