Hangleton commented on code in PR #13378:
URL: https://github.com/apache/kafka/pull/13378#discussion_r1132523221
##
core/src/main/scala/kafka/coordinator/group/GroupCoordinatorAdapter.scala:
##
@@ -388,18 +393,27 @@ private[group] class GroupCoordinatorAdapter(
case reten
Hangleton commented on code in PR #13378:
URL: https://github.com/apache/kafka/pull/13378#discussion_r1132525996
##
core/src/main/scala/kafka/coordinator/group/GroupCoordinator.scala:
##
@@ -1034,16 +1035,21 @@ private[group] class GroupCoordinator(
if (validationErrorOpt
Hangleton commented on code in PR #13378:
URL: https://github.com/apache/kafka/pull/13378#discussion_r1132525996
##
core/src/main/scala/kafka/coordinator/group/GroupCoordinator.scala:
##
@@ -1034,16 +1035,21 @@ private[group] class GroupCoordinator(
if (validationErrorOpt
Hangleton commented on code in PR #13378:
URL: https://github.com/apache/kafka/pull/13378#discussion_r1132523221
##
core/src/main/scala/kafka/coordinator/group/GroupCoordinatorAdapter.scala:
##
@@ -388,18 +393,27 @@ private[group] class GroupCoordinatorAdapter(
case reten
Hangleton commented on code in PR #13378:
URL: https://github.com/apache/kafka/pull/13378#discussion_r1132780881
##
core/src/main/scala/kafka/coordinator/group/GroupCoordinator.scala:
##
@@ -971,8 +971,11 @@ private[group] class GroupCoordinator(
if (validationErrorOpt.is
Hangleton commented on code in PR #13378:
URL: https://github.com/apache/kafka/pull/13378#discussion_r1132780881
##
core/src/main/scala/kafka/coordinator/group/GroupCoordinator.scala:
##
@@ -971,8 +971,11 @@ private[group] class GroupCoordinator(
if (validationErrorOpt.is
Hangleton commented on code in PR #13378:
URL: https://github.com/apache/kafka/pull/13378#discussion_r1132780881
##
core/src/main/scala/kafka/coordinator/group/GroupCoordinator.scala:
##
@@ -971,8 +971,11 @@ private[group] class GroupCoordinator(
if (validationErrorOpt.is
Hangleton commented on code in PR #13378:
URL: https://github.com/apache/kafka/pull/13378#discussion_r1133737665
##
core/src/main/scala/kafka/coordinator/group/GroupMetadataManager.scala:
##
@@ -469,11 +469,11 @@ class GroupMetadataManager(brokerId: Int,
if (isTxnOffs
Hangleton commented on code in PR #13378:
URL: https://github.com/apache/kafka/pull/13378#discussion_r1133751522
##
core/src/main/scala/kafka/coordinator/group/GroupMetadataManager.scala:
##
@@ -469,11 +469,11 @@ class GroupMetadataManager(brokerId: Int,
if (isTxnOffs
Hangleton commented on code in PR #13378:
URL: https://github.com/apache/kafka/pull/13378#discussion_r1133792178
##
core/src/main/scala/kafka/coordinator/group/GroupMetadataManager.scala:
##
@@ -469,11 +469,11 @@ class GroupMetadataManager(brokerId: Int,
if (isTxnOffs
Hangleton commented on code in PR #13378:
URL: https://github.com/apache/kafka/pull/13378#discussion_r1133796725
##
core/src/test/scala/unit/kafka/coordinator/group/GroupCoordinatorConcurrencyTest.scala:
##
@@ -295,8 +295,12 @@ class GroupCoordinatorConcurrencyTest extends
Abst
Hangleton commented on code in PR #13378:
URL: https://github.com/apache/kafka/pull/13378#discussion_r1133971136
##
core/src/test/scala/unit/kafka/coordinator/group/GroupMetadataTest.scala:
##
@@ -386,175 +386,269 @@ class GroupMetadataTest {
@Test
def testOffsetCommit()
Hangleton commented on code in PR #13378:
URL: https://github.com/apache/kafka/pull/13378#discussion_r1134008996
##
core/src/main/scala/kafka/coordinator/group/GroupMetadata.scala:
##
@@ -649,26 +649,27 @@ private[group] class GroupMetadata(val groupId: String,
initialState: Gr
Hangleton commented on code in PR #13378:
URL: https://github.com/apache/kafka/pull/13378#discussion_r1134476449
##
core/src/main/scala/kafka/coordinator/group/GroupMetadata.scala:
##
@@ -827,6 +831,14 @@ private[group] class GroupMetadata(val groupId: String,
initialState: Gro
Hangleton commented on code in PR #13378:
URL: https://github.com/apache/kafka/pull/13378#discussion_r1134485210
##
core/src/test/scala/unit/kafka/coordinator/group/GroupCoordinatorTest.scala:
##
@@ -2917,34 +2925,33 @@ class GroupCoordinatorTest {
@Test
def testFetchAll
15 matches
Mail list logo