[GitHub] [kafka] clolov commented on a diff in pull request #14161: KAFKA-15267: Do not allow Tiered Storage to be disabled while topics have remote.storage.enable property

2023-08-29 Thread via GitHub
clolov commented on code in PR #14161: URL: https://github.com/apache/kafka/pull/14161#discussion_r1308983492 ## core/src/main/scala/kafka/log/LogManager.scala: ## @@ -871,12 +871,17 @@ class LogManager(logDirs: Seq[File], * Update the configuration of the provided topic.

[GitHub] [kafka] clolov commented on a diff in pull request #14161: KAFKA-15267: Do not allow Tiered Storage to be disabled while topics have remote.storage.enable property

2023-08-24 Thread via GitHub
clolov commented on code in PR #14161: URL: https://github.com/apache/kafka/pull/14161#discussion_r1304576992 ## core/src/main/scala/kafka/log/LogManager.scala: ## @@ -870,12 +870,17 @@ class LogManager(logDirs: Seq[File], * Update the configuration of the provided topic.

[GitHub] [kafka] clolov commented on a diff in pull request #14161: KAFKA-15267: Do not allow Tiered Storage to be disabled while topics have remote.storage.enable property

2023-08-24 Thread via GitHub
clolov commented on code in PR #14161: URL: https://github.com/apache/kafka/pull/14161#discussion_r1304576992 ## core/src/main/scala/kafka/log/LogManager.scala: ## @@ -870,12 +870,17 @@ class LogManager(logDirs: Seq[File], * Update the configuration of the provided topic.

[GitHub] [kafka] clolov commented on a diff in pull request #14161: KAFKA-15267: Do not allow Tiered Storage to be disabled while topics have remote.storage.enable property

2023-08-22 Thread via GitHub
clolov commented on code in PR #14161: URL: https://github.com/apache/kafka/pull/14161#discussion_r1301857857 ## core/src/test/scala/unit/kafka/server/TieredStorageSystemWideConfigTest.scala: ## @@ -0,0 +1,100 @@ +package unit.kafka.server + +import kafka.integration.KafkaServer

[GitHub] [kafka] clolov commented on a diff in pull request #14161: KAFKA-15267: Do not allow Tiered Storage to be disabled while topics have remote.storage.enable property

2023-08-22 Thread via GitHub
clolov commented on code in PR #14161: URL: https://github.com/apache/kafka/pull/14161#discussion_r1301856757 ## storage/src/main/java/org/apache/kafka/storage/internals/log/LogConfig.java: ## @@ -500,22 +500,27 @@ public static void validateBrokerLogConfigValues(Map props,

[GitHub] [kafka] clolov commented on a diff in pull request #14161: KAFKA-15267: Do not allow Tiered Storage to be disabled while topics have remote.storage.enable property

2023-08-22 Thread via GitHub
clolov commented on code in PR #14161: URL: https://github.com/apache/kafka/pull/14161#discussion_r1301785987 ## storage/src/main/java/org/apache/kafka/storage/internals/log/LogConfig.java: ## @@ -500,22 +500,29 @@ public static void validateBrokerLogConfigValues(Map props,

[GitHub] [kafka] clolov commented on a diff in pull request #14161: KAFKA-15267: Do not allow Tiered Storage to be disabled while topics have remote.storage.enable property

2023-08-22 Thread via GitHub
clolov commented on code in PR #14161: URL: https://github.com/apache/kafka/pull/14161#discussion_r1301784967 ## storage/src/main/java/org/apache/kafka/storage/internals/log/LogConfig.java: ## @@ -500,22 +500,29 @@ public static void validateBrokerLogConfigValues(Map props,

[GitHub] [kafka] clolov commented on a diff in pull request #14161: KAFKA-15267: Do not allow Tiered Storage to be disabled while topics have remote.storage.enable property

2023-08-22 Thread via GitHub
clolov commented on code in PR #14161: URL: https://github.com/apache/kafka/pull/14161#discussion_r1301784533 ## core/src/main/scala/kafka/log/LogManager.scala: ## @@ -870,12 +870,14 @@ class LogManager(logDirs: Seq[File], * Update the configuration of the provided topic.

[GitHub] [kafka] clolov commented on a diff in pull request #14161: KAFKA-15267: Do not allow Tiered Storage to be disabled while topics have remote.storage.enable property

2023-08-21 Thread via GitHub
clolov commented on code in PR #14161: URL: https://github.com/apache/kafka/pull/14161#discussion_r1300216608 ## storage/src/main/java/org/apache/kafka/storage/internals/log/LogConfig.java: ## @@ -500,22 +500,29 @@ public static void validateBrokerLogConfigValues(Map props,

[GitHub] [kafka] clolov commented on a diff in pull request #14161: KAFKA-15267: Do not allow Tiered Storage to be disabled while topics have remote.storage.enable property

2023-08-21 Thread via GitHub
clolov commented on code in PR #14161: URL: https://github.com/apache/kafka/pull/14161#discussion_r1300216006 ## storage/src/main/java/org/apache/kafka/storage/internals/log/LogConfig.java: ## @@ -500,22 +500,29 @@ public static void validateBrokerLogConfigValues(Map props,

[GitHub] [kafka] clolov commented on a diff in pull request #14161: KAFKA-15267: Do not allow Tiered Storage to be disabled while topics have remote.storage.enable property

2023-08-18 Thread via GitHub
clolov commented on code in PR #14161: URL: https://github.com/apache/kafka/pull/14161#discussion_r1298593281 ## core/src/test/scala/unit/kafka/server/KafkaServerTest.scala: ## @@ -154,6 +155,96 @@ class KafkaServerTest extends QuorumTestHarness { server.shutdown() } +

[GitHub] [kafka] clolov commented on a diff in pull request #14161: KAFKA-15267: Do not allow Tiered Storage to be disabled while topics have remote.storage.enable property

2023-08-17 Thread via GitHub
clolov commented on code in PR #14161: URL: https://github.com/apache/kafka/pull/14161#discussion_r1297412799 ## core/src/main/scala/kafka/server/ConfigHandler.scala: ## @@ -62,6 +62,12 @@ class TopicConfigHandler(private val logManager: LogManager, kafkaConfig: KafkaC top

[GitHub] [kafka] clolov commented on a diff in pull request #14161: KAFKA-15267: Do not allow Tiered Storage to be disabled while topics have remote.storage.enable property

2023-08-17 Thread via GitHub
clolov commented on code in PR #14161: URL: https://github.com/apache/kafka/pull/14161#discussion_r1297412799 ## core/src/main/scala/kafka/server/ConfigHandler.scala: ## @@ -62,6 +62,12 @@ class TopicConfigHandler(private val logManager: LogManager, kafkaConfig: KafkaC top

[GitHub] [kafka] clolov commented on a diff in pull request #14161: KAFKA-15267: Do not allow Tiered Storage to be disabled while topics have remote.storage.enable property

2023-08-17 Thread via GitHub
clolov commented on code in PR #14161: URL: https://github.com/apache/kafka/pull/14161#discussion_r1297412799 ## core/src/main/scala/kafka/server/ConfigHandler.scala: ## @@ -62,6 +62,12 @@ class TopicConfigHandler(private val logManager: LogManager, kafkaConfig: KafkaC top

[GitHub] [kafka] clolov commented on a diff in pull request #14161: KAFKA-15267: Do not allow Tiered Storage to be disabled while topics have remote.storage.enable property

2023-08-15 Thread via GitHub
clolov commented on code in PR #14161: URL: https://github.com/apache/kafka/pull/14161#discussion_r1294263440 ## core/src/main/scala/kafka/server/ConfigHandler.scala: ## @@ -62,6 +62,12 @@ class TopicConfigHandler(private val logManager: LogManager, kafkaConfig: KafkaC top

[GitHub] [kafka] clolov commented on a diff in pull request #14161: KAFKA-15267: Do not allow Tiered Storage to be disabled while topics have remote.storage.enable property

2023-08-15 Thread via GitHub
clolov commented on code in PR #14161: URL: https://github.com/apache/kafka/pull/14161#discussion_r1294261443 ## core/src/main/scala/kafka/server/ConfigHandler.scala: ## @@ -62,6 +62,12 @@ class TopicConfigHandler(private val logManager: LogManager, kafkaConfig: KafkaC top

[GitHub] [kafka] clolov commented on a diff in pull request #14161: KAFKA-15267: Do not allow Tiered Storage to be disabled while topics have remote.storage.enable property

2023-08-10 Thread via GitHub
clolov commented on code in PR #14161: URL: https://github.com/apache/kafka/pull/14161#discussion_r1290124230 ## core/src/main/scala/kafka/server/ConfigHandler.scala: ## @@ -62,6 +62,12 @@ class TopicConfigHandler(private val logManager: LogManager, kafkaConfig: KafkaC top

[GitHub] [kafka] clolov commented on a diff in pull request #14161: KAFKA-15267: Do not allow Tiered Storage to be disabled while topics have remote.storage.enable property

2023-08-10 Thread via GitHub
clolov commented on code in PR #14161: URL: https://github.com/apache/kafka/pull/14161#discussion_r1290120601 ## core/src/main/scala/kafka/server/ConfigHandler.scala: ## @@ -62,6 +62,12 @@ class TopicConfigHandler(private val logManager: LogManager, kafkaConfig: KafkaC top

[GitHub] [kafka] clolov commented on a diff in pull request #14161: KAFKA-15267: Do not allow Tiered Storage to be disabled while topics have remote.storage.enable property

2023-08-10 Thread via GitHub
clolov commented on code in PR #14161: URL: https://github.com/apache/kafka/pull/14161#discussion_r1290107019 ## core/src/main/scala/kafka/server/ConfigHandler.scala: ## @@ -62,6 +62,12 @@ class TopicConfigHandler(private val logManager: LogManager, kafkaConfig: KafkaC top

[GitHub] [kafka] clolov commented on a diff in pull request #14161: KAFKA-15267: Do not allow Tiered Storage to be disabled while topics have remote.storage.enable property

2023-08-09 Thread via GitHub
clolov commented on code in PR #14161: URL: https://github.com/apache/kafka/pull/14161#discussion_r1288265653 ## core/src/main/scala/kafka/server/ConfigHandler.scala: ## @@ -62,6 +62,12 @@ class TopicConfigHandler(private val logManager: LogManager, kafkaConfig: KafkaC top

[GitHub] [kafka] clolov commented on a diff in pull request #14161: KAFKA-15267: Do not allow Tiered Storage to be disabled while topics have remote.storage.enable property

2023-08-08 Thread via GitHub
clolov commented on code in PR #14161: URL: https://github.com/apache/kafka/pull/14161#discussion_r1287188953 ## core/src/test/scala/unit/kafka/server/KafkaServerTest.scala: ## @@ -154,6 +155,92 @@ class KafkaServerTest extends QuorumTestHarness { server.shutdown() } +

[GitHub] [kafka] clolov commented on a diff in pull request #14161: KAFKA-15267: Do not allow Tiered Storage to be disabled while topics have remote.storage.enable property

2023-08-08 Thread via GitHub
clolov commented on code in PR #14161: URL: https://github.com/apache/kafka/pull/14161#discussion_r1287005592 ## core/src/main/scala/kafka/server/ConfigHandler.scala: ## @@ -62,6 +62,12 @@ class TopicConfigHandler(private val logManager: LogManager, kafkaConfig: KafkaC top

[GitHub] [kafka] clolov commented on a diff in pull request #14161: KAFKA-15267: Do not allow Tiered Storage to be disabled while topics have remote.storage.enable property

2023-08-08 Thread via GitHub
clolov commented on code in PR #14161: URL: https://github.com/apache/kafka/pull/14161#discussion_r1286895377 ## core/src/main/scala/kafka/server/ConfigHandler.scala: ## @@ -62,6 +62,12 @@ class TopicConfigHandler(private val logManager: LogManager, kafkaConfig: KafkaC top

[GitHub] [kafka] clolov commented on a diff in pull request #14161: KAFKA-15267: Do not allow Tiered Storage to be disabled while topics have remote.storage.enable property

2023-08-08 Thread via GitHub
clolov commented on code in PR #14161: URL: https://github.com/apache/kafka/pull/14161#discussion_r1286890333 ## core/src/main/scala/kafka/server/ConfigHandler.scala: ## @@ -62,6 +62,12 @@ class TopicConfigHandler(private val logManager: LogManager, kafkaConfig: KafkaC top

[GitHub] [kafka] clolov commented on a diff in pull request #14161: KAFKA-15267: Do not allow Tiered Storage to be disabled while topics have remote.storage.enable property

2023-08-08 Thread via GitHub
clolov commented on code in PR #14161: URL: https://github.com/apache/kafka/pull/14161#discussion_r1286890333 ## core/src/main/scala/kafka/server/ConfigHandler.scala: ## @@ -62,6 +62,12 @@ class TopicConfigHandler(private val logManager: LogManager, kafkaConfig: KafkaC top