[GitHub] [kafka] cmccabe commented on a diff in pull request #14010: KAFKA-15183: Add more controller, loader, snapshot emitter metrics

cmccabe commented on code in PR #14010: URL: https://github.com/apache/kafka/pull/14010#discussion_r1268717074 ## metadata/src/main/java/org/apache/kafka/image/publisher/metrics/SnapshotEmitterMetrics.java: ## @@ -0,0 +1,108 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] cmccabe commented on a diff in pull request #14010: KAFKA-15183: Add more controller, loader, snapshot emitter metrics

cmccabe commented on code in PR #14010: URL: https://github.com/apache/kafka/pull/14010#discussion_r1268716163 ## metadata/src/main/java/org/apache/kafka/controller/metrics/QuorumControllerMetrics.java: ## @@ -54,6 +54,14 @@ public class QuorumControllerMetrics implements AutoC

[GitHub] [kafka] cmccabe commented on a diff in pull request #14010: KAFKA-15183: Add more controller, loader, snapshot emitter metrics

cmccabe commented on code in PR #14010: URL: https://github.com/apache/kafka/pull/14010#discussion_r1267289475 ## metadata/src/main/java/org/apache/kafka/controller/metrics/QuorumControllerMetrics.java: ## @@ -176,17 +210,53 @@ public long dualWriteOffset() { } publi

[GitHub] [kafka] cmccabe commented on a diff in pull request #14010: KAFKA-15183: Add more controller, loader, snapshot emitter metrics

cmccabe commented on code in PR #14010: URL: https://github.com/apache/kafka/pull/14010#discussion_r1267289020 ## metadata/src/main/java/org/apache/kafka/controller/metrics/QuorumControllerMetrics.java: ## @@ -113,7 +124,30 @@ public Long value() { return time.m

[GitHub] [kafka] cmccabe commented on a diff in pull request #14010: KAFKA-15183: Add more controller, loader, snapshot emitter metrics

cmccabe commented on code in PR #14010: URL: https://github.com/apache/kafka/pull/14010#discussion_r1267287803 ## metadata/src/main/java/org/apache/kafka/image/loader/MetadataLoader.java: ## @@ -418,24 +415,30 @@ LogDeltaManifest loadLogDelta( public void handleLoadSnapshot

[GitHub] [kafka] cmccabe commented on a diff in pull request #14010: KAFKA-15183: Add more controller, loader, snapshot emitter metrics

cmccabe commented on code in PR #14010: URL: https://github.com/apache/kafka/pull/14010#discussion_r1267254133 ## metadata/src/main/java/org/apache/kafka/controller/metrics/QuorumControllerMetrics.java: ## @@ -113,7 +124,30 @@ public Long value() { return time.m

[GitHub] [kafka] cmccabe commented on a diff in pull request #14010: KAFKA-15183: Add more controller, loader, snapshot emitter metrics

cmccabe commented on code in PR #14010: URL: https://github.com/apache/kafka/pull/14010#discussion_r1267253682 ## metadata/src/main/java/org/apache/kafka/controller/metrics/QuorumControllerMetrics.java: ## @@ -113,7 +124,30 @@ public Long value() { return time.m

[GitHub] [kafka] cmccabe commented on a diff in pull request #14010: KAFKA-15183: Add more controller, loader, snapshot emitter metrics

cmccabe commented on code in PR #14010: URL: https://github.com/apache/kafka/pull/14010#discussion_r1267252934 ## core/src/main/scala/kafka/server/SharedServer.scala: ## @@ -282,15 +294,15 @@ class SharedServer( setDisabledReason(snapshotsDisabledReason). s

[GitHub] [kafka] cmccabe commented on a diff in pull request #14010: KAFKA-15183: Add more controller, loader, snapshot emitter metrics

cmccabe commented on code in PR #14010: URL: https://github.com/apache/kafka/pull/14010#discussion_r1267251882 ## core/src/main/scala/kafka/server/SharedServer.scala: ## @@ -282,15 +294,15 @@ class SharedServer( setDisabledReason(snapshotsDisabledReason). s

[GitHub] [kafka] cmccabe commented on a diff in pull request #14010: KAFKA-15183: Add more controller, loader, snapshot emitter metrics

cmccabe commented on code in PR #14010: URL: https://github.com/apache/kafka/pull/14010#discussion_r1267251209 ## core/src/main/scala/kafka/server/SharedServer.scala: ## @@ -259,15 +262,24 @@ class SharedServer( raftManager = _raftManager _raftManager.startup()

[GitHub] [kafka] cmccabe commented on a diff in pull request #14010: KAFKA-15183: Add more controller, loader, snapshot emitter metrics

cmccabe commented on code in PR #14010: URL: https://github.com/apache/kafka/pull/14010#discussion_r1267248743 ## metadata/src/test/java/org/apache/kafka/controller/QuorumControllerTest.java: ## @@ -782,7 +735,7 @@ public void testTimeouts() throws Throwable { b

[GitHub] [kafka] cmccabe commented on a diff in pull request #14010: KAFKA-15183: Add more controller, loader, snapshot emitter metrics

cmccabe commented on code in PR #14010: URL: https://github.com/apache/kafka/pull/14010#discussion_r1267249264 ## metadata/src/test/java/org/apache/kafka/controller/QuorumControllerTest.java: ## @@ -140,39 +142,6 @@ public class QuorumControllerTest { static final Bootstrap

[GitHub] [kafka] cmccabe commented on a diff in pull request #14010: KAFKA-15183: Add more controller, loader, snapshot emitter metrics

cmccabe commented on code in PR #14010: URL: https://github.com/apache/kafka/pull/14010#discussion_r1267246622 ## metadata/src/test/java/org/apache/kafka/image/loader/metrics/MetadataLoaderMetricsTest.java: ## @@ -0,0 +1,148 @@ +/* + * Licensed to the Apache Software Foundation