[GitHub] [kafka] cmccabe commented on a diff in pull request #14208: KAFKA-14538 Metadata transactions in MetadataLoader

cmccabe commented on code in PR #14208: URL: https://github.com/apache/kafka/pull/14208#discussion_r1298865134 ## metadata/src/main/java/org/apache/kafka/controller/ActivationRecordsGenerator.java: ## @@ -0,0 +1,197 @@ +/* + * Licensed to the Apache Software Foundation (ASF) und

[GitHub] [kafka] cmccabe commented on a diff in pull request #14208: KAFKA-14538 Metadata transactions in MetadataLoader

cmccabe commented on code in PR #14208: URL: https://github.com/apache/kafka/pull/14208#discussion_r1297536422 ## metadata/src/main/java/org/apache/kafka/controller/ActivationRecordsGenerator.java: ## @@ -0,0 +1,197 @@ +/* + * Licensed to the Apache Software Foundation (ASF) und

[GitHub] [kafka] cmccabe commented on a diff in pull request #14208: KAFKA-14538 Metadata transactions in MetadataLoader

cmccabe commented on code in PR #14208: URL: https://github.com/apache/kafka/pull/14208#discussion_r1297536422 ## metadata/src/main/java/org/apache/kafka/controller/ActivationRecordsGenerator.java: ## @@ -0,0 +1,197 @@ +/* + * Licensed to the Apache Software Foundation (ASF) und

[GitHub] [kafka] cmccabe commented on a diff in pull request #14208: KAFKA-14538 Metadata transactions in MetadataLoader

cmccabe commented on code in PR #14208: URL: https://github.com/apache/kafka/pull/14208#discussion_r1297533375 ## metadata/src/main/java/org/apache/kafka/controller/ActivationRecordsGenerator.java: ## @@ -0,0 +1,197 @@ +/* + * Licensed to the Apache Software Foundation (ASF) und

[GitHub] [kafka] cmccabe commented on a diff in pull request #14208: KAFKA-14538 Metadata transactions in MetadataLoader

cmccabe commented on code in PR #14208: URL: https://github.com/apache/kafka/pull/14208#discussion_r1297531045 ## metadata/src/main/java/org/apache/kafka/controller/ActivationRecordsGenerator.java: ## @@ -0,0 +1,197 @@ +/* + * Licensed to the Apache Software Foundation (ASF) und

[GitHub] [kafka] cmccabe commented on a diff in pull request #14208: KAFKA-14538 Metadata transactions in MetadataLoader

cmccabe commented on code in PR #14208: URL: https://github.com/apache/kafka/pull/14208#discussion_r1297529651 ## metadata/src/main/java/org/apache/kafka/controller/ActivationRecordsGenerator.java: ## @@ -0,0 +1,197 @@ +/* + * Licensed to the Apache Software Foundation (ASF) und

[GitHub] [kafka] cmccabe commented on a diff in pull request #14208: KAFKA-14538 Metadata transactions in MetadataLoader

cmccabe commented on code in PR #14208: URL: https://github.com/apache/kafka/pull/14208#discussion_r1297529002 ## metadata/src/main/java/org/apache/kafka/controller/ActivationRecordsGenerator.java: ## @@ -0,0 +1,197 @@ +/* + * Licensed to the Apache Software Foundation (ASF) und

[GitHub] [kafka] cmccabe commented on a diff in pull request #14208: KAFKA-14538 Metadata transactions in MetadataLoader

cmccabe commented on code in PR #14208: URL: https://github.com/apache/kafka/pull/14208#discussion_r1297526521 ## metadata/src/main/java/org/apache/kafka/controller/ActivationRecordsGenerator.java: ## @@ -0,0 +1,197 @@ +/* + * Licensed to the Apache Software Foundation (ASF) und

[GitHub] [kafka] cmccabe commented on a diff in pull request #14208: KAFKA-14538 Metadata transactions in MetadataLoader

cmccabe commented on code in PR #14208: URL: https://github.com/apache/kafka/pull/14208#discussion_r1297525659 ## metadata/src/main/java/org/apache/kafka/controller/ActivationRecordsGenerator.java: ## @@ -0,0 +1,197 @@ +/* + * Licensed to the Apache Software Foundation (ASF) und

[GitHub] [kafka] cmccabe commented on a diff in pull request #14208: KAFKA-14538 Metadata transactions in MetadataLoader

cmccabe commented on code in PR #14208: URL: https://github.com/apache/kafka/pull/14208#discussion_r1297521425 ## metadata/src/main/java/org/apache/kafka/controller/ActivationRecordsGenerator.java: ## @@ -0,0 +1,197 @@ +/* + * Licensed to the Apache Software Foundation (ASF) und

[GitHub] [kafka] cmccabe commented on a diff in pull request #14208: KAFKA-14538 Metadata transactions in MetadataLoader

cmccabe commented on code in PR #14208: URL: https://github.com/apache/kafka/pull/14208#discussion_r1297521425 ## metadata/src/main/java/org/apache/kafka/controller/ActivationRecordsGenerator.java: ## @@ -0,0 +1,197 @@ +/* + * Licensed to the Apache Software Foundation (ASF) und

[GitHub] [kafka] cmccabe commented on a diff in pull request #14208: KAFKA-14538 Metadata transactions in MetadataLoader

cmccabe commented on code in PR #14208: URL: https://github.com/apache/kafka/pull/14208#discussion_r1296512550 ## metadata/src/main/java/org/apache/kafka/controller/OffsetControlManager.java: ## @@ -212,10 +213,14 @@ long lastStableOffset() { } /** - * @return th

[GitHub] [kafka] cmccabe commented on a diff in pull request #14208: KAFKA-14538 Metadata transactions in MetadataLoader

cmccabe commented on code in PR #14208: URL: https://github.com/apache/kafka/pull/14208#discussion_r1296172460 ## metadata/src/main/java/org/apache/kafka/controller/QuorumController.java: ## @@ -892,48 +915,73 @@ class MigrationWriteOperation implements ControllerWriteOperation

[GitHub] [kafka] cmccabe commented on a diff in pull request #14208: KAFKA-14538 Metadata transactions in MetadataLoader

cmccabe commented on code in PR #14208: URL: https://github.com/apache/kafka/pull/14208#discussion_r1296200794 ## metadata/src/main/java/org/apache/kafka/image/loader/LogDeltaManifest.java: ## @@ -66,6 +119,10 @@ public LogDeltaManifest( this.numBytes = numBytes; }

[GitHub] [kafka] cmccabe commented on a diff in pull request #14208: KAFKA-14538 Metadata transactions in MetadataLoader

cmccabe commented on code in PR #14208: URL: https://github.com/apache/kafka/pull/14208#discussion_r129629 ## metadata/src/main/java/org/apache/kafka/controller/OffsetControlManager.java: ## @@ -212,10 +213,14 @@ long lastStableOffset() { } /** - * @return th

[GitHub] [kafka] cmccabe commented on a diff in pull request #14208: KAFKA-14538 Metadata transactions in MetadataLoader

cmccabe commented on code in PR #14208: URL: https://github.com/apache/kafka/pull/14208#discussion_r1296178891 ## metadata/src/main/java/org/apache/kafka/controller/QuorumController.java: ## @@ -892,48 +915,73 @@ class MigrationWriteOperation implements ControllerWriteOperation

[GitHub] [kafka] cmccabe commented on a diff in pull request #14208: KAFKA-14538 Metadata transactions in MetadataLoader

cmccabe commented on code in PR #14208: URL: https://github.com/apache/kafka/pull/14208#discussion_r1296178891 ## metadata/src/main/java/org/apache/kafka/controller/QuorumController.java: ## @@ -892,48 +915,73 @@ class MigrationWriteOperation implements ControllerWriteOperation

[GitHub] [kafka] cmccabe commented on a diff in pull request #14208: KAFKA-14538 Metadata transactions in MetadataLoader

cmccabe commented on code in PR #14208: URL: https://github.com/apache/kafka/pull/14208#discussion_r1296178891 ## metadata/src/main/java/org/apache/kafka/controller/QuorumController.java: ## @@ -892,48 +915,73 @@ class MigrationWriteOperation implements ControllerWriteOperation

[GitHub] [kafka] cmccabe commented on a diff in pull request #14208: KAFKA-14538 Metadata transactions in MetadataLoader

cmccabe commented on code in PR #14208: URL: https://github.com/apache/kafka/pull/14208#discussion_r1296173796 ## metadata/src/main/java/org/apache/kafka/controller/QuorumController.java: ## @@ -892,48 +915,73 @@ class MigrationWriteOperation implements ControllerWriteOperation

[GitHub] [kafka] cmccabe commented on a diff in pull request #14208: KAFKA-14538 Metadata transactions in MetadataLoader

cmccabe commented on code in PR #14208: URL: https://github.com/apache/kafka/pull/14208#discussion_r1296172460 ## metadata/src/main/java/org/apache/kafka/controller/QuorumController.java: ## @@ -892,48 +915,73 @@ class MigrationWriteOperation implements ControllerWriteOperation

[GitHub] [kafka] cmccabe commented on a diff in pull request #14208: KAFKA-14538 Metadata transactions in MetadataLoader

cmccabe commented on code in PR #14208: URL: https://github.com/apache/kafka/pull/14208#discussion_r1296173796 ## metadata/src/main/java/org/apache/kafka/controller/QuorumController.java: ## @@ -892,48 +915,73 @@ class MigrationWriteOperation implements ControllerWriteOperation

[GitHub] [kafka] cmccabe commented on a diff in pull request #14208: KAFKA-14538 Metadata transactions in MetadataLoader

cmccabe commented on code in PR #14208: URL: https://github.com/apache/kafka/pull/14208#discussion_r1296172460 ## metadata/src/main/java/org/apache/kafka/controller/QuorumController.java: ## @@ -892,48 +915,73 @@ class MigrationWriteOperation implements ControllerWriteOperation

[GitHub] [kafka] cmccabe commented on a diff in pull request #14208: KAFKA-14538 Metadata transactions in MetadataLoader

cmccabe commented on code in PR #14208: URL: https://github.com/apache/kafka/pull/14208#discussion_r1295077023 ## metadata/src/main/java/org/apache/kafka/image/loader/LogDeltaManifest.java: ## @@ -80,6 +137,7 @@ public LeaderAndEpoch leaderAndEpoch() { return leaderAndE

[GitHub] [kafka] cmccabe commented on a diff in pull request #14208: KAFKA-14538 Metadata transactions in MetadataLoader

cmccabe commented on code in PR #14208: URL: https://github.com/apache/kafka/pull/14208#discussion_r1295076740 ## metadata/src/main/java/org/apache/kafka/image/loader/LogDeltaManifest.java: ## @@ -27,6 +27,59 @@ * Contains information about a set of changes that were loaded fr

[GitHub] [kafka] cmccabe commented on a diff in pull request #14208: KAFKA-14538 Metadata transactions in MetadataLoader

cmccabe commented on code in PR #14208: URL: https://github.com/apache/kafka/pull/14208#discussion_r1295091800 ## metadata/src/main/java/org/apache/kafka/image/loader/MetadataBatchLoader.java: ## @@ -0,0 +1,257 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under on

[GitHub] [kafka] cmccabe commented on a diff in pull request #14208: KAFKA-14538 Metadata transactions in MetadataLoader

cmccabe commented on code in PR #14208: URL: https://github.com/apache/kafka/pull/14208#discussion_r1295084331 ## metadata/src/main/java/org/apache/kafka/image/loader/MetadataBatchLoader.java: ## @@ -0,0 +1,257 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under on

[GitHub] [kafka] cmccabe commented on a diff in pull request #14208: KAFKA-14538 Metadata transactions in MetadataLoader

cmccabe commented on code in PR #14208: URL: https://github.com/apache/kafka/pull/14208#discussion_r1295090413 ## metadata/src/main/java/org/apache/kafka/image/loader/MetadataLoader.java: ## @@ -183,6 +183,8 @@ public MetadataLoader build() { */ private MetadataImage

[GitHub] [kafka] cmccabe commented on a diff in pull request #14208: KAFKA-14538 Metadata transactions in MetadataLoader

cmccabe commented on code in PR #14208: URL: https://github.com/apache/kafka/pull/14208#discussion_r1295084521 ## metadata/src/main/java/org/apache/kafka/image/loader/MetadataBatchLoader.java: ## @@ -0,0 +1,257 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under on

[GitHub] [kafka] cmccabe commented on a diff in pull request #14208: KAFKA-14538 Metadata transactions in MetadataLoader

cmccabe commented on code in PR #14208: URL: https://github.com/apache/kafka/pull/14208#discussion_r1295077023 ## metadata/src/main/java/org/apache/kafka/image/loader/LogDeltaManifest.java: ## @@ -80,6 +137,7 @@ public LeaderAndEpoch leaderAndEpoch() { return leaderAndE

[GitHub] [kafka] cmccabe commented on a diff in pull request #14208: KAFKA-14538 Metadata transactions in MetadataLoader

cmccabe commented on code in PR #14208: URL: https://github.com/apache/kafka/pull/14208#discussion_r1295081634 ## metadata/src/main/java/org/apache/kafka/image/loader/MetadataBatchLoader.java: ## @@ -0,0 +1,257 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under on

[GitHub] [kafka] cmccabe commented on a diff in pull request #14208: KAFKA-14538 Metadata transactions in MetadataLoader

cmccabe commented on code in PR #14208: URL: https://github.com/apache/kafka/pull/14208#discussion_r1295077448 ## metadata/src/main/java/org/apache/kafka/image/loader/LogDeltaManifest.java: ## @@ -66,6 +119,10 @@ public LogDeltaManifest( this.numBytes = numBytes; }

[GitHub] [kafka] cmccabe commented on a diff in pull request #14208: KAFKA-14538 Metadata transactions in MetadataLoader

cmccabe commented on code in PR #14208: URL: https://github.com/apache/kafka/pull/14208#discussion_r1295074841 ## metadata/src/main/java/org/apache/kafka/controller/QuorumController.java: ## @@ -1200,6 +1235,16 @@ public static List generateActivationRecords(

[GitHub] [kafka] cmccabe commented on a diff in pull request #14208: KAFKA-14538 Metadata transactions in MetadataLoader

cmccabe commented on code in PR #14208: URL: https://github.com/apache/kafka/pull/14208#discussion_r1295072484 ## metadata/src/main/java/org/apache/kafka/controller/QuorumController.java: ## @@ -892,48 +909,62 @@ class MigrationWriteOperation implements ControllerWriteOperation

[GitHub] [kafka] cmccabe commented on a diff in pull request #14208: KAFKA-14538 Metadata transactions in MetadataLoader

cmccabe commented on code in PR #14208: URL: https://github.com/apache/kafka/pull/14208#discussion_r1295073210 ## metadata/src/main/java/org/apache/kafka/controller/QuorumController.java: ## @@ -954,11 +985,14 @@ public void handleCommit(BatchReader reader) {

[GitHub] [kafka] cmccabe commented on a diff in pull request #14208: KAFKA-14538 Metadata transactions in MetadataLoader

cmccabe commented on code in PR #14208: URL: https://github.com/apache/kafka/pull/14208#discussion_r1295069992 ## metadata/src/main/java/org/apache/kafka/controller/QuorumController.java: ## @@ -623,7 +624,14 @@ enum ControllerOperationFlag { * even though the cluster

[GitHub] [kafka] cmccabe commented on a diff in pull request #14208: KAFKA-14538 Metadata transactions in MetadataLoader

cmccabe commented on code in PR #14208: URL: https://github.com/apache/kafka/pull/14208#discussion_r1295071752 ## metadata/src/main/java/org/apache/kafka/controller/QuorumController.java: ## @@ -892,48 +909,62 @@ class MigrationWriteOperation implements ControllerWriteOperation