[GitHub] [kafka] showuon commented on a change in pull request #11691: KAFKA-13598: enable idempotence producer by default and validate the configs

showuon commented on a change in pull request #11691: URL: https://github.com/apache/kafka/pull/11691#discussion_r800030072 ## File path: clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java ## @@ -514,12 +512,11 @@ public ProducerConfig(Map props) {

[GitHub] [kafka] showuon commented on a change in pull request #11691: KAFKA-13598: enable idempotence producer by default and validate the configs

showuon commented on a change in pull request #11691: URL: https://github.com/apache/kafka/pull/11691#discussion_r800029493 ## File path: docs/upgrade.html ## @@ -19,6 +19,13 @@

[GitHub] [kafka] showuon commented on a change in pull request #11691: KAFKA-13598: enable idempotence producer by default and validate the configs

showuon commented on a change in pull request #11691: URL: https://github.com/apache/kafka/pull/11691#discussion_r799127097 ## File path: core/src/main/scala/kafka/tools/ConsoleProducer.scala ## @@ -168,7 +168,7 @@ object ConsoleProducer { .withRequiredArg .descri

[GitHub] [kafka] showuon commented on a change in pull request #11691: KAFKA-13598: enable idempotence producer by default and validate the configs

showuon commented on a change in pull request #11691: URL: https://github.com/apache/kafka/pull/11691#discussion_r795017377 ## File path: clients/src/test/java/org/apache/kafka/clients/producer/KafkaProducerTest.java ## @@ -514,18 +635,21 @@ public void testMetadataFetch() thr

[GitHub] [kafka] showuon commented on a change in pull request #11691: KAFKA-13598: enable idempotence producer by default and validate the configs

showuon commented on a change in pull request #11691: URL: https://github.com/apache/kafka/pull/11691#discussion_r795017038 ## File path: clients/src/main/java/org/apache/kafka/common/config/AbstractConfig.java ## @@ -226,6 +227,10 @@ public Password getPassword(String key) {

[GitHub] [kafka] showuon commented on a change in pull request #11691: KAFKA-13598: enable idempotence producer by default and validate the configs

showuon commented on a change in pull request #11691: URL: https://github.com/apache/kafka/pull/11691#discussion_r795016730 ## File path: clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java ## @@ -456,33 +455,29 @@ private void maybeOverrideClientId(fin

[GitHub] [kafka] showuon commented on a change in pull request #11691: KAFKA-13598: enable idempotence producer by default and validate the configs

showuon commented on a change in pull request #11691: URL: https://github.com/apache/kafka/pull/11691#discussion_r795016633 ## File path: clients/src/main/java/org/apache/kafka/common/config/AbstractConfig.java ## @@ -226,6 +227,10 @@ public Password getPassword(String key) {

[GitHub] [kafka] showuon commented on a change in pull request #11691: KAFKA-13598: enable idempotence producer by default and validate the configs

showuon commented on a change in pull request #11691: URL: https://github.com/apache/kafka/pull/11691#discussion_r795016591 ## File path: clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java ## @@ -514,11 +509,12 @@ public ProducerConfig(Map props) {

[GitHub] [kafka] showuon commented on a change in pull request #11691: KAFKA-13598: enable idempotence producer by default and validate the configs

showuon commented on a change in pull request #11691: URL: https://github.com/apache/kafka/pull/11691#discussion_r793569502 ## File path: core/src/test/scala/integration/kafka/api/EndToEndAuthorizationTest.scala ## @@ -352,20 +359,28 @@ abstract class EndToEndAuthorizationTest

[GitHub] [kafka] showuon commented on a change in pull request #11691: KAFKA-13598: enable idempotence producer by default and validate the configs

showuon commented on a change in pull request #11691: URL: https://github.com/apache/kafka/pull/11691#discussion_r793568939 ## File path: core/src/test/scala/integration/kafka/api/AuthorizerIntegrationTest.scala ## @@ -143,6 +143,7 @@ class AuthorizerIntegrationTest extends Ba

[GitHub] [kafka] showuon commented on a change in pull request #11691: KAFKA-13598: enable idempotence producer by default and validate the configs

showuon commented on a change in pull request #11691: URL: https://github.com/apache/kafka/pull/11691#discussion_r793568939 ## File path: core/src/test/scala/integration/kafka/api/AuthorizerIntegrationTest.scala ## @@ -143,6 +143,7 @@ class AuthorizerIntegrationTest extends Ba

[GitHub] [kafka] showuon commented on a change in pull request #11691: KAFKA-13598: enable idempotence producer by default and validate the configs

showuon commented on a change in pull request #11691: URL: https://github.com/apache/kafka/pull/11691#discussion_r792663973 ## File path: core/src/test/scala/integration/kafka/api/EndToEndAuthorizationTest.scala ## @@ -352,20 +359,28 @@ abstract class EndToEndAuthorizationTest

[GitHub] [kafka] showuon commented on a change in pull request #11691: KAFKA-13598: enable idempotence producer by default and validate the configs

showuon commented on a change in pull request #11691: URL: https://github.com/apache/kafka/pull/11691#discussion_r792658808 ## File path: core/src/test/scala/integration/kafka/api/AuthorizerIntegrationTest.scala ## @@ -2383,6 +2384,7 @@ class AuthorizerIntegrationTest extends

[GitHub] [kafka] showuon commented on a change in pull request #11691: KAFKA-13598: enable idempotence producer by default and validate the configs

showuon commented on a change in pull request #11691: URL: https://github.com/apache/kafka/pull/11691#discussion_r792657463 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/storage/KafkaStatusBackingStore.java ## @@ -170,6 +170,7 @@ public void configure(fi

[GitHub] [kafka] showuon commented on a change in pull request #11691: KAFKA-13598: enable idempotence producer by default and validate the configs

showuon commented on a change in pull request #11691: URL: https://github.com/apache/kafka/pull/11691#discussion_r792653054 ## File path: clients/src/main/java/org/apache/kafka/common/config/AbstractConfig.java ## @@ -24,14 +24,15 @@ import org.slf4j.LoggerFactory; import or

[GitHub] [kafka] showuon commented on a change in pull request #11691: KAFKA-13598: enable idempotence producer by default and validate the configs

showuon commented on a change in pull request #11691: URL: https://github.com/apache/kafka/pull/11691#discussion_r792651448 ## File path: clients/src/main/java/org/apache/kafka/common/config/AbstractConfig.java ## @@ -226,6 +227,11 @@ public Password getPassword(String key) {