[GitHub] [kafka] vpapavas commented on a change in pull request #11513: feat: Write offset position to changelog

vpapavas commented on a change in pull request #11513: URL: https://github.com/apache/kafka/pull/11513#discussion_r755285644 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/AbstractProcessorContext.java ## @@ -246,4 +246,4 @@ public TaskType ta

[GitHub] [kafka] vpapavas commented on a change in pull request #11513: feat: Write offset position to changelog

vpapavas commented on a change in pull request #11513: URL: https://github.com/apache/kafka/pull/11513#discussion_r761142526 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/ConsistencyVectorIntegrationTest.java ## @@ -0,0 +1,236 @@ +/* + * Licensed to

[GitHub] [kafka] vpapavas commented on a change in pull request #11513: feat: Write offset position to changelog

vpapavas commented on a change in pull request #11513: URL: https://github.com/apache/kafka/pull/11513#discussion_r761141392 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBStore.java ## @@ -312,6 +318,11 @@ public synchronized void put(fina

[GitHub] [kafka] vpapavas commented on a change in pull request #11513: feat: Write offset position to changelog

vpapavas commented on a change in pull request #11513: URL: https://github.com/apache/kafka/pull/11513#discussion_r761140618 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBStore.java ## @@ -106,10 +111,13 @@ private final RocksDBMetric

[GitHub] [kafka] vpapavas commented on a change in pull request #11513: feat: Write offset position to changelog

vpapavas commented on a change in pull request #11513: URL: https://github.com/apache/kafka/pull/11513#discussion_r761138847 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/ChangeLoggingKeyValueBytesStore.java ## @@ -76,6 +87,10 @@ public long appr

[GitHub] [kafka] vpapavas commented on a change in pull request #11513: feat: Write offset position to changelog

vpapavas commented on a change in pull request #11513: URL: https://github.com/apache/kafka/pull/11513#discussion_r761135387 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/AbstractRocksDBSegmentedBytesStore.java ## @@ -216,6 +226,11 @@ public void

[GitHub] [kafka] vpapavas commented on a change in pull request #11513: feat: Write offset position to changelog

vpapavas commented on a change in pull request #11513: URL: https://github.com/apache/kafka/pull/11513#discussion_r760099865 ## File path: streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java ## @@ -947,6 +947,11 @@ // Private API used to control the emit

[GitHub] [kafka] vpapavas commented on a change in pull request #11513: feat: Write offset position to changelog

vpapavas commented on a change in pull request #11513: URL: https://github.com/apache/kafka/pull/11513#discussion_r760111821 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/ChangeLoggingSessionBytesStore.java ## @@ -79,15 +94,21 @@ public void init

[GitHub] [kafka] vpapavas commented on a change in pull request #11513: feat: Write offset position to changelog

vpapavas commented on a change in pull request #11513: URL: https://github.com/apache/kafka/pull/11513#discussion_r760121526 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/Position.java ## @@ -27,6 +30,8 @@ import java.util.function.BiConsumer;

[GitHub] [kafka] vpapavas commented on a change in pull request #11513: feat: Write offset position to changelog

vpapavas commented on a change in pull request #11513: URL: https://github.com/apache/kafka/pull/11513#discussion_r760111821 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/ChangeLoggingSessionBytesStore.java ## @@ -79,15 +94,21 @@ public void init

[GitHub] [kafka] vpapavas commented on a change in pull request #11513: feat: Write offset position to changelog

vpapavas commented on a change in pull request #11513: URL: https://github.com/apache/kafka/pull/11513#discussion_r760111821 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/ChangeLoggingSessionBytesStore.java ## @@ -79,15 +94,21 @@ public void init

[GitHub] [kafka] vpapavas commented on a change in pull request #11513: feat: Write offset position to changelog

vpapavas commented on a change in pull request #11513: URL: https://github.com/apache/kafka/pull/11513#discussion_r755099262 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/CachingKeyValueStore.java ## @@ -155,6 +169,11 @@ private void putInternal(

[GitHub] [kafka] vpapavas commented on a change in pull request #11513: feat: Write offset position to changelog

vpapavas commented on a change in pull request #11513: URL: https://github.com/apache/kafka/pull/11513#discussion_r755096395 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/ChangelogRecordDeserializationHelper.java ## @@ -0,0 +1,38 @@ +/* + * L

[GitHub] [kafka] vpapavas commented on a change in pull request #11513: feat: Write offset position to changelog

vpapavas commented on a change in pull request #11513: URL: https://github.com/apache/kafka/pull/11513#discussion_r755096395 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/ChangelogRecordDeserializationHelper.java ## @@ -0,0 +1,38 @@ +/* + * L

[GitHub] [kafka] vpapavas commented on a change in pull request #11513: feat: Write offset position to changelog

vpapavas commented on a change in pull request #11513: URL: https://github.com/apache/kafka/pull/11513#discussion_r760099865 ## File path: streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java ## @@ -947,6 +947,11 @@ // Private API used to control the emit