github-actions[bot] commented on PR #15264:
URL: https://github.com/apache/kafka/pull/15264#issuecomment-2126168320
This PR is being marked as stale since it has not had any activity in 90
days. If you would like to keep this PR alive, please ask a committer for
review. If the PR has
nicktelford commented on PR #15264:
URL: https://github.com/apache/kafka/pull/15264#issuecomment-1956411417
@cadonna @ableegoldman Is there any more we need to do with this PR before
we can merge it?
--
This is an automated message from the Apache Git Service.
To respond to the message,
nicktelford commented on code in PR #15264:
URL: https://github.com/apache/kafka/pull/15264#discussion_r1487649620
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java:
##
@@ -1836,6 +1842,36 @@ public void
ableegoldman commented on code in PR #15264:
URL: https://github.com/apache/kafka/pull/15264#discussion_r1486914766
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java:
##
@@ -1836,6 +1842,36 @@ public void
nicktelford commented on code in PR #15264:
URL: https://github.com/apache/kafka/pull/15264#discussion_r1485925149
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java:
##
@@ -1836,6 +1842,36 @@ public void
nicktelford commented on code in PR #15264:
URL: https://github.com/apache/kafka/pull/15264#discussion_r1485925149
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java:
##
@@ -1836,6 +1842,36 @@ public void
nicktelford commented on code in PR #15264:
URL: https://github.com/apache/kafka/pull/15264#discussion_r1485911481
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java:
##
@@ -1889,7 +1925,8 @@ private int
ableegoldman commented on code in PR #15264:
URL: https://github.com/apache/kafka/pull/15264#discussion_r1483722072
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java:
##
@@ -1836,6 +1842,36 @@ public void
nicktelford commented on code in PR #15264:
URL: https://github.com/apache/kafka/pull/15264#discussion_r1478581894
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskExecutor.java:
##
@@ -157,7 +158,8 @@ int
nicktelford commented on code in PR #15264:
URL: https://github.com/apache/kafka/pull/15264#discussion_r1476237948
##
streams/src/main/java/org/apache/kafka/streams/state/internals/AbstractSegments.java:
##
@@ -152,6 +153,13 @@ public List allSegments(final boolean forward) {
nicktelford commented on code in PR #15264:
URL: https://github.com/apache/kafka/pull/15264#discussion_r1476236204
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/Tasks.java:
##
@@ -404,4 +404,11 @@ public synchronized Map allTasksPerId() {
public
nicktelford commented on code in PR #15264:
URL: https://github.com/apache/kafka/pull/15264#discussion_r1476235869
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamThreadTest.java:
##
@@ -1073,6 +1078,35 @@ int commit(final Collection tasksToCommit) {
nicktelford commented on code in PR #15264:
URL: https://github.com/apache/kafka/pull/15264#discussion_r1476175960
##
streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java:
##
@@ -1343,6 +1348,17 @@ private long getCacheSizePerThread(final int
numStreamThreads) {
nicktelford commented on code in PR #15264:
URL: https://github.com/apache/kafka/pull/15264#discussion_r1476172950
##
streams/src/test/java/org/apache/kafka/streams/StreamsConfigTest.java:
##
@@ -1320,6 +1320,19 @@ public void
cadonna commented on code in PR #15264:
URL: https://github.com/apache/kafka/pull/15264#discussion_r1474135551
##
streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java:
##
@@ -1343,6 +1348,17 @@ private long getCacheSizePerThread(final int
numStreamThreads) {
nicktelford commented on code in PR #15264:
URL: https://github.com/apache/kafka/pull/15264#discussion_r1473168658
##
streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java:
##
Review Comment:
Yeah, I can do that. I'm a little concerned that we might forget to
nicktelford commented on code in PR #15264:
URL: https://github.com/apache/kafka/pull/15264#discussion_r1473167769
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java:
##
@@ -1836,6 +1841,33 @@ public void
nicktelford commented on code in PR #15264:
URL: https://github.com/apache/kafka/pull/15264#discussion_r1473167034
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java:
##
@@ -1836,6 +1841,33 @@ public void
nicktelford commented on code in PR #15264:
URL: https://github.com/apache/kafka/pull/15264#discussion_r1473166531
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java:
##
@@ -1836,6 +1841,33 @@ public void
nicktelford commented on code in PR #15264:
URL: https://github.com/apache/kafka/pull/15264#discussion_r1473165230
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java:
##
@@ -1836,6 +1841,33 @@ public void
nicktelford commented on code in PR #15264:
URL: https://github.com/apache/kafka/pull/15264#discussion_r1473153338
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java:
##
@@ -1097,10 +1102,10 @@ void handleRevocation(final Collection
nicktelford commented on code in PR #15264:
URL: https://github.com/apache/kafka/pull/15264#discussion_r1473141072
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskExecutor.java:
##
@@ -157,7 +158,8 @@ int
nicktelford commented on code in PR #15264:
URL: https://github.com/apache/kafka/pull/15264#discussion_r1473126369
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java:
##
@@ -1374,7 +1376,7 @@ public void signalResume() {
*/
int
nicktelford commented on code in PR #15264:
URL: https://github.com/apache/kafka/pull/15264#discussion_r1473083987
##
streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java:
##
@@ -874,6 +879,12 @@ public class StreamsConfig extends AbstractConfig {
nicktelford commented on code in PR #15264:
URL: https://github.com/apache/kafka/pull/15264#discussion_r1473084666
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/ProcessorStateManager.java:
##
@@ -754,4 +754,11 @@ public void
nicktelford commented on code in PR #15264:
URL: https://github.com/apache/kafka/pull/15264#discussion_r1473084319
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/GlobalStateManagerImpl.java:
##
@@ -438,4 +438,11 @@ public Map changelogOffsets() {
nicktelford commented on code in PR #15264:
URL: https://github.com/apache/kafka/pull/15264#discussion_r1473083327
##
streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java:
##
@@ -505,6 +505,11 @@ public class StreamsConfig extends AbstractConfig {
public
cadonna commented on code in PR #15264:
URL: https://github.com/apache/kafka/pull/15264#discussion_r1471044772
##
streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java:
##
@@ -874,6 +879,12 @@ public class StreamsConfig extends AbstractConfig {
nicktelford commented on code in PR #15264:
URL: https://github.com/apache/kafka/pull/15264#discussion_r1466520246
##
streams/src/main/java/org/apache/kafka/streams/processor/StateStore.java:
##
@@ -165,4 +165,22 @@ default Position getPosition() {
"getPosition is
nicktelford commented on PR #15264:
URL: https://github.com/apache/kafka/pull/15264#issuecomment-1910401911
Note: this is part of KIP-892 Transactional StateStores. It introduces a new
config option that will have no effect until the rest of KIP-892 lands at a
later date.
@cadonna
nicktelford opened a new pull request, #15264:
URL: https://github.com/apache/kafka/pull/15264
This configuration controls the maximum amount of local state store data to
buffer in transaction buffers.
When the total uncommitted data, across all stores and all threads, exceeds
this
31 matches
Mail list logo
