rondagostino commented on PR #14984:
URL: https://github.com/apache/kafka/pull/14984#issuecomment-1856027270
Merged to 3.7
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
rondagostino merged PR #14984:
URL: https://github.com/apache/kafka/pull/14984
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
rondagostino commented on code in PR #14984:
URL: https://github.com/apache/kafka/pull/14984#discussion_r1426827635
##
server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java:
##
@@ -393,7 +400,7 @@ public short partitionRecordVersion() {
}
ijuma commented on PR #14984:
URL: https://github.com/apache/kafka/pull/14984#issuecomment-1855332987
Java 21 build passed, others have failures that look unrelated:
> Build / JDK 11 and Scala 2.13 /
pprovenzano commented on code in PR #14984:
URL: https://github.com/apache/kafka/pull/14984#discussion_r1426151584
##
server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java:
##
@@ -194,8 +194,14 @@ public enum MetadataVersion {
// Add JBOD support
pprovenzano commented on code in PR #14984:
URL: https://github.com/apache/kafka/pull/14984#discussion_r1426151584
##
server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java:
##
@@ -194,8 +194,14 @@ public enum MetadataVersion {
// Add JBOD support
pprovenzano commented on PR #14984:
URL: https://github.com/apache/kafka/pull/14984#issuecomment-1855063162
> Please update the PR description to explain what issue is being fixed. The
description doesn't match the changes included in this PR.
>
> Same with the PR title. Is the
jsancio commented on code in PR #14984:
URL: https://github.com/apache/kafka/pull/14984#discussion_r1426122289
##
server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java:
##
@@ -194,8 +194,14 @@ public enum MetadataVersion {
// Add JBOD support for
jsancio commented on code in PR #14984:
URL: https://github.com/apache/kafka/pull/14984#discussion_r1426122289
##
server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java:
##
@@ -194,8 +194,14 @@ public enum MetadataVersion {
// Add JBOD support for
pprovenzano commented on code in PR #14984:
URL: https://github.com/apache/kafka/pull/14984#discussion_r1426120064
##
server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java:
##
@@ -194,8 +194,13 @@ public enum MetadataVersion {
// Add JBOD support
pprovenzano commented on code in PR #14984:
URL: https://github.com/apache/kafka/pull/14984#discussion_r1426109379
##
server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java:
##
@@ -194,8 +194,14 @@ public enum MetadataVersion {
// Add JBOD support
pprovenzano commented on code in PR #14984:
URL: https://github.com/apache/kafka/pull/14984#discussion_r1426109379
##
server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java:
##
@@ -194,8 +194,14 @@ public enum MetadataVersion {
// Add JBOD support
jsancio commented on code in PR #14984:
URL: https://github.com/apache/kafka/pull/14984#discussion_r1426068254
##
server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java:
##
@@ -194,8 +194,14 @@ public enum MetadataVersion {
// Add JBOD support for
jolshan commented on code in PR #14984:
URL: https://github.com/apache/kafka/pull/14984#discussion_r1426014858
##
server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java:
##
@@ -194,8 +194,13 @@ public enum MetadataVersion {
// Add JBOD support for
pprovenzano commented on code in PR #14984:
URL: https://github.com/apache/kafka/pull/14984#discussion_r1426006570
##
server-common/src/test/java/org/apache/kafka/server/common/MetadataVersionTest.java:
##
@@ -228,6 +230,8 @@ public void testShortVersion() {
pprovenzano commented on code in PR #14984:
URL: https://github.com/apache/kafka/pull/14984#discussion_r1426005487
##
core/src/test/scala/integration/kafka/zk/ZkMigrationIntegrationTest.scala:
##
@@ -74,7 +74,8 @@ object ZkMigrationIntegrationTest {
pprovenzano commented on code in PR #14984:
URL: https://github.com/apache/kafka/pull/14984#discussion_r1426004845
##
server-common/src/test/java/org/apache/kafka/server/common/MetadataVersionTest.java:
##
@@ -274,7 +278,8 @@ public void testVersion() {
pprovenzano commented on code in PR #14984:
URL: https://github.com/apache/kafka/pull/14984#discussion_r1426003941
##
server-common/src/test/java/org/apache/kafka/server/common/MetadataVersionTest.java:
##
@@ -165,13 +165,15 @@ public void testFromVersionString() {
pprovenzano commented on code in PR #14984:
URL: https://github.com/apache/kafka/pull/14984#discussion_r1426003081
##
server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java:
##
@@ -194,8 +194,13 @@ public enum MetadataVersion {
// Add JBOD support
jolshan commented on code in PR #14984:
URL: https://github.com/apache/kafka/pull/14984#discussion_r1425960046
##
server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java:
##
@@ -194,8 +194,13 @@ public enum MetadataVersion {
// Add JBOD support for
rondagostino commented on code in PR #14984:
URL: https://github.com/apache/kafka/pull/14984#discussion_r1425956907
##
core/src/test/scala/integration/kafka/zk/ZkMigrationIntegrationTest.scala:
##
@@ -74,7 +74,8 @@ object ZkMigrationIntegrationTest {
rondagostino commented on code in PR #14984:
URL: https://github.com/apache/kafka/pull/14984#discussion_r1425955291
##
server-common/src/test/java/org/apache/kafka/server/common/MetadataVersionTest.java:
##
@@ -165,13 +165,15 @@ public void testFromVersionString() {
pprovenzano commented on code in PR #14984:
URL: https://github.com/apache/kafka/pull/14984#discussion_r1424185932
##
server-common/src/test/java/org/apache/kafka/server/common/MetadataVersionTest.java:
##
@@ -166,13 +166,12 @@ public void testFromVersionString() {
ijuma commented on code in PR #14984:
URL: https://github.com/apache/kafka/pull/14984#discussion_r1423923940
##
server-common/src/test/java/org/apache/kafka/server/common/MetadataVersionTest.java:
##
@@ -166,13 +166,12 @@ public void testFromVersionString() {
pprovenzano commented on PR #14984:
URL: https://github.com/apache/kafka/pull/14984#issuecomment-1851271238
Okay, I think I have addresses the issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
rondagostino commented on PR #14984:
URL: https://github.com/apache/kafka/pull/14984#issuecomment-1850991968
@pprovenzano Can you look at the test failures?
`60 tests have failed. There are 0 new tests failing, 60 existing failing`
26 matches
Mail list logo
