cvs commit: jakarta-jmeter/src/core/org/apache/jmeter/junit JMeterTest.java

2004-02-09 Thread sebb
sebb2004/02/09 17:28:29 Modified:src/core/org/apache/jmeter/junit JMeterTest.java Log: ASF L V2; catch Exception when running headless Revision ChangesPath 1.43 +31 -7 jakarta-jmeter/src/core/org/apache/jmeter/junit/JMeterTest.java Index: JMeterTest.jav

cvs commit: jakarta-jmeter/lib LICENSE(jdom).txt

2004-02-09 Thread sebb
sebb2004/02/09 16:59:07 Added: lib LICENSE(jdom).txt Log: ASF L V2 Revision ChangesPath 1.1 jakarta-jmeter/lib/LICENSE(jdom).txt Index: LICENSE(jdom).txt === /*-- $

cvs commit: jakarta-jmeter NOTICE

2004-02-09 Thread sebb
sebb2004/02/09 16:58:51 Added: .NOTICE Log: ASF L V2 Revision ChangesPath 1.1 jakarta-jmeter/NOTICE Index: NOTICE === This product includes software developed by The

cvs commit: jakarta-jmeter/src/protocol/java/org/apache/jmeter/protocol/java/test SleepTest.java JavaTest.java

2004-02-09 Thread sebb
sebb2004/02/09 16:46:44 Modified:src/protocol/java/org/apache/jmeter/protocol/java/sampler AbstractJavaSamplerClient.java JavaSamplerContext.java JavaSampler.java BeanShellSampler.java BSFSampler.java

cvs commit: jakarta-jmeter/src/protocol/tcp/org/apache/jmeter/protocol/tcp/control/gui TCPSamplerGui.java

2004-02-09 Thread sebb
sebb2004/02/09 16:39:37 Modified:src/protocol/tcp/org/apache/jmeter/protocol/tcp/config/gui TCPConfigGui.java src/protocol/tcp/org/apache/jmeter/protocol/tcp/sampler TCPClientImpl.java TCPClient.java TCPSampler.java

cvs commit: jakarta-jmeter/src/functions/org/apache/jmeter/functions StringFromFile.java RegexFunction.java IntSum.java Property2.java FileRowColContainer.java Package.html LogFunction.java CSVRead.java PackageTest.java Random.java FileWrapper.java JavaScript.java MachineName.java LogFunction2.java Property.java ThreadNumber.java IterationCounter.java

2004-02-09 Thread sebb
sebb2004/02/09 16:35:12 Modified:src/functions/org/apache/jmeter/functions StringFromFile.java RegexFunction.java IntSum.java Property2.java FileRowColContainer.java Package.html LogFunction.java CSVRead.java

cvs commit: jakarta-jmeter/src/functions/org/apache/jmeter/functions BeanShell.java

2004-02-09 Thread sebb
sebb2004/02/09 16:34:37 Modified:src/functions/org/apache/jmeter/functions BeanShell.java Log: ASF V2; replace string with property Revision ChangesPath 1.2 +17 -54 jakarta-jmeter/src/functions/org/apache/jmeter/functions/BeanShell.java Index: BeanShell

cvs commit: jakarta-jmeter/src/core/org/apache/jmeter/resources messages.properties

2004-02-09 Thread sebb
sebb2004/02/09 16:33:52 Modified:src/core/org/apache/jmeter/resources messages.properties Log: BeanShell function message Revision ChangesPath 1.100 +1 -0 jakarta-jmeter/src/core/org/apache/jmeter/resources/messages.properties Index: messages.properties

cvs commit: jakarta-jmeter LICENSE

2004-02-09 Thread sebb
sebb2004/02/09 16:08:46 Modified:.LICENSE Log: ASF License V2.0 + 3rd party pointers Revision ChangesPath 1.4 +210 -51 jakarta-jmeter/LICENSE Index: LICENSE === RCS file: /home/cv

cvs commit: jakarta-jmeter/src/protocol/http/org/apache/jmeter/protocol/http/parser URLCollection.java URLString.java

2004-02-09 Thread sebb
sebb2004/02/09 15:45:22 Modified:src/protocol/http/org/apache/jmeter/protocol/http/parser URLCollection.java URLString.java Log: Try Header Revision ChangesPath 1.3 +2 -2 jakarta-jmeter/src/protocol/http/org/apache/jmeter/protocol/h

Re: ASF 2.0 licence - tags

2004-02-09 Thread sebb
I'd forgotten about the guidelines, but I agree with them all apart from @version $Id$. $Id$ looks rather odd to me in a @version tag, so I tend to use @version $Revision$ updated on $Date$ which seems to me to be enough information for the Javadoc comments. It's much easier to pick out the ver

Re: ASF 2.0 licence

2004-02-09 Thread Jordi Salvat i Alabart
Actually, the formatting guidelines we agreed to follow a while ago (http://jakarta.apache.org/turbine/common/code-standards.html) read: « 9. All .java files should have a @version tag like the one below. @version $Id: code-standards.xml,v 1.6 2003/03/12 21:34:39 quintonm Exp$ » Related, but not

Re: ASF 2.0 licence

2004-02-09 Thread sebb
Oops! that should have been // $Id$ ! - Original Message - From: "BAZLEY, Sebastian" <[EMAIL PROTECTED]> To: "'JMeter Developers List'" <[EMAIL PROTECTED]> Sent: Monday, February 09, 2004 5:49 PM Subject: RE: ASF 2.0 licence; Junit >-Original Message- >From: peter lin [mailto:[E

cvs commit: jakarta-jmeter/xdocs/usermanual component_reference.xml

2004-02-09 Thread jsalvata
jsalvata2004/02/09 14:50:52 Modified:src/core/org/apache/jmeter/resources messages.properties xdocs/usermanual component_reference.xml Added: src/components/org/apache/jmeter/control RandomOrderController.java src/components/o

Re: [PATCH] new controller - RandomOrderController

2004-02-09 Thread Jordi Salvat i Alabart
Hi Mike. Your contribution looks useful to me, and while Mike's suggestion to merge it with the RandomController makes sense, I still feel it's more important to get the functionality there before the next release. So unless you or someone else volonteers to do the merging, I will add it as-is

DO NOT REPLY [Bug 26804] New: - Java Sampler GUI does not allow leaving arguments undefined

2004-02-09 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bu

DO NOT REPLY [Bug 26605] - Java Config elements override samplers

2004-02-09 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bu

Re: Are we ready for a RC?

2004-02-09 Thread Jordi Salvat i Alabart
I've finally found a low-risk way into this one. In short, the Arguments.getArgumentsAsMap() method was arbitrarily returning the last value for a name in case there were several properties for that same name in the collection. I've changed this to return the first. This will make the element's

cvs commit: jakarta-jmeter/src/core/org/apache/jmeter/config Arguments.java

2004-02-09 Thread jsalvata
jsalvata2004/02/09 14:00:16 Modified:src/core/org/apache/jmeter/config Arguments.java Log: Make config elements work for Arguments in cases where Arguments are actually a key->value map (such as for the Java Sampler.) (That's oposed to when Arguments is a set of {key,value} pai

Re: cvs commit: jakarta-jmeter/src/protocol/http/org/apache/jmeter/protocol/http/util/accesslog LogFilter.java

2004-02-09 Thread peter lin
that seems fine to me :) no seems to be using the accesslog sampler anyways. Plus, the filter is there, but the GUI doesn't provide a way to enter the filter, so a user would have to harcode it in their own generator/parser. I couldn't decide how to hook the filter into the sampler, so the im

Re: cvs commit: jakarta-jmeter/src/protocol/http/org/apache/jmeter/protocol/http/util/accesslog LogFilter.java

2004-02-09 Thread Jordi Salvat i Alabart
Hi Peter, I'm not 100% sure these regexps can be used concurrently, since they are 'owned' by each filter, so as far as filters are not reused by different threads, we should be safe. I preferred to fix it anyway since the performance penalty incurred is, as fas as I know, very small -- and, as

cvs commit: jakarta-jmeter/src/protocol/http/org/apache/jmeter/protocol/http/util/accesslog LogFilter.java

2004-02-09 Thread jsalvata
jsalvata2004/02/09 10:28:15 Modified:src/protocol/http/org/apache/jmeter/protocol/http/util/accesslog LogFilter.java Log: Making thread-safe by using READ_ONLY_MASK when compiling regexps. Revision ChangesPath 1.6 +1 -1 jakarta-jmeter/s

cvs commit: jakarta-jmeter/src/functions/org/apache/jmeter/functions RegexFunction.java

2004-02-09 Thread jsalvata
jsalvata2004/02/09 10:25:07 Modified:src/functions/org/apache/jmeter/functions RegexFunction.java Log: * Making thread-safe by using READ_ONLY_MASK when compiling regexps. * Using a pattern cache for better performance. Revision ChangesPath 1.19 +7 -27 jakarta

RE: ASF 2.0 licence; Junit

2004-02-09 Thread BAZLEY, Sebastian
>-Original Message- >From: peter lin [mailto:[EMAIL PROTECTED] >Sent: 09 February 2004 17:35 >To: JMeter Developers List >Subject: Re: ASF 2.0 licence; Junit > >Ok, I'll start changing the headers on the stuff I'm >responsible for and then move on from there. Good idea. Divide and conquer

Re: ASF 2.0 licence; Junit

2004-02-09 Thread peter lin
Ok, I'll start changing the headers on the stuff I'm responsible for and then move on from there. peter lin Jordi Salvat i Alabart <[EMAIL PROTECTED]> wrote: BAZLEY, Sebastian wrote: > I started trying to set up for the new ASF 2.0 licence, by following in > instructions at: > > http://ww

Re: ASF 2.0 licence; Junit

2004-02-09 Thread Jordi Salvat i Alabart
BAZLEY, Sebastian wrote: I started trying to set up for the new ASF 2.0 licence, by following in instructions at: http://www.apache.org/dev/apply-license.html {see also http://www.apache.org/licenses/] The new URLString and URLCollection classes have got the new licence headers - I hope I've got

DO NOT REPLY [Bug 26797] - Timestamp should be shown in Result Table

2004-02-09 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bu

DO NOT REPLY [Bug 26797] New: - Timestamp should be shown in Result Table

2004-02-09 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bu

RE: Problem with "headless" Gump tests

2004-02-09 Thread BAZLEY, Sebastian
>-Original Message- >From: Stefan Bodewig [mailto:[EMAIL PROTECTED] >Sent: 09 February 2004 14:10 >To: JMeter Developers List >Subject: Re: Problem with "headless" Gump tests > >On Mon, 09 Feb 2004, Sebastian BAZLEY ><[EMAIL PROTECTED]> wrote: >>>From: Stefan Bodewig [mailto:[EMAIL PROTECTE

RE: ASF 2.0 licence; Junit

2004-02-09 Thread BAZLEY, Sebastian
Doh! Ignore the bit about removing JUnit - it's needed to compile the test code, and as that is mixed in with the live code, of course it's needed ... [unless one day all the test code is moved into separate files] S. >-Original Message- >From: BAZLEY, Sebastian >Sent: 09 February 200

cvs commit: jakarta-jmeter/src/protocol/http/org/apache/jmeter/protocol/http/parser URLCollection.java URLString.java

2004-02-09 Thread sebb
sebb2004/02/09 07:45:11 Modified:src/protocol/http/org/apache/jmeter/protocol/http/parser URLCollection.java URLString.java Log: Oops! left off the The ... Revision ChangesPath 1.2 +3 -3 jakarta-jmeter/src/protocol/http/org/apache/j

Re: Problem with "headless" Gump tests

2004-02-09 Thread Stefan Bodewig
On Mon, 09 Feb 2004, Sebastian BAZLEY <[EMAIL PROTECTED]> wrote: >>From: Stefan Bodewig [mailto:[EMAIL PROTECTED] >>I don't have the historical data necessary to say whether you should >>expect nags at all. JMeter hasn't been built by Gump last night as >>the velocity build has failed. > > We di

Re: Are we ready for a RC?

2004-02-09 Thread peter lin
+1 might be good to include a note in the docs or user manual. peter lin Jordi Salvat i Alabart <[EMAIL PROTECTED]> wrote: BAZLEY, Sebastian wrote: > I'm not averse to creating a release candidate, but it would be good if we > could fix at least some of the following before release: > >

Re: Problem with "headless" Gump tests

2004-02-09 Thread Jordi Salvat i Alabart
Nags used to reach jmeter-dev a (long) while ago. Last one in my records is 28th july. I think one of the Gump machines --the only one nagging-- stopped working, and we've never had nags since. jmeter-dev is moderated -- but non-subscriber's e-mails can still reach it: the moderators receive a

RE: Problem with "headless" Gump tests

2004-02-09 Thread BAZLEY, Sebastian
>-Original Message- >From: Jordi Salvat i Alabart [mailto:[EMAIL PROTECTED] >Sent: 09 February 2004 12:32 >To: JMeter Developers List >Subject: Re: Problem with "headless" Gump tests > > >I recently changed some GUI-related code in test methods. It may be >related. I'm attaching the releva

RE: Problem with "headless" Gump tests

2004-02-09 Thread BAZLEY, Sebastian
>-Original Message- >From: Stefan Bodewig [mailto:[EMAIL PROTECTED] >Sent: 09 February 2004 12:57 >To: JMeter Developers List >Subject: Re: Problem with "headless" Gump tests > > >On Mon, 09 Feb 2004, Jordi Salvat i. Alabart <[EMAIL PROTECTED]> wrote: > >> BTW, any idea why Gump nags are no

Re: Problem with "headless" Gump tests

2004-02-09 Thread Stefan Bodewig
On Mon, 09 Feb 2004, Jordi Salvat i. Alabart <[EMAIL PROTECTED]> wrote: > BTW, any idea why Gump nags are not working? Issues like this would > be spotted much quicker if they did. I don't have the historical data necessary to say whether you should expect nags at all. JMeter hasn't been built b

ASF 2.0 licence; Junit

2004-02-09 Thread BAZLEY, Sebastian
I started trying to set up for the new ASF 2.0 licence, by following in instructions at: http://www.apache.org/dev/apply-license.html {see also http://www.apache.org/licenses/] The new URLString and URLCollection classes have got the new licence headers - I hope I've got them right! I've not yet

Re: Problem with "headless" Gump tests

2004-02-09 Thread Jordi Salvat i Alabart
I recently changed some GUI-related code in test methods. It may be related. I'm attaching the relevant CVS commit message. BTW, any idea why Gump nags are not working? Issues like this would be spotted much quicker if they did. -- Salut, Jordi. BAZLEY, Sebastian wrote: Something has broken th

Re: Are we ready for a RC?

2004-02-09 Thread Jordi Salvat i Alabart
BAZLEY, Sebastian wrote: I'm not averse to creating a release candidate, but it would be good if we could fix at least some of the following before release: 26605 Maj Oth All [EMAIL PROTECTED] NEW Java Config elements override samplers Been looking at this one. I believe the correct solution

Problem with "headless" Gump tests

2004-02-09 Thread BAZLEY, Sebastian
Something has broken the test setup when running "headless" - i.e. with no display hardware. This may be because of something I changed; anyway, I'll try to have a look at it later today. By the way, one can use the "test-headless" Ant build target to test running headless - I must have forgotten

cvs commit: jakarta-jmeter/src/protocol/http/org/apache/jmeter/protocol/http/parser HTMLParser.java

2004-02-09 Thread sebb
sebb2004/02/09 02:59:27 Modified:src/protocol/http/org/apache/jmeter/protocol/http/parser HTMLParser.java Log: Add back original method signature (using a Collection) Revision ChangesPath 1.20 +29 -3 jakarta-jmeter/src/protocol/http/o