[josm-dev] EastNorth immutable and cloning

2010-11-16 Thread Olivier Croquette
Hi all While implementing my improvements for PicLayer, I came upon 2 issues in the core code. NB: while I know other languages quite well (in particular C++ and Perl), I am a Java newbie. That may explains things ;-) 1) First, it's documented as a immutable class : /** * Northing, Easting o

Re: [josm-dev] Removing scale_max / scale_min from elemstyles.xml?

2010-11-16 Thread Ulf Lamping
Am 15.11.2010 23:48, schrieb Sebastian Klein: No objections. Maybe we can switch the default value of mappaint.zoomLevelDisplay from false to true afterwards. This way authors of external style sets can create fancy scale dependent styles and don't need to bother their users with advanced prefere

[josm-dev] Draft patch for PicLayer

2010-11-16 Thread Olivier Croquette
Hi, as already discussed, I have been working on PicLayer recently. You will find attached a patch which adds the following features and corrections : Misc: - allow to auto-zoom on PicLayers (e.g. support of the bounding box visitor) - added possibility to rename the Piclayers Precision : - hig

Re: [josm-dev] Removing scale_max / scale_min from elemstyles.xml? / mapcss

2010-11-16 Thread Ulf Lamping
Am 16.11.2010 15:09, schrieb Sebastian Klein: Yes, I'm aware of this. Currently, the new PaintVisitor is slightly slower (basically due to z-level ordering) but not significantly ( < 5% I think, but I will do careful benchmarking). All styles are cached, of course, so most time is not spend in JO

Re: [josm-dev] EastNorth immutable and cloning

2010-11-16 Thread Sebastian Klein
Olivier Croquette wrote: Hi all While implementing my improvements for PicLayer, I came upon 2 issues in the core code. NB: while I know other languages quite well (in particular C++ and Perl), I am a Java newbie. That may explains things ;-) 1) First, it's documented as a immutable class :

Re: [josm-dev] Draft patch for PicLayer

2010-11-16 Thread MP
On Tue, 16 Nov 2010 20:09:07 +0100, Olivier Croquette wrote: Hi, as already discussed, I have been working on PicLayer recently. You will find attached a patch which adds the following features and corrections : Misc: - allow to auto-zoom on PicLayers (e.g. support of the bounding box visitor

Re: [josm-dev] Draft patch for PicLayer

2010-11-16 Thread Olivier Croquette
On 16 nov. 2010, at 22:27, MP wrote: > There is still one quite important feature missing - calibration given > geographic coordinates. Hi Martin ! I would be happy if only one important feature was missing :-) There are actually many : support for GeoTiff (load/save), transparency, ... I reall

[josm-dev] AddPrimitivesCommand constructor

2010-11-16 Thread Roman Byshko
Hi guys, currently AddPrimitivesCommand does not have a constructor where OsmLayer can be give as a parameter. I'm developing a plugin right now and need this option. The patch in the attachment adds this functionality. Would you please commit it into the trunk? Regards, Roman p.s. sorry if the