Re: [JPP-Devel] Possible Bug in FeatureCollectionTools.getEnvelopeForFeatures method.

2009-06-24 Thread Michaël Michaud
Hi, I believe there may be a bug in the getEnvelopeForFeatures method of the FeatureCollectionTools class. It uses the Geometry.getCoordinate method when it should use the Geometry.getEnvelopeInternal method. This may result in the calculation of an envolope that does not include the envelope

Re: [JPP-Devel] Select an item

2009-06-24 Thread Rahkonen Jukka
Hi, Sorry, I cannot answer your question, but I see that you are working with IACS/LPIS data and that interests me. Could you possibly provide some information about your project, perhaps with personal mail? -Jukka Rahkonen- mickael.violle wrote: Hello, I replaced the TreeView with a

Re: [JPP-Devel] Possible Bug in FeatureCollectionTools.getEnvelopeForFeatures method.

2009-06-24 Thread Larry Becker
Hi SS, If you are talking about this code, it looks like it works to me: public static Envelope getEnvelopeForFeatures(Feature[] features){ Envelope env = null; Feature feat; for (int i=0; ifeatures.length; i++){ feat = features[i]; if

Re: [JPP-Devel] Select an item

2009-06-24 Thread mickael.violle
Hi, I found the answer : SelectionManager sm = context.getLayerViewPanel().getSelectionManager(); sm.clear(); sm.getFeatureSelection().selectItems(layer, features); Thank you :) Message du 24/06/09 11:57 De : Rahkonen Jukka jukka.rahko...@mmmtike.fi A : mickael.violle

Re: [JPP-Devel] Category and order

2009-06-24 Thread Larry Becker
Are using LayerManage's .addCategory()? regards, Larry On Wed, Jun 24, 2009 at 5:08 AM, Julien Perret julien.per...@gmail.comwrote: Hi guys, is there any specific way of specifying the order in which categories are displayed in the LayerNamePanel? It seems that, even when adding them

Re: [JPP-Devel] Category and order

2009-06-24 Thread Giuseppe Aruta
Hi all, this is a discussion from Openjump-User_list. Ravi descibes a problem with Geoff's print plugin on Windows Vista. I put this discussion on Devel list just in case Geoff can see it. Peppe --- Mer 24/6/09, Ravi Vundavalli ravivundava...@gmail.com ha scritto: Da: Ravi Vundavalli

Re: [JPP-Devel] CADPLAN printer plugin problem

2009-06-24 Thread Giuseppe Aruta
Sorry, I put is the real subject of the message Hi all, this is a discussion from Openjump-User_list. Ravi descibes a problem with Geoff's print plugin on Windows Vista. I put this discussion on Devel list just in case Geoff can see it. Peppe --- Mer 24/6/09, Ravi Vundavalli

Re: [JPP-Devel] Possible Bug in FeatureCollectionTools.getEnvelopeForFeatures method.

2009-06-24 Thread Sunburned Surveyor
Thanks for the responses Larry and Michael. I have attached a text file with my modified method. (Note: There are other changes to my method that I would not include in the patch.) I believe that the use of getCoordinate method should be replaced with the getEnvelopeInternal method. But I could

Re: [JPP-Devel] Possible Bug in FeatureCollectionTools.getEnvelopeForFeatures method.

2009-06-24 Thread Larry Becker
Yes, you are right. The getCoordinate() only works when looping through a single feature's points. Larry On Wed, Jun 24, 2009 at 12:12 PM, Sunburned Surveyor sunburned.surve...@gmail.com wrote: Thanks for the responses Larry and Michael. I have attached a text file with my modified method.

Re: [JPP-Devel] Category and order

2009-06-24 Thread Julien Perret
Actually, I'm using LayerManager's addLayer(categoryName,layer) which calls addLayerable(categoryName, layer) which, in turn, calls : addCategory(categoryName) Category cat = getCategory(categoryName); cat.add(0, layerable); So, if I understant it right, it should always add layers in the same

Re: [JPP-Devel] Possible Bug in FeatureCollectionTools.getEnvelopeForFeatures method.

2009-06-24 Thread Sunburned Surveyor
I'll get a patch ready for OJ when I have unit tested the method. Thanks for the review Michael and Larry. While we are on the topic, could you guys look at the getCenterOfMass method in the same class. Its supposed to act like the Geometry.getCentroid method, but for a group of Feature objects.

[JPP-Devel] Moving some org.openjump.core.apitools members to com.vividsolutions.jump.util.CollectionUtil.

2009-06-24 Thread Sunburned Surveyor
There are two (2) methods in the org.openjump.core.apitools that I think we should move to the com.vividsolutions.jump.util.CollectionUtil class. The first method is the org.openjump.core.apitools.CollectionTools.addArrayToList method. The second is the

Re: [JPP-Devel] Moving some org.openjump.core.apitools members to com.vividsolutions.jump.util.CollectionUtil.

2009-06-24 Thread Larry Becker
I think we should look at the vividsolutions code base as legacy - to be maintained but not extended much. New stuff should generally go into openjump.core. What is it about these two methods that doesn't fit this paradigm? regards, Larry On Wed, Jun 24, 2009 at 2:54 PM, Sunburned Surveyor

Re: [JPP-Devel] Possible Bug in FeatureCollectionTools.getEnvelopeForFeatures method.

2009-06-24 Thread Michaël Michaud
Hi, I agree getCoordinate must be replaced by getEnvelopeInternal, but your method is way too complex. If you study Envelope class, you'll notice that EmptyGeometry envelopes are already managed by this class, so that the following few lines should do what you want : public Envelope

Re: [JPP-Devel] Possible Bug in FeatureCollectionTools.getEnvelopeForFeatures method.

2009-06-24 Thread Sunburned Surveyor
Roger that Michael. I will remove the portions of my method that deal with empty geomtries. Thanks for the suggestion. SS 2009/6/24 Michaël Michaud michael.mich...@free.fr: Hi, I agree getCoordinate must be replaced by getEnvelopeInternal, but your method is way too complex. If you study

Re: [JPP-Devel] Possible Bug in FeatureCollectionTools.getEnvelopeForFeatures method.

2009-06-24 Thread Michaël Michaud
Hi, I think you're right again. For a better result with non puntal geometries, one should use getCentroid instead of getCoordinate in getCenterOfMass method One could also compute something closer to a center of mass by using the area or the length of the feature as the mass of each feature Of

Re: [JPP-Devel] Moving some org.openjump.core.apitools members to com.vividsolutions.jump.util.CollectionUtil.

2009-06-24 Thread Sunburned Surveyor
Larry wrote: I think we should look at the vividsolutions code base as legacy - to be maintained but not extended much. I'm OK with that philosphy. It would provide better separation between Vivid's code and code contributed by the community if copyright or other legal issues ever come up. Larry

Re: [JPP-Devel] [SPAM]Re: [SPAM]Re: a couple of requests.... on dimensions

2009-06-24 Thread Michaël Michaud
Hi Larry, Thanks for the effort. Did you commit the change ? If it can solve the problem, I'll change Montrer seulement la couche quand l'échelle est entre with your sentence (you french is very good !) or with something close to that (maybe Visible entre les échelles :) Michaël Larry Becker

Re: [JPP-Devel] Possible Bug in FeatureCollectionTools.getEnvelopeForFeatures method.

2009-06-24 Thread Sunburned Surveyor
Michael, When I fist started looking hard at the method, I realized that center of mass could mean different things to different people. I don't have time now to explore the differernt ways this center of mass could be defined and the different ways this method could be implemented, but it sounds

Re: [JPP-Devel] Moving some org.openjump.core.apitools members to com.vividsolutions.jump.util.CollectionUtil.

2009-06-24 Thread Michaël Michaud
Hi SS and Larry, I often feel uncomfortable having a com.vividsolutions tree structure and a org.openjump tree structure (this is confusing, more difficult to find existing code, a risk to create redundant methods...) But this would be much work to refactor all the code, and most developpers

Re: [JPP-Devel] Possible Bug in FeatureCollectionTools.getEnvelopeForFeatures method.

2009-06-24 Thread Michaël Michaud
Hi If all we need to do is replace calls to getCoordinate with getCentroid, I can prepare a patch for this as well. I don't know who (which plugin) use it, but I think that with the current implementation, the centerOfMass of a set of polygons made of a single regular polygon will return

Re: [JPP-Devel] Moving some org.openjump.core.apitools members to com.vividsolutions.jump.util.CollectionUtil.

2009-06-24 Thread Larry Becker
I think it would be better to have a org.openjump.core.util.CollectionUtil class, where all new utility methods dealing with collections could be stored. I don't have a problem with that. regards, Larry On Wed, Jun 24, 2009 at 4:19 PM, Sunburned Surveyor sunburned.surve...@gmail.com wrote:

Re: [JPP-Devel] [SPAM]Re: [SPAM]Re: a couple of requests.... on dimensions

2009-06-24 Thread Larry Becker
Hi Michaël, I'll commit the change right now, and you can adjust the language file if necessary. regards, Larry 2009/6/24 Michaël Michaud michael.mich...@free.fr Hi Larry, Thanks for the effort. Did you commit the change ? If it can solve the problem, I'll change Montrer seulement la