Re: [JPP-Devel] SVN: [6517] core/trunk/src/com/vividsolutions/jump/workbench/imagery/ geotiff

2020-09-22 Thread Michaud Michael
Hi Ede,Answers inlineenvoyé : 22 septembre 2020 à 22:43de : edgar.sol...@web.deà : jump-pilot-devel@lists.sourceforge.netobjet : Re: [JPP-Devel] SVN: [6517] core/trunk/src/com/vividsolutions/jump/workbench/imagery/ geotiffhey Mike, questions inlineOn 22.09.2020 16:56, jump-pilot-svn--- via

Re: [JPP-Devel] 6506 loading raster test

2020-09-22 Thread Roberto Rossi
Hello Edgard, i repeated the test with the "-v trace" option... the log is really verbose now: from 50 to 15000 kb! :-) I tried at first to load the shapefiles , the error raised at the 7th raster

Re: [JPP-Devel] SVN: [6517] core/trunk/src/com/vividsolutions/jump/workbench/imagery/ geotiff

2020-09-22 Thread edgar . soldin
hey Mike, questions inline On 22.09.2020 16:56, jump-pilot-svn--- via Jump-pilot-devel wrote: > Revision: 6517 > http://sourceforge.net/p/jump-pilot/code/6517 > Author: michaudm > Date: 2020-09-22 14:56:54 + (Tue, 22 Sep 2020) > Log Message: > --- > Do not use

Re: [JPP-Devel] SVN: [6518] core/trunk/src/org/openjump/core/rasterimage

2020-09-22 Thread edgar . soldin
On 22.09.2020 18:20, Giuseppe Aruta wrote: > Hi Ede, > The changes I did: > a) remove the reading of overviews as you suggested why didn't you disable/comment the whole method? > b) removed the usage of commons imaging to compute some metadata > the reason is that those metadata are already

Re: [JPP-Devel] SVN: [6518] core/trunk/src/org/openjump/core/rasterimage

2020-09-22 Thread edgar . soldin
hey Peppe, ajaics this still leaves private static ImageAndMetadata readImage(File tiffFile, int overviewIndex, int indexStart, Point originalSize, Resolution originalCellSize, Envelope wholeImageEnvelope, Envelope viewportEnvelope, double noDataValue, Stats stats) throws

Re: [JPP-Devel] Fwd: [jira] [Commented] (IMAGING-267) Colorful rendering of b/w Monoband TIF

2020-09-22 Thread edgar . soldin
Peppe, would you mind posting your answer in the jira ticket [1] or do you want me to post it in your stead? ..ede [1] https://issues.apache.org/jira/browse/IMAGING-267?page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel=17200118#comment-17200118 On 22.09.2020 18:37,

Re: [JPP-Devel] SVN: [6507] core/trunk/src/org/openjump/core/rasterimage

2020-09-22 Thread Rahkonen Jukka (MML)
Hi, What is the question? TIFF files can have either internal or external overviews and if client supports them it is much faster to render the image at small scales. I have no idea about what readers can handle internal/external overviews but I can arrange test images easily. External

[JPP-Devel] RasterizePlugIn

2020-09-22 Thread Michaud Michael
Peppe,RasterizePlugIn is an interesting addition. Maybe you have not completely finished, sorry, I saw this today and had some time in the train to make a quick review :- plugin is not activated yet (not in default-plugin.xml)- not fully internationalized (method getName)- would be nice to have

Re: [JPP-Devel] Fwd: [jira] [Commented] (IMAGING-267) Colorful rendering of b/w Monoband TIF

2020-09-22 Thread Giuseppe Aruta
*First off, this TIFF appears to be geophysical data. But there are no GeoTIFF tags bundled with the image. Judging from the ModelTiepointTag, it appears that the original image was configured using a projected coordinate system, maybe a UTM zone. It might help me understand this better if there

Re: [JPP-Devel] SVN: [6518] core/trunk/src/org/openjump/core/rasterimage

2020-09-22 Thread Giuseppe Aruta
Removing common imaging also "prodigiously" solved the problem on AsterDem dimension that Michael described in a previous post Il giorno mar 22 set 2020 alle ore 18:20 Giuseppe Aruta < giuseppe.ar...@gmail.com> ha scritto: > Hi Ede, > The changes I did: > a) remove the reading of overviews as

Re: [JPP-Devel] SVN: [6518] core/trunk/src/org/openjump/core/rasterimage

2020-09-22 Thread Giuseppe Aruta
Hi Ede, The changes I did: a) remove the reading of overviews as you suggested b) removed the usage of commons imaging to compute some metadata the reason is that those metadata are already computed by method GeoReferencedRaster getGeoReferencedRaster(File tiffFile), except NoData, I also removed

[JPP-Devel] SVN: [6519] core/trunk/src/org/openjump/core/rasterimage/TiffUtilsV2.java

2020-09-22 Thread jump-pilot-svn--- via Jump-pilot-devel
Revision: 6519 http://sourceforge.net/p/jump-pilot/code/6519 Author: ma15569 Date: 2020-09-22 16:08:22 + (Tue, 22 Sep 2020) Log Message: --- correct typo Modified Paths: -- core/trunk/src/org/openjump/core/rasterimage/TiffUtilsV2.java Modified:

[JPP-Devel] SVN: [6518] core/trunk/src/org/openjump/core/rasterimage

2020-09-22 Thread jump-pilot-svn--- via Jump-pilot-devel
Revision: 6518 http://sourceforge.net/p/jump-pilot/code/6518 Author: ma15569 Date: 2020-09-22 16:07:41 + (Tue, 22 Sep 2020) Log Message: --- Added a new method to read Image and Metadata for TIF. It gets rid of using Commons Imaging that sometimes throws exception on

[JPP-Devel] SVN: [6517] core/trunk/src/com/vividsolutions/jump/workbench/imagery/ geotiff

2020-09-22 Thread jump-pilot-svn--- via Jump-pilot-devel
Revision: 6517 http://sourceforge.net/p/jump-pilot/code/6517 Author: michaudm Date: 2020-09-22 14:56:54 + (Tue, 22 Sep 2020) Log Message: --- Do not use RasterPainter, inherit from GeoImage and use superclass paint method instead (avoid redundant and error-prone code)

Re: [JPP-Devel] SVN: [6507] core/trunk/src/org/openjump/core/rasterimage

2020-09-22 Thread edgar . soldin
On 22.09.2020 16:18, Giuseppe Aruta wrote: > I prefer to  comment out and build a new clean method up to you. as long as it is not active while we are trying to beat it into shape ;).. ede ___ Jump-pilot-devel mailing list

Re: [JPP-Devel] SVN: [6507] core/trunk/src/org/openjump/core/rasterimage

2020-09-22 Thread Giuseppe Aruta
Let us wait for Michael and Jukka's opinion about it. I am not sure but possibly it was request by one of the member of the list years ago to Alberto De Luca who implemented this part of the code. I prefer to comment out and build a new clean method Il giorno mar 22 set 2020 alle ore 15:29 ha

Re: [JPP-Devel] 6506 loading raster test

2020-09-22 Thread edgar . soldin
hey Roberto, the verbosity setting was just added to the start scripts, so it is not actually documented yet. looks like your on windows. on windows edit 'bin/oj_windows.bat' find rem -- set some default OJ options here (eg. -v debug), initialize empty -- rem -- run OJ with '--help' argument

[JPP-Devel] Fwd: [jira] [Commented] (IMAGING-267) Colorful rendering of b/w Monoband TIF

2020-09-22 Thread edgar . soldin
hey Gang, Gary at Apache-Commons-Imaging has some questions regarding a monoband TIF i provided. would one of you with a deeper knowledge of rasters (Peppe, Jukka, both?) answer him please in the ticket linked below (you need an account, so may have to register, but it's painless and fast).

Re: [JPP-Devel] SVN: [6507] core/trunk/src/org/openjump/core/rasterimage

2020-09-22 Thread edgar . soldin
On 9/22/2020 13:49, Giuseppe Aruta wrote: +       private static ImageAndMetadata readImage(File tiffFile, int overviewIndex, int indexStart, Point originalSize, +           Resolution originalCellSize, Envelope wholeImageEnvelope, Envelope viewportEnvelope, double noDataValue, +           

[JPP-Devel] SVN: [6516] core/trunk/src/org/openjump/core/rasterimage/TiffUtilsV2.java

2020-09-22 Thread jump-pilot-svn--- via Jump-pilot-devel
Revision: 6516 http://sourceforge.net/p/jump-pilot/code/6516 Author: ma15569 Date: 2020-09-22 12:06:16 + (Tue, 22 Sep 2020) Log Message: --- corrected typo Modified Paths: -- core/trunk/src/org/openjump/core/rasterimage/TiffUtilsV2.java Modified:

[JPP-Devel] SVN: [6515] core/trunk/src/org/openjump/core/rasterimage/TiffUtilsV2.java

2020-09-22 Thread jump-pilot-svn--- via Jump-pilot-devel
Revision: 6515 http://sourceforge.net/p/jump-pilot/code/6515 Author: ma15569 Date: 2020-09-22 12:04:10 + (Tue, 22 Sep 2020) Log Message: --- Added comments to Javadoc Modified Paths: -- core/trunk/src/org/openjump/core/rasterimage/TiffUtilsV2.java

Re: [JPP-Devel] SVN: [6507] core/trunk/src/org/openjump/core/rasterimage

2020-09-22 Thread Giuseppe Aruta
*we already have support for reading GeoReferencedRaster.parseGDALM**etaData(URI uri) (seems format agnostic too). but that is depending on GDAL installed, while the implementaion in TiffUtils.calculateStats() seems be plain java utilizing some apache commons imaging code but is limited to TIFF

Re: [JPP-Devel] SVN: [6507] core/trunk/src/org/openjump/core/rasterimage

2020-09-22 Thread Giuseppe Aruta
> + private static ImageAndMetadata readImage(File tiffFile, int overviewIndex, int indexStart, Point originalSize, > + Resolution originalCellSize, Envelope wholeImageEnvelope, Envelope viewportEnvelope, double noDataValue, > + Stats stats) throws IOException,

[JPP-Devel] SVN: [6514] core/trunk/src/org/openjump/sigle/utilities/geom/ FeatureCollectionUtil.java

2020-09-22 Thread jump-pilot-svn--- via Jump-pilot-devel
Revision: 6514 http://sourceforge.net/p/jump-pilot/code/6514 Author: edso Date: 2020-09-22 11:30:56 + (Tue, 22 Sep 2020) Log Message: --- reformatted from mixed space/tabs to spaces only/tabwidth 2 spaces Modified Paths: --

Re: [JPP-Devel] SVN: [6513] core/trunk/src/org/openjump/sigle/utilities/geom/ FeatureCollectionUtil.java

2020-09-22 Thread Giuseppe Aruta
OK 2020-09-22 13:28 GMT+02:00, edgar.sol...@web.de : > Peppe, > > just rephrased/formatted/typofixed some more. can you check that it > describes what is done? ..thx ede > > On 9/22/2020 13:26, jump-pilot-svn--- via Jump-pilot-devel wrote: >> Revision: 6513 >>

Re: [JPP-Devel] SVN: [6513] core/trunk/src/org/openjump/sigle/utilities/geom/ FeatureCollectionUtil.java

2020-09-22 Thread edgar . soldin
Peppe, just rephrased/formatted/typofixed some more. can you check that it describes what is done? ..thx ede On 9/22/2020 13:26, jump-pilot-svn--- via Jump-pilot-devel wrote: Revision: 6513 http://sourceforge.net/p/jump-pilot/code/6513 Author: edso Date: 2020-09-22 11:26:31

[JPP-Devel] SVN: [6513] core/trunk/src/org/openjump/sigle/utilities/geom/ FeatureCollectionUtil.java

2020-09-22 Thread jump-pilot-svn--- via Jump-pilot-devel
Revision: 6513 http://sourceforge.net/p/jump-pilot/code/6513 Author: edso Date: 2020-09-22 11:26:31 + (Tue, 22 Sep 2020) Log Message: --- some rephrasing/formatting Modified Paths: --

Re: [JPP-Devel] SVN: [6508] core/trunk/src/org/openjump/sigle/utilities/geom/ FeatureCollectionUtil.java

2020-09-22 Thread Giuseppe Aruta
com.vividsolutions.jump.util.CollectionUtil seemed to me too generic to add these method. The only class I found that could have been used was Sigle one Il giorno mar 22 set 2020 alle ore 13:17 ha scritto: > any specific reason why you added it to the class in the sigle package? > ..ede > > On

Re: [JPP-Devel] SVN: [6508] core/trunk/src/org/openjump/sigle/utilities/geom/ FeatureCollectionUtil.java

2020-09-22 Thread edgar . soldin
any specific reason why you added it to the class in the sigle package? ..ede On 9/22/2020 12:25, Giuseppe Aruta wrote: Done Il giorno mar 22 set 2020 alle ore 12:06 mailto:edgar.sol...@web.de>> ha scritto: Peppe, some comments inline below ..ede On 9/22/2020 11:30, jump-pilot-svn---

Re: [JPP-Devel] SVN: [6507] core/trunk/src/org/openjump/core/rasterimage

2020-09-22 Thread edgar . soldin
we already have support for reading GeoReferencedRaster.parseGDALMetaData(URI uri) (seems format agnostic too). but that is depending on GDAL installed, while the implementaion in TiffUtils.calculateStats() seems be plain java utilizing some apache commons imaging code but is limited to TIFF

[JPP-Devel] New tool to rasterize vectors

2020-09-22 Thread Giuseppe Aruta
Hi all, Roberto Rossi and I made a revision on Rasterize vector layer tools in OpenJUMP. This functionality is quite essential in raster analysis as it allows to transfer info in a raster to reuse in so-called Raster algebra to get new information. Generally, in a raster analysis, the number of

Re: [JPP-Devel] SVN: [6507] core/trunk/src/org/openjump/core/rasterimage

2020-09-22 Thread Giuseppe Aruta
I will make those changes. Statistics are calculated in order to reuse on raster analysis (sextante). It is also saved into a special .aux.xml sidecar file. At this moment there is no need to implement GeoReferencedRaster with Statistic read as it is uìused only by Sextante. Il giorno mar 22 set

Re: [JPP-Devel] SVN: [6508] core/trunk/src/org/openjump/sigle/utilities/geom/ FeatureCollectionUtil.java

2020-09-22 Thread Giuseppe Aruta
Done Il giorno mar 22 set 2020 alle ore 12:06 ha scritto: > Peppe, some comments inline below ..ede > > On 9/22/2020 11:30, jump-pilot-svn--- via Jump-pilot-devel wrote: > > Revision: 6508 > >http://sourceforge.net/p/jump-pilot/code/6508 > > Author: ma15569 > > Date:

[JPP-Devel] SVN: [6512] core/trunk/src/org/openjump/sigle/utilities/geom/ FeatureCollectionUtil.java

2020-09-22 Thread jump-pilot-svn--- via Jump-pilot-devel
Revision: 6512 http://sourceforge.net/p/jump-pilot/code/6512 Author: ma15569 Date: 2020-09-22 10:25:35 + (Tue, 22 Sep 2020) Log Message: --- Javadoc Modified Paths: -- core/trunk/src/org/openjump/sigle/utilities/geom/FeatureCollectionUtil.java

Re: [JPP-Devel] SVN: [6508] core/trunk/src/org/openjump/sigle/utilities/geom/ FeatureCollectionUtil.java

2020-09-22 Thread edgar . soldin
Peppe, some comments inline below ..ede On 9/22/2020 11:30, jump-pilot-svn--- via Jump-pilot-devel wrote: Revision: 6508 http://sourceforge.net/p/jump-pilot/code/6508 Author: ma15569 Date: 2020-09-22 09:30:06 + (Tue, 22 Sep 2020) Log Message: --- added two method to

[JPP-Devel] SVN: [6511] core/trunk/src/org/openjump/core/ui/plugin/tools/generate/ RasterizePlugIn.java

2020-09-22 Thread jump-pilot-svn--- via Jump-pilot-devel
Revision: 6511 http://sourceforge.net/p/jump-pilot/code/6511 Author: ma15569 Date: 2020-09-22 10:04:12 + (Tue, 22 Sep 2020) Log Message: --- Added Rasterize vector plugin Added Paths: ---

Re: [JPP-Devel] SVN: [6507] core/trunk/src/org/openjump/core/rasterimage

2020-09-22 Thread edgar . soldin
hey Peppe, nice try, but no dice. the reason i created an explicit TiffUtilsV2 was to make sure it contains no reference to RasterImageIO or TiffTags anymore. the idea is to wrap GeoReferencedRaster functionality to reuse. GeoReferencedRaster includes all functionality for retrieving an Envelope

[JPP-Devel] SVN: [6510] core/trunk/src/com/vividsolutions/jump/workbench/ui/images/ rasterize.png

2020-09-22 Thread jump-pilot-svn--- via Jump-pilot-devel
Revision: 6510 http://sourceforge.net/p/jump-pilot/code/6510 Author: ma15569 Date: 2020-09-22 09:54:15 + (Tue, 22 Sep 2020) Log Message: --- Add icon for rasterize plugin Added Paths: ---

[JPP-Devel] SVN: [6509] core/trunk/src/org/openjump/core/rasterimage/algorithms/ RasterizeAlgorithm.java

2020-09-22 Thread jump-pilot-svn--- via Jump-pilot-devel
Revision: 6509 http://sourceforge.net/p/jump-pilot/code/6509 Author: ma15569 Date: 2020-09-22 09:39:49 + (Tue, 22 Sep 2020) Log Message: --- Added two methods (from Sextante and from AdbToolbox) to rasterize a vector layer. Those methods are modified in order to speed

[JPP-Devel] SVN: [6508] core/trunk/src/org/openjump/sigle/utilities/geom/ FeatureCollectionUtil.java

2020-09-22 Thread jump-pilot-svn--- via Jump-pilot-devel
Revision: 6508 http://sourceforge.net/p/jump-pilot/code/6508 Author: ma15569 Date: 2020-09-22 09:30:06 + (Tue, 22 Sep 2020) Log Message: --- added two method to valid and to union by attribute a FeatureCollection Modified Paths: --

[JPP-Devel] SVN: [6507] core/trunk/src/org/openjump/core/rasterimage

2020-09-22 Thread jump-pilot-svn--- via Jump-pilot-devel
Revision: 6507 http://sourceforge.net/p/jump-pilot/code/6507 Author: ma15569 Date: 2020-09-22 09:26:19 + (Tue, 22 Sep 2020) Log Message: --- Ported functionality from TiffUtils to TiffUtilsV2. Make TiffUtils deprecated Modified Paths: --