Re: [JPP-Devel] System.out in code

2010-09-10 Thread Sunburned Surveyor
Thanks for the feedback Michael. Landon 2010/9/7 Michaël Michaud : >  Hi, > > Of course, I agree with Martin's solution to report bad features in a > dedicated layer. > > Ede also reminded us about the HTMLFrame, which may not be well suited > to report geometry problems, but which is the way to

Re: [JPP-Devel] System.out in code

2010-09-07 Thread Michaël Michaud
Hi, Of course, I agree with Martin's solution to report bad features in a dedicated layer. Ede also reminded us about the HTMLFrame, which may not be well suited to report geometry problems, but which is the way to go for other information messages directed to the user (ex. statistics, expla

Re: [JPP-Devel] System.out in code

2010-09-07 Thread Sunburned Surveyor
OK. Thanks Martin. The only question I had about this method was the possiblity of a "corrupt feature". It the plug-in is processing a layer with a corrupt feature, trying to add it to another layer could throw an exception, which is what I am trying to avoid. I suppose all the features the plug-i

Re: [JPP-Devel] System.out in code

2010-09-07 Thread Martin Davis
Landon, My 2c worth on this is that you should write the problem features to a new layer. I used that approach quite a bit in JCS development, and it worked well. With features in a layer it makes them easy to visualize, and the user can use all the tools already in OJ to examine and/or fix

Re: [JPP-Devel] System.out in code

2010-09-07 Thread Michaël Michaud
Hi, > Stefan, >> ... I have used Log4j before, >> and it seemed a little complicated. > I find the log4j.properties variant complicated as well. But the > log4j.xml [1] configuration variant I find fairly straight forward [2]. > I can include/exclude log messages from particular java packages an

Re: [JPP-Devel] System.out in code

2010-09-07 Thread edgar . soldin
Hey Landon, as far as I remember (from the hello world plugin) there is a console built in OJ on which you can output text. Maybe this would be another convenient way to tell the user. .. ede On 07.09.2010 21:29, Sunburned Surveyor wrote: > Kevin, > > Thanks for the clarification. I agree that

Re: [JPP-Devel] System.out in code

2010-09-07 Thread Sunburned Surveyor
Kevin, Thanks for the clarification. I agree that since the project is already has Log4J as a dependency, we should use it to replace the System.out statements in the core. I was thinking about plug-in developers as well. I'm working on the Union By Attribute plug-in. I'm tweaking it to report an

Re: [JPP-Devel] System.out in code

2010-09-07 Thread Kevin Neufeld
Hi Landon, I'm not sure I understand your question, sorry. I'm not suggesting to expose any method to access logging functionality. I hope this makes this more clear: What I'm suggesting is that the 330 calls to System.out currently in src get cleaned up, replaced with appropriate log4j call

Re: [JPP-Devel] System.out in code

2010-09-07 Thread Sunburned Surveyor
I'll have to take a look at log4J again. Did you imagine exposing a method to access the logging functionality through the plug-in context, or through some other mechanism? The Sunburned Surveyor On Tue, Sep 7, 2010 at 8:29 AM, Kevin Neufeld wrote: >  On 9/7/2010 7:38 AM, Sunburned Surveyor wrot

Re: [JPP-Devel] System.out in code

2010-09-07 Thread Kevin Neufeld
On 9/7/2010 7:38 AM, Sunburned Surveyor wrote: > Stefan, > > ... I have used Log4j before, > and it seemed a little complicated. I find the log4j.properties variant complicated as well. But the log4j.xml [1] configuration variant I find fairly straight forward [2]. I can include/exclude log

Re: [JPP-Devel] System.out in code

2010-09-07 Thread Sunburned Surveyor
Stefan, Do you have a problem with letting Kevin apply his patches to the ImageFactory classes? Would it be possible to set-up a simple log-to-file mechanism that could be accessed from the plug-in context? I have used Log4j before, and it seemed a little complicated. I wonder if just having the

Re: [JPP-Devel] System.out in code

2010-08-30 Thread Stefan Steiniger
Hei, > Here are a couple of questions: > > (1) Are the calls to System.out in plug-ins or the core? was the core > (2) Does the information sent to System.out need to be reported to the > user, and if not, what is the purpose of the logging? was needed because I wanted to see if the image drive

Re: [JPP-Devel] System.out in code

2010-08-30 Thread Sunburned Surveyor
I agree that calls to System.out are not the best thing. Did we decide that log4J is the best way to handle error messages? Here are a couple of questions: (1) Are the calls to System.out in plug-ins or the core? (2) Does the information sent to System.out need to be reported to the user, and if

[JPP-Devel] System.out in code

2010-08-27 Thread Kevin Neufeld
My I suggest that System.out lines be replaced with appropriate log4j statements in OpenJUMP? One of the purposes/advantages of using log4j is that I can filter output generated by other people's plugins that don't pertain to my own development. Attached is a couple of example patches that