https://bugs.kde.org/show_bug.cgi?id=444883
Christoph Cullmann changed:
What|Removed |Added
Latest Commit|https://invent.kde.org/fram |https://invent.kde.org/fram
https://bugs.kde.org/show_bug.cgi?id=444883
Christoph Cullmann changed:
What|Removed |Added
Latest Commit||https://invent.kde.org/fram
https://bugs.kde.org/show_bug.cgi?id=444883
--- Comment #27 from Bug Janitor Service ---
A possibly relevant merge request was started @
https://invent.kde.org/frameworks/ktexteditor/-/merge_requests/241
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.kde.org/show_bug.cgi?id=444883
Sven Brauch changed:
What|Removed |Added
CC||mattia.basag...@gmail.com
--- Comment #26 from
https://bugs.kde.org/show_bug.cgi?id=444883
Bug Janitor Service changed:
What|Removed |Added
Status|CONFIRMED |ASSIGNED
--- Comment #25 from Bug
https://bugs.kde.org/show_bug.cgi?id=444883
--- Comment #24 from Sven Brauch ---
That sounds pragmatic. Thank you very much!
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.kde.org/show_bug.cgi?id=444883
--- Comment #23 from Waqar Ahmed ---
Anyways, The query on every character has broken UI so no point in making it
work via hacks either.
Will make a MR to revert the hack + introduce the change to honor "minimum word
length for completion". The
https://bugs.kde.org/show_bug.cgi?id=444883
--- Comment #22 from Sven Brauch ---
I mean, in the KDevelop case, there's nothing better to be done. It won't
profit from re-computing the list after typing a few characters, it has no
useful additional information over what it had in the beginning --
https://bugs.kde.org/show_bug.cgi?id=444883
--- Comment #21 from Waqar Ahmed ---
> Do the LSP servers cut off the completion list after N items because it gets
too long (performance-wise) otherwise
Every lsp is different, but I think that's what clangd does... It's up to the
server to
https://bugs.kde.org/show_bug.cgi?id=444883
--- Comment #20 from Sven Brauch ---
Why is this happening, though? Do the LSP servers cut off the completion list
after N items because it gets too long (performance-wise) otherwise?
But yes, this seems to be the obvious difference to the KDevelop
https://bugs.kde.org/show_bug.cgi?id=444883
--- Comment #19 from Waqar Ahmed ---
I have been thinking about this for a while and might have a solution.
We are limited by LSP(s), and also because how we are doing things(in Kate).
One major problem on Kate's side is that we start completing after
https://bugs.kde.org/show_bug.cgi?id=444883
--- Comment #18 from Sven Brauch ---
Ah. I didn't understand that either, but trusted the people who had used it
with the LSP stuff to have a valid reason for this behaviour.
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.kde.org/show_bug.cgi?id=444883
--- Comment #17 from Milian Wolff ---
I was more talking about this part from waqar's earlier comment:
{quote}
The reason for the slowness is likely because very recently, a change was made
in ktexteditor that allows requerying the underlying
https://bugs.kde.org/show_bug.cgi?id=444883
--- Comment #16 from Sven Brauch ---
@milian: There are more results because the filter gets cleared, it just shows
all, not just matching after the bug triggers.
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.kde.org/show_bug.cgi?id=444883
Milian Wolff changed:
What|Removed |Added
CC||m...@milianw.de
--
You are receiving this mail
https://bugs.kde.org/show_bug.cgi?id=444883
--- Comment #15 from Milian Wolff ---
I don't quite understand why there are _more_ results after typing more? if at
all, it should reduce the result set. Is clangd different in that regard?
I'm also going to look into this issue a bit, as it has such
https://bugs.kde.org/show_bug.cgi?id=444883
--- Comment #14 from Sven Brauch ---
That might make sense, yes. I don't think any of the KDevelop sources profit
from getting a larger part of the current word; they are designed to just
provide all possible items and then filter.
--
You are
https://bugs.kde.org/show_bug.cgi?id=444883
--- Comment #13 from Waqar Ahmed ---
Will try. Don't have a kdevelop build close by atm so might take a while.
The problematic change is this I think
https://invent.kde.org/frameworks/ktexteditor/-/merge_requests/183
Rethinking about this, I think
https://bugs.kde.org/show_bug.cgi?id=444883
--- Comment #12 from Sven Brauch ---
You can try in KDevelop, it's really easy to reproduce there. Just start typing
something that will open a completion (e.g. member completion on anything), and
keep adding characters. At some point it will flicker
https://bugs.kde.org/show_bug.cgi?id=444883
--- Comment #11 from Kåre Särs ---
@waqar
Now that I want to reproduce it I have a hard time doing so... The last time I
remember it happening I have a vague memory that the LSP plugin was
re-highlighting at the same time as I was typing and selecting
https://bugs.kde.org/show_bug.cgi?id=444883
--- Comment #10 from Waqar Ahmed ---
@sars
What completion backends do you have enabled? I am trying to reproduce this
(lsp-clangd, tags, document) but haven't been able to.
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.kde.org/show_bug.cgi?id=444883
Kåre Särs changed:
What|Removed |Added
CC||kare.s...@iki.fi
--- Comment #9 from Kåre Särs
https://bugs.kde.org/show_bug.cgi?id=444883
--- Comment #8 from Christoph Cullmann ---
Interesting enough, the completion works well for me for the clangd LSP stuff.
And that seemed always comparable slow.
It would be really good to know how we screw up like that for KDevelop :/
--
You are
https://bugs.kde.org/show_bug.cgi?id=444883
--- Comment #7 from Waqar Ahmed ---
@Sven
> Additionally, cancellation doesn't work properly; e.g. typing
> "foo();"...
That might be a bug that was there all the time but only became an issue due to
the slowness.
Anyways, the relevant change
https://bugs.kde.org/show_bug.cgi?id=444883
--- Comment #6 from Sven Brauch ---
Hi, sorry, I didn't want to play a blame game, I am thankful for Waqar's work
on this topic and I do feel somewhat responsible for the issue at hand because
I know I should have taken the time to test those changes.
https://bugs.kde.org/show_bug.cgi?id=444883
Christoph Cullmann changed:
What|Removed |Added
CC||cullm...@kde.org
--- Comment #5 from
https://bugs.kde.org/show_bug.cgi?id=444883
--- Comment #4 from Sven Brauch ---
Hi Waqar,
thanks for having a look at this. The problem is not (only) that it is slow in
KDevelop, the problem is also that it now misbehaves. Try it out with a
somewhat large project; the re-querying will somehow
https://bugs.kde.org/show_bug.cgi?id=444883
Waqar Ahmed changed:
What|Removed |Added
CC||waqar@gmail.com
--- Comment #3 from Waqar
https://bugs.kde.org/show_bug.cgi?id=444883
Sven Brauch changed:
What|Removed |Added
CC||m...@svenbrauch.de
Product|kdevelop
29 matches
Mail list logo
