Re: Review Request 108770: Fix double-free in ~KCompositeJobPrivate

2013-02-06 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108770/#review26717 --- I'd add the setParent(0), document it, and then this looks ok

Re: Review Request 108770: Fix double-free in ~KCompositeJobPrivate

2013-02-06 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108770/#review26748 --- kdecore/tests/kcompositejobtest.cpp

Review Request 108802: Switch Delete/Move To Trash actions when Shift key is pressed in Konqueror context menu

2013-02-06 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108802/ --- Review request for KDE Base Apps, David Faure and Frank Reininghaus.

Re: kwalletmanager ui refactor

2013-02-06 Thread Aurélien Gâteau
On 05.02.2013 21:34, Valentin Rusu wrote: On Tuesday 05 February 2013 10:49:55 Aurélien Gâteau wrote: 2. The disconnect button should be kept, in my opinnion. Here is a screen capture with the disconnect menu for my main wallet: http://imgur.com/JG6rr8b And here is another one showing

Review Request 108808: Do not reset opacity if call for GetWindowProperty fails

2013-02-06 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108808/ --- Review request for kdelibs and kwin. Description --- Do not reset

Re: Review Request 108808: Do not reset opacity if call for GetWindowProperty fails

2013-02-06 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108808/#review26756 --- Works fine here. - Aurélien Gâteau On Feb. 6, 2013, 3:38

Re: Review Request 108770: Fix double-free in ~KCompositeJobPrivate

2013-02-06 Thread Kevin Funk
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108770/ --- (Updated Feb. 6, 2013, 11:33 a.m.) Review request for kdelibs and Kevin

Re: Review Request 108770: Fix double-free in ~KCompositeJobPrivate

2013-02-06 Thread Kevin Funk
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108770/ --- (Updated Feb. 6, 2013, 1:15 p.m.) Review request for kdelibs and Kevin

Re: Review Request 107678: Keep clickmessage text visible when empty and focused

2013-02-06 Thread Aurélien Gâteau
On Dec. 12, 2012, 7:43 p.m., Laszlo Papp wrote: It did not get a ship it back then for the plasma components, but I would not like to block the rediscussion, just saying what happened earlier. :-) https://git.reviewboard.kde.org/r/104895/ David Edmundson wrote: One of the key

Re: Review Request 108808: Do not reset opacity if call for GetWindowProperty fails

2013-02-06 Thread Thomas Lübking
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108808/#review26760 --- If the property does not exist or is of wrong type or contains

Re: Review Request 108727: ktimezoned: Watch /etc/localtime if it doesn't exist yet.

2013-02-06 Thread Kevin Kofler
On Feb. 5, 2013, 8:27 p.m., David Faure wrote: Looks ok to me, although I don't really know this code. So, should I wait for David Jarvie or some other person who feels familiar with this code to give it a go, or do you think I can commit this right now? - Kevin

Login for bug reporting

2013-02-06 Thread Kevin Krammer
Hi folks, at FOSDEM I was approached by a person who asked me to relay his dissatisfaction with the requirement of having a KDE Bugzilla account to report crashes via the KDE crash handler dialog. The issue in his case was kind of made worse by having this obstacle appear too late, i.e. after

Re: Login for bug reporting

2013-02-06 Thread Christoph Cullmann
Hi, actually, if he has taken the obstacles of installing tens of megabytes of stuff, what was the problem with creating an account? Was it some problem with privacy, that he doesn't want his mail to register there (than he won't give his mail address as feedback point, anyway) or was the

Re: Review Request 108770: Fix double-free in ~KCompositeJobPrivate

2013-02-06 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108770/#review26776 --- Ship it! Ship It! - Kevin Ottens On Feb. 6, 2013, 1:15

Re: Login for bug reporting

2013-02-06 Thread Alex Fiestas
On Wednesday 06 February 2013 20:36:33 Christoph Cullmann wrote: Hi, actually, if he has taken the obstacles of installing tens of megabytes of stuff, what was the problem with creating an account? Haven't it ever happened to you that you are buying something on the interwebs or checking

Re: Login for bug reporting

2013-02-06 Thread Anders Lund
Onsdag den 6. februar 2013 21:52:53 skrev Alex Fiestas: On Wednesday 06 February 2013 20:36:33 Christoph Cullmann wrote: Hi, actually, if he has taken the obstacles of installing tens of megabytes of stuff, what was the problem with creating an account? Haven't it ever happened to you

Re: Login for bug reporting

2013-02-06 Thread Nicolás Alvarez
2013/2/6, Kevin Krammer kram...@kde.org: Hi folks, at FOSDEM I was approached by a person who asked me to relay his dissatisfaction with the requirement of having a KDE Bugzilla account to report crashes via the KDE crash handler dialog. The issue in his case was kind of made worse by

Re: Login for bug reporting

2013-02-06 Thread Frank Reininghaus
Am 06.02.2013 18:57 schrieb Kevin Krammer: Hi folks, at FOSDEM I was approached by a person who asked me to relay his dissatisfaction with the requirement of having a KDE Bugzilla account to report crashes via the KDE crash handler dialog. The issue in his case was kind of made worse by

Re: Login for bug reporting

2013-02-06 Thread Myriam Schweingruber
Hi all, On Wed, Feb 6, 2013 at 10:20 PM, Frank Reininghaus frank7...@googlemail.com wrote: Am 06.02.2013 18:57 schrieb Kevin Krammer: Hi folks, at FOSDEM I was approached by a person who asked me to relay his dissatisfaction with the requirement of having a KDE Bugzilla account to report

Re: Login for bug reporting

2013-02-06 Thread Martin Graesslin
On Wednesday 06 February 2013 22:41:25 Myriam Schweingruber wrote: Hi all, On Wed, Feb 6, 2013 at 10:20 PM, Frank Reininghaus frank7...@googlemail.com wrote: Am 06.02.2013 18:57 schrieb Kevin Krammer: Hi folks, at FOSDEM I was approached by a person who asked me to relay his

Re: kwalletmanager ui refactor

2013-02-06 Thread Valentin Rusu
On Wednesday 06 February 2013 14:28:17 Aurélien Gâteau wrote: On 05.02.2013 21:34, Valentin Rusu wrote: I assumed the Disconnect button listed applications authorized to access the wallet. The Authorized applications tab was thus another way to show its content. But it seems I got it

Re: Review Request 108711: kcmdatetimehelper: Hardcode PATH because $PATH is empty here.

2013-02-06 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108711/#review26785 --- This review has been submitted with commit

Re: Login for bug reporting

2013-02-06 Thread Alex Fiestas
On Wednesday 06 February 2013 23:00:53 Martin Graesslin wrote: On Wednesday 06 February 2013 22:41:25 Myriam Schweingruber wrote: Hi all, On Wed, Feb 6, 2013 at 10:20 PM, Frank Reininghaus frank7...@googlemail.com wrote: Am 06.02.2013 18:57 schrieb Kevin Krammer: Hi folks,

Re: Review Request 108711: kcmdatetimehelper: Hardcode PATH because $PATH is empty here.

2013-02-06 Thread Kevin Kofler
On Feb. 6, 2013, 10:26 p.m., Commit Hook wrote: This review has been submitted with commit c517bbc175a3fbb09f13a8468a6987fdbc547d23 by Kevin Kofler to branch KDE/4.10. … and merged to master with merge commit e99a0e5b1223b7a673b0bc29c280d962c6e8dfb6. - Kevin

Re: Review Request 108057: Add some new User Agent files for spoofing browser identities in konqueror, rekonq

2013-02-06 Thread Albert Astals Cid
On Jan. 7, 2013, 12:33 p.m., Frank Reininghaus wrote: Please run git pull --rebase before pushing any non-merge commits to prevent polluting the logs with commits like http://quickgit.kde.org/?p=kde-baseapps.gita=commith=94b3817429b470eed5687922661832b260bcc06c Thanks. Has this

Re: Review Request 108770: Fix double-free in ~KCompositeJobPrivate

2013-02-06 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108770/#review26820 --- This review has been submitted with commit