Re: Review Request 112009: Update thumbnail support for Microsoft Windows executables and images, and use WINAPI when on Windows.

2013-08-13 Thread Pali Rohár
On Aug. 13, 2013, 12:53 a.m., Patrick Spendrin wrote: Patrick Spendrin wrote: In general of course: thanks for your review request, one of the small nice overdue features! How does this work on Linux, e.g. do the changes to the .desktop file affect Linux here? In desktop

Re: Review Request 112009: Update thumbnail support for Microsoft Windows executables and images, and use WINAPI when on Windows.

2013-08-13 Thread Patrick Spendrin
On Aug. 12, 2013, 10:53 p.m., Patrick Spendrin wrote: Patrick Spendrin wrote: In general of course: thanks for your review request, one of the small nice overdue features! How does this work on Linux, e.g. do the changes to the .desktop file affect Linux here? Pali Rohár

Re: Review Request 112009: Update thumbnail support for Microsoft Windows executables and images, and use WINAPI when on Windows.

2013-08-13 Thread Pali Rohár
On Aug. 13, 2013, 12:53 a.m., Patrick Spendrin wrote: Patrick Spendrin wrote: In general of course: thanks for your review request, one of the small nice overdue features! How does this work on Linux, e.g. do the changes to the .desktop file affect Linux here? Pali Rohár

Re: Review Request 112009: Update thumbnail support for Microsoft Windows executables and images, and use WINAPI when on Windows.

2013-08-13 Thread Patrick Spendrin
On Aug. 12, 2013, 10:53 p.m., Patrick Spendrin wrote: Patrick Spendrin wrote: In general of course: thanks for your review request, one of the small nice overdue features! How does this work on Linux, e.g. do the changes to the .desktop file affect Linux here? Pali Rohár

Re: Review Request 111992: Activity bar in QML.

2013-08-13 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111992/#review37672 --- Looks good to me. Wait for Marco or Sebas to tell you to Ship

Re: Review Request 111992: Activity bar in QML.

2013-08-13 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111992/#review37675 --- It's looking good already, a few stylistic remarks inline, and

Re: Review Request 111992: Activity bar in QML.

2013-08-13 Thread Bhushan Shah
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111992/ --- (Updated Aug. 13, 2013, 12:37 p.m.) Review request for kde-workspace and

Re: Review Request 111992: Activity bar in QML.

2013-08-13 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111992/#review37698 ---

Re: Review Request 111992: Activity bar in QML.

2013-08-13 Thread Bhushan Shah
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111992/ --- (Updated Aug. 13, 2013, 3:16 p.m.) Review request for kde-workspace and

Re: Review Request 111992: Activity bar in QML.

2013-08-13 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111992/#review37700 --- Ship it! Ship It! - Sebastian Kügler On Aug. 13, 2013,

Re: Review Request 111992: Activity bar in QML.

2013-08-13 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111992/ --- (Updated Aug. 13, 2013, 3:31 p.m.) Status -- This change has been

Re: Review Request 111953: KLinkItemSelectionModel: synchronize currentIndex

2013-08-13 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111953/ --- (Updated Aug. 13, 2013, 5:57 p.m.) Review request for kdelibs and Stephen

Re: Review Request 111953: KLinkItemSelectionModel: synchronize currentIndex

2013-08-13 Thread Aurélien Gâteau
On Aug. 9, 2013, 2:59 p.m., Stephen Kelly wrote: Have you tried kdepim applications with this patch too? Many of them use this class. I just grepped in kdepim, it seems only kmail-mobile makes use of it. It looks like it's working, but I am not familiar with this application so I am

Re: Review Request 111953: KLinkItemSelectionModel: synchronize currentIndex

2013-08-13 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111953/ --- (Updated Aug. 13, 2013, 5:59 p.m.) Review request for kdelibs, Michael

Re: Review Request 111953: KLinkItemSelectionModel: synchronize currentIndex

2013-08-13 Thread Michael Bohlender
On Aug. 9, 2013, 12:59 p.m., Stephen Kelly wrote: Have you tried kdepim applications with this patch too? Many of them use this class. Aurélien Gâteau wrote: I just grepped in kdepim, it seems only kmail-mobile makes use of it. It looks like it's working, but I am not familiar

Re: Review Request 111952: Properly detect xz and lzma compressed archives in Get New Stuff

2013-08-13 Thread Gabi Sarkis
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111952/#review37713 --- Ship it! Ship It! - Gabi Sarkis On Aug. 8, 2013, 7:12

Re: Review Request 111952: Properly detect xz and lzma compressed archives in Get New Stuff

2013-08-13 Thread Gabi Sarkis
On Aug. 13, 2013, 6:06 p.m., Gabi Sarkis wrote: Ship It! Sorry about that. How do I go about Shipping it? Thanks - Gabi --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 111952: Properly detect xz and lzma compressed archives in Get New Stuff

2013-08-13 Thread Yuri Chornoivan
On Aug. 13, 2013, 6:06 p.m., Gabi Sarkis wrote: Ship It! Gabi Sarkis wrote: Sorry about that. How do I go about Shipping it? Thanks Just commit it into the repo or ask someone to do it for you. Commit message should contain a separate string REVIEW: 111952 to close this

Re: Review Request 111952: Properly detect xz and lzma compressed archives in Get New Stuff

2013-08-13 Thread Jeremy Paul Whiting
On Aug. 13, 2013, 12:06 p.m., Gabi Sarkis wrote: Ship It! Gabi Sarkis wrote: Sorry about that. How do I go about Shipping it? Thanks Yuri Chornoivan wrote: Just commit it into the repo or ask someone to do it for you. Commit message should contain a

Re: Review Request 111952: Properly detect xz and lzma compressed archives in Get New Stuff

2013-08-13 Thread Gabi Sarkis
On Aug. 13, 2013, 6:06 p.m., Gabi Sarkis wrote: Ship It! Gabi Sarkis wrote: Sorry about that. How do I go about Shipping it? Thanks Yuri Chornoivan wrote: Just commit it into the repo or ask someone to do it for you. Commit message should contain a

Re: Review Request 111952: Properly detect xz and lzma compressed archives in Get New Stuff

2013-08-13 Thread Jeremy Paul Whiting
On Aug. 13, 2013, 12:06 p.m., Gabi Sarkis wrote: Ship It! Gabi Sarkis wrote: Sorry about that. How do I go about Shipping it? Thanks Yuri Chornoivan wrote: Just commit it into the repo or ask someone to do it for you. Commit message should contain a

Review Request 112068: KCharSelect: Show LaTeX commands for Unicode characters

2013-08-13 Thread Thomas Fischer
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112068/ --- Review request for kdelibs and KDE Utils. Description --- Attached

Re: Review Request 112068: KCharSelect: Show LaTeX commands for Unicode characters

2013-08-13 Thread Thiago Macieira
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112068/#review37740 --- Don't put QChar in your structures. That makes them non-POD.