Re: Review Request 119497: Report crashes of KDE apps in Apple OS X (1) (fix kcrash, kinit)

2014-07-28 Thread David Faure
> On July 28, 2014, 12:57 a.m., Ian Wadham wrote: > > kinit/kinit.cpp, line 119 > > > > > > The real issue is on this line. I do not know how "MAC_DISPLAY" got > > into the act, but clearly it has not been teste

Re: Review Request 119497: Report crashes of KDE apps in Apple OS X (1) (fix kcrash, kinit)

2014-07-28 Thread RJVB Bertin
> On July 27, 2014, 1:32 p.m., Thomas Lübking wrote: > > kinit/kinit.cpp, line 118 > > > > > > this looks fishy, because this should be related to the Window System, > > not the OS (ie. if you're running X11 on

Re: Review Request 119497: Report crashes of KDE apps in Apple OS X (1) (fix kcrash, kinit)

2014-07-28 Thread RJVB Bertin
> On July 28, 2014, 2:57 a.m., Ian Wadham wrote: > > kinit/kinit.cpp, line 119 > > > > > > The real issue is on this line. I do not know how "MAC_DISPLAY" got > > into the act, but clearly it has not been tested

Re: Review Request 119497: Report crashes of KDE apps in Apple OS X (1) (fix kcrash, kinit)

2014-07-28 Thread David Faure
> On July 28, 2014, 12:57 a.m., Ian Wadham wrote: > > kinit/kinit.cpp, line 119 > > > > > > The real issue is on this line. I do not know how "MAC_DISPLAY" got > > into the act, but clearly it has not been teste

Review Request 119512: Fix saving/loading of file dialog sizes

2014-07-28 Thread Lukáš Tinkl
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119512/ --- Review request for kdelibs, Aleix Pol Gonzalez and Martin Klapetek. Repos

Re: Review Request 119512: Fix saving/loading of file dialog sizes

2014-07-28 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119512/#review63309 --- +1, looks good to me - Martin Klapetek On July 28, 2014, 11

Re: Review Request 119512: Fix saving/loading of file dialog sizes

2014-07-28 Thread Thomas Lübking
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119512/#review63311 --- src/platformtheme/kdeplatformfiledialoghelper.h

Re: Review Request 119497: Report crashes of KDE apps in Apple OS X (1) (fix kcrash, kinit)

2014-07-28 Thread RJVB Bertin
> On July 28, 2014, 2:57 a.m., Ian Wadham wrote: > > kinit/kinit.cpp, line 119 > > > > > > The real issue is on this line. I do not know how "MAC_DISPLAY" got > > into the act, but clearly it has not been tested

Re: Review Request 119512: Fix saving/loading of file dialog sizes

2014-07-28 Thread Lukáš Tinkl
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119512/ --- (Updated July 28, 2014, 10:21 a.m.) Review request for KDE Frameworks, kd

Re: Review Request 119512: Fix saving/loading of file dialog sizes

2014-07-28 Thread Lukáš Tinkl
> On Čec. 28, 2014, 12:17 odp., Thomas Lübking wrote: > > src/platformtheme/kdeplatformfiledialoghelper.h, line 53 > > > > > > this will also hit when the window is shaded, minimized or moved to > > another virtu

Re: Review Request 119512: Fix saving/loading of file dialog sizes

2014-07-28 Thread Thomas Lübking
On Juli 28, 2014, 10:17 vorm., Lukáš Tinkl wrote: > > If the only issue is the open ::exec() TODO, you might "trick" it by > > calling ::winId(), then restore the size and ultimately ::exec() > > > > Otherwise you could open an own nested eventloop instead of relying on the > > dialogs exec, b

Re: Review Request 119512: Fix saving/loading of file dialog sizes

2014-07-28 Thread Martin Klapetek
On July 28, 2014, 12:17 p.m., Lukáš Tinkl wrote: > > If the only issue is the open ::exec() TODO, you might "trick" it by > > calling ::winId(), then restore the size and ultimately ::exec() > > > > Otherwise you could open an own nested eventloop instead of relying on the > > dialogs exec, bu

Re: Review Request 119512: Fix saving/loading of file dialog sizes

2014-07-28 Thread Lukáš Tinkl
> On Čec. 28, 2014, 12:17 odp., Thomas Lübking wrote: > > src/platformtheme/kdeplatformfiledialoghelper.h, line 53 > > > > > > this will also hit when the window is shaded, minimized or moved to > > another virtu

Re: Review Request 119025: Actually pass IBUS_DEFINITIONS when compiling ibus-panel

2014-07-28 Thread Raphael Kubo da Costa
On July 19, 2014, 12:17 a.m., Vadim Zhukov wrote: > > (As a general note, for build system related stuff like this you can also > > try including the "buildsystem" group, which can be more responsive at > > times) > > > > > The ibus-panel can't build on OpenBSD because some required definition