Re: Using Gerrit for code review in KDE

2014-09-14 Thread Jan Kundrát
On Saturday, 13 September 2014 20:40:27 CEST, Kevin Krammer wrote: As for submit, that IMHO should at least also be available to the review request owner. Does anyone see advantages of having submit restricted at all once the necessary approval has been achieved? I made a mistake when

Re: Gerrit available for trial

2014-09-12 Thread Jan Kundrát
Hi folks, we're trying to document how to work with Gerrit within KDE at [1]. If you can make that page better, please go ahead. With kind regards, Jan [1] https://techbase.kde.org/Development/Gerrit -- Trojitá, a fast Qt IMAP e-mail client -- http://trojita.flaska.net/

Re: Using Gerrit for code review in KDE

2014-09-09 Thread Jan Kundrát
Hi, we agreed on the Frameworks BoF that the following two repos are now using Gerrit for some initial testing: - kio - plasma-framework Some rudimentary instructions are at https://techbase.kde.org/Development/Gerrit , edits are welcome. If you would like to become a Gerrit admin, want to

Re: Using Gerrit for code review in KDE

2014-09-09 Thread Jan Kundrát
On Tuesday, 9 September 2014 17:39:54 CEST, Aaron J. Seigo wrote: Would it not make more sense to trial it using newer / smaller / unstable projects, as it is an experiment? Yes, which is why trojita.git was dogfooding Gerrit before I announced this. As it stands with plasma-framework in

Re: Using Gerrit for code review in KDE

2014-09-09 Thread Jan Kundrát
On Tuesday, 9 September 2014 20:02:55 CEST, Aaron J. Seigo wrote: That would honestly make more sense for Plasma imho, though it still would make sense to start small and consistent. A suggestion made by sysadmins was to start with just a couple of repos to prevent further confusion and to

Using Gerrit for code review in KDE

2014-09-07 Thread Jan Kundrát
Hi folks, as requested by Ben, I would like to accounce that Trojita (extragear/pim/trojita) is now using Gerrit [1] for patch review. The system is open for other KDE projects as well -- if you're interested, see [2] for further details, or come to my talk today at 14:00 in room #2 at the

Re: Using Gerrit for code review in KDE

2014-09-07 Thread Jan Kundrát
On Sunday, 7 September 2014 21:27:44 CEST, Eike Hein wrote: I'm curious however, what's the state of manifesto-compliance[1] for the Gerrit instance? Does KDE Sysadmin have admin access and the ability to get the data out if needed? This is a very good question. Right now, only I (and other

Re: Moving Baloo and Baloo-widgets into KDE SC

2013-12-27 Thread Jan Kundrát
On Friday, 27 December 2013 13:43:50 CEST, Albert Astals Cid wrote: kphotoalbum Unless I'm terribly mistaken, KPhotoAlbum uses just the stars widget. The actual rating is saved in its own DB. We do care about the backwards compatibility, though, which means that a released tarball needs to

Re: Review Request 114321: Fix timezone saving in System Settings - Date Time

2013-12-05 Thread Jan Kundrát
On Dec. 5, 2013, 11:52 p.m., Martin Klapetek wrote: Note that Debian-based systems actually do copy the file rather than symlink - main reason being that if you use a symlink and your /usr is mounted on a separate partition, anything that starts before /usr gets mounted will not have

Re: KMountPoint::probablySlow and cifs mount points

2013-11-25 Thread Jan Kundrát
On Tuesday, 26 November 2013 00:35:18 CEST, Alexander Neundorf wrote: Serious question: do systems, which run KDE4 and are connected to a 10 Mbps wired network exist ? One place I know used to use this as a crude form of traffic shaping just a couple years ago. The offices were provisioned

Re: QDialog on stack+exec and dbus quit crash is no more

2013-11-15 Thread Jan Kundrát
On Thursday, 14 November 2013 22:02:09 CEST, Michael Reeves wrote: That link is broken. Try this one -- it's from valgrind, not the gdb, but it points to the actual problem: http://kde.6490.n7.nabble.com/QDialog-on-stack-exec-and-dbus-quit-crash-is-no-more-tp1549181p1549244.html Cheers,

Re: QDialog on stack+exec and dbus quit crash is no more

2013-11-11 Thread Jan Kundrát
On Monday, 11 November 2013 19:17:22 CEST, Albert Astals Cid wrote: Not sure you're understanding what i say, we have an explicit check about QDialog on stack+exec that says it will crash if you dbus quit. We've chatted about this with Albert on IRC. My understanding of this is that there are

Re: Review Request 113355: Reduce UDSEntry memory usage with implicit sharing

2013-10-25 Thread Jan Kundrát
for the QVectorField. Saves some time when loading the UDSEntry, and reduces the memory usage further. It isn't clear to me how a call to QVector::reserve might reduce memory usage. - Jan Kundrát On Oct. 24, 2013, 10:34 p.m., Frank Reininghaus wrote

Re: Review Request 113355: Reduce UDSEntry memory usage with implicit sharing

2013-10-21 Thread Jan Kundrát
and the associated memory streaming benefits. The STL class has a lower overhead than an implicitly shared QVector (and you do not need implicit sharing of the actual entries, do you?). Anyway, the point is, if the number is small enough, the big-O notation does not necessarily matter. - Jan Kundrát

Re: Review Request 113355: Reduce UDSEntry memory usage with implicit sharing

2013-10-21 Thread Jan Kundrát
On Oct. 21, 2013, 4:26 p.m., Jan Kundrát wrote: Have you tried a naive implementation with a std::vectorstd::pairKey,Value? You say that a typical use case has eight entries; that's a very small number where a well-tuned vector could easily beat the O(1) of QHash or the O(log n

Re: Review Request 113162: fix invalid type conversion (char vs. const char)

2013-10-09 Thread Jan Kundrát
that the actual pointer itself is const, too. That said, in this particular case I would just use a hardcoded HOME in both getenv and setenv for simplicity, but I'm not a kdelibs developer. - Jan Kundrát On Oct. 7, 2013, 7:40 p.m., Jiří Pinkava wrote

Re: Review Request 113162: fix invalid type conversion (char vs. const char)

2013-10-09 Thread Jan Kundrát
On Oct. 9, 2013, 11:24 a.m., Jan Kundrát wrote: You can even make it a `const char * const` to communicate that the actual pointer itself is const, too. That said, in this particular case I would just use a hardcoded HOME in both getenv and setenv for simplicity, but I'm

Re: Review Request 109551: port KPtyProcess to QProcess

2013-03-18 Thread Jan Kundrát
/109551/#comment21974 Why are these commented out instead of being removed? - Jan Kundrát On March 17, 2013, 4:44 p.m., Martin Tobias Holmedahl Sandsmark wrote: --- This is an automatically generated e-mail. To reply, visit: http

Re: Login for bug reporting

2013-02-07 Thread Jan Kundrát
On Thursday, 7 February 2013 10:26:52 CEST, Anders Lund wrote: I'm already spending a lot of time marking reports as duplicate/invalid or telling people that reporting bugs for KDE 4.8 or earlier is not quite as useful as they think. Are most of these reports coming from DrKonqi? If so, have

Re: Moving Trojitá to extragear

2012-12-18 Thread Jan Kundrát
On Tuesday, 18 December 2012 16:15:15 CEST, David Faure wrote: It just means that l10n will have to run lconvert during make install, in order to install .qm files (compiled from .ts files), rather than .mo files, for these frameworks which use tr() and not i18n(). In Trojita, the lconvert

Re: Moving Trojitá to extragear

2012-12-13 Thread Jan Kundrát
On Thursday, 13 December 2012 18:52:51 CEST, David Faure wrote: If it handles this correctly (so that tr() works at runtime), this is good news then, it sounds like we can drop the weird QCoreApp::translate(, text) in KF5. I can confirm that lconvert from Qt 4.8.3 is enough to preserve the

Re: Moving Trojitá to extragear

2012-12-10 Thread Jan Kundrát
On Monday, 10 December 2012 11:16:40 CEST, Chusslove Illich wrote: The scripts Jan had to write are a temporary fix, due to Scripty machine having too old lconvert which produces broken POTs. Once lconvert is updated, no third-party scripts should be necessary. Chusslove's description is

Re: Moving Trojitá to extragear

2012-12-05 Thread Jan Kundrát
On Tuesday, 4 December 2012 13:03:57 CEST, Burkhard Lück wrote: Scripty does not like your message extraction, see ftp://l10n.kde.org/121204.trunk_l10n-kde4. Hi Burkhard, the latest log [1] looks fine to me. Could you please confirm that it is indeed OK now? With kind regards, Jan [1]

Re: Moving Trojitá to extragear

2012-12-04 Thread Jan Kundrát
On Tuesday, 4 December 2012 13:03:57 CEST, Burkhard Lück wrote: Scripty does not like your message extraction, see ftp://l10n.kde.org/121204.trunk_l10n-kde4. Using a simple $XGETTEXT_QT `find src/ -name \*.cpp` -o $podir/trojita_common.pot will avoid the duplicated messages make Scripty

Re: Moving Trojitá to extragear

2012-12-04 Thread Jan Kundrát
On Tuesday, 4 December 2012 14:32:20 CEST, Chusslove Illich wrote: Other than the difference in contexts, the POT file is actually invalid (due to duplication of messages, which must be unique by msgctxt+msgid). My gettext skills are very sub-par, I know just what I've read in the last two

Re: Moving Trojitá to extragear

2012-11-24 Thread Jan Kundrát
It took quite a few hours, but it looks like I've tamed the beast. I wanted to follow the way how Marble works, i.e. calling QObject::tr and converting between the .ts and .po files. This turned out to be a problem because QObject::tr expects the context to be a name of the class while the

Re: Moving Trojitá to extragear

2012-11-22 Thread Jan Kundrát
On Wednesday, 21 November 2012 20:53:14 CEST, Albert Astals Cid wrote: I.e. if you don't use i18n() or tr() + kdecore (and actually this one has a missing feature because someone in Qt decided to make a method not virtual) you can't get our .po/.mo system work-flow to work. Not having

Moving Trojitá to extragear

2012-11-21 Thread Jan Kundrát
Hi, thanks for your encouragement. Trojitá, a fast IMAP e-mail client (homepage [1], more in-depth look [2], the KDE project page [3]) has spent the last week or so under playground and was just moved to kdereview (thanks to sysadmins for their excellent turnaround time). I'd appreciate people

<    1   2