: https://git.reviewboard.kde.org/r/122653/diff/
Testing
---
dolphin remote:
-> no lock icon on smb:, mtp:, ... links
Thanks,
Stefan Brüns
://git.reviewboard.kde.org/r/122652/diff/
Testing
---
dolphin remote:
-> no lock icon on smb:, mtp:, ... links
Thanks,
Stefan Brüns
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122652/#review76619
---
Ping!
- Stefan Brüns
On Feb. 20, 2015, 9:28 p.m., Stefan
KF5
- Stefan
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122652/#review76626
-------
On Feb. 20, 2015, 9:28 p.m., Stefan Brüns
fixes a
> bug, it can go in.
> Of course it should be forward-ported to KIO Framework if it is still
> relevant there.
>
> Stefan Brüns wrote:
> So shall I commit this (and https://git.reviewboard.kde.org/r/122653/ as
> well)?
>
> AFAIK next Application
marked as submitted.
Review request for KDE Frameworks, kdelibs and David Faure.
Changes
---
Submitted with commit 6215e878706dc6e79d1b6ac5df33f5751d6c7ec0 by Stefan Brüns
to branch master.
Bugs: 339193
http://bugs.kde.org/show_bug.cgi?id=339193
Repository: kdelibs
Description
.
CCBUG: 339193
Diffs
-
kioslave/remote/remoteimpl.cpp 5d973c6c1b6c31b7f3107d0d15805ef04bfdd661
Diff: https://git.reviewboard.kde.org/r/122653/diff/
Testing
---
dolphin remote:
-> no lock icon on smb:, mtp:, ... links
Thanks,
Stefan Brüns
/backends/fstab/fstabstorageaccess.cpp 5482d48
Diff: https://git.reviewboard.kde.org/r/113587/diff/
Testing
---
Add "x-gvfs-name=Share%20on%20Laptop" to CIFS mount, open dolphin -> Name has
changed
Thanks,
Stefan Brüns
/112294/diff/
Testing
---
Single seat system, several multiseat systems
Thanks,
Stefan Brüns
On Aug. 27, 2013, 2:08 p.m., Stefan Brüns wrote:
> > looks fine to me, just that tiny minor nitpick on variable naming.
I assume this applies to systemd_monitor{,_fd} in dm.c as well. Will fix,
waiting a few days for more comments ...
-
d8dd6f3
kdm/backend/session.c 0e7901c
Diff: http://git.reviewboard.kde.org/r/112294/diff/
Testing
---
Single seat system, several multiseat systems
Thanks,
Stefan Brüns
/session.c 0e7901c
Diff: http://git.reviewboard.kde.org/r/112294/diff/
Testing
---
Single seat system, several multiseat systems
Thanks,
Stefan Brüns
generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112294/#review39302
---
On Sept. 2, 2013, 11:34 p.m., Stefan Brüns wrote:
>
> ---
> This is an automaticall
crash.
Possible fix for 320006
Diffs
-
kio/bookmarks/kbookmark.cc 8459a02
Diff: http://git.reviewboard.kde.org/r/113866/diff/
Testing
---
None
Thanks,
Stefan Brüns
QDomElement.
toElement will return NULL and accessing it will crash.
Possible fix for 320006
Diffs (updated)
-
kio/bookmarks/kbookmark.cc 8459a02
Diff: http://git.reviewboard.kde.org/r/113866/diff/
Testing
---
None
Thanks,
Stefan Brüns
viewboard.kde.org/r/113866/#review44510
---
On Dec. 16, 2013, 6:33 p.m., Stefan Brüns wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113866/
> ---
/kbookmarktest.cpp 5ab002b
Diff: http://git.reviewboard.kde.org/r/114506/diff/
Testing
---
Thanks,
Stefan Brüns
QDomElement.
toElement will return NULL and accessing it will crash.
Possible fix for 320006
Diffs
-
kio/bookmarks/kbookmark.cc 8459a02
Diff: https://git.reviewboard.kde.org/r/113866/diff/
Testing
---
None
Thanks,
Stefan Brüns
> On Sept. 3, 2013, 10:20 p.m., Oswald Buddenhagen wrote:
> > given that there is no intention to make further feature releases of the
> > kde workspace which will include kdm, i wonder why we'd go through the
> > (potentially tedious) process of upstreaming this no
/backend/server.c d8dd6f3
kdm/backend/session.c 0e7901c
Diff: https://git.reviewboard.kde.org/r/112294/diff/
Testing
---
Single seat system, several multiseat systems
Thanks,
Stefan Brüns
/backend/client.c 26bb0b4
kdm/backend/dm.h b2f8c61
kdm/backend/dm.c 77a2ef7
kdm/backend/server.c d8dd6f3
kdm/backend/session.c 0e7901c
Diff: https://git.reviewboard.kde.org/r/112294/diff/
Testing
---
Single seat system, several multiseat systems
Thanks,
Stefan Brüns
taking the "seat" into account, so the only
possibility to apply a specific config is to use "layout".
- Stefan
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.or
-------
On March 29, 2014, 5:38 p.m., Stefan Brüns wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/112294/
> --
> On March 28, 2014, 10:59 a.m., Oswald Buddenhagen wrote:
> > kdm/backend/server.c, line 79
> > <https://git.reviewboard.kde.org/r/112294/diff/2/?file=186613#file186613line79>
> >
> > why the redundant supply of the seat as a layout?
>
> Stefan
/server.c d8dd6f3
kdm/backend/session.c 0e7901c
Diff: https://git.reviewboard.kde.org/r/112294/diff/
Testing
---
Single seat system, several multiseat systems
Thanks,
Stefan Brüns
ly generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/112294/#review54418
---
On April 6, 2014, 8:16 p.m., Stefan Brüns wrote:
>
> ---
> This is an auto
/plasma-wallpaper-image.desktop 6484545
Diff: https://git.reviewboard.kde.org/r/112294/diff/
Testing
---
Single seat system, several multiseat systems
Thanks,
Stefan Brüns
nable to me. why are you re-defining the display to
> > be permanent? when the seat goes away, kdm won't know what to do with it.
>
> Stefan Brüns wrote:
> When a seat goes away, rStopDisplay(d, DS_RESERVE) is called - maybe a
> "d->displayType = dLoca
38a8c70
kdm/config.def 751c0ed
kdm/kfrontend/kdm_config.c 368c8d1
Diff: https://git.reviewboard.kde.org/r/112294/diff/
Testing
---
Single seat system, several multiseat systems
Thanks,
Stefan Brüns
; > be permanent? when the seat goes away, kdm won't know what to do with it.
>
> Stefan Brüns wrote:
> When a seat goes away, rStopDisplay(d, DS_RESERVE) is called - maybe a
> "d->displayType = dLocal | dReserve" is missing for these cases.
> But as
---------
On May 18, 2014, 7:44 p.m., Stefan Brüns wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/112294/
>
On May 24, 2014, 11:46 a.m., Stefan Brüns wrote:
> > regarding DynamicDisplays and your magic backwards compat handling ... i
> > think the seat-encoded config stuff i insisted on makes that redundant,
> > after all. suppose we do it like that:
> >
> > Static
://git.reviewboard.kde.org/r/112294/diff/
Testing
---
Single seat system, several multiseat systems
Thanks,
Stefan Brüns
g/r/112294/#comment40630>
This is actually needed to supply the seat to logind session registration
via pam_systemd.
This could be placed earlier, but I chose this place because it is near the
old CK session registration, and it only has to be before pam_open_session(...)
- Stefan Brün
esource.c
<https://git.reviewboard.kde.org/r/112294/#comment40688>
They are:
http://domainkeys.sourceforge.net/underscore.html
kdm/backend/resource.c
<https://git.reviewboard.kde.org/r/112294/#comment40689>
see above
kdm/backend/session.c
<https://git.reviewboard.kde.org/
cular pam module needs this setting, it should be done
> > much earlier than here, and the next line would be pointless (we use
> > pam_getenvlist). that would also mean that pam is a hard dependency, which
> > should be expressed by the configure code and appropriate ifdefs.
>
> On May 26, 2014, 2:50 p.m., Stefan Brüns wrote:
> > kdm/backend/dm.c, line 1430
> > <https://git.reviewboard.kde.org/r/112294/diff/7/?file=274916#file274916line1430>
> >
> > Hm, I prefer this notation, in particular as this is the same as for
> &
:
https://git.reviewboard.kde.org/r/112294/#review58394
-------
On May 26, 2014, 12:06 a.m., Stefan Brüns wrote:
>
> ---
> This is an automatically generated e-m
sounds
strange IMHO
- Stefan
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/112294/#review58442
---
On May 26, 2014, 12:06
/resource.c 38a8c70
kdm/backend/server.c d8dd6f3
kdm/config-kdm.h.cmake 3e8912d
kdm/kfrontend/kdm_config.c 368c8d1
Diff: https://git.reviewboard.kde.org/r/112294/diff/
Testing
---
Single seat system, several multiseat systems
Thanks,
Stefan Brüns
automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/112294/#review58845
-------
On May 29, 2014, 7:03 p.m., Stefan Brüns wrote:
>
> ---
> This
> On May 26, 2014, 8:32 a.m., Oswald Buddenhagen wrote:
> > kdm/backend/dm.c, line 1436
> > <https://git.reviewboard.kde.org/r/112294/diff/7/?file=274916#file274916line1436>
> >
> > "no matching unused"
>
> Stefan Brüns wrote:
> "
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/112294/#review58845
-------
On May 29, 2014, 7:03 p.m., Stefan Brüns wrote:
>
> --
t; > seat changed? i don't think you are handling the transition (which would
> > involve the 'raiser' state, iirc), so the display would come up again only
> > after the next hup or replug.
> >
> > it's probably not worth it to handle the com
solid/solid/backends/fstab/fstabdevice.h bac409e
Diff: https://git.reviewboard.kde.org/r/113587/diff/
Testing
---
Add "x-gvfs-name=Share%20on%20Laptop" to CIFS mount, open dolphin -> Name has
changed
Thanks,
Stefan Brüns
tbcache file is created when the toolbar bookmarks are the
full bookmarks, i.e. no entries/folders with toolbar attribute.
Diffs
-
kio/bookmarks/kbookmarkmanager.cc d8a9cb7
Diff: http://git.reviewboard.kde.org/r/106563/diff/
Testing
---
Thanks,
Stefan Brüns
r/106563/#review19523
---
On Sept. 25, 2012, 11:01 a.m., Stefan Brüns wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106563/
> -
---
Thanks,
Stefan Brüns
/kbookmarkmanager.cc d8a9cb7
Diff: http://git.reviewboard.kde.org/r/106563/diff/
Testing
---
Thanks,
Stefan Brüns
49 matches
Mail list logo
