Re: KDE file dialog

2016-03-06 Thread Thomas Lübking
On Sonntag, 6. März 2016 11:34:32 CEST, Martin Graesslin wrote: I don't know how often we have heard over the last decade that Plasma's look and feel is terribly because of fonts. I'd have assumed that'd be because of the freetype rasterizers being, errr ummm... shit (almost as shit as c

Re: Policy regarding QtWebKit and QtScript

2016-03-05 Thread Thomas Lübking
On Samstag, 5. März 2016 08:09:22 CEST, Thomas Friedrichsmeier wrote: QtWebEngine can _only_ be compiled using (free as in beer) MSVC 2013. In particular, MinGW is explicitly _not_ supported. Out of pure curiosity: got details on this? MSVC 2013 hardly supersets the GNU toolchain and the code c

Re: KDE file dialog

2016-03-02 Thread Thomas Lübking
On Mittwoch, 2. März 2016 12:51:28 CEST, Martin Graesslin wrote: On Wednesday, March 2, 2016 12:09:17 PM CET Sven Brauch wrote: On 03/02/2016 11:56 AM, Thomas Lübking wrote: ... Just saying: I wrote that SNI integration and I have never heard of that problem before Sven mentioned it here

Re: KDE file dialog

2016-03-02 Thread Thomas Lübking
On Mittwoch, 2. März 2016 11:19:42 CEST, Martin Graesslin wrote: On Wednesday, March 2, 2016 11:08:30 AM CET Mark Gaiser wrote: On Wed, Mar 2, 2016 at 9:42 AM, Martin Graesslin wrote: ... What is that "kf5" plugin you talk of? The origin of this thread was that the default Qt file dialog su

Re: KDE file dialog

2016-03-01 Thread Thomas Lübking
On Dienstag, 1. März 2016 19:42:58 CEST, Sven Brauch wrote: Otherwise I agree with your reasoning. I'm just not sure what we can effectively do about it. Build option to build the kde/plasma QPA into a strict "KF5" (tier 1) QPA? Forking sucks terribly and a tier 1 QPA might be interesting for

Re: mailing list archive gone ?

2016-02-27 Thread Thomas Lübking
On Samstag, 27. Februar 2016 16:09:00 CEST, Martin Koller wrote: Hi, https://mail.kde.org/pipermail/kde-core-devel/ shows only 3 mails from the year 2000. Where are the other archives gone ? No idea, but it's still on https://marc.info/?l=kde-core-devel&r=1&w=2 Cheers, Thomas

Re: Review Request 127102: Use fixed width for digital clock applet

2016-02-19 Thread Thomas Lübking
console.log("hour: " + (i*10 + i) + ", minute: " + (i*10 + i) + " -> " > + str); > } > > qml: hour: 0, minute: 0 -> 00:00 > qml: hour: 11, minute: 11 -> 11:11 > qml: hour: 22, minute: 22 -> 22:22 > qml

Re: Review Request 127102: Use fixed width for digital clock applet

2016-02-18 Thread Thomas Lübking
> On Feb. 18, 2016, 12:05 a.m., David Edmundson wrote: > > applets/digital-clock/package/contents/ui/DigitalClock.qml, line 555 > > > > > > rather than looping, can we use FontMetric's maximumCharacterWidth > >

Re: Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

2016-01-24 Thread Thomas Lübking
could just adapt this in the future to use that. > - Clean out the tooltip. Remove the parts on right-clicking and what-if. > Users will visit help if they need it, and right-clicking is common > functionality. Instead of adding mroe to make thing visible, we remove noise. > - Le

Re: Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

2016-01-23 Thread Thomas Lübking
> On Jan. 23, 2016, 5:31 p.m., Gregor Mi wrote: > > > If someone has changed the shortcut, they should know what shortcut they > > > set it to, right? So having the tooltip just say "To kill a specific > > > window, press the "Kill Window" shortcut (Ctrl-Alt-Esc by default)" > > > should do th

Re: Policy regarding QtWebKit and QtScript

2015-12-25 Thread Thomas Lübking
On Freitag, 25. Dezember 2015 12:42:26 CEST, Milian Wolff wrote: Sorry, but how is "it takes long to compile" and argument for or against a piece of software if there is no feature equivalent alternative that takes less time to compile? How demanding is it exactly? Considering Gentoo users, i

Re: Review Request 126308: KPushButton: respect SH_DialogButtonBox_ButtonsHaveIcons, also when drawing

2015-12-24 Thread Thomas Lübking
y in case Thomas > wants to pursue his view on fixing what there is to fix. > > You are right though, it's a workaround for KPushButton which doesn't > depend on fixing QPushButton. And whether or not QPushButton requires fixing > is apparently the big question

Re: Review Request 126308: KPushButton: respect SH_DialogButtonBox_ButtonsHaveIcons, also when drawing

2015-12-23 Thread Thomas Lübking
y in case Thomas > wants to pursue his view on fixing what there is to fix. > > You are right though, it's a workaround for KPushButton which doesn't > depend on fixing QPushButton. And whether or not QPushButton requires fixing > is apparently the big question

Re: Review Request 126308: KPushButton: respect SH_DialogButtonBox_ButtonsHaveIcons, also when drawing

2015-12-23 Thread Thomas Lübking
y in case Thomas > wants to pursue his view on fixing what there is to fix. > > You are right though, it's a workaround for KPushButton which doesn't > depend on fixing QPushButton. And whether or not QPushButton requires fixing > is apparently the big question

Re: Policy regarding QtWebKit and QtScript

2015-12-22 Thread Thomas Lübking
On Dienstag, 22. Dezember 2015 19:44:21 CEST, Aleix Pol wrote: compiling for some time, but that's not a reason to rely on it on our side. Sure, getting rid of it is mandatory. What worries me is that this *break* happens in a *minor* Qt release. Should generally not happen. Period. It shoul

Re: Policy regarding QtWebKit and QtScript

2015-12-22 Thread Thomas Lübking
On Dienstag, 22. Dezember 2015 19:05:23 CEST, Ivan Čukić wrote: So, using Kross would mean implementing the kjs backend for it that we had in 4.x times? Isn't the designated successor for QtScript QJSEngine (I even assumed there should be some porting tools?) About QtWebkit - what exactly do

Re: Review Request 126308: KPushButton: respect SH_DialogButtonBox_ButtonsHaveIcons, also when drawing

2015-12-21 Thread Thomas Lübking
y in case Thomas > wants to pursue his view on fixing what there is to fix. > > You are right though, it's a workaround for KPushButton which doesn't > depend on fixing QPushButton. And whether or not QPushButton requires fixing > is apparently the big question

Re: Review Request 126308: KPushButton: respect SH_DialogButtonBox_ButtonsHaveIcons, also when drawing

2015-12-21 Thread Thomas Lübking
y in case Thomas > wants to pursue his view on fixing what there is to fix. > > You are right though, it's a workaround for KPushButton which doesn't > depend on fixing QPushButton. And whether or not QPushButton requires fixing > is apparently the big question

Re: Review Request 126308: KPushButton: respect SH_DialogButtonBox_ButtonsHaveIcons, also when drawing

2015-12-21 Thread Thomas Lübking
y in case Thomas > wants to pursue his view on fixing what there is to fix. > > You are right though, it's a workaround for KPushButton which doesn't > depend on fixing QPushButton. And whether or not QPushButton requires fixing > is apparently the big question

Re: Review Request 126308: KPushButton: respect SH_DialogButtonBox_ButtonsHaveIcons, also when drawing

2015-12-21 Thread Thomas Lübking
> On Dec. 19, 2015, 10:23 a.m., David Faure wrote: > > src/kdeui/kpushbutton.cpp, line 256 > > > > > > This patch looks wrong because KPushButton can be used outside of > > "dialog button boxes", while the style

Re: Why is C90 enforced in KDE?

2015-12-20 Thread Thomas Lübking
On Sonntag, 20. Dezember 2015 04:21:29 CEST, Kevin Kofler wrote: The kdewin team should just point people to a flex.exe that produces files that work with the bitrotten C compiler included with Visual C++. So we only need somebody who forks the hardly maintained flex/yacc tools for windows...

Re: Why is C90 enforced in KDE?

2015-12-20 Thread Thomas Lübking
On Sonntag, 20. Dezember 2015 04:08:20 CEST, Kevin Kofler wrote: - pipe flex/yacc results through c++ rather than the C compiler won't do much good, because the C++ compiler will not necessarily grok any other C99isms in the code. This only really helps for "//" comments. Afaiu flex/yacc ca

Re: Review Request 126308: KPushButton: respect SH_DialogButtonBox_ButtonsHaveIcons, also when drawing

2015-12-17 Thread Thomas Lübking
> On Dec. 11, 2015, 1:55 p.m., Thomas Lübking wrote: > > src/kdeui/kdialogbuttonbox.cpp, line 39 > > <https://git.reviewboard.kde.org/r/126308/diff/5/?file=421661#file421661line39> > > > > QDialogButtonBox::addButton should do correctly anyway, so please don&

Re: Review Request 126308: KPushButton: respect SH_DialogButtonBox_ButtonsHaveIcons, also when drawing

2015-12-13 Thread Thomas Lübking
> On Dec. 10, 2015, 10:11 p.m., Thomas Lübking wrote: > > 1. What tells you that this is a dialog buttonbox pushbutton? > > 2. What happens if the button has no text? > > > > > > The bug is in QDialogButtonBox (or rather the K variant, > > QDialogBu

Re: Review Request 126308: KPushButton: respect SH_DialogButtonBox_ButtonsHaveIcons, also when drawing

2015-12-13 Thread Thomas Lübking
> On Dec. 11, 2015, 1:55 p.m., Thomas Lübking wrote: > > src/kdeui/kdialogbuttonbox.cpp, line 39 > > <https://git.reviewboard.kde.org/r/126308/diff/5/?file=421661#file421661line39> > > > > QDialogButtonBox::addButton should do correctly anyway, so please don&

Re: Review Request 126308: KPushButton: respect SH_DialogButtonBox_ButtonsHaveIcons, also when drawing

2015-12-11 Thread Thomas Lübking
> On Dec. 10, 2015, 10:11 p.m., Thomas Lübking wrote: > > 1. What tells you that this is a dialog buttonbox pushbutton? > > 2. What happens if the button has no text? > > > > > > The bug is in QDialogButtonBox (or rather the K variant, > > QDialogBu

Re: Review Request 126308: KPushButton: respect SH_DialogButtonBox_ButtonsHaveIcons, also when drawing

2015-12-11 Thread Thomas Lübking
> On Dec. 10, 2015, 10:11 p.m., Thomas Lübking wrote: > > 1. What tells you that this is a dialog buttonbox pushbutton? > > 2. What happens if the button has no text? > > > > > > The bug is in QDialogButtonBox (or rather the K variant, > > QDialogBu

Re: Review Request 126308: KPushButton: respect SH_DialogButtonBox_ButtonsHaveIcons, also when drawing

2015-12-11 Thread Thomas Lübking
board.kde.org/r/126308/#comment6> still wrong and again, please don't mess with the icon size - you're just tempting DIV zero segfaults. - Thomas Lübking On Dec. 11, 2015, 12:59 p.m., René J.V. Bertin wrote: > > --

Re: Review Request 126308: KPushButton: respect SH_DialogButtonBox_ButtonsHaveIcons, also when drawing

2015-12-11 Thread Thomas Lübking
> On Dec. 10, 2015, 10:11 p.m., Thomas Lübking wrote: > > 1. What tells you that this is a dialog buttonbox pushbutton? > > 2. What happens if the button has no text? > > > > > > The bug is in QDialogButtonBox (or rather the K variant, > > QDialogBu

Re: Review Request 126308: KPushButton: respect SH_DialogButtonBox_ButtonsHaveIcons, also when drawing

2015-12-11 Thread Thomas Lübking
> On Dec. 10, 2015, 10:11 p.m., Thomas Lübking wrote: > > 1. What tells you that this is a dialog buttonbox pushbutton? > > 2. What happens if the button has no text? > > > > > > The bug is in QDialogButtonBox (or rather the K variant, > > QDialogBu

Re: Review Request 126308: KPushButton: respect SH_DialogButtonBox_ButtonsHaveIcons, also when drawing

2015-12-11 Thread Thomas Lübking
> On Dec. 10, 2015, 10:11 p.m., Thomas Lübking wrote: > > 1. What tells you that this is a dialog buttonbox pushbutton? > > 2. What happens if the button has no text? > > > > > > The bug is in QDialogButtonBox (or rather the K variant, > > QDialogBu

Re: Review Request 126308: KPushButton: respect SH_DialogButtonBox_ButtonsHaveIcons, also when drawing

2015-12-10 Thread Thomas Lübking
> On Dec. 10, 2015, 10:11 p.m., Thomas Lübking wrote: > > 1. What tells you that this is a dialog buttonbox pushbutton? > > 2. What happens if the button has no text? > > > > > > The bug is in QDialogButtonBox (or rather the K variant, > > QDialogBu

Re: Review Request 126308: KPushButton: respect SH_DialogButtonBox_ButtonsHaveIcons, also when drawing

2015-12-10 Thread Thomas Lübking
precated KPushButton doesn't really fix anything. We'll face the mix we had, just that users of QPushButton were far less prone to pass them an icon in pre-KF5 times. Please also attach Hugo Pereira Da Costa. - Thomas Lüb

Re: Remove legacy session management support?

2015-12-10 Thread Thomas Lübking
On Donnerstag, 26. November 2015 23:20:24 CEST, Andreas Hartmetz wrote: So, does anybody know of any relevant application that supports only legacy session management? The scheme seems to be called WM_COMMAND / WM_SAVE_YOURSELF for lack of a better name. Google suggests Tcl/Tk might still be

Re: Change to Mail Infrastructure - SPF and DKIM verification will now be enforced

2015-12-08 Thread Thomas Lübking
> It is irrelevant what our personal preference is. The fact of life is that there *are* mailing lists out there which perform these modifications, and these MLs won't change their config despite changes on our side. If we start rejecting these e-mails, well, our addresses will be unsubscribed from

Re: Why is C90 enforced in KDE?

2015-12-07 Thread Thomas Lübking
On Montag, 7. Dezember 2015 17:22:47 CEST, Boudewijn Rempt wrote: There are two sides, of course: if making it easier for a distribution to package KDE software makes it harder for an application to be packaged for another distribution, where do we go? What's most important? Just adding a depend

Re: Why is C90 enforced in KDE?

2015-12-07 Thread Thomas Lübking
On Montag, 7. Dezember 2015 15:54:40 CEST, Luca Beltrame wrote: Given you've said this multiple times, with my packager hat on I'll just mention this: just don't make it harder *for us* to work just because you're targeting another platform. I actually don't think this related at all. Compil

Re: Generated files in version control (was: Re: Why is C90 enforced in KDE?)

2015-12-07 Thread Thomas Lübking
On Montag, 7. Dezember 2015 01:08:31 CEST, Nicolás Alvarez wrote: It will look better to stick my app logo into the real-artist-designed piece-of-paper-with-shadow than to draw an icon from scratch... Afaiu, one should have asked the oxygen team to avoid this kind of patched icons. I don't

Re: Why is C90 enforced in KDE?

2015-12-07 Thread Thomas Lübking
On Montag, 7. Dezember 2015 03:14:05 CEST, Kevin Kofler wrote: not surprised that they are now using C99 comments (which ARE compliant to the current C standard, and have been for 16 years (!)). Sure, but since it seems it's the only C99 feature used(?, stdint is more a library thing, at least

Re: Why is C90 enforced in KDE?

2015-12-06 Thread Thomas Lübking
On Sonntag, 6. Dezember 2015 17:41:07 CEST, Nicolás Alvarez wrote: Then we ignore warnings about // comments and pay attention to others Wtf does flex/yacc produce incompliant comments? Seriously, COMMENTS! That's a convenience thing. int foo = bar; // bar defined in wherever is simpler than

Re: Generated files in version control (was: Re: Why is C90 enforced in KDE?)

2015-12-06 Thread Thomas Lübking
On Sonntag, 6. Dezember 2015 22:23:01 CEST, Nicolás Alvarez wrote: I am aware that Nuno manually chose rendering engine and scaling method for every individual Oxygen icon based on seeing which one gave (subjectively) better results. That is not documented anywhere Seriously? I mean, are you s

Re: Why is C90 enforced in KDE?

2015-12-06 Thread Thomas Lübking
On Sonntag, 6. Dezember 2015 16:08:04 CEST, Antonio Rojas wrote: C90. Adding -std=c99 to the CFLAGS at compile time doesn't have any effect, since it is overriden by kdelibs (and by extra-cmake-modules in KF5). What is the reason for this? I guess because of poor compiler support. One needs MS

Re: Causes of session management problems in Plasma 5

2015-11-25 Thread Thomas Lübking
On Donnerstag, 26. November 2015 00:37:35 CEST, Andreas Hartmetz wrote: First, by copy I mean a temporary copy that is never merged back into the main list, it's kept around only to know which processes have already agreed to have their session saved and submitted the corresponding data.

Re: Causes of session management problems in Plasma 5

2015-11-25 Thread Thomas Lübking
On Donnerstag, 26. November 2015 05:19:34 CEST, Nicolás Alvarez wrote: What do you mean with "konsole asks"? Things like "You have multiple tabs open, are you sure you want to quit?" and "You have unsaved changes"? Yes. If so, the scenario you describe is bad regardless of session restorati

Re: Causes of session management problems in Plasma 5

2015-11-25 Thread Thomas Lübking
On Dienstag, 24. November 2015 02:02:46 CEST, Andreas Hartmetz wrote: - The session manager not "locking down" or better copying the list of clients *while* logging out. This would arguably only help buggy clients, but may still be a net positive. It would falsely restore clients that do n

Re: Review Request 125910: Fix for Bug 334525 - Gwenview hangs when switching from normal to full screen mode

2015-11-01 Thread Thomas Lübking
> On Nov. 1, 2015, 2:18 nachm., Christoph Feck wrote: > > kdeui/notifications/knotificationrestrictions.cpp, line 67 > > > > > > I am not sure all compilers support initialization of (non-static) > > members insi

Re: Review Request 125613: Race condition and error notification loss in ListJob

2015-10-28 Thread Thomas Lübking
gt; > ../../include/QtCore/../../../../frameworks/qt5/qtbase/src/corelib/kernel/qcoreapplication.h:230 > > #42 QApplicationPrivate::sendMouseEvent (receiver=receiver@entry=0x8c1fc0, > > event=event@entry=0x7fffd4e0, alienWidget=alienWidget@entry=0x8c1fc0, &

Re: Review Request 125613: Race condition and error notification loss in ListJob

2015-10-28 Thread Thomas Lübking
> On Okt. 26, 2015, 5:27 nachm., Aleix Pol Gonzalez wrote: > > This patch introduced a crash here. Could you maybe look into it? Here's a > > backtrace. > > > > It happens on some (not all) programs when the open dialog is displayed. I > > can reproduce it with ksnapshot and kdevelop, but not

Re: Review Request 125613: Race condition and error notification loss in ListJob

2015-10-12 Thread Thomas Lübking
> On Okt. 12, 2015, 7:29 nachm., Albert Astals Cid wrote: > > Do you think you can add an unittest for this or is it hard to recreate the > > conditionts? > > Alberto Jiménez Ruiz wrote: > It happens to very few people. Most developers tried to reproduce bug > 333436 and bug 162211(I belie

Re: Problem investigating a heap-use-after-free in kwindowsystem

2015-10-02 Thread Thomas Lübking
get_stringlist_reply creates the byte arrays QByteArray::fromRawData(), nukes the reply and returns the list which now contains freed memory. This also was just a problem in Baloo; smells like the ::fromRawArray "constructor" could use a free function pointer to be called when the bytearray i

Re: State of Audio CD support in KDE

2015-10-01 Thread Thomas Lübking
On Freitag, 2. Oktober 2015 01:16:08 CEST, Boudhayan Gupta wrote: On 2 October 2015 at 01:19, Albert Astals Cid wrote: I'd miss the ripping habilities of kio-audiocd personally, maybe we can merge it with kaudiocreator and make them share code? Yeah, let's make KAudioCreator do the conversio

Re: Spectacle moved to KDE Graphics, future of KSnapshot?

2015-09-27 Thread Thomas Lübking
On Sonntag, 27. September 2015 20:32:28 CEST, Ivan Čukić wrote: Hi, Which cmd line options are available in KSnapshot and not in Spectacle? Is it only --freeregion and --child? -m, --currentCapture the current monitor -a, --activewindow Capture the active window -u, --wind

Re: Spectacle moved to KDE Graphics, future of KSnapshot?

2015-09-27 Thread Thomas Lübking
On Samstag, 26. September 2015 11:05:25 CEST, Boudhayan Gupta wrote: On 26 September 2015 at 06:55, Eike Hein wrote: I'm more concerned about the migration path from KSnapshot to Spectacle. Can we make a hard decision to abandon KSnapshot on X11 +1 and have Spectacle install a ksnapshot sym

Re: Naming scheme for Qt5/KF5-based libraries outside of KF5

2015-09-27 Thread Thomas Lübking
On Sonntag, 27. September 2015 16:48:03 CEST, Friedrich W. H. Kossebau wrote: Yes, I still think so: libQt* is left to Qt libs, and IMHO in the same way should libKF5* be only used with real KF5 libs, if that prefix should have a consistent semantic, i.e. should say they are part of the KDE Fr

Re: Spectacle moved to KDE Graphics, future of KSnapshot?

2015-09-25 Thread Thomas Lübking
On Freitag, 25. September 2015 16:54:44 CEST, Boudhayan Gupta wrote: I don't know about khotkeys, but are QDbus* classes not an option? Seems better than depending on qdbus (or any other command for that matter). I'll have to patch KHotkeys rather than write a simple config file then. KHotke

Re: KTabWidget vs QTabWidget

2015-09-19 Thread Thomas Lübking
Disclaimer: I've no knowledge about the made decision process/intentions. On Samstag, 19. September 2015 02:46:24 CEST, Jeremy Whiting wrote: KTabWidget documentation on api.kde.org it still says that KTabWidget is preferred over QTabWidget [1]. Wild guess: the class was moved, but nobody took

Re: Review Request 125297: okular: Change Shell::openDocument parameter from QUrl to QString so it can be called via DBus

2015-09-17 Thread Thomas Lübking
> On Sept. 17, 2015, 9:28 nachm., Thomas Lübking wrote: > > a) fix the test? > > b) the patch first limits to a Url subset and then guesses what it was ... > > if that is the "fix" it smell like okular or the test scenario cannot deal > > with remote files

Re: Review Request 125297: okular: Change Shell::openDocument parameter from QUrl to QString so it can be called via DBus

2015-09-17 Thread Thomas Lübking
line 179) <https://git.reviewboard.kde.org/r/125297/#comment59145> QUrl(url, QUrl::StrictMode) - Thomas Lübking On Sept. 17, 2015, 9:06 nachm., Jeremy Whiting wrote: > > --- > This is an automatically generated e

Re: KSyCoca, Thread safety, and Cache invalidation

2015-09-13 Thread Thomas Lübking
On Sonntag, 13. September 2015 23:04:01 CEST, David Faure wrote: It's really a problem that QDateTime isn't threadsafe, it's really unexpected for application programmers. The particular conversion happens because /you/ followed Thiago's advise to use UTC, but QFileInfo does not - what causes

Re: AW: folder icons where should they be set

2015-09-11 Thread Thomas Lübking
On Freitag, 11. September 2015 09:00:57 CEST, Kai Uwe Broulik wrote: Hi, Aren't these XDG standard dirs you can even configure? Just show the folder at XDG images with a pictures folder icon and so on. If you use different folders without telling the system, it's your own fault ;) What fa

Re: folder icons where should they be set

2015-09-11 Thread Thomas Lübking
On Freitag, 11. September 2015 09:37:44 CEST, Harald Sitter wrote: http://freedesktop.org/wiki/Software/xdg-user-dirs/ "Interesting" concept where the system keeps creating directories on the user on login an requires him to vim ~/.config/userdirs.dirs to stop that... That's of course "suppor

Re: folder icons where should they be set

2015-09-10 Thread Thomas Lübking
On Freitag, 11. September 2015 00:16:35 CEST, Harald Sitter wrote: being my confused self I am rather clueless as to where the correct place to implement this is, so any help on this would be very welcome. http://www.linfo.org/etc_skel.html Guessing the "correct" folder icon by the directory

Re: Review Request 125043: expose the WheelMouseZooms global setting through the input ("mouse") KCM

2015-09-04 Thread Thomas Lübking
> On Sept. 4, 2015, 1:38 nachm., Martin Gräßlin wrote: > > You are aware that this is a dead repo and that this is a new feature for a > > repository that has been feature frozen for years? > > > > Given that I think this should not and never be merged. If you want to keep > > the repo going f

Re: Review Request 125043: expose the WheelMouseZooms global setting through the input ("mouse") KCM

2015-09-04 Thread Thomas Lübking
nce to a user there's hardly a difference between QTextBrowser and KTextBrowser) kcontrol/input/mouse.cpp (line 184) <https://git.reviewboard.kde.org/r/125043/#comment58701> read this line closely, then fix it ;-P - Thomas Lübking On Sept. 4, 2015, 11:51 vorm., René

Re: Review Request 120319: Make Kate mousewheel zoom feature respect the corresponding global setting (KGlobalSettings::wheelMouseZooms())

2015-09-03 Thread Thomas Lübking
> On Sept. 23, 2014, 3:01 nachm., Thomas Lübking wrote: > > Qt cannot "distiguish" because there's nothing to distinguish - the driver > > generates synthetic wheel event for the inertia. > > You can btw. turn that off. > > > > Seems an issue w

Re: Review Request 120319: Make Kate mousewheel zoom feature respect the corresponding global setting (KGlobalSettings::wheelMouseZooms())

2015-09-03 Thread Thomas Lübking
> On Sept. 23, 2014, 3:01 nachm., Thomas Lübking wrote: > > Qt cannot "distiguish" because there's nothing to distinguish - the driver > > generates synthetic wheel event for the inertia. > > You can btw. turn that off. > > > > Seems an issue w

Re: Review Request 120319: Make Kate mousewheel zoom feature respect the corresponding global setting (KGlobalSettings::wheelMouseZooms())

2015-09-02 Thread Thomas Lübking
> On Sept. 23, 2014, 3:01 nachm., Thomas Lübking wrote: > > Qt cannot "distiguish" because there's nothing to distinguish - the driver > > generates synthetic wheel event for the inertia. > > You can btw. turn that off. > > > > Seems an issue w

Re: Review Request 120319: Make Kate mousewheel zoom feature respect the corresponding global setting (KGlobalSettings::wheelMouseZooms())

2015-09-02 Thread Thomas Lübking
> On Sept. 23, 2014, 3:01 nachm., Thomas Lübking wrote: > > Qt cannot "distiguish" because there's nothing to distinguish - the driver > > generates synthetic wheel event for the inertia. > > You can btw. turn that off. > > > > Seems an issue w

Re: Review Request 120319: Make Kate mousewheel zoom feature respect the corresponding global setting (KGlobalSettings::wheelMouseZooms())

2015-09-01 Thread Thomas Lübking
> On Sept. 23, 2014, 3:01 nachm., Thomas Lübking wrote: > > Qt cannot "distiguish" because there's nothing to distinguish - the driver > > generates synthetic wheel event for the inertia. > > You can btw. turn that off. > > > > Seems an issue w

Re: Review Request 120319: Make Kate mousewheel zoom feature respect the corresponding global setting (KGlobalSettings::wheelMouseZooms())

2015-09-01 Thread Thomas Lübking
> On Sept. 23, 2014, 3:01 nachm., Thomas Lübking wrote: > > Qt cannot "distiguish" because there's nothing to distinguish - the driver > > generates synthetic wheel event for the inertia. > > You can btw. turn that off. > > > > Seems an issue w

Re: Review Request 120319: Make Kate mousewheel zoom feature respect the corresponding global setting (KGlobalSettings::wheelMouseZooms())

2015-09-01 Thread Thomas Lübking
> On Sept. 23, 2014, 3:01 nachm., Thomas Lübking wrote: > > Qt cannot "distiguish" because there's nothing to distinguish - the driver > > generates synthetic wheel event for the inertia. > > You can btw. turn that off. > > > > Seems an issue w

Re: Modular startkde proof of concept

2015-08-20 Thread Thomas Lübking
On Donnerstag, 20. August 2015 17:22:26 CEST, Sebastian Kügler wrote: That means that we need at least two ways to start a session. startkde.common.d startkde.wayland.d startkde.x11.d ls -1 | sort -t=/ -k2 profit!...? Cheers, Thomas

Re: kdesudo in git

2015-08-20 Thread Thomas Lübking
On Donnerstag, 20. August 2015 15:28:23 CEST, Jonathan Riddell wrote: I couldn't work out a secure and easy way to do that when I looked at it years ago, kdesudo works so we went with that. Does ksudo caching work w/o caching across shells? Cheers, Thomas

Re: Using nullptr instead of Q_NULLPTR

2015-08-14 Thread Thomas Lübking
On Freitag, 14. August 2015 22:34:28 CEST, Thiago Macieira wrote: Don't do that. If you use nullptr, there's no going back to zero because it's not the same. You've irrevocably locked yourself into requiring a compiler that supports it. Even if it's only been used in a 0x0 "compliant" way? S

Re: Using nullptr instead of Q_NULLPTR

2015-08-13 Thread Thomas Lübking
We could just detect the compiler, and in need define nullptr 0x0, look the other side and hope for the best (ie. anybody on modern compilers anyway and nobody actually making use of std::nullptr_t atm. but just of the keyword) - not very nice, but better than breaking compilation(?) and not as

Re: Review Request 121755: Fix input focus for KDM's dialogs when GrabInput is not active

2015-08-04 Thread Thomas Lübking
> On Juli 30, 2015, 10:05 vorm., Thomas Lübking wrote: > > This is Qt4, right? > > > > ::activateWindow() should be equivalent to "XSetInputFocus(display, > > winId(), XRevertToParent, X11->time);" unless > > a) _NET_ACTIVE_WINDOW is listed in _N

Re: Review Request 121755: Fix input focus for KDM's dialogs when GrabInput is not active

2015-08-04 Thread Thomas Lübking
> On Juli 30, 2015, 10:05 vorm., Thomas Lübking wrote: > > This is Qt4, right? > > > > ::activateWindow() should be equivalent to "XSetInputFocus(display, > > winId(), XRevertToParent, X11->time);" unless > > a) _NET_ACTIVE_WINDOW is listed in _N

Re: Review Request 121755: Fix input focus for KDM's dialogs when GrabInput is not active

2015-08-04 Thread Thomas Lübking
> On Juli 30, 2015, 10:05 vorm., Thomas Lübking wrote: > > This is Qt4, right? > > > > ::activateWindow() should be equivalent to "XSetInputFocus(display, > > winId(), XRevertToParent, X11->time);" unless > > a) _NET_ACTIVE_WINDOW is listed in _N

Re: Replacement for KDateTime

2015-08-04 Thread Thomas Lübking
On Montag, 3. August 2015 23:17:04 CEST, John Layt wrote: Not nonsense, exactly my long-term plan to get Gtk and other apps to use the right Plasma locale settings when running under Plasma. It 'just' requires the kcm to learn how to write and compile a POSIX locale file. That actually doesn't

Re: Replacement for KDateTime

2015-08-03 Thread Thomas Lübking
On Sonntag, 2. August 2015 20:32:43 CEST, David Jarvie wrote: Having a date-only attribute in KDateTime is very useful because it allows both date-time and date-only values to be encapsulated in a single class. This avoids having to be able to pass either a QDate or QDateTime or to have a sepa

Re: Replacement for KDateTime

2015-08-03 Thread Thomas Lübking
On Montag, 3. August 2015 19:09:17 CEST, Martin Klapetek wrote: Setting different LC_TIME values proven to not be feasible, because very often users want "just" 24h clock format _and_ their locale's date format. Or some date format and their locale's time format. Disclaimer: I may talk nonsens

Re: RFC: KDE Bugzilla Bugs Expiration

2015-07-31 Thread Thomas Lübking
On Freitag, 31. Juli 2015 19:29:53 CEST, Ingo Klöcker wrote: I also do not see the point in nagging the user after a certain period of time if nobody else ever cared to comment on the bug. Feels a bit like little kids asking "Are we there yet?" over and over again. The idea is not only to get

Re: RFC: KDE Bugzilla Bugs Expiration

2015-07-31 Thread Thomas Lübking
On Freitag, 31. Juli 2015 14:05:09 CEST, laurent Montel wrote: Especially for KDE PIM, given the size of the userbase and the amount of developers (3), bugs often take more than a year to get to and to be fixed. +1 As Daniel wrote we have a lot of bug and a very small team. So we can't able t

Re: Review Request 121755: Fix input focus for KDM's dialogs when GrabInput is not active

2015-07-30 Thread Thomas Lübking
> On Juli 30, 2015, 10:05 vorm., Thomas Lübking wrote: > > This is Qt4, right? > > > > ::activateWindow() should be equivalent to "XSetInputFocus(display, > > winId(), XRevertToParent, X11->time);" unless > > a) _NET_ACTIVE_WINDOW is listed in _N

Re: Review Request 121755: Fix input focus for KDM's dialogs when GrabInput is not active

2015-07-30 Thread Thomas Lübking
bug caused by a crashing WM => setting Qt::X11BypassWindowManagerHint will likely be sufficient. - Thomas Lübking On Juli 29, 2015, 9:39 vorm., Wolfgang Bauer wrote: > > --- > This is an auto

Re: [Development] Please help me get my pending review count down

2015-07-29 Thread Thomas Lübking
On Mittwoch, 29. Juli 2015 04:06:59 CEST, Thiago Macieira wrote: On Tuesday 28 July 2015 14:51:49 Thiago Macieira wrote: - QtDBus changes: https://codereview.qt-project.org/101967 https://codereview.qt-project.org/102762 https://codereview.qt-project.org/103731 https://codereview.qt-project.org

[kdelibs/KDE/4.14] Re: cmake/modules: Remove policy settings from FindKDE4Internal.

2015-07-20 Thread Thomas Lübking
On Montag, 20. Juli 2015 23:07:00 CEST, Allen Winter wrote: For years I have passed -DKDE4_ENABLE_HTMLHANDBOOK=1 to cmake when building KDE projects. As of today I get this error: CMake Error at cmake/modules/KDE4Macros.cmake:315 (add_custom_target): add_custom_target cannot create target "ht

Re: KSyCoca, Thread safety, and Cache invalidation

2015-07-14 Thread Thomas Lübking
On Dienstag, 14. Juli 2015 19:00:14 CEST, Milian Wolff wrote: On Tuesday, July 14, 2015 11:49:25 AM David Faure wrote: On Friday 26 June 2015 18:03:00 Frank Reininghaus wrote: ... It has. Querying the current time repeatedly is quite costly, and often shows up in code that extensively uses t

Re: KScreenGenie moved to KDE Review

2015-07-04 Thread Thomas Lübking
On Donnerstag, 2. Juli 2015 18:17:16 CEST, Boudhayan Gupta wrote: Hi, I've fixed up the UI as per the above mail thread, and pushed to master. Download and test! "Window under mouse" actually shoots the active window what makes it ipossible to shoot eg. floating docks (*unrelated* to hiding i

Re: KScreenGenie moved to KDE Review

2015-06-29 Thread Thomas Lübking
On Montag, 29. Juni 2015 11:58:29 CEST, Boudhayan Gupta wrote: Hi Thomas, It's a standard QDialogButtonBox. I haven't set the button ordering manually at all. Maybe it's a QDialogButtonBox bug then. It's because eg. you use the "Apply" role for "Save & Exit" (would rather be "Ok" role) and "

Re: KScreenGenie moved to KDE Review

2015-06-28 Thread Thomas Lübking
Did a functional test only. a) The button role assignment seems wrong (you tried to arrange buttons in a certain order that suits either the KDE or windows order? They end up totally weird other orders eg. GTK or OSX) b) Buttons 1. While I like the "Save & Exit" idea, it leaves uncertainity

Re: KSyCoca, Thread safety, and Cache invalidation

2015-06-26 Thread Thomas Lübking
On Freitag, 26. Juni 2015 18:03:00 CEST, Frank Reininghaus wrote: Hi, 2015-06-21 16:54 GMT+02:00 David Faure: On Friday 19 June 2015 22:00:09 Vishesh Handa wrote: On Sat, Jun 13, 2015 at 9:26 PM, David Faure wrote: ... I thought about it again, and there's a much simpler solution. We get rid

Re: KSNI and actionCollection

2015-06-22 Thread Thomas Lübking
On Dienstag, 23. Juni 2015 00:06:13 CEST, Albert Astals Cid wrote: El Dimarts, 23 de juny de 2015, a les 07:50:49, Vladimir Perepechin va escriure: 23 июня 2015 г. 8:41 пользователь "Albert Astals Cid" написал: ... tsdgeos@xps:~$ ls /usr/include/KF5/KXmlGui/kactioncollection.h /usr/include/

Re: Review Request 112328: Add case sensitive sorting option to KGlobalSettings and KDirSortFilterProxyModel

2015-06-21 Thread Thomas Lübking
> On Sept. 4, 2013, 2:38 nachm., Martin Gräßlin wrote: > > KGlobalSettings moved into KDE4Support in frameworks 5. I would suggest to > > not add new API to an already deprecated class. Maybe you want to provide a > > patch for the proper way in frameworks? > > Frank Reininghaus wrote: > M

Re: Review Request 123806: [klipper] Ignore empty / blank entries

2015-05-27 Thread Thomas Lübking
> On Mai 27, 2015, 7:30 vorm., Martin Gräßlin wrote: > > I just gave the patch a try and it seems not to work. Although "Allow > > whitespace entries" is not checked I was able to get an entry with three > > new lines into the history. The patch looks like it only affects loading the history f

Re: Review Request 123806: [klipper] Ignore empty / blank entries

2015-05-22 Thread Thomas Lübking
gt; > /home/patrick/kdesrc/plasma-workspace/klipper/klippersettings.h:72: > > undefined reference to `KlipperSettings::self()' > > > > > > Note: The whole file is full of *return self()->member*, I don't know > > why it

Re: Review Request 123806: [klipper] Ignore empty / blank entries

2015-05-22 Thread Thomas Lübking
gt; > /home/patrick/kdesrc/plasma-workspace/klipper/klippersettings.h:72: > > undefined reference to `KlipperSettings::self()' > > > > > > Note: The whole file is full of *return self()->member*, I don't know > > why it

Re: Review Request 123806: [klipper] Ignore empty / blank entries

2015-05-22 Thread Thomas Lübking
gt; > /home/patrick/kdesrc/plasma-workspace/klipper/klippersettings.h:72: > > undefined reference to `KlipperSettings::self()' > > > > > > Note: The whole file is full of *return self()->member*, I don't know > > why it

Re: Review Request 123806: [klipper] Ignore empty / blank entries

2015-05-21 Thread Thomas Lübking
> On Mai 21, 2015, 5:02 nachm., Patrick Eigensatz wrote: > > klipper/klipper.kcfg, line 24 > > > > > > **Question:** Compiled plasma-workspace using *kdesrc-build > > --include-dependencies plasma-workspace*, app

Re: Review Request 123806: [klipper] Ignore empty / blank entries

2015-05-18 Thread Thomas Lübking
> On Mai 18, 2015, 7:28 nachm., Patrick Eigensatz wrote: > > klipper/historyitem.cpp, line 92 > > > > > > Not sure if *text.isEmpty()* returns true if text=="\n\t \n" > > > > QT Documentation says: "Retur

  1   2   3   4   5   6   7   8   9   >