Re: Review Request 104222: Display recent documents in places bookmark by default

82dee90 Diff: https://git.reviewboard.kde.org/r/104222/diff/ Testing --- Thanks, Xuetian Weng

Re: Review Request 104222: Display recent documents in places bookmark by default

/104222/diff/ Testing --- Thanks, Xuetian Weng

Re: Review Request 104222: Display recent documents in places bookmark by default

t: http://git.reviewboard.kde.org/r/104222/#review42492 ------- On Oct. 27, 2013, 7:07 p.m., Xuetian Weng wrote: > > --- > This is an automatically generated e-mail. To repl

Re: Review Request 104222: Display recent documents in places bookmark by default

://git.reviewboard.kde.org/r/104222/diff/ Testing --- Thanks, Xuetian Weng

Re: Review Request 113413: Improved Keyboard Layout Preview

> On Oct. 25, 2013, 7:58 p.m., Xuetian Weng wrote: > > Could you also post a preview for French ? It should have 4 symbol on one > > key, I'd like to how that looks. > > Seems you didn't parse the led information? (It's ok to leave it there) > > &

Re: Review Request 113413: Improved Keyboard Layout Preview

ring position can be improved, for example, the "Space" in second screenshot. - Xuetian Weng On Oct. 25, 2013, 7:13 p.m., shivam makkar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: &g

Review Request 112602: Delay KDE class initialization to main loop

bug 324574. http://bugs.kde.org/show_bug.cgi?id=324574 Diffs - qguiplatformplugin_kde/qguiplatformplugin_kde.cpp ce22622 Diff: http://git.reviewboard.kde.org/r/112602/diff/ Testing --- 324574 fixed. and other applications are unaffected. Thanks, Xuetian Weng

Re: Review Request 110089: fix lightdm with systemd and kde user switch

28fabfc Diff: http://git.reviewboard.kde.org/r/110089/diff/ Testing --- Now shutdown and reboot correctly shown in kickoff, and working. Switch user also working. Thanks, Xuetian Weng

Re: Review Request 110089: fix lightdm with systemd and kde user switch

git.reviewboard.kde.org/r/110089/#review31309 --- On April 19, 2013, 7:36 p.m., Xuetian Weng wrote: > > --- > This is an automatically generated e-mail. To reply, visit:

Review Request 110089: fix lightdm with systemd and kde user switch

shutdown and reboot correctly shown in kickoff, and working. Switch user also working. Thanks, Xuetian Weng

Re: Review Request 108965: fix kde_infopage css for webkit

konqueror still looks all the same (seems about:konqueror is still using KHTML). Thanks, Xuetian Weng

Review Request 108965: fix kde_infopage css for webkit

). Thanks, Xuetian Weng

Re: Review Request 108367: Complete keyboard preview rework for KControl

> On Jan. 26, 2013, 3:13 a.m., Andriy Rysin wrote: > > Manuel, I like how it looks in general with rounded corners and space > > between keys, but I must say that the font size is quite small. E.g. small > > letters are not easy to read even with good eyes, I wander if there's a way > > to rea

Review Request 108418: use system to suspend and hibernate in powerdevil

/ Testing --- I don't have swap so only suspend is tested. Problem seems fixed. Thanks, Xuetian Weng

Re: Review Request 108367: Complete keyboard preview rework for KControl

> On Jan. 13, 2013, 12:27 p.m., Xuetian Weng wrote: > > You may want to look this: > > https://github.com/fcitx/kcm-fcitx/blob/master/layout/keyboardlayoutwidget.cpp > > > > It's a more featured widget in fcitx (but the code I mentioned is only >

Re: Review Request 108367: Complete keyboard preview rework for KControl

would explain it: http://susepaste.org/3952607 I'd admit your key string is much better :) , but feel free to take my code to improve it - Xuetian Weng On Jan. 12, 2013, 5:13 p.m., Manuel Tortosa wrote: > > --- > This

Re: Review Request 107983: Fix KWindowSystem::compositingChanged signal

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107983/#review25307 --- After several days test, so far no problem here. - Xuetian

Re: Review Request: fix 234407 - set minimum width for system settings icon view

r/108328/s/1023/ Thanks, Xuetian Weng

Re: Review Request: fix 234407 - set minimum width for system settings icon view

utomatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108328/#review25177 --- On Jan. 10, 2013, 8:47 p.m., Xuetian Weng wrote: > > -

Re: Review Request: fix 234407 - set minimum width for system settings icon view

p://git.reviewboard.kde.org/r/108328/#review25179 ------- On Jan. 10, 2013, 8:47 p.m., Xuetian Weng wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request: fix 234407 - set minimum width for system settings icon view

board.kde.org/r/108328/s/1015/ chinese before change http://git.reviewboard.kde.org/r/108328/s/1016/ spanish after change http://git.reviewboard.kde.org/r/108328/s/1017/ Thanks, Xuetian Weng

Re: Review Request: fix 234407 - set minimum width for system settings icon view

board.kde.org/r/108328/s/1015/ chinese before change http://git.reviewboard.kde.org/r/108328/s/1016/ spanish after change http://git.reviewboard.kde.org/r/108328/s/1017/ Thanks, Xuetian Weng

Review Request: fix 234407 - set minimum width for system settings icon view

/1014/ chinese after change http://git.reviewboard.kde.org/r/108328/s/1015/ chinese before change http://git.reviewboard.kde.org/r/108328/s/1016/ spanish after change http://git.reviewboard.kde.org/r/108328/s/1017/ Thanks, Xuetian Weng

Re: Review Request: use _NET_WM_STATE_HIDDEN to check if the window is minimized instead of WM_STATE == ICONIC when possible.

> On Jan. 9, 2013, 10:45 p.m., Thomas Lübking wrote: > > Random addendums: > > - state hidden is also provided by metacity, icewm, openbox and compiz > > - mappingState() is part of the public API, thus not cut off (if you > > actually want to know it) > > - not unmapping windows has more issues

Re: Review Request: use _NET_WM_STATE_HIDDEN to check if the window is minimized instead of WM_STATE == ICONIC when possible.

> In this case a less invasive alternative would be to alter the > taskbar/pager implementation to check KWindowInfo::state() rather then > ::isMinimized() > > I'll test the ones mentioned above and later on e17 > > Xuetian Weng wrote: > ... ahhh, while I'm discu

Review Request: fix isMinimized in KWindowInfo

ow is not minimized. Diffs - kdeui/windowmanagement/kwindowinfo_x11.cpp d983c9a Diff: http://git.reviewboard.kde.org/r/108314/diff/ Testing --- compiles and pager is fixed. Thanks, Xuetian Weng

Re: Review Request: Fix bug 234407 - systemsettings iconview wordwrapping cause narrow icon in zhcn locale

> On Jan. 9, 2013, 10:09 a.m., Ben Cooksley wrote: > > systemsettings/icons/IconMode.cpp, line 183 > > > > > > Not sure I like the idea of a hardcoded list of languages... is there a > > better way of determining

Re: Review Request: Fix KWindowSystem::compositingChanged signal

ystem already calls SelectSelectionInput in constructor, just use the above one and do window == winId and event->selection == net_wm_cm is enough. - Xuetian Weng On Jan. 9, 2013, 12:52 a.m., Thomas Lübking wrote: > > -

Re: Review Request: Fix KWindowSystem::compositingChanged signal

> On Jan. 8, 2013, 11:15 p.m., Xuetian Weng wrote: > > after I apply the patch, I notice that in some random unknnow case > > KWindowSystem will emit the signal, while KSelectionOwner is not. (And I > > think KSelectionOwner is correct since I didn't do anything t

Re: Review Request: Fix KWindowSystem::compositingChanged signal

> On Jan. 8, 2013, 11:15 p.m., Xuetian Weng wrote: > > after I apply the patch, I notice that in some random unknnow case > > KWindowSystem will emit the signal, while KSelectionOwner is not. (And I > > think KSelectionOwner is correct since I didn't do anything t

Re: Review Request: Fix KWindowSystem::compositingChanged signal

case KWindowSystem will emit the signal, while KSelectionOwner is not. (And I think KSelectionOwner is correct since I didn't do anything to kwin), and I notice some strange plasma theme change caused by this. Trying to find you why.. - Xuetian Weng On Jan. 5, 2013, 5:08 p.m., Thomas Lü

Re: Review Request: qml based kwin shadow

tabbox is tested with Air and Slim Glow, composite and non-composite, no problem. Thanks, Xuetian Weng

Re: Review Request: qml based kwin shadow

desktop tabbox is tested with Air and Slim Glow, composite and non-composite, no problem. Thanks, Xuetian Weng

Re: Review Request: qml based kwin shadow

and Slim Glow, composite and non-composite, no problem. Thanks, Xuetian Weng

Re: Review Request: qml based kwin shadow

.10 (current one is half-baked) - Xuetian --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108243/#review24924 ------- On

Re: Review Request: qml based kwin shadow

ATION kwin/tabbox/qml/tabbox.qml 4176231 Diff: http://git.reviewboard.kde.org/r/108243/diff/ Testing --- all desktop tabbox is tested with Air and Slim Glow, composite and non-composite, no problem. Thanks, Xuetian Weng

Review Request: qml based kwin shadow

/main.qml efe3ebe kwin/tabbox/qml/tabbox.qml 4176231 Diff: http://git.reviewboard.kde.org/r/108243/diff/ Testing --- all desktop tabbox is tested with Air and Slim Glow, composite and non-composite, no problem. Thanks, Xuetian Weng

Re: Review Request: use Plasma::Dialog for brightness osd

/diff/ Testing --- locally tested, no problem. Thanks, Xuetian Weng

Re: Review Request: use Plasma::Dialog for brightness osd

: http://git.reviewboard.kde.org/r/108222/diff/ Testing --- locally tested, no problem. Thanks, Xuetian Weng

Re: Review Request: use Plasma::Dialog for brightness osd

23/ - Xuetian --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108222/#review24840 --- On Jan. 6, 2013, 1:36 p.m., Xue

Re: Review Request: set brightness to zero in profile doesn't work

) - powerdevil/daemon/actions/bundled/brightnesscontrol.cpp 5088e4e Diff: http://git.reviewboard.kde.org/r/108230/diff/ Testing --- now zero in profile works. Thanks, Xuetian Weng

Review Request: set brightness to zero in profile doesn't work

/brightnesscontrol.cpp 5088e4e powerdevil/daemon/brightnessosdwidget.h ef08903 powerdevil/daemon/brightnessosdwidget.cpp e4cf80a Diff: http://git.reviewboard.kde.org/r/108230/diff/ Testing --- now zero in profile works. Thanks, Xuetian Weng

Re: Review Request: use Plasma::Dialog for brightness osd

o see if we don't consider that bug, it will work or not. - Xuetian --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108222/#review24834 ------

Re: Review Request: use Plasma::Dialog for brightness osd

/diff/ Testing (updated) --- locally tested, no problem. Thanks, Xuetian Weng

Review Request: use Plasma::Dialog for brightness osd

--- well, you know.. this would fix the shadow problem. Diffs - powerdevil/daemon/brightnessosdwidget.h ef08903 powerdevil/daemon/brightnessosdwidget.cpp e4cf80a Diff: http://git.reviewboard.kde.org/r/108222/diff/ Testing --- locally tested, problem. Thanks, Xuetian Weng

Re: Review Request: try fix tooltip shadow problem

fixed, but not sure it's the right way. Thanks, Xuetian Weng

Review Request: try fix tooltip shadow problem

ignal, hence it will handle that gracefully. This addresses bug 311502. http://bugs.kde.org/show_bug.cgi?id=311502 Diffs - plasma/tooltipmanager.cpp 00bfcdb Diff: http://git.reviewboard.kde.org/r/107905/diff/ Testing --- seems it fixed, but not sure it's the right way. Thanks, Xuetian Weng

Re: Review Request: add pager drag switch feature back

(updated) - plasma/desktop/applets/pager/package/contents/ui/main.qml 9f53b7f plasma/desktop/applets/pager/pager.h 767b2dd plasma/desktop/applets/pager/pager.cpp 956bde2 Diff: http://git.reviewboard.kde.org/r/107843/diff/ Testing --- tested, no problem. Thanks, Xuetian Weng

Re: Review Request: add pager drag switch feature back

(updated) - plasma/desktop/applets/pager/package/contents/ui/main.qml 9f53b7f plasma/desktop/applets/pager/pager.h 767b2dd plasma/desktop/applets/pager/pager.cpp 956bde2 Diff: http://git.reviewboard.kde.org/r/107843/diff/ Testing --- tested, no problem. Thanks, Xuetian Weng

Re: Review Request: add pager drag switch feature back

lasma/desktop/applets/pager/pager.h 767b2dd plasma/desktop/applets/pager/pager.cpp 956bde2 Diff: http://git.reviewboard.kde.org/r/107843/diff/ Testing --- tested, no problem. Thanks, Xuetian Weng

Review Request: add pager drag switch feature back

/pager.cpp 956bde2 Diff: http://git.reviewboard.kde.org/r/107843/diff/ Testing --- tested, no problem. Thanks, Xuetian Weng

Review Request: Fix pager window dragging and icon

75 Diffs - plasma/desktop/applets/pager/package/contents/ui/main.qml 40a829d Diff: http://git.reviewboard.kde.org/r/107828/diff/ Testing --- No problem. Thanks, Xuetian Weng

Re: Review Request: fix kio_activities cannot handle utf8 file name/path

n soprano or we should fix it when the original url is saved. - Xuetian --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105222/#review15736 -------

Re: Review Request: fix kio_activities cannot handle utf8 file name/path

/kio_activities.cpp 8ef1f7b Diff: http://git.reviewboard.kde.org/r/105222/diff/ Testing --- Works here for utf8 file name. Thanks, Xuetian Weng

Re: Review Request: fix kio_activities cannot handle utf8 file name/path

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105222/#review14775 --- Ping? - Xuetian Weng On June 12, 2012, 1:37 a.m., Xuetian

Review Request: fix kio_activities cannot handle utf8 file name/path

/ Testing --- Works here for utf8 file name. Thanks, Xuetian Weng

Review Request: Display recent documents in places bookmark by default

this https://git.reviewboard.kde.org/r/103849/ , I hope this KIO can be displayed in the places bookmark by default. Diffs - kfile/kfileplacesmodel.cpp 82dee90 Diff: http://git.reviewboard.kde.org/r/104222/diff/ Testing --- Thanks, Xuetian Weng

Re: Review Request: Add recentdocuments:/ kio slave to kde-runtime.

-- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103849/#review10588 ------- On Feb. 15, 2012, 3:11 p.m., Xuetian Weng wrote: > > -

Re: Review Request: Add recentdocuments:/ kio slave to kde-runtime.

-- Works for me. Thanks, Xuetian Weng

Re: Review Request: Add recentdocuments:/ kio slave to kde-runtime.

centdocuments/recentdocumentsnotifier.h PRE-CREATION kioslave/recentdocuments/recentdocumentsnotifier.cpp PRE-CREATION kioslave/recentdocuments/recentdocumentsnotifier.desktop PRE-CREATION Diff: http://git.reviewboard.kde.org/r/103849/diff/diff Testing --- Works for me. Thanks, Xuetian Weng

Re: Review Request: Add recentdocuments:/ kio slave to kde-runtime.

Works for me. Thanks, Xuetian Weng

Re: Review Request: Add recentdocuments:/ kio slave to kde-runtime.

ecentdocuments/recentdocuments.cpp PRE-CREATION > kioslave/recentdocuments/recentdocuments.protocol PRE-CREATION > kioslave/recentdocuments/recentdocumentsnotifier.h PRE-CREATION > kioslave/recentdocuments/recentdocumentsnotifier.cpp PRE-CREATION > kioslave/recentdocuments/recentdocumentsnotifier.desktop PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/103849/diff/diff > > > Testing > --- > > Works for me. > > > Thanks, > > Xuetian Weng > >

Review Request: Add recentdocuments:/ kio slave to kde-runtime.

N kioslave/recentdocuments/recentdocumentsnotifier.desktop PRE-CREATION Diff: http://git.reviewboard.kde.org/r/103849/diff/diff Testing --- Works for me. Thanks, Xuetian Weng

Re: Review Request: Fix Date Display in dolphin info panel

y, visit: http://git.reviewboard.kde.org/r/103300/#review8638 --- On Nov. 30, 2011, 9:17 p.m., Xuetian Weng wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http:/

Re: Review Request: Fix Date Display in dolphin info panel

an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103300/#review8628 --- On Nov. 30, 2011, 9:17 p.m., Xuetian Weng wrote: > > --- > This

Review Request: Fix Date Display in dolphin info panel

KComponentData. Diffs - nepomuk/utils/utils.cpp e81615a kio/kfile/kfilemetadatareaderprocess.cpp 03ff887 Diff: http://git.reviewboard.kde.org/r/103300/diff/diff Testing --- Works for me. Thanks, Xuetian Weng

Review Request: Further fix for Bug 285731

/diff/diff Testing --- No more crash Thanks, Xuetian Weng