Re: Review Request: In Konqueror's session restore dialog, allow user to chose which sessions to restore

2012-10-12 Thread Christoph Feck
> On Oct. 12, 2012, 2:11 a.m., Commit Hook wrote: > > This review has been submitted with commit > > a78c6a50dcb33028eb572bc260bdaca8f30a597a by Dawit Alemayehu to branch > > KDE/4.9. > > Dawit Alemayehu wrote: > Ahhh... I did not do this! How did this patch end up being cherry-picked > i

Re: Review Request: In Konqueror's session restore dialog, allow user to chose which sessions to restore

2012-10-11 Thread Dawit Alemayehu
> On Oct. 12, 2012, 2:11 a.m., Commit Hook wrote: > > This review has been submitted with commit > > a78c6a50dcb33028eb572bc260bdaca8f30a597a by Dawit Alemayehu to branch > > KDE/4.9. Ahhh... I did not do this! How did this patch end up being cherry-picked into 4.9 branch ??!?! It is only sup

Re: Review Request: In Konqueror's session restore dialog, allow user to chose which sessions to restore

2012-10-11 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106503/#review20214 --- This review has been submitted with commit a78c6a50dcb33028eb5

Re: Review Request: In Konqueror's session restore dialog, allow user to chose which sessions to restore

2012-10-09 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106503/#review20112 --- Ship it! Ship It! - David Faure On Oct. 8, 2012, 5:43 p.m.,

Re: Review Request: In Konqueror's session restore dialog, allow user to chose which sessions to restore

2012-10-09 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106503/#review20110 --- konqueror/src/konqsessionmanager.cpp

Re: Review Request: In Konqueror's session restore dialog, allow user to chose which sessions to restore

2012-10-08 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106503/ --- (Updated Oct. 8, 2012, 5:43 p.m.) Review request for KDE Base Apps and Dav

Re: Review Request: In Konqueror's session restore dialog, allow user to chose which sessions to restore

2012-10-08 Thread Dawit Alemayehu
> On Oct. 8, 2012, 10:30 a.m., David Faure wrote: > > konqueror/src/konqsessionmanager.cpp, line 123 > > > > > > Did you change this if() wrongly? > > > > Now the code says "if I could find the dialog-warni

Re: Review Request: In Konqueror's session restore dialog, allow user to chose which sessions to restore

2012-10-08 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106503/#review20065 --- konqueror/src/konqsessionmanager.cpp

Re: Review Request: In Konqueror's session restore dialog, allow user to chose which sessions to restore

2012-10-03 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106503/ --- (Updated Oct. 4, 2012, 3:50 a.m.) Review request for KDE Base Apps and Dav

Re: Review Request: In Konqueror's session restore dialog, allow user to chose which sessions to restore

2012-10-02 Thread Thomas Lübking
> On Oct. 2, 2012, 8:57 a.m., David Faure wrote: > > konqueror/src/konqsessionmanager.cpp, line 166 > > > > > > Does this really make any difference? Widgets are transparent by > > default, in Qt4... > > Thomas Lü

Re: Review Request: In Konqueror's session restore dialog, allow user to chose which sessions to restore

2012-10-02 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106503/ --- (Updated Oct. 2, 2012, 9:07 p.m.) Review request for KDE Base Apps and Dav

Re: Review Request: In Konqueror's session restore dialog, allow user to chose which sessions to restore

2012-10-02 Thread Dawit Alemayehu
> On Oct. 2, 2012, 8:57 a.m., David Faure wrote: > > konqueror/src/konqsessionmanager.cpp, line 257 > > > > > > in the... ? :-) > > > > (unfinished sentence) > > > > It's easier to just move the co

Re: Review Request: In Konqueror's session restore dialog, allow user to chose which sessions to restore

2012-10-02 Thread Dawit Alemayehu
> On Oct. 2, 2012, 8:57 a.m., David Faure wrote: > > konqueror/src/konqsessionmanager.cpp, line 166 > > > > > > Does this really make any difference? Widgets are transparent by > > default, in Qt4... > > Thomas Lü

Re: Review Request: In Konqueror's session restore dialog, allow user to chose which sessions to restore

2012-10-02 Thread Thomas Lübking
> On Oct. 2, 2012, 8:57 a.m., David Faure wrote: > > konqueror/src/konqsessionmanager.cpp, line 166 > > > > > > Does this really make any difference? Widgets are transparent by > > default, in Qt4... To be more ag

Re: Review Request: In Konqueror's session restore dialog, allow user to chose which sessions to restore

2012-10-02 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106503/#review19731 --- konqueror/src/konqsessionmanager.h

Re: Review Request: In Konqueror's session restore dialog, allow user to chose which sessions to restore

2012-10-02 Thread David Faure
> On Sept. 29, 2012, 9:20 a.m., David Faure wrote: > > konqueror/src/konqsessionmanager.cpp, line 450 > > > > > > Doesn't this lose ItemIsSelectable? I guess item->flags() | > > Qt::ItemIsUserCheckable would be bet

Re: Review Request: In Konqueror's session restore dialog, allow user to chose which sessions to restore

2012-10-01 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106503/ --- (Updated Oct. 1, 2012, 8:56 p.m.) Review request for KDE Base Apps and Dav

Re: Review Request: In Konqueror's session restore dialog, allow user to chose which sessions to restore

2012-10-01 Thread Dawit Alemayehu
> On Sept. 29, 2012, 9:36 a.m., Pino Toscano wrote: > > konqueror/src/konqsessionmanager.cpp, lines 343-345 > > > > > > i18n: what do these "filter-..." contexts mean? I copied those straight out of KMessageBox's c

Re: Review Request: In Konqueror's session restore dialog, allow user to chose which sessions to restore

2012-10-01 Thread Dawit Alemayehu
> On Sept. 29, 2012, 9:20 a.m., David Faure wrote: > > konqueror/src/konqsessionmanager.cpp, line 450 > > > > > > Doesn't this lose ItemIsSelectable? I guess item->flags() | > > Qt::ItemIsUserCheckable would be bet

Re: Review Request: In Konqueror's session restore dialog, allow user to chose which sessions to restore

2012-09-29 Thread Pino Toscano
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106503/#review19565 --- konqueror/src/konqsessionmanager.cpp

Re: Review Request: In Konqueror's session restore dialog, allow user to chose which sessions to restore

2012-09-29 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106503/#review19563 --- konqueror/src/konqsessionmanager.cpp

Re: Review Request: In Konqueror's session restore dialog, allow user to chose which sessions to restore

2012-09-28 Thread Dawit Alemayehu
> On Sept. 19, 2012, 9:28 p.m., Christoph Feck wrote: > > Very nice. I think the text at the header could mention something along the > > line that you can choose which pages to restore. Would a tooltip suffice ? See the new restore dialog v2 screenshot. - Dawit

Re: Review Request: In Konqueror's session restore dialog, allow user to chose which sessions to restore

2012-09-28 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106503/ --- (Updated Sept. 28, 2012, 4:45 p.m.) Review request for KDE Base Apps and D

Re: Review Request: In Konqueror's session restore dialog, allow user to chose which sessions to restore

2012-09-19 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106503/#review19192 --- Very nice. I think the text at the header could mention somethi

Re: Review Request: In Konqueror's session restore dialog, allow user to chose which sessions to restore

2012-09-19 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106503/ --- (Updated Sept. 19, 2012, 9:15 p.m.) Review request for KDE Base Apps and D

Re: Review Request: In Konqueror's session restore dialog, allow user to chose which sessions to restore

2012-09-19 Thread Dawit A
On Wed, Sep 19, 2012 at 2:31 AM, Rolf Eike Beer wrote: > > * If all available sessions are unselected, > > presssing "Restore Session" button will behave like "Do not Restore". > > What about just disabling "Restore Session" then? > Well, I guess that can be done as well with a bit more code.

Re: Review Request: In Konqueror's session restore dialog, allow user to chose which sessions to restore

2012-09-18 Thread Rolf Eike Beer
> * If all available sessions are unselected, > presssing "Restore Session" button will behave like "Do not Restore". What about just disabling "Restore Session" then? Eike signature.asc Description: This is a digitally signed message part.

Review Request: In Konqueror's session restore dialog, allow user to chose which sessions to restore

2012-09-18 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106503/ --- Review request for KDE Base Apps and David Faure. Description --- The