> On Jan. 8, 2014, 8:10 a.m., Martin Gräßlin wrote:
> > If you have the possibility (build setup) please merge to master and fix
> > the merge conflict I expect to see :-) I merged 4.11 into master yesterday
> > so there should no be anything else which could conflict
bbly windows. Please excuse again the long time for the
review.
- Martin Gräßlin
On June 3, 2013, 9:55 p.m., Stefanos Harhalakis wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://
ng to kglobalacceld from KF5?
- Martin Gräßlin
On Jan. 13, 2014, 4:51 p.m., Jonathan Riddell wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard
7;s a good idea as that
breaks any communication with the kdelibs4.
- Martin Gräßlin
On Jan. 14, 2014, 4:21 p.m., Jonathan Riddell wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.review
> On Jan. 14, 2014, 8:22 p.m., Martin Gräßlin wrote:
> > like with the other patch I'm not sure whether that's a good idea as that
> > breaks any communication with the kdelibs4.
>
> Thomas Lübking wrote:
> is there a functional incompitibility between
> to journald instead.
>
> KDE applications are the largest users of qDebug today.
>
> If we changed the default, it would mean ~/.xsession-errors would probably
> become rather empty. Is that ok for KDE?
I like this +1
--
Martin Gräßlin
signature.asc
Description: This is a digitally signed message part.
t for kgloballacel: I
consider copying the files to every user as the wrong solution. In Qt terms I
would give it a -2.
- Martin Gräßlin
On Jan. 21, 2014, 1:48 p.m., Jonathan Riddell wrote:
>
> ---
> This is an automatically genera
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115079/#review47882
---
much better! Thanks for working on it.
- Martin Gräßlin
On
On Tuesday 21 January 2014 13:12:58 David Hubner wrote:
> > In the plasma sprint we have done a session to plan what we are going to
> > do
> > with kde-workspace/kde-runtime repositories, here is the proposal we came
> > with.
> >
> > We are going to create 2 new repos called plasma-desktop and
>
> On Jan. 28, 2014, 8:03 a.m., Commit Hook wrote:
> > This review has been submitted with commit
> > 77202a2102306a288431462e6c874216ac4cd29c by Martin Gräßlin on behalf of
> > James Jones to branch KDE/4.11.
>
> James Jones wrote:
> Thanks Martin. Will the
helper.cpp 1fe78c24c053e74f2179de00ee9a5701997a0acb
Diff: https://git.reviewboard.kde.org/r/115515/diff/
Testing
---
running Kate on Wayland till it crashes (or doesn't)
Thanks,
Martin Gräßlin
il. To reply, visit:
https://git.reviewboard.kde.org/r/115515/#review49102
-------
On Feb. 6, 2014, 11:55 a.m., Martin Gräßlin wrote:
>
> ---
> This is an automati
de.org/r/115515/diff/
Testing
---
running Kate on Wayland till it crashes (or doesn't)
Thanks,
Martin Gräßlin
looked at e.g. startkde and systemsettings
which have now 4.11.6.
Thanks,
Martin Gräßlin
: https://git.reviewboard.kde.org/r/115519/diff/
Testing
---
compiled with 4.12.60 kdelibs and looked at e.g. startkde and systemsettings
which have now 4.11.6.
Thanks,
Martin Gräßlin
yland till it crashes (or doesn't)
Thanks,
Martin Gräßlin
On Tuesday 25 February 2014 23:20:18 Matthias Klumpp wrote:
> 2014-02-25 22:57 GMT+01:00 Thomas Lübking :
> > On Dienstag, 25. Februar 2014 22:22:36 CEST, Matthias Klumpp wrote:
> >> 2014-02-25 21:51 GMT+01:00 Kevin Krammer :
> >>> On Tuesday, 2014-02-25, 21:36:27, Albert Astals Cid wrote: ...
> >>
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116600/#review51906
---
Ship it!
Ship It!
- Martin Gräßlin
On March 4, 2014, 5:25
diff/
Testing
---
Thanks,
Martin Gräßlin
see a benefit in
renaming the desktop files, etc. in the source dir. Otherwise we will have to
rename again with kglobalaccel6
- Martin Gräßlin
On March 21, 2014, 5:35 p.m., Jonathan Riddell wrote:
>
> ---
> This is an automatic
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116956/#review54152
---
Ship it!
Ship It!
- Martin Gräßlin
On March 25, 2014, 7
On Friday 28 March 2014 16:17:19 David Boosalis wrote:
> At the risk of getting 50 lashes. Can I make a request for new KDE Git
> build instructions. All the instructions for building might be out there
> and I know there is the uber "kdesrc-build" script, but you really got to
> squint to get all
and I consider this
as a security issue. It basically means that the session can get unlocked
without going through authentication.
- Martin Gräßlin
On March 29, 2014, 12:58 p.m., Kirill Elagin wrote:
>
> ---
> This is an auto
> On March 29, 2014, 1:05 p.m., Martin Gräßlin wrote:
> > I also have problems imagining what a use case for this is and I consider
> > this as a security issue. It basically means that the session can get
> > unlocked without going through authentication.
>
> Kir
> On March 29, 2014, 1:05 p.m., Martin Gräßlin wrote:
> > I also have problems imagining what a use case for this is and I consider
> > this as a security issue. It basically means that the session can get
> > unlocked without going through authentication.
>
> Kir
> On March 29, 2014, 1:05 p.m., Martin Gräßlin wrote:
> > I also have problems imagining what a use case for this is and I consider
> > this as a security issue. It basically means that the session can get
> > unlocked without going through authentication.
>
> Kir
On Sunday 30 March 2014 18:06:52 Thiago Macieira wrote:
> > Leaving access to an open shell is certainly bad enough - beyond question.
> > The question is whether gaining direct access to a running session and
> > random open clients (and leaving the stage untraced) is more valuable and
> > thus wo
On Monday 31 March 2014 11:46:58 Thiago Macieira wrote:
> Em seg 31 mar 2014, às 08:55:05, Martin Gräßlin escreveu:
> > Personally I have to disagree. To me the graphical login is a an asset
> > which needs to be protected in a stronger way. Access to a tty should not
> >
://git.reviewboard.kde.org/r/117324/ to
use logind as an authority to unlock.
- Martin Gräßlin
On March 29, 2014, 12:58 p.m., Kirill Elagin wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.
On Thursday 17 April 2014 20:17:38 David Faure wrote:
> I represented KDE again this year at the freedesktop summit in Nuremberg.
> Please find our report below.
sorry to ask, but were there any discussions about the fact that GTK+ based
applications start to be broken on other environments? See
(new master)?
- Martin Gräßlin
On April 22, 2014, 10:41 p.m., Wolfgang Bauer wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.
the new locker?
I'm just wondering whether it needs to be ported to master
- Martin Gräßlin
On April 22, 2014, 10:34 p.m., Wolfgang Bauer wrote:
>
> ---
> This is an automatically generated e-mail. To reply,
> On April 23, 2014, 7:36 a.m., Martin Gräßlin wrote:
> > would you please also adapt that for plasma-workspace repo (new master)?
>
> Wolfgang Bauer wrote:
> Yes, I will.
>
> Should I create a new review request for that, or should I just submit it?
The co
eeter/main.cpp
<https://git.reviewboard.kde.org/r/117091/#comment39351>
coding style: return in next line
ksmserver/screenlocker/greeter/main.cpp
<https://git.reviewboard.kde.org/r/117091/#comment39353>
maybe set the m_instance pointer in the ctor of ScreenLocker::UnlockApp and
set it bac
> On April 23, 2014, 7:41 a.m., Martin Gräßlin wrote:
> > Is that only relevant for the legacy (XSS) locker or also for the new
> > locker? I'm just wondering whether it needs to be ported to master
>
> Wolfgang Bauer wrote:
> Yes. I just tried, and the scre
> On April 23, 2014, 5:43 p.m., Martin Gräßlin wrote:
> > ksmserver/screenlocker/greeter/main.cpp, line 34
> > <https://git.reviewboard.kde.org/r/117091/diff/5/?file=267770#file267770line34>
> >
> > I'm wondering about the variable naming. It'
is an underlying problem
which needs a more proper fix. I recently hit this problem myself on one on my
systems and a crash one can reproduce is as good as fixed ;-)
- Martin Gräßlin
On April 26, 2014, 12:51 a.m., Alexander Richardson
could help me to
reproduce and find the root cause.
- Martin Gräßlin
On April 26, 2014, 12:51 a.m., Alexander Richardson wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.
> On April 28, 2014, 10:24 a.m., Martin Gräßlin wrote:
> > did you notice any pattern which triggers the crash? That could help me to
> > reproduce and find the root cause.
I found the condition myself:
1. show thumbnail
2. let it hide again
3. show thumbnail for same task
wh
> On April 26, 2014, 8:22 a.m., Martin Gräßlin wrote:
> > I'd rather not want to see us hide this crash. There is an underlying
> > problem which needs a more proper fix. I recently hit this problem myself
> > on one on my systems and a crash one can reproduce is as
Hi all,
I need some advice. The new GTK+ release introduced and enforces client-side-
decorations (CSD) and that is causing severe compatibility problems with
Plasma Workspaces (especially the stable release which we cannot adjust any
more). I'll give a list of issues below.
I'm not sure what w
On Wednesday 07 May 2014 11:24:03 Marco Martin wrote:
> On Wednesday 07 May 2014 10:11:37 Martin Gräßlin wrote:
> > * A hung window can no longer be closed or moved. Technical explanation:
> > there is a ping protocol to detect hung applications. KWin only sends ping
> > req
Martin GräßlinOn Wednesday 07 May 2014 10:11:37 wrote:
> Any advice on how to handle this situation is appreciated.
As several people responded that I should report the issues I just did that
and reported the following bug reports against GTK:
* CSD styled windows don't react on compositing cha
On Thursday 08 May 2014 14:39:49 Matthias Klumpp wrote:
> 2014-05-08 9:31 GMT+02:00 Martin Gräßlin :
> > Martin GräßlinOn Wednesday 07 May 2014 10:11:37 wrote:
> >> Any advice on how to handle this situation is appreciated.
> >
> > As several people responded tha
On Friday 09 May 2014 09:54:53 John Layt wrote:
> On 8 May 2014 13:56, Sebastian Kügler wrote:
> > On Thursday, May 08, 2014 14:39:49 Matthias Klumpp wrote:
> >> However, to support the cross-desktop efforts, the GNOME people should
> >> maybe make a few compromises (e.g. make GTK+ behave differen
On Friday 09 May 2014 09:42:50 Daniel Nicoletti wrote:
> +Martin,
> does clicking on the shadow drawn by the window
> also prevents you from say focusing the window
> below (when no windeco is in place)? As from what
> I understood there is no hint margins.
> Maybe add this to your big list :P
Jus
started port to
xcb and thus Qt5, see https://git.reviewboard.kde.org/r/114178/
- Martin Gräßlin
On May 12, 2014, 3:36 a.m., Uzair Shamim wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit
is method is not yet
ported. See the #if 0 which indicates that this code has not been adjusted to
xcb yet.
- Martin Gräßlin
On May 27, 2014, 11:02 p.m., shivam makkar wrote:
>
> ---
> This is an automatically generated
for the signals. But I'm not
sure whether we can extend it to catch this condition (we don't have a BSD CI
system yet).
- Martin Gräßlin
On June 5, 2014, 3:16 p.m., Wolfgang Bauer wrote:
>
> ---
> This is an automatical
Review Request,
though.
The review request made me wonder whether we still need to find XLib in Oxygen,
though. The parts shown only use XCB, so maybe we could just go for finding
only XCB?
- Martin Gräßlin
On June 15, 2014, 2:47 p.m., Bernd Steinhauser wrote
> On May 28, 2014, 8:10 a.m., Martin Gräßlin wrote:
> > kcms/keyboard/kcmmisc.cpp, lines 77-78
> > <https://git.reviewboard.kde.org/r/118366/diff/2/?file=275630#file275630line77>
> >
> > for new connects I would use the new compile time checked syntax.
>
g/r/118898/#comment42380>
please use a copyright header as in
http://techbase.kde.org/Policies/Licensing_Policy#GPL_Header
kcmkgamma/init_kgamma.cpp
<https://git.reviewboard.kde.org/r/118898/#comment42381>
why delete config? I would just use a KSharedConfig::openConfig
- Ma
> On June 23, 2014, 5:13 p.m., Martin Gräßlin wrote:
> > kcmkgamma/init_kgamma.cpp, line 39
> > <https://git.reviewboard.kde.org/r/118898/diff/1/?file=283881#file283881line39>
> >
> > why delete config? I would just use a KSharedConfig::openConfig
>
>
go, and I'm
> afraid no one noticed (the bug's CC list is empty...)
In comment #5 you are asked to use review board. Bugzilla is very bad in
tracking or reviewing patches, that's why we have a dedicated application for
it.
Cheers
Martin Gräßlin
signature.asc
Description: This is a digitally signed message part.
On Wednesday 09 July 2014 10:23:59 Kevin Ottens wrote:
> On Wednesday 09 July 2014 10:15:03 David Faure wrote:
> > On Saturday 28 June 2014 08:51:42 Rodrigo Bonifacio wrote:
> > > Dear all, is there any code guideline that recommends developers to
> > > avoid
> > > the use of exception handling mec
224>
what's the "RJVB 20140706" standing for?
- Martin Gräßlin
On July 12, 2014, 4:22 p.m., Marko Käning wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https:/
tps://git.reviewboard.kde.org/r/118180/#comment43523>
here the coding style looks wrong
- Martin Gräßlin
On June 5, 2014, 12:32 p.m., TOM Harrison wrote:
>
> ---
> This is an automatically generated e-mail. To reply,
On Saturday 09 August 2014 17:34:04 Kevin Krammer wrote:
> Greetings all,
>
> I'd like to ask if there is any interest of having a BoF around the topic of
> script language based extensions for KDE applications.
>
> Some applications already offer that, e.g. Kate, and Plasma is even designed
> ar
On Saturday 13 September 2014 16:51:15 Albert Astals Cid wrote:
> El Divendres, 12 de setembre de 2014, a les 22:52:40, Marco Martin va
>
> escriure:
> > On Tuesday, September 9, 2014, Jan Kundrát wrote:
> > > If you would like all plasma to go, just give me a list of repos and I
> >
> > can mak
On Saturday 13 September 2014 20:38:21 Eike Hein wrote:
> The argument "but you can still bypass Gerrit and push
> directly, this is just social etiquette" doesn't matter
> because the whole thing is about social etiquette. The
> ACLs we already have reflect our social etiquette, and
> that means w
On Wednesday 03 September 2014 14:36:48 Paulo Lieuthier wrote:
> Hello everyone,
>
> I'm a LXQt contributor and I've been working on getting it rid of Xlib calls
> by using KF5's WindowSystem. It looks nice so far.
>
> The problem I'm having now is that I can't get the taskbar to indicate a
> win
an inintended change
- Martin Gräßlin
On Sept. 19, 2014, 8:13 nachm., René J.V. Bertin wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https:/
> On Sept. 19, 2014, 10:24 nachm., Martin Gräßlin wrote:
> > kcontrol/krdb/krdb.cpp, lines 544-548
> > <https://git.reviewboard.kde.org/r/120287/diff/1/?file=313477#file313477line544>
> >
> > this looks like an inintended change
>
> René J.V. Berti
db/krdb.cpp
<https://git.reviewboard.kde.org/r/120287/#comment46751>
why this change?
- Martin Gräßlin
On Sept. 19, 2014, 10:43 nachm., René J.V. Bertin wrote:
>
> ---
> This is an automatically generated
> On Sept. 19, 2014, 10:24 nachm., Martin Gräßlin wrote:
> > overall I rather tend to -1 for these changes. I consider changing the
> > build system in a long term release as way too risky considering that the
> > core development doesn't use this iteratio
db/krdb.cpp
<https://git.reviewboard.kde.org/r/120287/#comment46764>
added newline
libs/CMakeLists.txt
<https://git.reviewboard.kde.org/r/120287/#comment46763>
why is that Darwin and all other cases are APPLE?
- Martin Gräßlin
On Sept. 20, 2014, 12:05
> On Sept. 20, 2014, 10:20 vorm., Martin Gräßlin wrote:
> > CMakeLists.txt, lines 225-234
> > <https://git.reviewboard.kde.org/r/120287/diff/3/?file=313626#file313626line225>
> >
> > tabs instead of whitespaces
>
> René J.V. Bertin wrote:
> I lo
> On Sept. 20, 2014, 10:25 vorm., René J.V. Bertin wrote:
> > While we're discussing krdb's function on non-X11 systems:
> >
> > I seem to recall that the colour theme selector kcm had an effect like it
> > has under X11: applying the new theme to running applications instantly. I
> > can no l
> On Sept. 20, 2014, 10:20 vorm., Martin Gräßlin wrote:
> > libs/CMakeLists.txt, line 10
> > <https://git.reviewboard.kde.org/r/120287/diff/3/?file=313630#file313630line10>
> >
> > why is that Darwin and all other cases are APPLE?
>
> René J.V. Bertin
> On Sept. 20, 2014, 10:20 vorm., Martin Gräßlin wrote:
> > kcontrol/krdb/krdb.cpp, line 56
> > <https://git.reviewboard.kde.org/r/120287/diff/3/?file=313628#file313628line56>
> >
> > added newline
>
> René J.V. Bertin wrote:
> Ah, the famou
> On Sept. 20, 2014, 10:20 a.m., Martin Gräßlin wrote:
> > CMakeLists.txt, lines 225-234
> > <https://git.reviewboard.kde.org/r/120287/diff/3/?file=313626#file313626line225>
> >
> > tabs instead of whitespaces
>
> René J.V. Bertin wrote:
> I lo
g/r/120287/#comment46794>
so what's the point of the if now?
We have:
* Windows
* Apple
* Linux (by fontconfig)
libs/CMakeLists.txt
<https://git.reviewboard.kde.org/r/120287/#comment46793>
why don't you merge with NOT WIN32? In all other cases i
ole thing into a
if(NOT WIN32 AND NOT APPLE)
- Martin Gräßlin
On Sept. 20, 2014, 2:52 p.m., René J.V. Bertin wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.
> On Sept. 20, 2014, 3:51 p.m., Martin Gräßlin wrote:
> > CMakeLists.txt, lines 223-239
> > <https://git.reviewboard.kde.org/r/120287/diff/5/?file=313819#file313819line223>
> >
> > out of interest: this is now a huge NOT WIN32 block with two NOT APPLE
>
> On Sept. 20, 2014, 3:51 p.m., Martin Gräßlin wrote:
> > CMakeLists.txt, lines 223-239
> > <https://git.reviewboard.kde.org/r/120287/diff/5/?file=313819#file313819line223>
> >
> > out of interest: this is now a huge NOT WIN32 block with two NOT APPLE
>
> On Sept. 20, 2014, 3:51 p.m., Martin Gräßlin wrote:
> > CMakeLists.txt, lines 223-239
> > <https://git.reviewboard.kde.org/r/120287/diff/5/?file=313819#file313819line223>
> >
> > out of interest: this is now a huge NOT WIN32 block with two NOT APPLE
>
qguiplatformplugin_kde.cpp?
CMakeLists.txt
<https://git.reviewboard.kde.org/r/120287/#comment46909>
just as a note: kinfocenter shold(tm) work on macos. at least there is a
source file called info_osx.cpp
- Martin Gräßlin
On Sept. 22, 2014, 6:17 nachm., René J.V. Bertin
> On Sept. 22, 2014, 6:52 nachm., Martin Gräßlin wrote:
> > CMakeLists.txt, line 249
> > <https://git.reviewboard.kde.org/r/120287/diff/6/?file=314531#file314531line249>
> >
> > just as a note: kinfocenter shold(tm) work on macos. at least there is
>
framework.
- Martin Gräßlin
On Sept. 24, 2014, 5:45 p.m., René J.V. Bertin wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.
> On Sept. 24, 2014, 7:10 p.m., Martin Gräßlin wrote:
> > Please watch coding style and please also have a look at the frameworks
> > variant. It still needs porting to MacOS *hint,hint* and that would be
> > very, very appreciated. I recently sent a mail to frameworks-
> On Sept. 24, 2014, 7:10 p.m., Martin Gräßlin wrote:
> > Please watch coding style and please also have a look at the frameworks
> > variant. It still needs porting to MacOS *hint,hint* and that would be
> > very, very appreciated. I recently sent a mail to frameworks-
20354/#comment47053>
it's obvious that the include is needed, otherwise one wouldn't add it. I
think that comment is not adding any information
- Martin Gräßlin
On Sept. 25, 2014, 4:02 p.m., René J.V. Bertin wrote:
>
>
g/r/120354/#comment47057>
looks like an unrelated code line deletion.
- Martin Gräßlin
On Sept. 25, 2014, 4:58 p.m., René J.V. Bertin wrote:
>
> ---
> This is an automatically generated e-mail. To reply,
g/r/120354/#comment47058>
now there are two deleted lines...
- Martin Gräßlin
On Sept. 25, 2014, 5:22 p.m., René J.V. Bertin wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.rev
comment on the platform specific
code.
- Martin Gräßlin
On Sept. 25, 2014, 6:14 p.m., René J.V. Bertin wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.
w"(TM) (expect a script which
parses the output) I doubt it's a 4.11 material, but should rather go into a
feature release. Though that's just my personal opinion and I'm not a
contributor to ksysguard.
- Martin Gräßlin
On Sept. 28, 2014, 5:
hy do you want the
Netbook shell on OSX while on the other side you disabled the desktop shell?
AFAIK you cannot replace the shell of OSX, so having Netbook sounds pretty
useless to me.
- Martin Gräßlin
On Oct. 14, 2014, 6:06 p.m., René J.V. Bertin
> On Okt. 14, 2014, 6:38 nachm., Martin Gräßlin wrote:
> > I'm not understanding the changes in Plasma Netbook. Why do you want the
> > Netbook shell on OSX while on the other side you disabled the desktop
> > shell? AFAIK you cannot replace the shell of OSX
g to the screensaver.
>From the code it looks like KWallet closes all wallets when the screen locks.
- Martin Gräßlin
On Oct. 14, 2014, 1:58 p.m., René J.V. Bertin wrote:
>
> ---
> This is an automatically generated e-mail. To r
On Saturday 18 October 2014 15:34:53 Thomas Lübking wrote:
> You MUST check the hinted support window anyway, because if the WM was
> killed -9 or -11 it will unlikely (in case of -9 "no way") have withdrawn
> any root property and your findings based upon this data alone would be
> wrong.
>
> The
I for this. Most likely this will end
in a specific subclass exposing new virtuals.
* Various pieces in KWin, especially in the configuration area. Help is more
than welcome :-)
Best Regards
Martin Gräßlin
[1] kde:kdecoration
[2] kde:kdecoration-viewer
[3] kde:breeze (branch graesslin/kdecoratio
On Monday 03 November 2014 22:29:22 Albert Astals Cid wrote:
> El Divendres, 31 d'octubre de 2014, a les 08:22:53, Martin Gräßlin va
>
> escriure:
> > Hi KDE core developers,
> >
> > today I want to start the review process for the new KDecoration
> > l
On Monday 03 November 2014 23:33:15 Milian Wolff wrote:
> On Friday 31 October 2014 08:22:53 Martin Gräßlin wrote:
> > Hi KDE core developers,
> >
> > today I want to start the review process for the new KDecoration
> > library[1]. This library is intended to re
On Tuesday 04 November 2014 13:40:30 Milian Wolff wrote:
> > I'd rather stress "notice that the return value can be nullptr and change
> > during the lifetime of the DecoratedClient".
> >
> > The user can still do
> > Decoration *m_deco = m_client->decoration(); // fails at some point
> >
> > Ove
On Thursday 06 November 2014 13:31:57 Thomas Lübking wrote:
> decoration.h
> -
> borderLeft|Right|Bottom|Top
> Use QMargins here as well (they'll usually be required together)?
>
> extendedBorder*
> QMargins as well?. Also maybe "resizeOnlyBorder"? (extendedBorder is very
> generic)
w
On Thursday 06 November 2014 15:14:52 Thomas Lübking wrote:
> decoratedclient.h
> --
>
> "maximal available" -> "maximal possible"
> "borderingScreenEdges" -> "adjacentScreenEdges" or "touchedScreenEdges"
>
> additional request:
> void monitorProperty(const QString &prop, bool ono
On Thursday 06 November 2014 13:31:57 Thomas Lübking wrote:
> decoration.h
> -
> borderLeft|Right|Bottom|Top
> Use QMargins here as well (they'll usually be required together)?
addressed with:
* kdecoration: f4ab8e4
* kdecoration-viewer: 1a1bbad
* breeze: db43181
* kwin: 1c90ca9
>
>
On Thursday 06 November 2014 15:14:52 Thomas Lübking wrote:
> decorationdefines.h, decorationsettings.h
> -
> "BorderSize" - do we *really* want to keep this or rather allow
> pixel/pointwise configuration of 2,3, or 4 border sizes globally?
could you please
On Thursday 06 November 2014 15:14:52 Thomas Lübking wrote:
> decoratedclient.h
> --
>
> "maximal available" -> "maximal possible"
Addressed in 389ff3b
> "borderingScreenEdges" -> "adjacentScreenEdges" or "touchedScreenEdges"
Renamed to adjacentScreenEdges:
* kdecoration: f8d114
On Thursday 06 November 2014 15:14:52 Thomas Lübking wrote:
> decorationshadow.h
> --
> QSize topLeft() etc. etc.:
> a) shadow->topLeft() does not sound like a size
> b) the entire information (9 tiles) can also be provided by two rects
> (innerRect, outerRect) c) with a conv. func.
101 - 200 of 410 matches
Mail list logo
