On Feb. 19, 2014, 3:07 p.m., Alex Merry wrote:
I don't think papering over the X11-ness of kdesu like this is the right
approach. Of course, what this framework really needs is a test app; maybe
a simple port of the kdesu app from kde-runtime?
Kevin Ottens wrote:
This kind of
On March 4, 2014, 8:45 p.m., Kevin Ottens wrote:
And I agree with Aurélien, a bug should be filed and Stephen involved in
that issue.
Please provide a minimal testcase. The feature is unit tested in cmake. If it's
broken, it needs to be fixed soon (before the final 3.0 release).
-
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116608/
---
Review request for KDE Frameworks, Aleix Pol Gonzalez and Christoph Feck.
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116598/
---
(Updated March 5, 2014, 9 a.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116598/#review52029
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116088/#review52032
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116088/
---
(Updated March 5, 2014, 9:10 a.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115137/
---
(Updated March 5, 2014, 10:11 a.m.)
Status
--
This change has been
On March 4, 2014, 1:06 a.m., Aleix Pol Gonzalez wrote:
Ok, I just realized this was being dealt with and I did a different patch:
https://git.reviewboard.kde.org/r/116573/
I think that having UI strings on a header file is quite bad TBH, but since
I see there's consensus I'll
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116545/
---
(Updated March 5, 2014, 9:26 a.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116542/#review52036
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116544/
---
(Updated March 5, 2014, 9:27 a.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116541/
---
(Updated March 5, 2014, 9:27 a.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116541/#review52037
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116544/#review52038
---
This review has been submitted with commit
On Feb. 19, 2014, 2:07 p.m., Alex Merry wrote:
I don't think papering over the X11-ness of kdesu like this is the right
approach. Of course, what this framework really needs is a test app; maybe
a simple port of the kdesu app from kde-runtime?
Kevin Ottens wrote:
This kind of
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116609/#review52043
---
Ship it!
Ship It!
- David Edmundson
On March 5, 2014,
Hello,
On Tuesday 04 March 2014 22:54:42 David Faure wrote:
On Tuesday 04 March 2014 01:32:14 Michael Pyne wrote:
It wasn't that transparent at all - a number of modules have been re-
downloaded in a different location in my local source directory:
* plasma-frameworks moved under
Hello,
On Tuesday 04 March 2014 16:43:10 Jeremy Whiting wrote:
I've realized a bit ago that kspeech was not included in
the kdelibs split (probably because it was in staging at the time and
didn't conform to the other framework policies yet). I've cleaned it
up a bit and put it in my scratch
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116610/
---
Review request for KDE Frameworks.
Repository: kwindowsystem
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116609/
---
(Updated March 5, 2014, 9:51 a.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116609/#review52045
---
This review has been submitted with commit
See http://build.kde.org/job/kdelibs_stable/1027/changes
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116608/#review52048
---
Ship it!
Thanks, this supersedes 116603.
- Christoph Feck
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115875/#review52049
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116075/
---
(Updated March 5, 2014, 12:14 p.m.)
Review request for KDE Frameworks,
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116603/
---
(Updated March 5, 2014, 11:49 a.m.)
Review request for KDE Frameworks.
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116075/
---
(Updated March 5, 2014, 11:49 a.m.)
Status
--
This change has been
On Feb. 27, 2014, 9:54 a.m., Alex Merry wrote:
The problem with doing this in support code is that it is not strictly
source compatible. An example this would break is if you want to embed the
value of QT_QMAKE_EXECUTABLE into a C++ executable using something like
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116608/#review52058
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115207/#review52059
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115207/
---
(Updated March 5, 2014, 11:55 a.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116603/
---
(Updated March 5, 2014, 12:04 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116096/
---
(Updated March 5, 2014, 12:08 p.m.)
Review request for KDE Frameworks.
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116567/#review52065
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116567/#review52064
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116567/
---
(Updated March 5, 2014, 12:11 p.m.)
Status
--
This change has been
On Feb. 27, 2014, 9:54 a.m., Alex Merry wrote:
The problem with doing this in support code is that it is not strictly
source compatible. An example this would break is if you want to embed the
value of QT_QMAKE_EXECUTABLE into a C++ executable using something like
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116598/#review52067
---
Note that find_package(Wayland COMPONENTS Client Egl)
On March 5, 2014, 12:31 p.m., Alex Merry wrote:
Note that find_package(Wayland COMPONENTS Client Egl) *should* fail. What
shouldn't fail is find_package(Wayland OPTIONAL_COMPONENTS Client Egl).
I hadn't realised that about pkg_check_modules(), though. I'll have to update
the docs I
On March 5, 2014, 1:31 p.m., Alex Merry wrote:
Note that find_package(Wayland COMPONENTS Client Egl) *should* fail. What
shouldn't fail is find_package(Wayland OPTIONAL_COMPONENTS Client Egl).
Alex Merry wrote:
I hadn't realised that about pkg_check_modules(), though. I'll have
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116098/#review52076
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116098/#review52077
---
This review has been submitted with commit
On March 4, 2014, 8:45 p.m., Kevin Ottens wrote:
And I agree with Aurélien, a bug should be filed and Stephen involved in
that issue.
Stephen Kelly wrote:
Please provide a minimal testcase. The feature is unit tested in cmake.
If it's broken, it needs to be fixed soon (before the
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116561/
---
(Updated March 5, 2014, 1:47 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116561/#review52080
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116615/
---
Review request for KDE Frameworks, David Faure and Kevin Ottens.
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116616/
---
Review request for Build System, Extra Cmake Modules and KDE Frameworks.
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116615/#review52086
---
Ship it!
This function will be removed before KDE4 is
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116615/
---
(Updated March 5, 2014, 3:05 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116616/#review52202
---
Ship it!
Ship It!
- Kevin Ottens
On March 5, 2014, 2:31
Hello,
Catching up with KF5 progress...
On Tuesday, March 04, 2014 04:59:58 PM Kevin Ottens wrote:
* Repository merges for kwallet and kdnssd still reported as pending...
What's that? Is that about merging 4.xx repository with the KF5 one?
* afiestas has kwallet patches in need of review,
Hello,
On Thursday 06 March 2014 02:13:36 Valentin Rusu wrote:
Catching up with KF5 progress...
On Tuesday, March 04, 2014 04:59:58 PM Kevin Ottens wrote:
* Repository merges for kwallet and kdnssd still reported as pending...
What's that? Is that about merging 4.xx repository with the
On Jan. 28, 2014, 5:49 p.m., Aleix Pol Gonzalez wrote:
Should we even comment/remove them? Doesn't seem like anybody's going to
read this output ever...
Ping, can someone tell me what to do with this? Can I either push this change
or remove the output altogether?
- Milian
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115351/#review52053
---
Heh, the Git history looks very sad in this part of kdelibs.
On March 4, 2014, 7:42 p.m., David Faure wrote:
I don't get it. What's the problem with sending a mimetype for empty files?
I would think this is actually expected - for all files, including empty
ones. Why does this fix the bug?
It fails and ends up sending an error message. See the
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116122/
---
(Updated March 5, 2014, 2:01 p.m.)
Review request for kdelibs, Andrea
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116604/#review52091
---
src/meinproc.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115351/#review52204
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115351/
---
(Updated March 5, 2014, 7:11 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116555/#review52218
---
Ship it!
Ship It!
- Valentin Rusu
On March 2, 2014, 11:33
On March 3, 2014, 11:57 p.m., Albert Astals Cid wrote:
The Beta 1 of 4.13 is on Wednesday. Can the maintainer of the code affected
by this give a evaluation of how dangerous this patch is and his
recommendation for the Freeze exception?
Oh, I only see this now. Is it too late?
-
Hello,
Catching up with KF5 progress...
On Tuesday, March 04, 2014 04:59:58 PM Kevin Ottens wrote:
* Repository merges for kwallet and kdnssd still reported as pending...
What's that? Is that about merging 4.xx repository with the KF5 one?
* afiestas has kwallet patches in need of review,
Hello,
On Thursday 06 March 2014 02:13:36 Valentin Rusu wrote:
Catching up with KF5 progress...
On Tuesday, March 04, 2014 04:59:58 PM Kevin Ottens wrote:
* Repository merges for kwallet and kdnssd still reported as pending...
What's that? Is that about merging 4.xx repository with the
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115877/#review52046
---
ConfigureChecks.cmake
On March 5, 2014, 11:53 a.m., David Edmundson wrote:
ConfigureChecks.cmake, line 1
https://git.reviewboard.kde.org/r/115877/diff/1/?file=244871#file244871line1
Why rename this from FindXattr.cmake?
it's basically doing the same thing, but searching in more places?
Hi,
I'm using Choqok's MediaManager to download images from twitter, but
without success.
For downloading the image the MediaManager uses the following piece of code:
KIO::Job *job = KIO::storedGet( srcUrl, KIO::NoReload,
KIO::HideProgressInfo);
srcUrl contains the correct image url (as KUrl).
Em qua 05 mar 2014, às 22:22:53, Daniel Kreuter escreveu:
Hi,
I'm using Choqok's MediaManager to download images from twitter, but
without success.
For downloading the image the MediaManager uses the following piece of code:
KIO::Job *job = KIO::storedGet( srcUrl, KIO::NoReload,
Hi,
I don't use a proxy. And for the profile images the code works but not for
other images.
Cheers
Daniel
Von meinem iPhone gesendet
Am 05.03.2014 um 22:53 schrieb Thiago Macieira thi...@kde.org:
Em qua 05 mar 2014, às 22:22:53, Daniel Kreuter escreveu:
Hi,
I'm using Choqok's
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115877/#review52215
---
This review has been submitted with commit
70 matches
Mail list logo