Re: Review Request 119805: Use svn export to fetch KDE identities if possible, and cache them

2014-08-17 Thread Denis Steckelmacher
On Aug. 16, 2014, 7:46 p.m., Denis Steckelmacher wrote: Great work! I've tested this patch in this configuration and it works: no PySVN, SVN installed, Python 2. I have one question, though: why do you try to get the temporary path for the cached file using three different

Re: Review Request 119809: KIO: New job RestoreJob, public API KIO::restoreFromTrash().

2014-08-17 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119809/ --- (Updated Aug. 17, 2014, 9:01 a.m.) Review request for KDE Frameworks and

Re: kio_trash

2014-08-17 Thread Alex Merry
On Sunday 17 August 2014 00:03:41 David Faure wrote: kio_trash is currently in kde-workspace/kio-extras, but KIO actually offers API that depends on kio_trash (KIO::trash(), JobUiDelegateExtension::Trash, support for trash in FileUndoManager, and I'm about to add a KIO::restoreFromTrash job).

Re: Review Request 119805: Use svn export to fetch KDE identities if possible, and cache them

2014-08-17 Thread Alex Merry
On Aug. 16, 2014, 7:46 p.m., Denis Steckelmacher wrote: Great work! I've tested this patch in this configuration and it works: no PySVN, SVN installed, Python 2. I have one question, though: why do you try to get the temporary path for the cached file using three different

Re: Review Request 119805: Use svn export to fetch KDE identities if possible, and cache them

2014-08-17 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119805/ --- (Updated Aug. 17, 2014, 10:10 a.m.) Review request for KDE Frameworks

Re: Review Request 119781: Port TextArea to QtControls

2014-08-17 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119781/#review64672 ---

Re: Review Request 119781: Port TextArea to QtControls

2014-08-17 Thread Marco Martin
On Aug. 17, 2014, 1:38 p.m., David Edmundson wrote: src/declarativeimports/plasmacomponents/qml/styles/TextAreaStyle.qml, line 30 https://git.reviewboard.kde.org/r/119781/diff/2/?file=305297#file305297line30 I can see why you're doing this but I think this approach is a bit

Re: Review Request 119781: Port TextArea to QtControls

2014-08-17 Thread David Edmundson
On Aug. 17, 2014, 1:38 p.m., David Edmundson wrote: src/declarativeimports/plasmacomponents/qml/styles/TextAreaStyle.qml, line 30 https://git.reviewboard.kde.org/r/119781/diff/2/?file=305297#file305297line30 I can see why you're doing this but I think this approach is a bit

Re: Review Request 119809: KIO: New job RestoreJob, public API KIO::restoreFromTrash().

2014-08-17 Thread Emmanuel Pescosta
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119809/#review64687 --- src/core/restorejob.cpp

Jenkins build became unstable: ktexteditor_master_qt5 #583

2014-08-17 Thread KDE CI System
See http://build.kde.org/job/ktexteditor_master_qt5/583/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build is back to stable : ktexteditor_master_qt5 #584

2014-08-17 Thread KDE CI System
See http://build.kde.org/job/ktexteditor_master_qt5/584/changes ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 119809: KIO: New job RestoreJob, public API KIO::restoreFromTrash().

2014-08-17 Thread David Faure
On Aug. 17, 2014, 6:07 p.m., Emmanuel Pescosta wrote: src/core/restorejob.cpp, line 36 https://git.reviewboard.kde.org/r/119809/diff/2/?file=305769#file305769line36 constBegin() because m_urlsIterator is a const iterator I compile with -DQT_STRICT_ITERATORS so the compiler tells me

Re: Review Request 119809: KIO: New job RestoreJob, public API KIO::restoreFromTrash().

2014-08-17 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119809/ --- (Updated Aug. 17, 2014, 9:38 p.m.) Review request for KDE Frameworks and

Re: Is Konqueror still a live project?

2014-08-17 Thread Nowardev-Team
well , in my daily usage i have seen this : firefox renders better webpages : it's a standard for web browsing , this is an average opinion , i mean there are website where firefox doesn't work well , instead chromium and konqueror do. chromium, is integrated better in kde , for example if you

Re: Review Request 118448: Use KCalendarSystem to get the list of the month and day names that should be recognized by the query parser

2014-08-17 Thread Denis Steckelmacher
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118448/ --- (Updated Aug. 17, 2014, 11:34 a.m.) Review request for Baloo,

Re: Is Konqueror still a live project?

2014-08-17 Thread Thiago Macieira
On Sunday 17 August 2014 12:56:41 Nowardev-Team wrote: rekonq : it's something that is in the middle it's lighter but it lacks of a lots of stuff and it doesn't render well pages , bank websites etc, so i don't use it . finally my love konqueror , LOL i like it even if it has problems , and

Re: Is Konqueror still a live project?

2014-08-17 Thread Thomas Lübking
On Sonntag, 17. August 2014 18:38:29 CEST, Thiago Macieira wrote: Konqueror and rekonq use the same engine. So what one renders, so does the other. The may ship with different defaults for khtml or webkit as backend. (Actually rekonq might even be linked to a newer version of QtWebkit in his

Re: Review Request 119789: Baloo:Add config option to index only filenames

2014-08-17 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119789/#review64688 --- Nice work. Just out of curiosity, is this something you need

Re: KDE applications 4.14 LTS or 4.15?

2014-08-17 Thread Christoph Feck
On Wednesday 04 June 2014 23:00:26 Albert Astals Cid wrote: Ok, so basically do: * 4.14 as planned * 4.15 but we don't call it 4.15 and we call it 14.12 and contains kdelibs4/qt4 and kf5 based applications How do we manage which branches are used for the next application releases? Let's

Re: KDE applications 4.14 LTS or 4.15?

2014-08-17 Thread Albert Astals Cid
El Diumenge, 17 d'agost de 2014, a les 21:47:09, Christoph Feck va escriure: On Wednesday 04 June 2014 23:00:26 Albert Astals Cid wrote: Ok, so basically do: * 4.14 as planned * 4.15 but we don't call it 4.15 and we call it 14.12 and contains kdelibs4/qt4 and kf5 based applications

Re: Review Request 118448: Use KCalendarSystem to get the list of the month and day names that should be recognized by the query parser

2014-08-17 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118448/#review64691 --- To me it looks reasonable. I'll let the final decision to

Re: Review Request 119789: Baloo:Add config option to index only filenames

2014-08-17 Thread Pinak Ahuja
On Aug. 17, 2014, 6:57 p.m., Vishesh Handa wrote: Nice work. Just out of curiosity, is this something you need or is just a simple bug to fix? Also, maybe we should be adding a unit test for this. It is a bit of both. I was looking for a simple bugfix to get involved and this looked