On April 23, 2015, 1:32 p.m., Aleix Pol Gonzalez wrote:
daemon/backends/upower/powerdevilupowerbackend.cpp, line 161
https://git.reviewboard.kde.org/r/123475/diff/1/?file=362676#file362676line161
Is it fine to use exec() here?
no, I missed that one :-(
- Martin
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123475/
---
(Updated April 24, 2015, 8:29 a.m.)
Review request for Solid and Kai Uwe
On Friday, April 24, 2015 17:24:34 Christian Gagneraud wrote:
Hi there,
I've just installed kubuntu-15.04, and I'm trying to run this tutorial
[1]. I'm using stock Qt5, KF5 and Qt Creator.
In my .pro file, I have QT += KXmlGui KI18n KTextWidgets, but qmake
complains with Project ERROR:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123452/#review79421
---
Ship it!
Ship It!
- Kevin Funk
On April 21, 2015, 4:24
Hey all, esp. Jeremy.
I have a question regarding kdesrc-build: Is it possible to manage multiple
build configurations with kdesrc-build? Most notably, I'd like to have two
builds of all modules in my configuration: One CMAKE_BUILD_TYPE=Debug build
and a ...=RelWithDebInfo build.
This is an
On 24/04/15 19:35, Kevin Funk wrote:
On Friday, April 24, 2015 08:48:53 Kevin Funk wrote:
On Friday, April 24, 2015 17:24:34 Christian Gagneraud wrote:
Hi there,
I've just installed kubuntu-15.04, and I'm trying to run this tutorial
[1]. I'm using stock Qt5, KF5 and Qt Creator.
In my .pro
On April 20, 2015, 10:36 p.m., Thomas Pfeiffer wrote:
What would likely be confusing is that the two button modes have different
interaction flows: The End Process mode requires to first select a
process and then press the button to work, whereas the Kill specific
window mode
On Thursday, April 23, 2015 10:25:20 PM Valentin Rusu wrote:
Hello,
Please be advised sysadmins moved kwallet-query to kdereview for your
constructive critics.
You may found more informations about it here:
https://barlog.rusu.info/valentin/blog/?p=386
This is a rather simple script
On Thursday, April 23, 2015 11:44:36 PM Valentin Rusu wrote:
* Allen Winter allen.d.win...@gmail.com [2015-04-23 17:32:32 -0400]:
On Thursday, April 23, 2015 10:25:20 PM Valentin Rusu wrote:
This is a rather simple script and I think it should go to kde-utils.
I'd like to write a
On April 23, 2015, 11:33 p.m., Alex Richardson wrote:
src/lib/io/kdirwatch.cpp, line 303
https://git.reviewboard.kde.org/r/123479/diff/2/?file=362725#file362725line303
Why this manual loop instead of strlen()? Does that mean that null
characters in the middle are valid? Or, more
On Friday, April 24, 2015 20:34:33 Christian Gagneraud wrote:
On 24/04/15 19:35, Kevin Funk wrote:
On Friday, April 24, 2015 08:48:53 Kevin Funk wrote:
On Friday, April 24, 2015 17:24:34 Christian Gagneraud wrote:
Hi there,
I've just installed kubuntu-15.04, and I'm trying to run this
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123479/
---
(Updated April 24, 2015, 12:06 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123490/
---
Review request for KDE Frameworks.
Bugs: 346496
Hey all,
what's the best-practice to export symbols for tests only? In Qt, there is the
Q_AUTOTEST_EXPORT macro:
qglobal.h:
/*
No, this is not an evil backdoor. QT_BUILD_INTERNAL just exports more
symbols
for Qt's internal unit tests. If you want slower loading times and more
symbols
kxmlgui has a file kdepackages.h which lists the products in bugzilla.
This is used by the dialog in Help → Report Bug. It was horribly out of
date so I've synced it with current bugzilla.
David could you add to the release scripts to run
make_kdepackages_updated.py in kxmlgui before release?
Most of the frameworks I've seen do something like the following to
explicitely link in the cpp files needed for the test. This taken from
knewstuff/autotests/CMakeLists.txt
macro(knewstuff_unit_tests)
foreach(_testname ${ARGN})
add_executable(${_testname} ${_testname}.cpp
On abr. 24, 2015, 3:36 p.m., Alex Merry wrote:
modules/ECMGeneratePriFile.cmake, lines 178-180
https://git.reviewboard.kde.org/r/123491/diff/2/?file=362992#file362992line178
I think there should be an argument that could be passed to disable
this (NO_TESTS?). Not all downstream
On April 24, 2015, 8:47 p.m., Matthew Dawson wrote:
autotests/kconfig_compiler/test13.cpp.ref, line 33
https://git.reviewboard.kde.org/r/123367/diff/7-8/?file=362762#file362762line33
Is there a reason this got moved back?
Well, Modified needs to be called together with Changed,
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123492/#review79480
---
Ship it!
Ship It!
- Aleix Pol Gonzalez
On April 24, 2015,
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123493/#review79481
---
Ship it!
Ship It!
- Aleix Pol Gonzalez
On April 24, 2015,
On Fri, Apr 24, 2015 at 4:41 PM, Milian Wolff m...@milianw.de wrote:
On Friday 24 April 2015 14:31:27 Aleix Pol wrote:
On Fri, Apr 24, 2015 at 2:17 PM, Milian Wolff m...@milianw.de wrote:
Hey all,
what's the best-practice to export symbols for tests only? In Qt, there is
the
On abr. 24, 2015, 3:21 p.m., Kevin Funk wrote:
Hm, this could cause problems in the case where you generate multiple .pri
files which depend on each other within one project. Problem .pri files are
not yet installed, thus the QT modules are not yet available.
I suggest trying this
On April 24, 2015, 3:49 p.m., Kevin Funk wrote:
modules/ECMGeneratePriFile.cmake, line 180
https://git.reviewboard.kde.org/r/123491/diff/2/?file=362992#file362992line180
Just tested the patch myself on sonnet.
The test indeed breaks if sonnet is not installed
On Friday 24 April 2015 05:52:40 Jeremy Whiting wrote:
Millian,
For that it should be adequate to have two separate config files. You
could leave one named ~/.kdesrc-buildrc and name the other
~/.debugkdesrc-buildrc or whatnot. Then to use the debug one, just
pass it to
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123491/#review79451
---
Cool stuff! :)
Maybe you can add some documentation
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123367/#review79450
---
autotests/kconfig_compiler/test13.cpp.ref (line 18)
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123491/#review79460
---
modules/ECMGeneratePriFile.cmake (line 179)
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123491/
---
Review request for Extra Cmake Modules, KDE Frameworks and Kevin Funk.
On Friday 24 April 2015 14:31:27 Aleix Pol wrote:
On Fri, Apr 24, 2015 at 2:17 PM, Milian Wolff m...@milianw.de wrote:
Hey all,
what's the best-practice to export symbols for tests only? In Qt, there is
the Q_AUTOTEST_EXPORT macro:
qglobal.h:
/*
No, this is not an evil
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123367/
---
(Updated April 25, 2015, 3:39 a.m.)
Review request for KDE Frameworks
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123367/#review79483
---
Ok, I think this should be last set of comments. One thing I
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123492/
---
Review request for KDE Frameworks and Plasma.
Repository:
On April 24, 2015, 3:36 p.m., Alex Merry wrote:
modules/ECMGeneratePriFile.cmake, lines 178-180
https://git.reviewboard.kde.org/r/123491/diff/2/?file=362992#file362992line178
I think there should be an argument that could be passed to disable
this (NO_TESTS?). Not all downstream
On abr. 24, 2015, 3:49 p.m., Kevin Funk wrote:
modules/ECMGeneratePriFile.cmake, line 180
https://git.reviewboard.kde.org/r/123491/diff/2/?file=362992#file362992line180
Just tested the patch myself on sonnet.
The test indeed breaks if sonnet is not installed beforehand.
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123367/
---
(Updated April 24, 2015, 6:56 p.m.)
Review request for KDE Frameworks
On Friday 24 April 2015 16:41:32 Milian Wolff wrote:
Or you want to conditionally define the Q_AUTOTEST_EXPORT depending on
whether BUILD_TESTING (cmake variable) is on?
This would add some differences into the libraries developersCI and
users use (which isn't ideal) but should be fine
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123493/
---
Review request for KDE Frameworks and Plasma.
Repository: kdeclarative
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123491/#review79452
---
Ship it!
modules/ECMGeneratePriFile.cmake (line 174)
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123491/
---
(Updated abr. 24, 2015, 3:26 p.m.)
Review request for Extra Cmake
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123367/#review79473
---
Looks good, one last comment:
On Friday, April 24, 2015 08:48:53 Kevin Funk wrote:
On Friday, April 24, 2015 17:24:34 Christian Gagneraud wrote:
Hi there,
I've just installed kubuntu-15.04, and I'm trying to run this tutorial
[1]. I'm using stock Qt5, KF5 and Qt Creator.
In my .pro file, I have QT += KXmlGui
Hi,
On Fri, Apr 24, 2015 at 8:48 AM, Kevin Funk kf...@kde.org wrote:
On Friday, April 24, 2015 17:24:34 Christian Gagneraud wrote:
Hi there,
I've just installed kubuntu-15.04, and I'm trying to run this tutorial
[1]. I'm using stock Qt5, KF5 and Qt Creator.
In my .pro file, I have
42 matches
Mail list logo
