Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 54 - Failure!

2015-09-10 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/54/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 10 Sep 2015 07:09:39 + Build duration: 1 min 0 sec CHANGE SET Revision

Adding further modules to api.kde.org

2015-09-10 Thread Martin Graesslin
Hi all, back in KDE4 days the workspace libraries were listed on api.kde.org [1]. But for the current version we don't have any API docs available. The section "Other KDE Software" [2] lists KDE Support, KDE Extragear and Playground but apparently nothing from what used to be KDE SC. Does

Re: Moving KDE Connect out of playground

2015-09-10 Thread Albert Vaca
+kde-core-devel Hi, With the latest changes we are making to KDE Connect as part of the sprint in Randa, I think that the project is becoming mature enough to be moved out of playground. Not only that, but Kubuntu and other distros are already installing KDE Connect by default, regardless of it

Moving KDE Connect out of playground

2015-09-10 Thread Albert Vaca
Hi, With the latest changes we are making to KDE Connect as part of the sprint in Randa, I think that the project is becoming mature enough to be moved out of playground. Not only that, but Kubuntu and other distros are already installing KDE Connect by default, regardless of it being in

Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 53 - Fixed!

2015-09-10 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/53/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 10 Sep 2015 07:05:29 + Build duration: 3 min 22 sec CHANGE SET Revision

Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 53 - Fixed!

2015-09-10 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/53/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 10 Sep 2015 07:05:29 + Build duration: 3 min 22 sec CHANGE SET Revision

Review Request 125130: Use actual method calls in mainadaptor instead of QMetaObject::invokeMethod

2015-09-10 Thread Pinak Ahuja
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125130/ --- Review request for Baloo, David Faure and Vishesh Handa. Repository:

Re: Review Request 125130: Use actual method calls in mainadaptor instead of QMetaObject::invokeMethod

2015-09-10 Thread Pinak Ahuja
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125130/ --- (Updated Sept. 10, 2015, 9:37 a.m.) Status -- This change has been

Re: Review Request 125125: Fix D-Bus API breaking compatibility with baloo KCM

2015-09-10 Thread Pinak Ahuja
> On Sept. 10, 2015, 6:38 a.m., David Faure wrote: > > src/file/mainadaptor.cpp, line 45 > > > > > > This could be a real method call instead, so that it doesn't break when > > someone renames/removes

Re: Review Request 125125: Fix D-Bus API breaking compatibility with baloo KCM

2015-09-10 Thread Pinak Ahuja
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125125/ --- (Updated Sept. 10, 2015, 7:36 a.m.) Status -- This change has been

Re: KF5 with qmake problems

2015-09-10 Thread David Faure
On Thursday 10 September 2015 07:57:11 Oswald Buddenhagen wrote: > On Sun, Sep 06, 2015 at 11:10:29AM +0200, David Faure wrote: > > This seems to be a bug in Qt. > > The code in qtAddModules (qtbase/mkspecs/features/qt_functions.prf ) > > turns "core gui KParts" into "core gui + all the deps from

Re: Moving KDE Connect out of playground

2015-09-10 Thread Albert Vaca
+kde-core-devel Hi, With the latest changes we are making to KDE Connect as part of the sprint in Randa, I think that the project is becoming mature enough to be moved out of playground. Not only that, but Kubuntu and other distros are already installing KDE Connect by default, regardless of it

Re: Review Request 125125: Fix D-Bus API breaking compatibility with baloo KCM

2015-09-10 Thread David Faure
> On Sept. 10, 2015, 6:38 a.m., David Faure wrote: > > src/file/mainadaptor.cpp, line 45 > > > > > > This could be a real method call instead, so that it doesn't break when > > someone renames/removes

Re: Moving KDE Connect out of playground

2015-09-10 Thread Harald Sitter
+1000 On Thu, Sep 10, 2015 at 10:32 AM, Albert Vaca wrote: > Hi, > > With the latest changes we are making to KDE Connect as part of the sprint > in Randa, I think that the project is becoming mature enough to be moved out > of playground. Not only that, but Kubuntu and

Jenkins-kde-ci: kservice master stable-kf5-qt5 » Linux,gcc - Build # 53 - Fixed!

2015-09-10 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kservice%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/53/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 10 Sep 2015 07:05:29 + Build duration: 1 min 56 sec CHANGE SET Revision

Jenkins-kde-ci: kservice master stable-kf5-qt5 » Linux,gcc - Build # 53 - Fixed!

2015-09-10 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kservice%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/53/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 10 Sep 2015 07:05:29 + Build duration: 1 min 56 sec CHANGE SET Revision

Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 55 - Fixed!

2015-09-10 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/55/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 10 Sep 2015 07:12:45 + Build duration: 2 min 7 sec CHANGE SET No changes JUNIT RESULTS Name:

Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 55 - Fixed!

2015-09-10 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/55/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 10 Sep 2015 07:12:45 + Build duration: 2 min 7 sec CHANGE SET No changes JUNIT RESULTS Name:

Re: QIcon::fromTheme(xxx, someFallback)

2015-09-10 Thread David Faure
On Wednesday 09 September 2015 10:24:23 Olivier Goffart wrote: > > I tried to optimize it by 'caching' the isNull value in QIconPrivate. > > But then the test failed: > http://code.woboq.org/qt5/qtbase/tests/auto/gui/image/qicon/tst_qicon.cpp.html#633 > In that test, the "address-book-new" was

Re: Review Request 125130: Use actual method calls in mainadaptor instead of QMetaObject::invokeMethod

2015-09-10 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125130/#review85089 --- Ship it! Looks good, thanks. Not sure which boilerplate

Re: Moving KDE Connect out of playground

2015-09-10 Thread Jeremy Whiting
+1 here too. On Thu, Sep 10, 2015 at 3:39 AM, Albert Vaca wrote: > +kde-core-devel > > Hi, > > With the latest changes we are making to KDE Connect as part of the sprint > in Randa, I think that the project is becoming mature enough to be moved out > of playground. Not only

Re: Moving KDE Connect out of playground

2015-09-10 Thread Jeremy Whiting
+1 here too. On Thu, Sep 10, 2015 at 3:39 AM, Albert Vaca wrote: > +kde-core-devel > > Hi, > > With the latest changes we are making to KDE Connect as part of the sprint > in Randa, I think that the project is becoming mature enough to be moved out > of playground. Not only

Re: [Kde-hardware-devel] Review Request 125026: Wayland implementation for DPMS

2015-09-10 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125026/ --- (Updated Sept. 10, 2015, 12:30 p.m.) Status -- This change has been

Re: Adding further modules to api.kde.org

2015-09-10 Thread Jeremy Whiting
Martin, I took a look at this as part of the gardening documentation websites, but I didn't get very far. The code that runs this and ebn is in kde:websites/quality-kde-org and is pretty outdated unfortunately. Actually now that Allen Winter is back maybe he could add it (Added him to cc)? What I

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 86 - Aborted!

2015-09-10 Thread no-reply
GENERAL INFO BUILD ABORTED Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/86/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 10 Sep 2015 11:32:05 + Build duration: 0.75 sec CHANGE SET No changes

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 79 - Aborted!

2015-09-10 Thread no-reply
GENERAL INFO BUILD ABORTED Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/79/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 10 Sep 2015 11:32:05 + Build duration: 0.43 sec CHANGE SET No changes

Re: Moving KDE Connect out of playground

2015-09-10 Thread Luigi Toscano
On Thursday 10 of September 2015 02:33:55 Albert Vaca wrote: > +kde-core-devel > > Hi, > > With the latest changes we are making to KDE Connect as part of the sprint > in Randa, I think that the project is becoming mature enough to be moved > out of playground. Not only that, but Kubuntu and

Re: Moving KDE Connect out of playground

2015-09-10 Thread Luigi Toscano
On Thursday 10 of September 2015 02:33:55 Albert Vaca wrote: > +kde-core-devel > > Hi, > > With the latest changes we are making to KDE Connect as part of the sprint > in Randa, I think that the project is becoming mature enough to be moved > out of playground. Not only that, but Kubuntu and

Re: Adding further modules to api.kde.org

2015-09-10 Thread Adriaan de Groot
On Thursday 10 September 2015 06:07:40 Jeremy Whiting wrote: > It would be awesome to have what used to be in KDE SC on api.kde.org > again. We have many libraries that aren't frameworks that are Qt5/KF5 > based which would be good to show on there imo. Perhaps half of this is figuring out what

Re: Adding further modules to api.kde.org

2015-09-10 Thread Jeremy Whiting
Well, it's not even just about workspace, we had in kde4 times kdeedu, kdegames, etc. etc. all on api.kde.org. Not all of it was api per se (I don't know anyone that would want to read the apidocs for kanagram for example, except to know how it's internals work or used to work when hacking on it).

Re: Moving KDE Connect out of playground

2015-09-10 Thread Albert Vaca
+kde-core-devel Hi, With the latest changes we are making to KDE Connect as part of the sprint in Randa, I think that the project is becoming mature enough to be moved out of playground. Not only that, but Kubuntu and other distros are already installing KDE Connect by default, regardless of it

Re: Review Request 125097: Icons for hiding/unhiding files

2015-09-10 Thread Emmanuel Pescosta
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125097/#review85127 --- Please add andreask as reviewer, so that we get these icons

Re: Moving KDE Connect out of playground

2015-09-10 Thread Filipe Saraiva
Em 10-09-2015 05:32, Albert Vaca escreveu: > Hi, > > With the latest changes we are making to KDE Connect as part of the > sprint in Randa, I think that the project is becoming mature enough to > be moved out of playground. Not only that, but Kubuntu and other > distros are already installing KDE

Re: Review Request 125097: Icons for hiding/unhiding files

2015-09-10 Thread andreas kainz
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125097/#review85144 --- hi, we have hint

folder icons where should they be set

2015-09-10 Thread Harald Sitter
salut mes amis so this popped up https://bugs.kde.org/show_bug.cgi?id=352498 and GTK/Gnome rather seems to set the folder icon as part of their folder-display-component sort of thing (e.g. file open as well as file browsers and what not). it does so however *without* creating a .directory file

folder icons where should they be set

2015-09-10 Thread Harald Sitter
salut mes amis so this popped up https://bugs.kde.org/show_bug.cgi?id=352498 and GTK/Gnome rather seems to set the folder icon as part of their folder-display-component sort of thing (e.g. file open as well as file browsers and what not). it does so however *without* creating a .directory file

folder icons where should they be set

2015-09-10 Thread Harald Sitter
salut mes amis so this popped up https://bugs.kde.org/show_bug.cgi?id=352498 and GTK/Gnome rather seems to set the folder icon as part of their folder-display-component sort of thing (e.g. file open as well as file browsers and what not). it does so however *without* creating a .directory file

Re: RFC: Enabling -DECM_ENABLE_SANITIZERS='address' in jenkins

2015-09-10 Thread Albert Astals Cid
El Dijous, 10 de setembre de 2015, a les 18:20:19, Lamarque Souza va escriure: > I agree but there is a problem: it can catch a lot of errors in our > dependency libraries (upstream bugs). No, it can not, asan works only on code you have compiled with asan enabled (which for most of our

Re: Review Request 125097: Icons for hiding/unhiding files

2015-09-10 Thread andreas kainz
> On Sept. 10, 2015, 9:29 p.m., andreas kainz wrote: > > hi, we have > > hint https://dl.dropboxusercontent.com/u/1642456/VDG/KF5/hint.svg and > > visibility > > https://dl.dropboxusercontent.com/u/1642456/VDG/KF5/visibility.svg > > in the kde:breeze Plasma/5.4 brunch and on 13.09. in master.

Re: QIcon::fromTheme(xxx, someFallback)

2015-09-10 Thread Michael Pyne
On Thu, September 10, 2015 09:16:11 David Faure wrote: > On Wednesday 09 September 2015 10:24:23 Olivier Goffart wrote: > > I tried to optimize it by 'caching' the isNull value in QIconPrivate. > > > > But then the test failed: > >

Re: Review Request 125097: Icons for hiding/unhiding files

2015-09-10 Thread Roman Gilg
> On Sept. 10, 2015, 11:29 p.m., andreas kainz wrote: > > hi, we have > > hint https://dl.dropboxusercontent.com/u/1642456/VDG/KF5/hint.svg and > > visibility > > https://dl.dropboxusercontent.com/u/1642456/VDG/KF5/visibility.svg > > in the kde:breeze Plasma/5.4 brunch and on 13.09. in master.

Re: [Kde-hardware-devel] Review Request 123263: WIP: KDE Connect backend for Solid

2015-09-10 Thread Aleix Pol Gonzalez
> On July 31, 2015, 9:38 p.m., Aleix Pol Gonzalez wrote: > > Is it done yet? What's the status? > > Kai Uwe Broulik wrote: > I don't know, someone marked it as submitted but it cearly isn't. > > Albert Vaca Cintora wrote: > What's left before we can merge it? Bump. - Aleix

Re: Adding further modules to api.kde.org

2015-09-10 Thread Allen Winter
On Thursday, September 10, 2015 01:55:21 PM Jeremy Whiting wrote: > Allen, > > Those are both KDE4 versions of workspace stuff. I don't see any place > where kf5 versions are. > oh. sorry I misunderstood the problem. > > On Thu, Sep 10, 2015 at 1:50 PM, Allen Winter wrote: >

Re: Adding further modules to api.kde.org

2015-09-10 Thread Allen Winter
On Thursday, September 10, 2015 10:57:10 AM Martin Graesslin wrote: > Hi all, > > back in KDE4 days the workspace libraries were listed on api.kde.org [1]. But > for the current version we don't have any API docs available. The section > "Other KDE Software" [2] lists KDE Support, KDE Extragear

Re: Adding further modules to api.kde.org

2015-09-10 Thread Jeremy Whiting
Allen, Those are both KDE4 versions of workspace stuff. I don't see any place where kf5 versions are. BR, Jeremy On Thu, Sep 10, 2015 at 1:50 PM, Allen Winter wrote: > On Thursday, September 10, 2015 10:57:10 AM Martin Graesslin wrote: >> Hi all, >> >> back in KDE4 days the

Review Request 125145: Restore the disabling of auto-rebuild-on-error in kbuildsycoca.

2015-09-10 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125145/ --- Review request for KDE Frameworks and Albert Astals Cid. Repository:

Re: Review Request 125144: Provide enabled property for QIconItem.

2015-09-10 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125144/#review85135 --- Ship it! Looks good. How come this class is so

Re: Moving KDE Connect out of playground

2015-09-10 Thread Aleix Pol
On Thu, Sep 10, 2015 at 2:20 PM, Luigi Toscano wrote: > On Thursday 10 of September 2015 02:33:55 Albert Vaca wrote: >> +kde-core-devel >> >> Hi, >> >> With the latest changes we are making to KDE Connect as part of the sprint >> in Randa, I think that the project is

Re: Moving KDE Connect out of playground

2015-09-10 Thread Aleix Pol
On Thu, Sep 10, 2015 at 2:20 PM, Luigi Toscano wrote: > On Thursday 10 of September 2015 02:33:55 Albert Vaca wrote: >> +kde-core-devel >> >> Hi, >> >> With the latest changes we are making to KDE Connect as part of the sprint >> in Randa, I think that the project is

Review Request 125144: Provide enabled property for QIconItem.

2015-09-10 Thread Andreas Cord-Landwehr
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125144/ --- Review request for KDE Frameworks and Marco Martin. Repository:

RFC: Enabling -DECM_ENABLE_SANITIZERS='address' in jenkins

2015-09-10 Thread Albert Astals Cid
We have this nice ECM module that gives us the option to compile with ASAN. I'd like to propose that we enable it by default in jenkins. This way we get all the autotests run with ASAN and potentially catch more bugs/regressions. Comments? Cheers, Albert

Re: Porting to frameworks 3: Krfb

2015-09-10 Thread Jeremy Whiting
If anyone using kde-telepathy is interested I just reenabled the ktp support in krfb frameworks branch (but I haven't set up ktp locally yet to test). BR, Jeremy On Sun, Sep 6, 2015 at 3:39 PM, Jeremy Whiting wrote: > Ah, another note. Sysadmin kindly created a phabricator

Re: Review Request 125145: Restore the disabling of auto-rebuild-on-error in kbuildsycoca.

2015-09-10 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125145/#review85136 --- What about removing s_autoRebuild and making

Re: Review Request 125145: Restore the disabling of auto-rebuild-on-error in kbuildsycoca.

2015-09-10 Thread David Faure
> On Sept. 10, 2015, 8:39 p.m., Albert Astals Cid wrote: > > What about removing s_autoRebuild and making KSycoca::disableAutoRebuild > > output a warning just in case someone weird out there is using it so they > > can get ready for KF6? Good point, that's indeed the alternative. It's less

Re: Review Request 125145: Restore the disabling of auto-rebuild-on-error in kbuildsycoca.

2015-09-10 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125145/ --- (Updated Sept. 10, 2015, 8:51 p.m.) Review request for KDE Frameworks

Re: Review Request 125145: Restore the disabling of auto-rebuild-on-error in kbuildsycoca.

2015-09-10 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125145/#review85142 --- Ship it! Ship It! - Albert Astals Cid On set. 10, 2015,

Review Request 125148: Call parent ::event()

2015-09-10 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125148/ --- Review request for KDE Frameworks. Repository: kdelibs4support

Re: Review Request 125145: Restore the disabling of auto-rebuild-on-error in kbuildsycoca.

2015-09-10 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125145/ --- (Updated Sept. 10, 2015, 9:17 p.m.) Status -- This change has been

Re: RFC: Enabling -DECM_ENABLE_SANITIZERS='address' in jenkins

2015-09-10 Thread Lamarque Souza
I agree but there is a problem: it can catch a lot of errors in our dependency libraries (upstream bugs). I had this problem when I used it with a program I develop at my work. Enabling it for all programs at once and fixing all those upstream bugs can be overwhelming. Maybe we should do it for a

Re: Review Request 125125: Fix D-Bus API breaking compatibility with baloo KCM

2015-09-10 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125125/#review85084 --- src/file/mainadaptor.cpp (line 45)

Re: Review Request 125121: Move checkGlobalHeader() within KBuildSycoca::recreate().

2015-09-10 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125121/ --- (Updated Sept. 10, 2015, 6:39 a.m.) Status -- This change has been

Re: Review Request 125108: kbuildsycoca: remove code for --checkstamps and --nocheckfiles.

2015-09-10 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125108/ --- (Updated Sept. 10, 2015, 6:39 a.m.) Status -- This change has been

Jenkins-kde-ci: kservice master stable-kf5-qt5 » Linux,gcc - Build # 52 - Failure!

2015-09-10 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kservice%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/52/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 10 Sep 2015 06:40:14 + Build duration: 1 min 53 sec CHANGE SET Revision

Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 52 - Failure!

2015-09-10 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/52/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 10 Sep 2015 06:40:14 + Build duration: 1 min 48 sec CHANGE SET Revision

Re: Review Request 125125: Fix D-Bus API breaking compatibility with baloo KCM

2015-09-10 Thread Pinak Ahuja
> On Sept. 10, 2015, 6:38 a.m., David Faure wrote: > > src/file/mainadaptor.cpp, line 45 > > > > > > This could be a real method call instead, so that it doesn't break when > > someone renames/removes

Re: KF5 with qmake problems

2015-09-10 Thread Oswald Buddenhagen
On Sun, Sep 06, 2015 at 11:10:29AM +0200, David Faure wrote: > This seems to be a bug in Qt. > The code in qtAddModules (qtbase/mkspecs/features/qt_functions.prf ) > turns "core gui KParts" into "core gui + all the deps from KParts". But > KParts itself is missing. > > If I change > #