[Differential] [Commented On] D4799: Delay notifications until desktop session has loaded

2017-02-25 Thread Martin Gräßlin
graesslin added a comment. I would say it is enough to just make plasma grab the interface early enough. It would result in the popups not show. We don't need to show those notifications. It is a bug in ksplash that the popups are visible at all. Another alternative could be to

[Differential] [Commented On] D4799: Delay notifications until desktop session has loaded

2017-02-25 Thread Martin Klapetek
mck182 added a comment. > 1. A quick check if KSplashQML is found in the processes list (afaics, there's no alternatives to ksplash) > 2. KNotifications could send an async call to KSplash with a very quick timeout and start deciding on its queued notifications if/after the answer arrives

[Differential] [Accepted] D4778: Add include that is needed in msys2

2017-02-25 Thread Kevin Funk
kfunk accepted this revision. This revision is now accepted and ready to land. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D4778 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: russellg, #frameworks, kfunk Cc: kfunk

[Differential] [Commented On] D4663: Allow setting the timeout value.

2017-02-25 Thread Martin Klapetek
mck182 added a comment. To expand on what Thomas said, SNI is just a specification, the implementation is fully up to the shells. We chose to implement it as systray icons, but some innovation there could take it to much different places. So far nobody has come with ideas of what that

Re: Review Request 125641: Allow PAM unlocking of a running wallet

2017-02-25 Thread Martin Klapetek
> On Feb. 25, 2017, 11:55 p.m., Albert Astals Cid wrote: > > Martin, Valentin, should I commit this? I honestly don't know what the state of this and/or the component(s) that needed it is. It was mainly meant for Plasma Mobile, no idea about that project either. I guess it should still work,

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 443 - Fixed!

2017-02-25 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/443/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 26 Feb 2017 04:55:04 + Build duration: 22 min CHANGE SET Revision b872213c5e247dd43ca55080095b14a5678e519e

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 443 - Fixed!

2017-02-25 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/443/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 26 Feb 2017 04:55:04 + Build duration: 22 min CHANGE SET Revision b872213c5e247dd43ca55080095b14a5678e519e

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,All,gcc - Build # 355 - Fixed!

2017-02-25 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/355/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Sun, 26 Feb 2017 04:55:59 + Build duration: 2 min 18 sec CHANGE SET Revision

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,All,gcc - Build # 355 - Fixed!

2017-02-25 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/355/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Sun, 26 Feb 2017 04:55:59 + Build duration: 2 min 18 sec CHANGE SET Revision

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 439 - Fixed!

2017-02-25 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/439/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 26 Feb 2017 04:55:04 + Build duration: 4 min 54 sec CHANGE SET Revision b872213c5e247dd43ca55080095b14a5678e519e

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 439 - Fixed!

2017-02-25 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/439/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 26 Feb 2017 04:55:04 + Build duration: 4 min 54 sec CHANGE SET Revision b872213c5e247dd43ca55080095b14a5678e519e

[Differential] [Request, 5 lines] D4802: [KTextEditor] Remember file type set by user over sessions

2017-02-25 Thread John Salatas
jsalatas created this revision. Restricted Application added a subscriber: kwrite-devel. Restricted Application added a project: Frameworks. REVISION SUMMARY File type set by user is being reset after opening a session and reloading (https://phabricator.kde.org/F5) a file with file type set by

Re: Review Request 114448: kjs: reogranize basic math functions & function checking

2017-02-25 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114448/#review102638 --- The patch was not commited 3 years ago. It still applies

Re: Review Request 113152: kcm_clock: Check for valid return values of QDateTime::toTime_t()

2017-02-25 Thread Martin Bříza
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/113152/ --- (Updated Feb. 26, 2017, 12:37 a.m.) Status -- This change has been

Re: Review Request 113152: kcm_clock: Check for valid return values of QDateTime::toTime_t()

2017-02-25 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/113152/#review102632 --- Patch wasn't commited for years so i guess it wasn't that

[Differential] [Commented On] D4799: Delay notifications until desktop session has loaded

2017-02-25 Thread Valerio Pilo
vpilo added a comment. In https://phabricator.kde.org/D4799#89931, @mck182 wrote: > Thanks for the patch! I wanted to do exactly this a long > time ago. However this solution brings a burden to all > apps using KNotification in form of a blocking dbus call > which is further only

Re: Review Request 127866: Oxygen: Fix QCache usage

2017-02-25 Thread Michael Pyne
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127866/ --- (Updated Feb. 26, 2017, 12:28 a.m.) Status -- This change has been

Re: Review Request 119170: Include ntdd* headers to make Solid build without the Windows DDK

2017-02-25 Thread Nicolás Alvarez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119170/ --- (Updated Feb. 25, 2017, 9:27 p.m.) Status -- This change has been

Re: Review Request 125081: Fix build on OS X

2017-02-25 Thread Samuel Gaist
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125081/ --- (Updated Feb. 26, 2017, 12:26 a.m.) Status -- This change has been

Re: Review Request 125081: Fix build on OS X

2017-02-25 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125081/#review102629 --- Since Samuel did not respond to the improvement requests by

Re: Review Request 123534: Add public dependency on ModemManager

2017-02-25 Thread Jan Grulich
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123534/ --- (Updated Feb. 26, 2017, 12:13 a.m.) Status -- This change has been

Re: Review Request 120160: KMessageWidget: fix handling of rapid succession of animatedHide+animatedShow calls

2017-02-25 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120160/#review102626 --- Given than this hasn't been worked for more than 2 years i

Re: Review Request 120160: KMessageWidget: fix handling of rapid succession of animatedHide+animatedShow calls

2017-02-25 Thread Fabio D'Urso
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120160/ --- (Updated Feb. 26, 2017, 12:11 a.m.) Status -- This change has been

Re: Review Request 122252: KRecursiveFilterProxyModel: fix emitting superfluous dataChanged signals

2017-02-25 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122252/#review102624 --- No progress here in 2 years and kdelibs is in

Re: Review Request 117436: Doesn't assume that the users home directory is under /home

2017-02-25 Thread Lindsay Mathieson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117436/ --- (Updated Feb. 26, 2017, 12:04 a.m.) Status -- This change has been

Re: Review Request 117436: Doesn't assume that the users home directory is under /home

2017-02-25 Thread Albert Astals Cid
> On Feb. 4, 2015, 4:26 p.m., Vishesh Handa wrote: > > I seem to have forgotten about this. Sorry. > > > > Do you want me to commit this for you? Didn't get an answer, so i guess the answer is no. Will discard. - Albert --- This is an

Re: Review Request 123534: Add public dependency on ModemManager

2017-02-25 Thread Lamarque Souza
> On Feb. 25, 2017, 11:53 p.m., Albert Astals Cid wrote: > > This patch is whitespace only, i guess because it was commited. If noone > > says anything against i'll will close it in two weeks. Yeah, it is already commited. You can discard it. - Lamarque

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,All,gcc - Build # 354 - Unstable!

2017-02-25 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/354/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Sat, 25 Feb 2017 23:59:41 + Build duration: 2 min 27 sec CHANGE SET Revision

Re: Review Request 122183: [KUnitConversion] Currency: Fetch the currency file properly

2017-02-25 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122183/#review102621 --- Patch doesn't apply anymore - Albert Astals Cid On Feb.

[Differential] [Commented On] D4799: Delay notifications until desktop session has loaded

2017-02-25 Thread Martin Klapetek
mck182 added a comment. Thanks for the patch! I wanted to do exactly this a long time ago. However this solution brings a burden to all apps using KNotification in form of a blocking dbus call which is further only relevant when used in Plasma. That's a no-no I'm afraid, we'd have

Re: Review Request 123534: Add public dependency on ModemManager

2017-02-25 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123534/#review102617 --- This patch is whitespace only, i guess because it was

Re: Review Request 123032: Search for public dep in KPeople's cmake config

2017-02-25 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123032/#review102616 --- This patch is whitespace only, i guess because was

Re: Review Request 124319: Add missing licenses

2017-02-25 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124319/#review102615 --- I'll dicard this in two weeks since there hasn't been any

[Differential] [Request, 16 lines] D4801: KNotifications cleanup

2017-02-25 Thread Valerio Pilo
vpilo created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Removed some dead code REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D4801 AFFECTED FILES

[Differential] [Request, 35 lines] D4799: Delay notifications until desktop session has loaded

2017-02-25 Thread Valerio Pilo
vpilo created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY The KNotifications library is immediately available for programs to send out notifications from the beginning of a desktop session. But if a

[Differential] [Request, 164 lines] D4797: [ToolButtonStyle] Use pure colors and no frame as background in flat mode

2017-02-25 Thread Roman Gilg
subdiff created this revision. subdiff added a project: Plasma. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY The ToolButton has a rather odd looking style, which often conflicts with its placement and other lines in

Re: Review Request 127866: Oxygen: Fix QCache usage

2017-02-25 Thread Hugo Pereira Da Costa
> On May 30, 2016, 11:34 a.m., Hugo Pereira Da Costa wrote: > > Ship It! > > Hugo Pereira Da Costa wrote: > err. Wait ... > There are rendering issues here once the patch is applied. > See http://wstaw.org/m/2016/05/30/plasma-desktopY12228.png > (left is "before", right is

Re: Review Request 125511: Add missing documentation for argument to LAUNCHER_EXEC_NEW

2017-02-25 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125511/ --- (Updated Feb. 25, 2017, 10:59 p.m.) Status -- This change has been

Re: Review Request 125641: Allow PAM unlocking of a running wallet

2017-02-25 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125641/#review102608 --- Martin, Valentin, should I commit this? - Albert Astals

Re: Review Request 125885: Support socks5 proxy in KTcpSocket

2017-02-25 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125885/#review102610 --- Patch doesn't apply anymore - Albert Astals Cid On Oct.

Re: Review Request 123229: Ensure we don't crash when using KIO from non-QApplication process

2017-02-25 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123229/#review102609 --- Patch doesn't apply anymore. - Albert Astals Cid On Dec.

Re: Review Request 126724: Expose callingUser in HelperSupport if available

2017-02-25 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126724/#review102607 --- Martin any reason this was not commmited? Should I? -

Re: Review Request 127409: Make sure we're not forcing the window to be created prematurely

2017-02-25 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127409/#review102600 --- What's the status of this? Should it be commited? improved?

Re: Review Request 127866: Oxygen: Fix QCache usage

2017-02-25 Thread Albert Astals Cid
> On May 30, 2016, 11:34 a.m., Hugo Pereira Da Costa wrote: > > Ship It! > > Hugo Pereira Da Costa wrote: > err. Wait ... > There are rendering issues here once the patch is applied. > See http://wstaw.org/m/2016/05/30/plasma-desktopY12228.png > (left is "before", right is

Re: Review Request 126894: Refactor the listjobtest to allow listing of multile paths.

2017-02-25 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126894/#review102596 --- Patch doesn't apply anymore - Albert Astals Cid On Jan.

Re: Review Request 120458: Port html, djvu and folder thumbcreators

2017-02-25 Thread Albert Astals Cid
> On Oct. 20, 2016, 11:49 a.m., Albert Astals Cid wrote: > > Unfortunately the patch does not apply anymore since we forgot to commit it > > and someone did part of the work, could you upload a new version of it that > > applies against current master? If this is not updated in 3 months i'll

[Differential] [Closed] D4699: [KTextEditor] Reset filetype when opening url

2017-02-25 Thread John Salatas
This revision was automatically updated to reflect the committed changes. Closed by commit R39:16d90fd266df: Reset filetype when opening url (authored by jsalatas). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4699?vs=11800=11823 REVISION DETAIL

[Differential] [Commented On] D4663: Allow setting the timeout value.

2017-02-25 Thread Thomas Pfeiffer
colomar added a comment. > even Windows and Mac have deprecated them in favor of persistent notifications! > Not only it's already implemented, but also it is what every major desktop and phone OS out there already use! SNIS != those legacy systray icons which were rightfully

[Differential] [Abandoned] D4663: Allow setting the timeout value.

2017-02-25 Thread Albert Vaca Cintora
albertvaka abandoned this revision. albertvaka added a comment. I'm discarding this patch and will find an alternative way to solve the problem in KDE Connect. I still think, though, that notifications are a way better solution to require interaction from the user than SNIs, so I don't

[Differential] [Accepted] D4699: [KTextEditor] Reset filetype when opening url

2017-02-25 Thread Christoph Cullmann
cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. ;=) Feel free to commit that, thanks! REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D4699 EMAIL PREFERENCES

[Differential] [Commented On] D3850: Pass -fno-operator-names when supported

2017-02-25 Thread Nicolás Alvarez
nalvarez added a comment. This might be better solved by a krazy-like check, instead of making the compilation fail... REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D3850 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 442 - Still Failing!

2017-02-25 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/442/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 25 Feb 2017 11:18:22 + Build duration: 6 min 15 sec CHANGE SET No changes

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 438 - Still Failing!

2017-02-25 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/438/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 25 Feb 2017 11:18:18 + Build duration: 2 min 22 sec CHANGE SET No changes