Review Request 129182: CLazy fixes: use const ref in for loop instead object

2016-10-14 Thread Christian Ehrlicher
n.cpp 908a81f src/file/fileindexerconfig.cpp ccb5d80 src/file/pendingfilequeue.cpp 489f100 tests/file/storagedevicestest.cpp f269c81 Diff: https://git.reviewboard.kde.org/r/129182/diff/ Testing --- Compiles fine Thanks, Christian Ehrlicher

Review Request 129183: CLazy fixes: removed unused member var, add Q_OBJECT

2016-10-14 Thread Christian Ehrlicher
://git.reviewboard.kde.org/r/129183/diff/ Testing --- Compiles fine Thanks, Christian Ehrlicher

Review Request 129185: [baloo] Add a small benchmark for PostingCodec::encode()

2016-10-14 Thread Christian Ehrlicher
/r/129185/diff/ Testing --- Thanks, Christian Ehrlicher

Re: Review Request 129183: [baloo] CLazy fixes: removed unused member var, add Q_OBJECT

2016-10-14 Thread Christian Ehrlicher
- src/file/extractor/iohandler.h c0dfbbb src/file/extractor/iohandler.cpp b49a2b2 src/file/timeestimator.h 11137d3 Diff: https://git.reviewboard.kde.org/r/129183/diff/ Testing --- Compiles fine Thanks, Christian Ehrlicher

Review Request 129186: [baloo] Speedup PostingCodec::encode()

2016-10-14 Thread Christian Ehrlicher
little bit more complex but the speedup should be gain enough for this. Diffs - src/codecs/coding.cpp 5961077 Diff: https://git.reviewboard.kde.org/r/129186/diff/ Testing --- positoncodectest calculates the same md5sum as before. Thanks, Christian Ehrlicher

Re: Review Request 129182: CLazy fixes: use const ref in for loop instead object

2016-10-14 Thread Christian Ehrlicher
Diff: https://git.reviewboard.kde.org/r/129182/diff/ Testing --- Compiles fine Thanks, Christian Ehrlicher

Re: Review Request 129182: CLazy fixes: use const ref in for loop instead object

2016-10-14 Thread Christian Ehrlicher
----- On Oct. 14, 2016, 9:11 p.m., Christian Ehrlicher wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129182/ >

Re: Review Request 129183: [baloo] CLazy fixes: removed unused member var, add Q_OBJECT

2016-10-14 Thread Christian Ehrlicher
/ Testing --- Compiles fine Thanks, Christian Ehrlicher

Re: Review Request 129182: [baloo] CLazy fixes: use const ref in for loop instead object

2016-10-15 Thread Christian Ehrlicher
marked as submitted. Review request for Baloo. Changes --- Submitted with commit e6bd357153a790ef66dc803cd3451270e9311134 by Christian Ehrlicher to branch master. Repository: baloo Description --- While trying to figure out why indexing my files is so slow, I compiled baloo on my

Re: Review Request 129185: [baloo] Add a small benchmark for PostingCodec::encode()

2016-10-15 Thread Christian Ehrlicher
/benchmarks/CMakeLists.txt 0d74718 tests/benchmarks/positioncodectest.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/129185/diff/ Testing --- Thanks, Christian Ehrlicher

Re: Review Request 129186: [baloo] Speedup Positioncodec::encode()

2016-10-16 Thread Christian Ehrlicher
tps://git.reviewboard.kde.org/r/129186/diff/ Testing --- positoncodectest calculates the same md5sum as before. Thanks, Christian Ehrlicher

Re: Review Request 129185: [baloo] Add a small benchmark for PositionCodec::encode()

2016-10-16 Thread Christian Ehrlicher
ome benchmarking to show the speedup. Diffs - tests/benchmarks/CMakeLists.txt 0d74718 tests/benchmarks/positioncodectest.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/129185/diff/ Testing --- Thanks, Christian Ehrlicher

Re: Review Request 129185: [baloo] Add a small benchmark for PositionCodec::encode()

2016-10-17 Thread Christian Ehrlicher
e7aeebf autotests/unit/codecs/CMakeLists.txt f65d633 autotests/unit/codecs/positioncodectest.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/129185/diff/ Testing --- Thanks, Christian Ehrlicher

Re: Review Request 129185: [baloo] Add a small benchmark for PositionCodec::encode()

2016-10-23 Thread Christian Ehrlicher
/benchmarks/positioncodecbenchmark.cpp e7aeebf autotests/unit/codecs/CMakeLists.txt f65d633 autotests/unit/codecs/positioncodectest.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/129185/diff/ Testing --- Thanks, Christian Ehrlicher

Re: Review Request 129185: [baloo] Add a small benchmark for PositionCodec::encode()

2016-11-05 Thread Christian Ehrlicher
marked as submitted. Review request for Baloo and Vishesh Handa. Changes --- Submitted with commit 8ca69dcb32a38027f4ec319ae112ca382b145733 by Christian Ehrlicher to branch master. Repository: baloo Description --- This small test is used to test if the changes inside PostingCodec

Re: Review Request 129186: [baloo] Speedup Positioncodec::encode()

2016-11-05 Thread Christian Ehrlicher
/ Testing --- positoncodectest calculates the same md5sum as before. Thanks, Christian Ehrlicher

Re: Review Request 129183: [baloo] CLazy fixes: removed unused member var, add Q_OBJECT

2016-11-05 Thread Christian Ehrlicher
6843165 src/file/extractor/autotests/iohandlertest.cpp 2c8eeaa src/file/extractor/iohandler.h c0dfbbb src/file/extractor/iohandler.cpp b49a2b2 src/file/timeestimator.h 11137d3 Diff: https://git.reviewboard.kde.org/r/129183/diff/ Testing --- Compiles fine Thanks, Christian Ehrlicher

Re: Review Request 129183: [baloo] CLazy fixes: removed unused member var, add Q_OBJECT

2016-11-06 Thread Christian Ehrlicher
marked as submitted. Review request for Baloo. Changes --- Submitted with commit edcda57297a1fc4ff74555afd402cf9c69a2db25 by Christian Ehrlicher to branch master. Repository: baloo Description --- CLayz warns about an unused member var in IOHandler and a missing Q_OBJECT macro in

Re: Review Request 129186: [baloo] Speedup Positioncodec::encode()

2016-11-06 Thread Christian Ehrlicher
/coding.cpp 5961077 Diff: https://git.reviewboard.kde.org/r/129186/diff/ Testing --- positoncodectest calculates the same md5sum as before. Thanks, Christian Ehrlicher

kde-devel@kde.org

2016-11-06 Thread Christian Ehrlicher
src/file/regexpcache.cpp 61f07d6 src/file/xattrindexer.cpp 3daecef src/kioslaves/tags/kio_tags.cpp de2e6d7 Diff: https://git.reviewboard.kde.org/r/129349/diff/ Testing --- Thanks, Christian Ehrlicher

Re: Review Request 129186: [baloo] Speedup Positioncodec::encode()

2016-11-07 Thread Christian Ehrlicher
marked as submitted. Review request for Baloo, KDE Frameworks and Vishesh Handa. Changes --- Submitted with commit 2717080c46072b2a2998cb7d043a7cbcefa6a843 by Christian Ehrlicher to branch master. Repository: baloo Description --- This patch speeds up PostingCodec::encode() by a

Review Request 129378: [baloo] Avoid some useless copies by using const references instead

2016-11-11 Thread Christian Ehrlicher
4d15 Diff: https://git.reviewboard.kde.org/r/129378/diff/ Testing --- Thanks, Christian Ehrlicher

Review Request 129379: [baloo] Remove unused functions

2016-11-11 Thread Christian Ehrlicher
/codecs/coding.cpp 73e2fa2 src/codecs/positioncodec.cpp 22f4895 Diff: https://git.reviewboard.kde.org/r/129379/diff/ Testing --- Unittests still working as expected Thanks, Christian Ehrlicher

Re: Review Request 129378: [baloo] Avoid some useless copies by using const references instead

2016-11-11 Thread Christian Ehrlicher
e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129378/#review100797 --- On Nov. 11, 2016, 4:58 nachm., Christian Ehrlicher wrote: > > --- > This is an automatically ge

Re: Review Request 129379: [baloo] Remove unused functions

2016-11-15 Thread Christian Ehrlicher
marked as submitted. Review request for Baloo and David Faure. Changes --- Submitted with commit e40689fb56fbcd12ca4eeaef1b44e93f5afc6d7d by Christian Ehrlicher to branch master. Repository: baloo Description --- As discussed in REVIEW 129186 there is a lot of bit rotting in

Re: Review Request 129378: [baloo] Avoid some useless copies by using const references instead

2016-12-11 Thread Christian Ehrlicher
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129378/#review101361 --- Ping, no interest anyone? - Christian Ehrlicher On Nov

kde-devel@kde.org

2016-12-11 Thread Christian Ehrlicher
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129349/#review101362 --- Ping, no interest anyone? - Christian Ehrlicher On Nov

kde-devel@kde.org

2016-12-12 Thread Christian Ehrlicher
/r/129349/diff/ Testing --- Thanks, Christian Ehrlicher

kde-devel@kde.org

2016-12-12 Thread Christian Ehrlicher
-- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129349/#review101405 --- On Dez. 12, 2016, 6:48 nachm., Christian Ehrlicher wrote: > > -

kde-devel@kde.org

2016-12-13 Thread Christian Ehrlicher
/kioslaves/timeline/timelinetools.cpp 26e44ee Diff: https://git.reviewboard.kde.org/r/129349/diff/ Testing --- Thanks, Christian Ehrlicher

Review Request 129650: [baloo] Remove useless includes

2016-12-13 Thread Christian Ehrlicher
0 Diff: https://git.reviewboard.kde.org/r/129650/diff/ Testing --- Thanks, Christian Ehrlicher

Re: Dropping the svn kio from kdesdk-kioslaves

2016-12-16 Thread Christian Ehrlicher
Am 15.12.2016 um 23:12 schrieb Kevin Funk: On Thursday, 15 December 2016 22:14:38 CET Albert Astals Cid wrote: Why? * It doesn't compile with newer libsvn * It's kdelibs4-based Heya, I know a few people that use kdesvn, how's the relation to that? I saw that Christian (CC'ed) put quite so

Re: Dropping the svn kio from kdesdk-kioslaves

2016-12-20 Thread Christian Ehrlicher
Am 16.12.2016 um 11:32 schrieb Kevin Funk: If the SVN kioslave is standalone, wouldn't it make more sense to actually keep it in a separate repository/package? So users who just want the Dolphin integration can just use that? Wouldn't it make more sense to move your kioslave implementation into

Re: KF5-based kdesvn doesn't display the authorization dialog

2017-02-14 Thread Christian Ehrlicher
Am 14.02.2017 um 10:43 schrieb Kevin Funk: CC'ed maintainer. I'm not sure he's reading kde-devel@. On Sunday, 29 January 2017 09:24:26 CET Safa Alfulaij wrote: Hello world. I have updated my *kdesvn* from KDE4 to KF5 recently, but didn't tried to use it back then. I'm having a problem that is

Re: Review Request 129650: [baloo] Remove useless includes

2017-08-23 Thread Christian Ehrlicher
marked as submitted. Review request for Baloo. Changes --- Submitted with commit 1ba4c1375ba74d6eb61f70d7215ed160735d269e by Christian Ehrlicher to branch master. Repository: baloo Description --- In mainadaptor there are a lot of useless forward declarations and includes - don&#

kde-devel@kde.org

2017-08-23 Thread Christian Ehrlicher
ew in the next days - Christian Ehrlicher On Dez. 13, 2016, 7:39 nachm., Christian Ehrlicher wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard

Re: Review Request 129378: [baloo] Avoid some useless copies by using const references instead

2017-08-23 Thread Christian Ehrlicher
ew in the next days - Christian Ehrlicher On Nov. 11, 2016, 4:58 nachm., Christian Ehrlicher wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard

Re: Review Request 129378: [baloo] Avoid some useless copies by using const references instead

2017-08-23 Thread Christian Ehrlicher
marked as submitted. Review request for Baloo. Changes --- Submitted with commit a75db7aedfcd356b027774e0dc156c334d4cb869 by Christian Ehrlicher to branch master. Repository: baloo Description --- No functional changes, just adding some const & to avoid copies where poss

kde-devel@kde.org

2017-08-23 Thread Christian Ehrlicher
/timelinetools.cpp 26e44ee8 Diff: https://git.reviewboard.kde.org/r/129349/diff/ Testing --- Thanks, Christian Ehrlicher

kde-devel@kde.org

2017-08-30 Thread Christian Ehrlicher
--- On Aug. 24, 2017, 5:48 vorm., Christian Ehrlicher wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129349/ > ---