Re: Review Request 119415: Patch to delete xattr from untagged file

/119415/diff/ Testing --- Thanks, Felix Eisele >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Re: Review Request 119415: Patch to delete xattr from untagged file

://git.reviewboard.kde.org/r/119415/diff/ Testing --- Thanks, Felix Eisele >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Re: Review Request 119415: Patch to delete xattr from untagged file

/filecustommetadata.cpp 664b13f Diff: https://git.reviewboard.kde.org/r/119415/diff/ Testing --- Thanks, Felix Eisele >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Re: Review Request 119415: Patch to delete xattr from untagged file

ink we need a new testcase in which explicit writing a empty tag. I recommend a new testmethod. - Felix --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119415/#review62926

Re: Review Request 119415: Patch to delete xattr from untagged file

ot;user.xdg.tags" xatrr was always being set, even if > > it did not have any value. > > * What value should you be checking for now? > > Felix Eisele wrote: > I'm not sure if i understand you. The test check only the old way and > only the positiv way

Re: Review Request 119415: Patch to delete xattr from untagged file

/filecustommetadata.cpp 664b13f Diff: https://git.reviewboard.kde.org/r/119415/diff/ Testing --- Thanks, Felix Eisele >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Re: Review Request 119415: Patch to delete xattr from untagged file

ot;user.xdg.tags" xatrr was always being set, even if > > it did not have any value. > > * What value should you be checking for now? > > Felix Eisele wrote: > I'm not sure if i understand you. The test check only the old way and > only the positiv way

Re: Review Request 119450: Unittest style

--- src/file/autotest/filemonitortest.cpp 19d8f85 Diff: https://git.reviewboard.kde.org/r/119450/diff/ Testing --- Thanks, Felix Eisele >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Re: Review Request 119450: Unittest style

hink about this idea to do in baloo? Diffs - src/file/autotest/filemonitortest.cpp 19d8f85 Diff: https://git.reviewboard.kde.org/r/119450/diff/ Testing --- Thanks, Felix Eisele >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Review Request 119459: Added some Unittest for FileMonitor

Description --- Added some Unittest for FileMonitor Diffs - src/file/autotest/filemonitortest.h 9a72813 src/file/autotest/filemonitortest.cpp 19d8f85 Diff: https://git.reviewboard.kde.org/r/119459/diff/ Testing --- Thanks, Felix Eisele >> Visit http://mail.kde.org/m

Re: Review Request 119415: Patch to delete xattr from untagged file

/filemodifyjobtest.cpp ebfc9d9 src/file/lib/filecustommetadata.cpp 664b13f Diff: https://git.reviewboard.kde.org/r/119415/diff/ Testing --- Thanks, Felix Eisele >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Re: Review Request 119459: Added some Unittest for FileMonitor

viewboard.kde.org/r/119459/#review63120 --- On Juli 25, 2014, 10:41 vorm., Felix Eisele wrote: > > --- > This is an automatically generated e-mail. To reply, v

Re: Review Request 119459: Added some Unittest for FileMonitor

Vishesh Handa. Repository: baloo Description --- Added some Unittest for FileMonitor Diffs (updated) - src/file/autotest/filemonitortest.h 9a72813 src/file/autotest/filemonitortest.cpp 19d8f85 Diff: https://git.reviewboard.kde.org/r/119459/diff/ Testing --- Thanks, Felix

Review Request 119511: Removed KDialog from kcommentwidget

/keditcommentdialog.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/119511/diff/ Testing --- Tested in dolphin Thanks, Felix Eisele >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Re: Review Request 119511: Removed KDialog from kcommentwidget

/keditcommentdialog.h PRE-CREATION src/keditcommentdialog.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/119511/diff/ Testing --- Tested in dolphin Thanks, Felix Eisele >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Re: Review Request 119511: Removed KDialog from kcommentwidget

itcommentdialog. If this way is ok, I will do this for the other dialogs. > > > Diffs > - > > src/CMakeLists.txt 9b3a2d3 > src/kcommentwidget.cpp 00f69a9 > src/keditcommentdialog.h PRE-CREATION > src/keditcommentdialog.cpp PRE-CREATION > > Di

Re: Review Request 119459: Added some Unittest for FileMonitor

On Juli 26, 2014, 1:58 nachm., Felix Eisele wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119459/ > --

Re: Review Request 119511: Removed KDialog from kcommentwidget

src/keditcommentdialog.h PRE-CREATION src/CMakeLists.txt 9b3a2d3 Diff: https://git.reviewboard.kde.org/r/119511/diff/ Testing --- Tested in dolphin Thanks, Felix Eisele >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Re: Review Request 119511: Removed KDialog from kcommentwidget

PRE-CREATION src/kcommentwidget.cpp 00f69a9 src/keditcommentdialog.h PRE-CREATION src/CMakeLists.txt 9b3a2d3 Diff: https://git.reviewboard.kde.org/r/119511/diff/ Testing --- Tested in dolphin Thanks, Felix Eisele >> Visit http://mail.kde.org/mailman/listinfo/kde-devel

Re: Review Request 119459: Added some Unittest for FileMonitor

/119459/diff/ Testing --- Thanks, Felix Eisele >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Review Request 119543: Removed all KDialogs from balooWidgets

5191b03 src/kedittagsdialog.cpp c83ce9d src/kedittagsdialog_p.h 0bcf744 src/tagcheckbox.cpp af07a6c Diff: https://git.reviewboard.kde.org/r/119543/diff/ Testing --- Thanks, Felix Eisele >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Re: Review Request 119543: Removed all KDialogs from balooWidgets

- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119543/#review63489 --- On Juli 30, 2014, 8:29 vorm., Felix Eisele wrote: &g

Re: Review Request 119543: Removed all KDialogs from balooWidgets

045a185 Diff: https://git.reviewboard.kde.org/r/119543/diff/ Testing --- Thanks, Felix Eisele >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Re: Review Request 119543: Removed all KDialogs from balooWidgets

but > > there was a point when it split up. > > > > Also, if one really doesn't need it to be split up, then we should > > probably use a QScopedPointer instead of deleting it outself. > > Felix Eisele wrote: > i did googling yesterday and i

Re: Review Request 119543: Removed all KDialogs from balooWidgets

but > > there was a point when it split up. > > > > Also, if one really doesn't need it to be split up, then we should > > probably use a QScopedPointer instead of deleting it outself. > > Felix Eisele wrote: > i did googling yesterday and i

Re: Review Request 119543: Removed all KDialogs from balooWidgets

but > > there was a point when it split up. > > > > Also, if one really doesn't need it to be split up, then we should > > probably use a QScopedPointer instead of deleting it outself. > > Felix Eisele wrote: > i did googling yesterday and i

Re: Review Request 119543: Removed KDialogs from kedittagsdialog(balooWidgets)

0bcf744 src/tagwidget.cpp f2c3601 Diff: https://git.reviewboard.kde.org/r/119543/diff/ Testing --- Thanks, Felix Eisele >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Re: Review Request 119543: Removed KDialogs from kedittagsdialog(balooWidgets)

://git.reviewboard.kde.org/r/119543/diff/ Testing --- Thanks, Felix Eisele >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<