Re: Review Request 116883: Fix KUserGroup::users() and KUserGroup::userNames() on UNIX

2014-03-19 Thread Milian Wolff
On March 19, 2014, 2:56 a.m., Michael Pyne wrote: src/lib/util/kuser_unix.cpp, line 349 https://git.reviewboard.kde.org/r/116883/diff/1/?file=255233#file255233line349 Does this need to be a template, or would std::function be sufficient? Templates have a poor reputation amongst

Re: Review Request 116545: Fix KHTML compilation when using clang.

2014-03-05 Thread Milian Wolff
, ^ static_castint() Diffs - src/kjs/create_hash_table 94f3e4358a6d78fc7c658369d65b0e75ca131bc8 Diff: https://git.reviewboard.kde.org/r/116545/diff/ Testing --- Thanks, Milian Wolff ___ Kde-frameworks

Re: Review Request 116544: Fix clang compilation warning:

2014-03-05 Thread Milian Wolff
? Is it really worth it here? Diffs - src/xml/dom_stringimpl.h 114101d525309e423f50c5164d83afee8c634413 Diff: https://git.reviewboard.kde.org/r/116544/diff/ Testing --- Thanks, Milian Wolff ___ Kde-frameworks-devel mailing list Kde-frameworks

Re: Review Request 116541: Fix compiler error when using clang:

2014-03-05 Thread Milian Wolff
}; ^~ static_castunsigned int( ) Diffs - src/misc/AtomicString.cpp 4c35662ddd47759ed7e70524ededdd5223c14c09 Diff: https://git.reviewboard.kde.org/r/116541/diff/ Testing --- Thanks, Milian Wolff ___ Kde-frameworks-devel mailing list Kde

Re: Review Request 115351: Use kDebug instead of qDebug in QSpellEnchantDict

2014-03-05 Thread Milian Wolff
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115351/#review48493 --- On Jan. 28, 2014, 1 p.m., Milian Wolff wrote

Re: Review Request 115351: Use kDebug instead of qDebug in QSpellEnchantDict

2014-03-05 Thread Milian Wolff
is enabled via kdebugdialog. Diffs - sonnet/plugins/enchant/enchantdict.cpp c289d26 Diff: https://git.reviewboard.kde.org/r/115351/diff/ Testing --- None actually, not even tested if it compiles. Thanks, Milian Wolff

Re: Review Request 116542: Fix compilation with clang 3.4.

2014-03-04 Thread Milian Wolff
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116542/#review51851 --- On March 2, 2014, 8:20 p.m., Milian Wolff wrote

Review Request 116544: Fix clang compilation warning:

2014-03-02 Thread Milian Wolff
114101d525309e423f50c5164d83afee8c634413 Diff: https://git.reviewboard.kde.org/r/116544/diff/ Testing --- Thanks, Milian Wolff ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: qt5 polkit-qt-1 and kdesrc-build

2014-03-01 Thread Milian Wolff
On Saturday 01 March 2014 16:42:31 David Faure wrote: On Wednesday 26 February 2014 22:25:01 Milian Wolff wrote: module-set repository kde-projects branch qt5 use-modules polkit-qt-1 cmake-options -DCMAKE_BUILD_TYPE:STRING=debug end module-set Considering

Cannot build with ccache clang - cmake issue?

2014-03-01 Thread Milian Wolff
? Thanks -- Milian Wolff m...@milianw.de http://milianw.de ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

kdesrc-build: stop after failure? --truly-verbose?

2014-02-26 Thread Milian Wolff
get a truly verbose flag, which actually outputs the output from whatever tool is currently running? For me as a developer, its really annoying having to tail -f on some random log files to get my hands on the make output... How are other developers handling this? Bye -- Milian Wolff m

clang fails to build khtml

2014-02-26 Thread Milian Wolff
/jpegloader.cpp:430:29: warning: cast from 'uchar *' (aka 'unsigned char *') to 'QRgb *' (aka 'unsigned int *') increases required alignment from 1 to 4 [-Wcast-align] QRgb *out = (QRgb *)scanline; ^~~~ Bye -- Milian Wolff m...@milianw.de http

qt5 polkit-qt-1 and kdesrc-build

2014-02-26 Thread Milian Wolff
-options -DCMAKE_BUILD_TYPE:STRING=debug end module-set Considering that all other people should hit the same issue - how did you resolve this? Can we get the above into the default configuration somehow please? Thanks -- Milian Wolff m...@milianw.de http://milianw.de

Re: KZoneAllocator static in KCompletion crashes on exit

2014-02-10 Thread Milian Wolff
: KZoneAllocator::~KZoneAllocator() (kallocator.cpp:110) https://git.reviewboard.kde.org/r/114715/ ? Jep, that one removes the qDebug, which at that point must not be used anymore. So fixed already? Kevin, can you double-check? Cheers -- Milian Wolff m...@milianw.de http://milianw.de

Review Request 115351: Use kDebug instead of qDebug in QSpellEnchantDict

2014-01-28 Thread Milian Wolff
: https://git.reviewboard.kde.org/r/115351/diff/ Testing --- None actually, not even tested if it compiles. Thanks, Milian Wolff

Re: Problem with KCompTreeNode on Windows (or: destruction order of static objects?)

2013-12-04 Thread Milian Wolff
, and it might also improve application start-up time because the KZoneAllocator would only be initialized on first use of a KCompletion object. Yes, that might work. Kevin, could you try it out? Bye -- Milian Wolff m...@milianw.de http://milianw.de Visit http://mail.kde.org/mailman/listinfo/kde

Re: FindKDE4Internal.cmake clang c++11 -fdelayed-template-parsing

2013-11-15 Thread Milian Wolff
On Tuesday 22 October 2013 10:17:02 Raphael Kubo da Costa wrote: Milian Wolff m...@milianw.de writes: Hey Raphael! Thank you for working on clang support in FindKDE4Internal.cmake. Since recently though I have build issues with clang due to the -fdelayed- template-parsing flag

Re: KF5 Update Meeting Minutes 2013-w45

2013-11-06 Thread Milian Wolff
? There are tons more cleanups required in these interfaces. Bye -- Milian Wolff m...@milianw.de http://milianw.de signature.asc Description: This is a digitally signed message part. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org

Re: Review Request 108845: add support for SSSE3 and SSE4.2 in cpufeatures and for msvc

2013-10-22 Thread Milian Wolff
monday. I've integrated it, you don't have to worry about closing this out. Pity we haven't heard from Patrick though, I hope he's OK. Which Patrick? At least the Spendrin one is OK. I've seen him today :) Cheers -- Milian Wolff m...@milianw.de http://milianw.de

Re: Review Request 113355: Reduce UDSEntry memory usage with implicit sharing

2013-10-22 Thread Milian Wolff
you?). Anyway, the point is, if the number is small enough, the big-O notation does not necessarily matter. Milian Wolff wrote: This is very true. Regarding std::vector not sharing, this is OK since UDSEntryPrivate _is_ sharing. Also, QString in Field is also shared

Re: Review Request 113355: Reduce UDSEntry memory usage with implicit sharing

2013-10-22 Thread Milian Wolff
On Oct. 21, 2013, 8:20 p.m., Milian Wolff wrote: kio/kio/udsentry.cpp, line 240 http://git.reviewboard.kde.org/r/113355/diff/2/?file=204198#file204198line240 you still check that for every uds - does it make sense for any fields besides the ones I listed in my previous comment

Re: Review Request 113355: Reduce UDSEntry memory usage with implicit sharing

2013-10-21 Thread Milian Wolff
), it will also be faster than QHash. And thus probably also faster than the combined QHash + QVector lookup. The code would also become cleaner that way. - Milian Wolff On Oct. 20, 2013, 5:27 p.m., Frank Reininghaus wrote

Re: Review Request 113355: Reduce UDSEntry memory usage with implicit sharing

2013-10-21 Thread Milian Wolff
= false; } // add new value to cache cachedUdsFields.append(uds); - Milian Wolff On Oct. 20, 2013, 5:27 p.m., Frank Reininghaus wrote: --- This is an automatically generated e-mail. To reply, visit: http

Re: Review Request 113355: Reduce UDSEntry memory usage with implicit sharing

2013-10-21 Thread Milian Wolff
On Oct. 21, 2013, 8:56 a.m., Milian Wolff wrote: kio/kio/udsentry.cpp, line 51 http://git.reviewboard.kde.org/r/113355/diff/1/?file=203549#file203549line51 have you tried with a QMap? It has a lower memory overhead than QHash. And for few items (which is the case here, if I

Re: Review Request 113355: Reduce UDSEntry memory usage with implicit sharing

2013-10-21 Thread Milian Wolff
On Oct. 21, 2013, 4:26 p.m., Jan Kundrát wrote: Have you tried a naive implementation with a std::vectorstd::pairKey,Value? You say that a typical use case has eight entries; that's a very small number where a well-tuned vector could easily beat the O(1) of QHash or the O(log n) of

Re: Review Request 108845: add support for SSSE3 and SSE4.2 in cpufeatures and for msvc

2013-10-21 Thread Milian Wolff
monday. I've integrated it, you don't have to worry about closing this out. Pity we haven't heard from Patrick though, I hope he's OK. Which Patrick? At least the Spendrin one is OK. I've seen him today :) Cheers -- Milian Wolff m...@milianw.de http://milianw.de

Re: Review Request 113355: Reduce UDSEntry memory usage with implicit sharing

2013-10-21 Thread Milian Wolff
operator[] in the loop below to fill the vector. Afaik QVector's clear actually clears (contrary to std::vector). Thus my approach might safe a call to realloc. - Milian Wolff On Oct. 21, 2013, 6:23 p.m., Frank Reininghaus wrote

Re: Review Request 113355: Reduce UDSEntry memory usage with implicit sharing

2013-10-21 Thread Milian Wolff
you?). Anyway, the point is, if the number is small enough, the big-O notation does not necessarily matter. Milian Wolff wrote: This is very true. Regarding std::vector not sharing, this is OK since UDSEntryPrivate _is_ sharing. Also, QString in Field is also shared

Re: Review Request 113216: some little performance improvement for network kio

2013-10-13 Thread Milian Wolff
to the internal refcounting of QString. Considering that someone has done the work here now, imo it's OK to commit it. Still, this is a micro-optimization. If the maintainer of this code feels against it, I could also understand that. - Milian Wolff On Oct. 12, 2013, 12:06 p.m., Jaime Torres Amate wrote

FindKDE4Internal.cmake clang c++11 -fdelayed-template-parsing

2013-10-12 Thread Milian Wolff
? Or do you know a workaround for that? Bye -- Milian Wolff m...@milianw.de http://milianw.de

Re: Packaging KDE Foundation 5 frameworks

2013-10-11 Thread Milian Wolff
On Thursday 10 October 2013 17:56:56 Alexander Neundorf wrote: On Thursday 10 October 2013, Milian Wolff wrote: On Wednesday 09 October 2013 19:26:48 Alexander Neundorf wrote: On Wednesday 09 October 2013, Lubomir Rintel wrote: Hi, I know it's a bit too early, but still better

Re: Packaging KDE Foundation 5 frameworks

2013-10-10 Thread Milian Wolff
, esp. from listening to the KF5 talk at dev days yesterday. Furthermore, David explicitly said that in the future they aim at splitting up the KF5 modules into separate git repositories. Afaik, there is no ETA on this yet though. Bye -- Milian Wolff m...@milianw.de http://milianw.de

Re: K_EXPORT_PLUGIN KAboutData in .cpp vs .desktop / KPluginInfo

2013-09-27 Thread Milian Wolff
On Friday 27 September 2013 12:40:13 Sebastian Kügler wrote: On Thursday, September 26, 2013 22:08:32 Milian Wolff wrote: why do we have to set much redundant information in .cpp/KAboutData which is already somewhat defined by the KPluginInfo i.e. .desktop file? Point in case

K_EXPORT_PLUGIN KAboutData in .cpp vs .desktop / KPluginInfo

2013-09-26 Thread Milian Wolff
, I only see the text from the KAboutData which often is not the same... So, is there any way (maybe for KF5) to reduce the maintenance effort here? Grab most info from the .desktop file and only make it possible to overwrite stuff if required via KAboutData? Cheers -- Milian Wolff m

Re: Acceptable protocol by KUrl?

2013-09-06 Thread Milian Wolff
own domain- specific URL protocols. Bye -- Milian Wolff m...@milianw.de http://milianw.de Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe

Re: Backporting Clang support to KDE 4.11 FindKDE4Internal.cmake

2013-08-20 Thread Milian Wolff
On Sunday 18 August 2013 02:38:04 Raphael Kubo da Costa wrote: Milian Wolff m...@milianw.de writes: Btw, is there still no BSD using clang by default to build KDE? How did they manage to get this to work without the patch? FreeBSD's the first BSD to move towards having clang

Re: Review Request 111870: KDirWatch, make a little bit better use of inotify and prevent a stat call

2013-08-07 Thread Milian Wolff
On Aug. 6, 2013, 10:01 p.m., David Faure wrote: Ship It! Mark Gaiser wrote: Thank you very much for the ship it! Since the release is _very_ close i will ask the release team for permission on this one as well. Otherwise i probably push it after the tag. As it's a non-critical

Re: Backporting Clang support to KDE 4.11 FindKDE4Internal.cmake

2013-08-06 Thread Milian Wolff
On Monday 05 August 2013 22:46:18 Alex Merry wrote: On 05/08/13 20:55, Milian Wolff wrote: I'm out of the loop, since this is so close to the final release I'm not sure whether I should get this in... I'd say commit it; the patch is pretty trivial, and I can't see any way it could break

Re: Review Request 111689: desktoptojson -- convert .desktop files to .json for plugin metadata

2013-08-05 Thread Milian Wolff
://git.reviewboard.kde.org/r/111689/#comment27507 that should be const,no? - Milian Wolff On Aug. 5, 2013, 11:29 p.m., Sebastian Kügler wrote: --- This is an automatically generated e-mail. To reply, visit: http

Re: Review Request 111870: KDirWatch, make a little bit better use of inotify and prevent a stat call

2013-08-05 Thread Milian Wolff
On Aug. 3, 2013, 10:27 p.m., Milian Wolff wrote: kdecore/io/kdirwatch.cpp, line 372 http://git.reviewboard.kde.org/r/111870/diff/1/?file=176087#file176087line372 the indentation is broken here, no? should be two spaces like the rest of the file. Mark Gaiser wrote

Re: Backporting Clang support to KDE 4.11 FindKDE4Internal.cmake

2013-08-05 Thread Milian Wolff
On Monday 05 August 2013 19:17:49 Albert Astals Cid wrote: El Dilluns, 5 d'agost de 2013, a les 01:34:07, Milian Wolff va escriure: On Sunday 04 August 2013 16:35:20 Albert Astals Cid wrote: El Diumenge, 4 d'agost de 2013, a les 00:29:06, Milian Wolff va escriure: On Sunday 04 August

Re: Backporting Clang support to KDE 4.11 FindKDE4Internal.cmake

2013-08-04 Thread Milian Wolff
On Sunday 04 August 2013 16:35:20 Albert Astals Cid wrote: El Diumenge, 4 d'agost de 2013, a les 00:29:06, Milian Wolff va escriure: On Sunday 04 August 2013 00:28:17 Milian Wolff wrote: Hey all, I'd like to backport this comment from kdelibs master to KDE 4.11, is this OK

Re: Review Request 111689: desktoptojson -- convert .desktop files to .json for plugin metadata

2013-08-03 Thread Milian Wolff
://git.reviewboard.kde.org/r/111689/#comment27345 why members? that's imo a verschlimmbesserung. If at all, mark them as static const. - Milian Wolff On Aug. 3, 2013, 10:07 p.m., Sebastian Kügler wrote: --- This is an automatically

Re: Review Request 111689: desktoptojson -- convert .desktop files to .json for plugin metadata

2013-08-03 Thread Milian Wolff
On Aug. 2, 2013, 9:08 a.m., David Faure wrote: staging/kservice/tools/desktoptojson/kconfigtojson.h, line 31 http://git.reviewboard.kde.org/r/111689/diff/8/?file=175878#file175878line31 I don't like file-static QStrings (global objects), and even less in headers (it creates an

Re: Review Request 111870: KDirWatch, make a little bit better use of inotify and prevent a stat call

2013-08-03 Thread Milian Wolff
of the file. kdecore/io/kdirwatch.cpp http://git.reviewboard.kde.org/r/111870/#comment27351 isDir looks like an outparam but is used like an in-param here. will this work for all cases where this function is being called when inotify is present? - Milian Wolff On Aug. 3, 2013, 9:28 p.m., Mark

Backporting Clang support to KDE 4.11 FindKDE4Internal.cmake

2013-08-03 Thread Milian Wolff
Hey all, I'd like to backport this comment from kdelibs master to KDE 4.11, is this OK? -- Milian Wolff m...@milianw.de http://milianw.de

Re: Review Request 111689: desktoptojson -- convert .desktop files to .json for plugin metadata

2013-08-01 Thread Milian Wolff
://git.reviewboard.kde.org/r/111689/#comment27215 I'm not sure about the style guide in KDELibs, but aren't the KLocalizedString kind of includes preferred? Same for the Qt files. - Milian Wolff On July 30, 2013, 7:45 p.m., Sebastian Kügler wrote

Re: Review Request 111689: desktoptojson -- convert .desktop files to .json for plugin metadata

2013-08-01 Thread Milian Wolff
(); if (!valid(var)) { return false; } do_stuff(); } staging/kservice/tools/desktoptojson/kconfigtojson.cpp http://git.reviewboard.kde.org/r/111689/#comment27246 merge with above to else if? - Milian Wolff On Aug. 1, 2013, 6:03 p.m., Sebastian Kügler wrote

Re: Review Request 111689: desktoptojson -- convert .desktop files to .json for plugin metadata

2013-08-01 Thread Milian Wolff
On Aug. 1, 2013, 6:14 p.m., Milian Wolff wrote: staging/kservice/tools/desktoptojson/kconfigtojson.cpp, line 60 http://git.reviewboard.kde.org/r/111689/diff/6/?file=175868#file175868line60 just do return convert(...); Nicolás Alvarez wrote: No, that would give the opposite

Re: Review Request 111689: desktoptojson -- convert .desktop files to .json for plugin metadata

2013-08-01 Thread Milian Wolff
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111689/#review36947 --- Ship it! awesome, I like it now :) - Milian Wolff On Aug

Re: KDirWatch bug and the analysis. Help is welcome!

2013-07-31 Thread Milian Wolff
-- Milian Wolff m...@milianw.de http://milianw.de

Re: Review Request 111688: QVariantList-based ctor for KPluginInfo

2013-07-30 Thread Milian Wolff
://git.reviewboard.kde.org/r/111688/#comment27169 I'd leave these unrelated changes out and do it in a separate cleanup commit. just new code should not need these cleanups afterwards. - Milian Wolff On July 30, 2013, 2:41 a.m., Sebastian Kügler wrote

Re: Review Request 111689: desktoptojson -- convert .desktop files to .json for plugin metadata

2013-07-25 Thread Milian Wolff
://git.reviewboard.kde.org/r/111689/#comment26951 why not directly file.write(jdoc.toJson())? staging/kservice/tools/desktoptojson/kconfigtojson.cpp http://git.reviewboard.kde.org/r/111689/#comment26952 will be done automatically when the function's scope is left. - Milian Wolff On July 25, 2013, 4:10

Re: Review Request 111688: QVariantList-based ctor for KPluginInfo

2013-07-25 Thread Milian Wolff
://git.reviewboard.kde.org/r/111688/#comment26956 static const QString metaData = QStringLiteral(MetaData); Also, all the strings below should use QStringLiteral. - Milian Wolff On July 25, 2013, 4:10 p.m., Sebastian Kügler wrote

Re: Review Request 111050: Fast mime detection speedup.

2013-06-23 Thread Milian Wolff
/kmimetype.cpp http://git.reviewboard.kde.org/r/111050/#comment25570 unrelated change - Milian Wolff On June 23, 2013, 6:12 p.m., Mark Gaiser wrote: --- This is an automatically generated e-mail. To reply, visit: http

Re: Review Request 111050: Fast mime detection speedup.

2013-06-23 Thread Milian Wolff
On June 23, 2013, 7:29 p.m., Thomas Lübking wrote: KMimeTypePrivate::iconName is now the one slowing everything down mostly because of the QHash. Sure? Try replacing QHash with QMap (QHash is very fast at lookup with fix base and no variable costs - but it's slower on insertion)

Re: Review Request 111050: Fast mime detection speedup.

2013-06-23 Thread Milian Wolff
On June 23, 2013, 6:29 p.m., Milian Wolff wrote: kdecore/services/kmimetype.cpp, line 345 http://git.reviewboard.kde.org/r/111050/diff/2/?file=165321#file165321line345 try using QStringRef here to safe allocations if you care about speed. Mark Gaiser wrote: QStringRef misses

Re: Should fast mime detection use a stat call?

2013-06-17 Thread Milian Wolff
/ -- Milian Wolff m...@milianw.de http://milianw.de signature.asc Description: This is a digitally signed message part.

Re: Review Request 111050: Fast mime detection speedup. Well over 10x faster.

2013-06-17 Thread Milian Wolff
://git.reviewboard.kde.org/r/111050/#comment25290 not thread safe - Milian Wolff On June 16, 2013, 4:42 p.m., Mark Gaiser wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111050

Initialization of QSharedDataPointer's for empty objects (i.e. Foo::Foo(void))

2013-04-29 Thread Milian Wolff
of additional code when its being used to ensure its only accessed when it is initialized. I think the pattern applied in QString is much nicer in that regard. [1]: http://qt-project.org/doc/qt-4.8/qshareddatapointer.html -- Milian Wolff m...@milianw.de http://milianw.de signature.asc Description

Re: Initialization of QSharedDataPointer's for empty objects (i.e. Foo::Foo(void))

2013-04-29 Thread Milian Wolff
On Monday 29 April 2013 15:16:29 Thiago Macieira wrote: On segunda-feira, 29 de abril de 2013 21.52.37, Milian Wolff wrote: I.e.: In the ctors that construct an empty object do not call new Private but instead (re-)use a static shared empty object created on the stack - see shared_empty

Re: kdev-python move to extragear -- once more

2013-03-21 Thread Milian Wolff
. considering that Sven did everything in his power to improve the situation. Considering that the stuff is even accepted upstream finally we can look forward to a bright future. Cheers -- Milian Wolff m...@milianw.de http://milianw.de signature.asc Description: This is a digitally signed message

Re: Review Request 109549: port KRun away from KProcess

2013-03-20 Thread Milian Wolff
/#comment22055 This is missing const for the workingDirectory parameter. (Sorry, forgot to publish that review - I hate that on ReviewBoard :-/) - Milian Wolff On March 18, 2013, 7:51 p.m., Martin Tobias Holmedahl Sandsmark wrote

Re: Review Request 109549: port KRun away from KProcess

2013-03-20 Thread Milian Wolff
/#comment22055 This is missing const for the workingDirectory parameter. (Sorry, forgot to publish that review - I hate that on ReviewBoard :-/) - Milian Wolff On March 18, 2013, 7:51 p.m., Martin Tobias Holmedahl Sandsmark wrote

Re: kdev-python move to extragear -- once more

2013-03-12 Thread Milian Wolff
of times? Cheers -- Milian Wolff m...@milianw.de http://milianw.de signature.asc Description: This is a digitally signed message part.

Re: kdev-python move to extragear -- once more

2013-03-12 Thread Milian Wolff
that to the amount of bugs you'd get by writing your own python parser it is probably a good pick. Cheers -- Milian Wolff m...@milianw.de http://milianw.de signature.asc Description: This is a digitally signed message part.

Re: Review Request 108929: khtml/kjs: Implement typed-arrays

2013-02-14 Thread Milian Wolff
On Feb. 13, 2013, 9:13 a.m., Andrea Iacovitti wrote: khtml/ecma/kjs_arraybufferview.h, line 29 http://git.reviewboard.kde.org/r/108929/diff/2/?file=113855#file113855line29 Is this include really necessary or just an accident? (Noticed because a compilation error) Bernd

Re: plasma and new shadow mess

2013-01-06 Thread Milian Wolff
shouldn't be using its own QWidget based thing at all. it ought to be a bit of QML in a Plasma::Dialog. Would that also work when running outside of Plasma then? Cheers -- Milian Wolff m...@milianw.de http://milianw.de signature.asc Description: This is a digitally signed message part.

Re: Kdelibs Coding Style vs. preparations for Qt5

2012-12-29 Thread Milian Wolff
a perfect rule set for either astyle or uncrustify. Generally though, I would very much welcome any effort in that direction. If we could at least catch a few common issues it should help a lot. Cheers -- Milian Wolff m...@milianw.de http://milianw.de signature.asc Description

Re: Review of kdev-python for move to extragear

2012-12-07 Thread Milian Wolff
On Friday 07 December 2012 06:01:19 Laszlo Papp wrote: Out of the curiosity: how much python3 is available? Thank you for your work. python3 _support_ please read http://scummos.blogspot.de/2012/11/kdev-python-14-stable- released.html 1.5 will get python3 support -- Milian Wolff m

Re: Understanding a crazy backtrace

2012-12-03 Thread Milian Wolff
0x7fde1ea5fb61 in __run_exit_handlers () from This is static deallocation, on exit - are you sure you tried to close dolphin? Anyhow, try to reproduce it in valgrind, it will tell you what happened - esp. if you think the stack is messed up it should tell you why. Cheers -- Milian Wolff m

Re: Review Request: KMainWindow: fix position support in --geometry option

2012-10-24 Thread Milian Wolff
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107023/#review20799 --- Ship it! works for me :) - Milian Wolff On Oct. 24, 2012

Review Request: Keep KService::createInstance error message in KServiceTypeTrader::createInstanceFromQuery

2012-10-24 Thread Milian Wolff
: (/home/milian/projects/compiled/kde4/lib/kde4/kdevfiletemplates.so: undefined symbol: _ZTIN8KDevelop17ITemplateProviderE) ' Thanks, Milian Wolff

Re: Akonadi Billions Of NNTP Headers

2012-10-12 Thread Milian Wolff
or not. I'd say: Try it out and improve the codebase until it works :) Cheers -- Milian Wolff m...@milianw.de http://milianw.de signature.asc Description: This is a digitally signed message part. Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe

Re: How to construct the DBus identifier for current app?

2012-08-18 Thread Milian Wolff
On Friday 17 August 2012 00:25:16 Kevin Krammer wrote: On Thursday, 2012-08-16, Milian Wolff wrote: On Thursday 16 August 2012 23:12:16 Kevin Krammer wrote: On Thursday, 2012-08-16, Milian Wolff wrote: Hey there, see for context: http://git.reviewboard.kde.org/r/105917

Re: Application specific cache

2012-08-18 Thread Milian Wolff
On Thursday 16 August 2012 23:55:14 Kevin Krammer wrote: On Thursday, 2012-08-16, Milian Wolff wrote: Hey there, where should an app store it's cache data? I see that KStandardDirs notes cache, but how would one actually use that? I.e. if I want to write a file to the app's cache

Re: KBzip2Filter::uncompress outputs qDebug messages

2012-08-16 Thread Milian Wolff
On Wednesday 15 August 2012 17:17:32 Michael Pyne wrote: On Wednesday, August 15, 2012 16:49:13 Milian Wolff wrote: The output is always: bzDecompress returned 4 KBzip2Filter::uncompress 1 Could someone shed some light on this? Is this a serious issue? If not, can we silence

How to construct the DBus identifier for current app?

2012-08-16 Thread Milian Wolff
(). There, I have organizationDomain() and appName(), which I could concatenate to the DBUS identifier like: id = %1.%2-%3.arg(orgDomain, appName, pid) Does that sound OK or is there a better, more direct approach, to find the DBus identifier for the currently running app? Cheers -- Milian Wolff m

Re: QtScript considered dangerous

2012-08-13 Thread Milian Wolff
, Dominik [1] http://kate-editor.org/2012/05/12/rfc-exporting-javascript-api/ On Wednesday, May 23, 2012 22:08:08 Milian Wolff wrote: Hey all, I have a sad discussion to start it seems: We have port Kate away from QtScript. See also: https://bugs.kde.org/show_bug.cgi?id

Re: QtScript considered dangerous

2012-08-13 Thread Milian Wolff
On Monday 13 August 2012 17:34:12 Aleix Pol wrote: On Mon, Aug 13, 2012 at 3:44 PM, Milian Wolff m...@milianw.de wrote: Hey all, I just wanted to notify you that a fix to this notorious QtScript bug was released in time for 4.8.3. For now, I can retract my statement that QtScript

Re: Logging in unit-tests.

2012-07-03 Thread Milian Wolff
using qtest, cmake. KDEHOME=~/.kde-unit-test/ kdebugdialog - ensure all (interesting) debug areas are enabled. Cheers -- Milian Wolff m...@milianw.de http://milianw.de signature.asc Description: This is a digitally signed message part. Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub

Re: QtScript considered dangerous

2012-05-26 Thread Milian Wolff
that is of course possible though that one is at least actively maintained (as was also said in other mails in this thread). Cheers [1] http://kate-editor.org/2012/05/12/rfc-exporting-javascript-api/ On Wednesday, May 23, 2012 22:08:08 Milian Wolff wrote: Hey all, I have a sad

Re: QtScript considered dangerous

2012-05-26 Thread Milian Wolff
On Thursday 24 May 2012 11:28:41 Thomas Friedrichsmeier wrote: -- Note: Reposting to follow Dominik's example of CCing kde-core-devel -- Hi, On Wednesday 23 May 2012, Milian Wolff wrote: We have port Kate away from QtScript. I'm not sure, whether this is a serious suggestion, or just

Re: QtScript considered dangerous

2012-05-26 Thread Milian Wolff
changes ontop of the new codebase. JSC has changed considerably in many places so this is a lot of work to do, it seems... Bye -- Milian Wolff m...@milianw.de http://milianw.de signature.asc Description: This is a digitally signed message part.

Re: unit testing a freeze

2012-03-22 Thread Milian Wolff
it and fail. But that's rather complicated for such a simple thing. Maybe QTest already provides some nice feature? Why not Zoidberg? Uhm I mean: ctest --timeout seconds Cheers -- Milian Wolff m...@milianw.de http://milianw.de signature.asc Description: This is a digitally signed message part

Re: unit testing a freeze

2012-03-22 Thread Milian Wolff
On Thursday 22 March 2012 11:08:35 Dominik Haumann wrote: On Thursday, March 22, 2012 10:47:18 Milian Wolff wrote: Why not Zoidberg? Uhm I mean: ctest --timeout seconds That would do the trick. Is it possible to set this timeout for a single test in CMakeLists.txt? yes: http

Re: Review Request: Fix Drkonqi to work with bugzilla 4 (partial port to xml-rpc)

2012-03-13 Thread Milian Wolff
On March 9, 2012, 2:23 p.m., Kevin Kofler wrote: I think adding a dependency is a much cleaner solution than bundling. But I wonder whether the best long-term fix wouldn't be to just move kxmlrpcclient to kdelibs, it clearly seems to be useful for more than just PIM. But in distros,

Re: DrKonqi improvement idea

2012-03-12 Thread Milian Wolff
and the whole point of this proposal... bye -- Milian Wolff m...@milianw.de http://milianw.de

Re: Mentoring for GSoc about KDevelop

2012-03-02 Thread Milian Wolff
the mentors decide whom choose, depending largely also on how many slots are available to which team. bye -- Milian Wolff m...@milianw.de http://milianw.de Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe

Re: Regarding development of an application for KDE

2012-03-01 Thread Milian Wolff
a diff as an patch email to the relevant list. I think these features would be great on the plasma dashboard. Milian:finally I understand what you meant.You mean that we should integerate small parts,that make sense.Sure,I'll do that. sounds good. bye -- Milian Wolff m...@milianw.de http

Re: Regarding development of an application for KDE

2012-03-01 Thread Milian Wolff
/HowToCompile - https://projects.kde.org/projects/extragear/kdevelop/kdevplatform/repository/revisions/master/show/plugins/dashboard bye On Thu, Mar 1, 2012 at 5:49 PM, Milian Wolff m...@milianw.de wrote: On Thursday 01 March 2012 09:18:05 Atri Sharma wrote: Hi all, I think we have

Re: Regarding development of an application for KDE

2012-02-29 Thread Milian Wolff
On Wednesday 29 February 2012 13:49:08 Jacky Alcine wrote: On Wed, Feb 29, 2012 at 1:39 PM, Milian Wolff m...@milianw.de wrote: On Wednesday 29 February 2012 16:20:07 Atri Sharma wrote: Hi, I am Atri Sharma.I am a C++ developer. I had an application in mind which I believe can

Re: Regarding development of an application for KDE

2012-02-29 Thread Milian Wolff
) in #kdevelop on freenode irc. bye On Thu, Mar 1, 2012 at 12:19 AM, Jacky Alcine jacky.alc...@thesii.orgwrote: On Wed, Feb 29, 2012 at 1:39 PM, Milian Wolff m...@milianw.de wrote: On Wednesday 29 February 2012 16:20:07 Atri Sharma wrote: Hi, I am Atri Sharma.I am a C++ developer. I had

Re: Regarding development of an application for KDE

2012-02-29 Thread Milian Wolff
On Wednesday 29 February 2012 22:03:24 Kevin Krammer wrote: On Wednesday, 2012-02-29, Milian Wolff wrote: On Wednesday 29 February 2012 16:20:07 Atri Sharma wrote: Hi, I am Atri Sharma.I am a C++ developer. I had an application in mind which I believe can be implemented on KDE

Re: Bugzilla upgrade.

2012-02-21 Thread Milian Wolff
. Also when you have any other concerns or questions about the upgrade. What version will the new bugzilla have? Are the REST/JSON/XMLRPC APIs going to be enabled? Bye and many thanks for giving our bug-pit some love! -- Milian Wolff m...@milianw.de http://milianw.de signature.asc Description

Re: Bugzilla upgrade.

2012-02-21 Thread Milian Wolff
On Wednesday 22 February 2012 11:47:36 Ben Cooksley wrote: On Wed, Feb 22, 2012 at 11:37 AM, Milian Wolff m...@milianw.de wrote: On Tuesday 21 February 2012 21:00:33 Tom Albers wrote: Hi, Our bugzilla instance is an old version. We are preparing to upgrade it to a recent version

Re: Bugzilla upgrade.

2012-02-21 Thread Milian Wolff
On Wednesday 22 February 2012 11:47:36 Ben Cooksley wrote: On Wed, Feb 22, 2012 at 11:37 AM, Milian Wolff m...@milianw.de wrote: On Tuesday 21 February 2012 21:00:33 Tom Albers wrote: Hi, Our bugzilla instance is an old version. We are preparing to upgrade it to a recent version

Re: multithreading support

2012-02-18 Thread Milian Wolff
. If you are good at multithreading I presume you might have knowledge of reducing lock contention. If you have ideas how to do that for KDevelop without rewriting most of the code, I'd welcome your insight. Yet for KDevelop this is nothing in the scope of a GSOC imo. Bye -- Milian Wolff m

Re: multithreading support

2012-02-18 Thread Milian Wolff
On Saturday 18 February 2012 07:55:36 Vladimir Dergachev wrote: On Sat, 18 Feb 2012, Milian Wolff wrote: On Saturday 18 February 2012 18:50:42 Janardhan Reddy wrote: Hi, Are there any applications in kde which need multithreading support. I would like to participate

Re: KTextEditor Highlighting custom area

2012-02-16 Thread Milian Wolff
as follows: KTextEditor::MovingInterface* if = qobject_castKTextEditor::MovingInterface*(view-document()); if (!if) return; This wont compile, if is a cpp-keyword :P cheers -- Milian Wolff m...@milianw.de http://milianw.de signature.asc Description: This is a digitally signed message

<    3   4   5   6   7   8   9   >