Hello,
On Friday 11 October 2013 20:10:23 Aleix Pol wrote:
On Fri, Oct 11, 2013 at 6:31 PM, Kevin Ottens er...@kde.org wrote:
ktoolbar_unittest segfaults in the CI. I tried to reproduce the error here
with no luck so far. If someone who manages to reproduce it or who has
access to
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113205/#review41670
---
Why do it just for result and not finished, suspended,
Hello all,
Just a quick reminder:
The next KF5 Update Meeting will happen on #kde-devel tomorrow at 4pm Paris
time.
See you there!
Regards.
--
Kévin Ottens, http://ervin.ipsquad.net
Sponsored by KDAB to work on KDE Frameworks
KDAB - proud supporter of KDE, http://www.kdab.com
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113153/#review41675
---
Yes, should have a note in KDE5Porting before going in.
-
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113154/#review41676
---
-1
I disagree with the removal, OK they get deprecated in
On Oct. 14, 2013, 7:31 a.m., Kevin Ottens wrote:
-1
I disagree with the removal, OK they get deprecated in KDE4... but it's
been done only recently (the patch isn't even in yet). We still have a
couple of users for those classes and it would be one more breakage on our
SC
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113182/#review41679
---
tier1/itemviews/src/kcategorydrawer.h
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113199/#review41680
---
Ship it!
Ship It!
- Kevin Ottens
On Oct. 11, 2013, 12:16
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113197/#review41682
---
Looks good indeed.
Maybe an idea for an improvement: What
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113158/#review41683
---
I'm not sold on bastardizing QErrorMessage for that feature.
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113157/#review41684
---
Ship it!
Ship It!
- Kevin Ottens
On Oct. 7, 2013, 5:25
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113199/
---
(Updated Oct. 14, 2013, 9:06 a.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113199/#review41685
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112730/#review41686
---
knewstuff/CMakeLists.txt
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113226/#review41687
---
Ship it!
Ship It!
- Kevin Ottens
On Oct. 13, 2013, 5:20
On Oct. 14, 2013, 8:27 a.m., Kevin Ottens wrote:
tier1/itemviews/src/kcategorydrawer.h, line 228
http://git.reviewboard.kde.org/r/113182/diff/1/?file=200162#file200162line228
Wouldn't a typedef be enough? OK... would loose the DEPRECATED effect
though...
I tried a typedef first,
On Oct. 14, 2013, 7:31 a.m., Kevin Ottens wrote:
-1
I disagree with the removal, OK they get deprecated in KDE4... but it's
been done only recently (the patch isn't even in yet). We still have a
couple of users for those classes and it would be one more breakage on our
SC
On Oct. 14, 2013, 8:27 a.m., Kevin Ottens wrote:
tier1/itemviews/src/kcategorydrawer.h, line 228
http://git.reviewboard.kde.org/r/113182/diff/1/?file=200162#file200162line228
Wouldn't a typedef be enough? OK... would loose the DEPRECATED effect
though...
David Edmundson wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113182/#review41695
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113182/
---
(Updated Oct. 14, 2013, 10:24 a.m.)
Status
--
This change has been
On Oct. 14, 2013, 7:31 a.m., Kevin Ottens wrote:
-1
I disagree with the removal, OK they get deprecated in KDE4... but it's
been done only recently (the patch isn't even in yet). We still have a
couple of users for those classes and it would be one more breakage on our
SC
See http://build.kde.org/job/kdelibs_frameworks_qt5/1428/changes
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
See http://build.kde.org/job/kdelibs_frameworks_qt5/1429/changes
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113238/
---
Review request for KDE Frameworks.
Repository: kdelibs
Description
On Sept. 23, 2013, 10:37 a.m., Kevin Ottens wrote:
I'm surprised it doesn't use qt5_wrap_ui. It seems to reinvent it at least
partly.
Jeremy Whiting wrote:
well, qt5_wrap_ui wasn't around when this was created (as
kde4_add_ui_files iirc). All I did was copy it and rename it.
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113238/#review41699
---
Ship it!
Also consider (separately) removing the _LIBRARIES
Hello,
On Thursday 03 October 2013 18:15:22 John Layt wrote:
KDateTimeEdit
- My new widget to replace many local widgets, added in last kdelibs release
- Can replace KDateComboBox, KTimeComboBox, api is almost the same - Not
used anywhere!?!
- API uses QDate, QTime, KDateTime,
On Sept. 23, 2013, 10:37 a.m., Kevin Ottens wrote:
I'm surprised it doesn't use qt5_wrap_ui. It seems to reinvent it at least
partly.
Jeremy Whiting wrote:
well, qt5_wrap_ui wasn't around when this was created (as
kde4_add_ui_files iirc). All I did was copy it and rename it.
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113237/
---
Review request for KDE Frameworks.
Repository: kdelibs
Description
On Oct. 14, 2013, 7:31 a.m., Kevin Ottens wrote:
-1
I disagree with the removal, OK they get deprecated in KDE4... but it's
been done only recently (the patch isn't even in yet). We still have a
couple of users for those classes and it would be one more breakage on our
SC
Minor update -
Sebastian Sauer's email does not seem to be working. I've tried contacting him
via twitter. Lets see.
If anyone knows how to contact him, please inform me.
--
Vishesh Handa
___
Kde-frameworks-devel mailing list
On Wednesday 02 October 2013 15:09:35 Aurélien Gâteau wrote:
On Wednesday 02 October 2013 14:48:45 Stephen Kelly wrote:
Aurélien Gâteau wrote:
On Wednesday 02 October 2013 12:06:57 Stephen Kelly wrote:
Aurélien Gâteau wrote:
I don't have any strong opinion on this, but if we allow
On Oct. 14, 2013, 7:31 a.m., Kevin Ottens wrote:
-1
I disagree with the removal, OK they get deprecated in KDE4... but it's
been done only recently (the patch isn't even in yet). We still have a
couple of users for those classes and it would be one more breakage on our
SC
On Sept. 23, 2013, 10:37 a.m., Kevin Ottens wrote:
I'm surprised it doesn't use qt5_wrap_ui. It seems to reinvent it at least
partly.
Jeremy Whiting wrote:
well, qt5_wrap_ui wasn't around when this was created (as
kde4_add_ui_files iirc). All I did was copy it and rename it.
On Sept. 23, 2013, 12:37 p.m., Kevin Ottens wrote:
I'm surprised it doesn't use qt5_wrap_ui. It seems to reinvent it at least
partly.
Jeremy Whiting wrote:
well, qt5_wrap_ui wasn't around when this was created (as
kde4_add_ui_files iirc). All I did was copy it and rename it.
On Sept. 23, 2013, 10:37 a.m., Kevin Ottens wrote:
I'm surprised it doesn't use qt5_wrap_ui. It seems to reinvent it at least
partly.
Jeremy Whiting wrote:
well, qt5_wrap_ui wasn't around when this was created (as
kde4_add_ui_files iirc). All I did was copy it and rename it.
On Sept. 23, 2013, 12:37 p.m., Kevin Ottens wrote:
I'm surprised it doesn't use qt5_wrap_ui. It seems to reinvent it at least
partly.
Jeremy Whiting wrote:
well, qt5_wrap_ui wasn't around when this was created (as
kde4_add_ui_files iirc). All I did was copy it and rename it.
On Oct. 14, 2013, 11 a.m., Kevin Ottens wrote:
Looks good indeed.
Maybe an idea for an improvement: What about having the internal methods
use a QScopedPointer on the dialog? It'd avoid the delete before the
return, and if someone modifies the file later on adding more such returns
On Oct. 14, 2013, 6:47 a.m., Kevin Ottens wrote:
Why do it just for result and not finished, suspended, resumed? We end up
with both mechanisms for private signals in the same header otherwise.
Will do. Will update this patch shortly.
- Mark
On Sept. 23, 2013, 10:37 a.m., Kevin Ottens wrote:
I'm surprised it doesn't use qt5_wrap_ui. It seems to reinvent it at least
partly.
Jeremy Whiting wrote:
well, qt5_wrap_ui wasn't around when this was created (as
kde4_add_ui_files iirc). All I did was copy it and rename it.
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113205/
---
(Updated Oct. 14, 2013, 12:46 p.m.)
Review request for KDE Frameworks,
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113205/#review41714
---
Ship it!
tier1/kcoreaddons/src/lib/jobs/kjob.h
On Oct. 14, 2013, 12:52 p.m., David Faure wrote:
tier1/kcoreaddons/src/lib/jobs/kjob.h, line 372
http://git.reviewboard.kde.org/r/113205/diff/3/?file=201072#file201072line372
I wonder if the Qt/kdelibs coding style has something about indentation
of pre-processor directives, I
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113197/#review41728
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113197/
---
(Updated Oct. 14, 2013, 2 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113238/#review41729
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113238/
---
(Updated Oct. 14, 2013, 2:07 p.m.)
Status
--
This change has been
On Oct. 14, 2013, 7:31 a.m., Kevin Ottens wrote:
-1
I disagree with the removal, OK they get deprecated in KDE4... but it's
been done only recently (the patch isn't even in yet). We still have a
couple of users for those classes and it would be one more breakage on our
SC
On Friday 11 October 2013 07:32:47 nerdopolis wrote:
On Thursday, October 10, 2013 12:00:04 PM kde-frameworks-devel-
requ...@kde.org wrote:
Is this a bug I should file?
no need to file a bug about it. It's code I have written and I know that
it
currently requires glx. The problem here
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113241/
---
Review request for KDE Frameworks.
Repository: kdelibs
Description
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113241/#review41734
---
Ship it!
Makes sense to have all this tests into their own
On 14 October 2013 12:55, Kevin Ottens er...@kde.org wrote:
Giving it a closer look, I'm wondering: are you sure about this course of
action?
KDateTimeEdit is basically a KDateComboBox and a KTimeComboBox layouted
together. So deprecating those two without deprecating KDateTimeEdit sounds
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113240/#review41735
---
Ship it!
Looks good, it compiles and all policies are done so
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113237/#review41736
---
Ship it!
No test is breaking because of the patch, it looks
On Oct. 12, 2013, 4:57 p.m., David Faure wrote:
kded/kbuildsycoca.cpp, line 84
http://git.reviewboard.kde.org/r/113148/diff/3/?file=200224#file200224line84
Not called anymore with your commit.
But I'm not sure we want to remove the feature... what's the problem
with
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113241/#review41739
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113241/
---
(Updated Oct. 14, 2013, 4:10 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113237/#review41740
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113237/
---
(Updated Oct. 14, 2013, 4:15 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113153/#review41741
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113153/
---
(Updated Oct. 14, 2013, 4:16 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113243/
---
Review request for KDE Frameworks.
Repository: kdelibs
Description
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113157/
---
(Updated Oct. 14, 2013, 4:21 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113154/
---
(Updated Oct. 14, 2013, 4:21 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113240/#review41744
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113240/
---
(Updated Oct. 14, 2013, 4:30 p.m.)
Status
--
This change has been
On 14 October 2013 12:55, Kevin Ottens er...@kde.org wrote:
Giving it a closer look, I'm wondering: are you sure about this course of
action?
KDateTimeEdit is basically a KDateComboBox and a KTimeComboBox layouted
together. So deprecating those two without deprecating KDateTimeEdit sounds
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113243/#review41746
---
Ship it!
Ship It!
- Aleix Pol Gonzalez
On Oct. 14, 2013,
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113247/
---
Review request for KDE Frameworks.
Repository: kdelibs
Description
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113248/
---
Review request for KDE Frameworks.
Repository: kdelibs
Description
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113247/#review41750
---
Ship it!
Good catch David!
- Aleix Pol Gonzalez
On Oct.
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113248/
---
(Updated Oct. 14, 2013, 5:33 p.m.)
Review request for KDE Frameworks.
On Oct. 12, 2013, 10:43 a.m., David Faure wrote:
knewstuff/KNewStuffConfig.cmake.in, line 4
http://git.reviewboard.kde.org/r/112730/diff/3/?file=200166#file200166line4
why is kjs listed as a dependency here but not in the cmakelists.txt?
Ah, the Config.cmake.in I copied from had
See http://build.kde.org/job/kdelibs_stable/858/changes
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Hi,
While trying to get KDE Frameworks to build on Windows, I found the
codebase of KDirWatch is full of Unixisms. I did a few improvements
towards getting it to build on Windows, but I'm now getting several
errors related to the lack of symbolic links (such as no lstat). It's
clear this code
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112730/
---
(Updated Oct. 14, 2013, 10:56 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112730/#review41760
---
This review has been submitted with commit
On Mon, Oct 14, 2013 at 11:42 PM, Nicolás Alvarez nicolas.alva...@gmail.com
wrote:
Hi,
While trying to get KDE Frameworks to build on Windows, I found the
codebase of KDirWatch is full of Unixisms. I did a few improvements
towards getting it to build on Windows, but I'm now getting several
2013/10/14 Aleix Pol aleix...@kde.org:
It's good to know that there's somebody out there taking care of kf5 on
windows. I'm unsure of what to say, though. Maybe you can come up with a
list of issues so that we can fix them? At least some output log could be
useful...
I'm now working on
Hello,
On Monday 14 October 2013 18:42:02 Nicolás Alvarez wrote:
While trying to get KDE Frameworks to build on Windows, I found the
codebase of KDirWatch is full of Unixisms. I did a few improvements
towards getting it to build on Windows, but I'm now getting several
errors related to the
80 matches
Mail list logo
