Build failed in Jenkins: kdelibs_frameworks_qt5 #1790

See Changes: [agateau] Always pass --srcdir to meinproc -- [...truncated 7428 lines...] [ 42%] [ 47%] [ 52%] [ 57%] [ 61%] Building CXX object src/CMakeFiles/KJobWidgets.dir/kabstractwidgetjob

Re: further coinstallability

On Thu, Nov 28, 2013 at 7:28 AM, Kevin Ottens wrote: > On Wednesday 27 November 2013 22:43:04 Nicolás Alvarez wrote: > > > Windows has no sonames, and in kdelibs4 the files are called > > khtml.dll, etc. with no version number. I think they should get one > > (eg. khtml5.dll), for the same reason

Review Request 114182: Add Kf5 prefix for libs, eg. libKf5Foo

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114182/ --- Review request for KDE Frameworks. Repository: kdelibs Description -

Build failed in Jenkins: kdelibs_frameworks_qt5 #1791

See Changes: [agateau] Add a cmake wrapper used in superbuild to handle DESTDIR -- [...truncated 5320 lines...] Scanning dependencies of target ThreadWeaverLifecycleTest Scanning dependencies o

Build failed in Jenkins: kdelibs_frameworks_qt5 #1792

See Changes: [agateau] Revert "Always pass --srcdir to meinproc" [agateau] Revert "Add a cmake wrapper used in superbuild to handle DESTDIR" -- [...truncated 5217 lines...] * Qt5Test (require

Re: Superbuild in kdelibs

Le jeudi 28 novembre 2013 08:21:13 Aurélien Gâteau a écrit : > Le jeudi 28 novembre 2013 19:58:38 Ben Cooksley a écrit : > > On Thu, Nov 28, 2013 at 9:10 AM, Aurélien Gâteau wrote: > > > Le jeudi 28 novembre 2013 07:41:19 Ben Cooksley a écrit : > > > > On Nov 28, 2013 7:26 AM, "Aurélien Gâteau" w

Re: Superbuild in kdelibs

On Thursday 28 November 2013 16:02:10 Aurélien Gâteau wrote: > After much wrestling with that, I cannot find any way to get superbuild to > work on build.kde.org, because of the use of DESTDIR. Someone with enough > karma should apply attached patch on build-kde-org repository to disable it > and m

Build failed in Jenkins: kdelibs_frameworks_qt5 #1793

See Changes: [agateau] superbuild: Add kf5umbrella framework [agateau] superbuild: Update doc -- [...truncated 7460 lines...] [ 42%] [ 47%] [ 52%] [ 57%] [ 61%] [ 66%] [ 71%] Building CXX obje

Re: Review Request 114182: Add Kf5 prefix for libs, eg. libKf5Foo

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114182/#review44703 --- Looks fine to me. Makes me wonder if we want to drop the K for

Re: Review Request 112785: Add ki18n_wrap_ui macro to ki18nMacros

> On Nov. 18, 2013, 5 p.m., Kevin Ottens wrote: > > After discussion on the mailing list, let's get that in for the time being. > > It is to be considered as a temporary solution and will be removed when > > CMake 3 will be available. > > Kevin Ottens wrote: > Please push it ASAP, we need

Re: Review Request 114050: Add manual test app for enableBlurBehind.

> On Nov. 25, 2013, 2 p.m., Kevin Ottens wrote: > > tier1/kwindowsystem/tests/blurbehindtest.cpp, line 34 > > > > > > Space before * and not after please (applies to the whole file). Please update as soon as possi

Re: Review Request 112880: Added KColorSchemeToken class.

> On Oct. 21, 2013, 11:22 a.m., Kevin Ottens wrote: > > To get in this patch would benefit from being based on the frameworks > > branch and go into kdeclarative. > > Kevin Ottens wrote: > Any chance for an update? > > Denis Kuplyakov wrote: > Yes I will finish it, when have time. Ther

Re: Review Request 114182: Add Kf5 prefix for libs, eg. libKf5Foo

> On Nov. 28, 2013, 3:43 p.m., Kevin Ottens wrote: > > Looks fine to me. Makes me wonder if we want to drop the K for the target > > name "KF5::ConfigCore"? Just like Qt5Widgets becomes Qt5::Widgets... Can do. Imho it makes sense but I'll wait for some other opinions so I don't have to redo/un

Re: Review Request 112785: Add ki18n_wrap_ui macro to ki18nMacros

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112785/#review44712 --- This review has been submitted with commit b266c82ca43d9dfff0c

Re: Review Request 112785: Add ki18n_wrap_ui macro to ki18nMacros

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112785/ --- (Updated Nov. 28, 2013, 4:27 p.m.) Status -- This change has been mar

Re: Review Request 114158: Use Sonnet::SpellCheckDecorator internally in KTextEdit

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114158/#review44713 --- This review has been submitted with commit e0e0efffb70b5c52fb8

Re: Review Request 114158: Use Sonnet::SpellCheckDecorator internally in KTextEdit

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114158/ --- (Updated Nov. 28, 2013, 4:28 p.m.) Status -- This change has been mar

Build failed in Jenkins: kdelibs_frameworks_qt5 #1794

See Changes: [jpwhiting] Adding ki18n_wrap_ui cmake macro to ki18n cmake files -- [...truncated 7459 lines...] [ 42%] [ 47%] [ 52%] [ 57%] [ 61%] [ 66%] Building CXX object src/CMakeFiles/KJob

Build failed in Jenkins: kdelibs_frameworks_qt5 #1795

See Changes: [kde] Use Sonnet::Decorator internally in KTextEdit -- [...truncated 7459 lines...] [ 42%] [ 47%] [ 52%] [ 57%] [ 61%] [ 66%] [ 71%] Building CXX object src/CMakeFiles/KJobWidgets

Re: Review Request 112463: Port SMB kioslave to KF5/Qt5

> On Nov. 26, 2013, 5:12 p.m., Kevin Ottens wrote: > > It's been stalled for almost three months now, any chance to see progress > > or should it be discarded? > > Mark Gaiser wrote: > No, it should most certainly not be disgarded. It was even working when i > posted this post up for revie

Dialogs, QPT and Qt5

Dear frameworkers, I've seen that when we ask for a QFileDialog in KF5 we get a generic QFileDialog at the moment. The reason is simple, KFileDialog is deprecated in KDE4Support and we are not implementing QPlatformDialogHelper *QPlatformThemecreatePlatformDialogHelper(DialogType dialogType). I wo

[kdelibs/frameworks] tier4/kde4support/src: Check for visibility support on gcc

Git commit 3bc8af3ec4477b5ff7acedd74b27d0d359e8bd1f by Aurélien Gâteau. Committed on 28/11/2013 at 17:02. Pushed by gateau into branch 'frameworks'. Check for visibility support on gcc __KDE_HAVE_GCC_VISIBILITY was not defined in kdemacros.h.cmake, causing KDE_EXPORT and KDE_IMPORT to be no-ops,

Build failed in Jenkins: kdelibs_frameworks_qt5 #1796

See Changes: [agateau] Check for visibility support on gcc -- [...truncated 7455 lines...] [ 42%] [ 47%] [ 52%] [ 57%] Building CXX object src/CMakeFiles/KJobWidgets.dir/kdialogjobuidelegate.c

Re: Review Request 114050: Add manual test app for enableBlurBehind.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114050/ --- (Updated Nov. 28, 2013, 2:23 p.m.) Review request for KDE Frameworks. Ch

Re: Review Request 112880: Added KColorSchemeToken class.

> On Oct. 21, 2013, 11:22 a.m., Kevin Ottens wrote: > > To get in this patch would benefit from being based on the frameworks > > branch and go into kdeclarative. > > Kevin Ottens wrote: > Any chance for an update? > > Denis Kuplyakov wrote: > Yes I will finish it, when have time. Ther

Review Request 114184: Remove everything in kstyle that is not about KDE integration

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114184/ --- Review request for KDE Frameworks. Repository: kdelibs Description -

Review Request 114185: Provide our own KFontDialog

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114185/ --- Review request for KDE Frameworks. Repository: kdelibs Description -

Re: Dialogs, QPT and Qt5

On Thursday 28 November 2013 17:53:14 Aleix Pol wrote: > Dear frameworkers, > I've seen that when we ask for a QFileDialog in KF5 we get a generic > QFileDialog at the moment. The reason is simple, KFileDialog is deprecated > in KDE4Support and we are not implementing > QPlatformDialogHelper *QPlat

Re: Review Request 114184: Remove everything in kstyle that is not about KDE integration

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114184/ --- (Updated Nov. 28, 2013, 6:20 p.m.) Review request for KDE Frameworks. Ch

Re: Review Request 114050: Add manual test app for enableBlurBehind.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114050/ --- (Updated Nov. 28, 2013, 4:17 p.m.) Review request for KDE Frameworks. Ch

Re: Review Request 114182: Add Kf5 prefix for libs, eg. libKf5Foo

> On Nov. 28, 2013, 3:43 p.m., Kevin Ottens wrote: > > Looks fine to me. Makes me wonder if we want to drop the K for the target > > name "KF5::ConfigCore"? Just like Qt5Widgets becomes Qt5::Widgets... > > Martin Klapetek wrote: > Can do. Imho it makes sense but I'll wait for some other opi

Re: Review Request 114182: Add Kf5 prefix for libs, eg. libKf5Foo

> On Nov. 28, 2013, 4:43 p.m., Kevin Ottens wrote: > > Looks fine to me. Makes me wonder if we want to drop the K for the target > > name "KF5::ConfigCore"? Just like Qt5Widgets becomes Qt5::Widgets... > > Martin Klapetek wrote: > Can do. Imho it makes sense but I'll wait for some other opi

Review Request 114187: KFormat - Add new KFormat class

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114187/ --- Review request for KDE Frameworks, Albert Astals Cid, David Faure, and Kevin

Re: Review Request 114182: Add Kf5 prefix for libs, eg. libKf5Foo

> On Nov. 28, 2013, 3:43 p.m., Kevin Ottens wrote: > > Looks fine to me. Makes me wonder if we want to drop the K for the target > > name "KF5::ConfigCore"? Just like Qt5Widgets becomes Qt5::Widgets... > > Martin Klapetek wrote: > Can do. Imho it makes sense but I'll wait for some other opi

Build failed in Jenkins: kdelibs_frameworks_qt5 #1797

See Changes: [mirko] Change collections so that elements are queued after run(). [mirko] Add tests for generating collections and sequences. [mirko] Adapt sequences to have self() run first.

Re: Review Request 114187: KFormat - Add new KFormat class

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114187/#review44737 --- This looks like a sensible overall design to me. tier1/kcorea

Re: Review Request 114182: Add Kf5 prefix for libs, eg. libKf5Foo

> On Nov. 28, 2013, 3:43 p.m., Kevin Ottens wrote: > > Looks fine to me. Makes me wonder if we want to drop the K for the target > > name "KF5::ConfigCore"? Just like Qt5Widgets becomes Qt5::Widgets... > > Martin Klapetek wrote: > Can do. Imho it makes sense but I'll wait for some other opi

Re: Review Request 114184: Remove everything in kstyle that is not about KDE integration

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114184/#review44741 --- tier4/frameworkintegration/src/kstyle/kstyle.h

Re: Dialogs, QPT and Qt5

On 28/11/13 16:53, Aleix Pol wrote: > Dear frameworkers, > I've seen that when we ask for a QFileDialog in KF5 we get a generic > QFileDialog at the moment. The reason is simple, KFileDialog is > deprecated in KDE4Support and we are not implementing > QPlatformDialogHelper > *QPlatformThemecreatePl

Review Request 114195: Add license in K4AboutData -> KAboutData conversion

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114195/ --- Review request for KDE Frameworks. Repository: kdelibs Description -

Re: Dialogs, QPT and Qt5

Hello, On Thursday 28 November 2013 17:53:14 Aleix Pol wrote: > I've seen that when we ask for a QFileDialog in KF5 we get a generic > QFileDialog at the moment. The reason is simple, KFileDialog is deprecated > in KDE4Support and we are not implementing > QPlatformDialogHelper *QPlatformThemecrea

Re: Review Request 112880: Added KColorSchemeToken class.

> On Oct. 21, 2013, 11:22 a.m., Kevin Ottens wrote: > > To get in this patch would benefit from being based on the frameworks > > branch and go into kdeclarative. > > Kevin Ottens wrote: > Any chance for an update? > > Denis Kuplyakov wrote: > Yes I will finish it, when have time. Ther