Re: Review Request 116952: Make sure non-prefixed desktop files win when looking up by name

2014-03-23 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116952/#review53782 --- Ship it! Another reason to get rid of prefixes indeed. - Dav

Re: Review Request 116938: Remove defunct plugin-loading code, and deprecate KLibrary

2014-03-23 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116938/#review53784 --- Ship it! Very nice. src/plugin/kpluginloader.h

Re: Review Request 116980: Update the kded5 man page

2014-03-23 Thread Burkhard Lück
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116980/#review53796 --- docs/kded5/man-kded5.8.docbook

Re: Review Request 116952: Make sure non-prefixed desktop files win when looking up by name

2014-03-23 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116952/ --- (Updated March 23, 2014, 12:20 p.m.) Status -- This change has been

Re: Review Request 116952: Make sure non-prefixed desktop files win when looking up by name

2014-03-23 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116952/#review53802 --- This review has been submitted with commit b603f91a57bfde646f

Re: Review Request 116952: Make sure non-prefixed desktop files win when looking up by name

2014-03-23 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116952/#review53800 --- This review has been submitted with commit 1993b3e7e22d4291df

Re: Review Request 116952: Make sure non-prefixed desktop files win when looking up by name

2014-03-23 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116952/#review53801 --- This review has been submitted with commit dc618b27253f5f2948

Re: Review Request 116938: Remove defunct plugin-loading code, and deprecate KLibrary

2014-03-23 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116938/#review53805 --- This review has been submitted with commit b779f3478b02fc60b3

Re: Review Request 116938: Remove defunct plugin-loading code, and deprecate KLibrary

2014-03-23 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116938/#review53803 --- This review has been submitted with commit 886298e6b251522687

Re: Review Request 116938: Remove defunct plugin-loading code, and deprecate KLibrary

2014-03-23 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116938/#review53804 --- This review has been submitted with commit 4a3a5699f4d5b81bc5

Re: Review Request 116938: Remove defunct plugin-loading code, and deprecate KLibrary

2014-03-23 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116938/ --- (Updated March 23, 2014, 12:23 p.m.) Status -- This change has been

Re: Review Request 116980: Update the kded5 man page

2014-03-23 Thread Alex Merry
> On March 23, 2014, 12:15 p.m., Burkhard Lück wrote: > > docs/kded5/man-kded5.8.docbook, line 9 > > > > > > All other docbook man pages in frameworks have "&kde; User's Manual" > > here, why this change? To refl

Re: Review Request 116980: Update the kded5 man page

2014-03-23 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116980/ --- (Updated March 23, 2014, 1:02 p.m.) Review request for KDE Frameworks.

Review Request 116991: kded: Use a consistent configuration file name

2014-03-23 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116991/ --- Review request for KDE Frameworks and David Faure. Repository: kded Des

Re: Review Request 116980: Update the kded5 man page

2014-03-23 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116980/ --- (Updated March 23, 2014, 1:37 p.m.) Review request for KDE Frameworks.

Re: Review Request 116984: Fix configuring of kde5init_win32lib_dummy.cpp.in

2014-03-23 Thread Alex Merry
> On March 22, 2014, 10:21 p.m., Nicolás Alvarez wrote: > > I can't test this because the kservice framework (dep of kinit) doesn't > > compile on Windows. Yeah... I was operating on the basis of "this is probably less broken than before". kwrapper_win.cpp also has some defunct stuff in it, I

Re: Review Request 116934: Use KPluginLoader to find kioslaves

2014-03-23 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116934/ --- (Updated March 23, 2014, 1:51 p.m.) Review request for KDE Frameworks and

Re: Review Request 116980: Update the kded5 man page

2014-03-23 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116980/ --- (Updated March 23, 2014, 1:55 p.m.) Review request for Documentation and

Re: Review Request 116934: Use KPluginLoader to find kioslaves

2014-03-23 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116934/#review53811 --- Ship it! Ship It! - David Faure On March 23, 2014, 1:51 p.

Re: Review Request 116934: Use KPluginLoader to find kioslaves

2014-03-23 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116934/ --- (Updated March 23, 2014, 2:11 p.m.) Status -- This change has been m

Re: Review Request 116934: Use KPluginLoader to find kioslaves

2014-03-23 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116934/#review53812 --- This review has been submitted with commit a2cd603db5191c49df

Review Request 116993: Use KPluginLoader::findPlugin and QLibrary instead of KLibrary

2014-03-23 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116993/ --- Review request for KDE Frameworks. Repository: kcmutils Description ---

Re: Review Request 116873: Replace GPL proctitle code with BSD-licensed code from OpenSSH

2014-03-23 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116873/#review53813 --- Ship it! Ship It! - David Faure On March 21, 2014, 3:47 p.

Review Request 116994: Use KPluginLoader::findPlugin and QLibrary instead of KLibrary

2014-03-23 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116994/ --- Review request for KDE Frameworks and Christoph Cullmann. Repository: kte

Re: Review Request 116991: kded: Use a consistent configuration file name

2014-03-23 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116991/#review53814 --- Ship it! src/kded.cpp

Re: Review Request 116994: Use KPluginLoader::findPlugin and QLibrary instead of KLibrary

2014-03-23 Thread Christoph Cullmann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116994/#review53815 --- Ship it! Ship It! - Christoph Cullmann On March 23, 2014,

Re: Review Request 116873: Replace GPL proctitle code with BSD-licensed code from OpenSSH

2014-03-23 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116873/ --- (Updated March 23, 2014, 2:46 p.m.) Status -- This change has been m

Re: Review Request 116873: Replace GPL proctitle code with BSD-licensed code from OpenSSH

2014-03-23 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116873/#review53816 --- This review has been submitted with commit 8d13c18a4e4d01bb39

Re: Review Request 116991: kded: Use a consistent configuration file name

2014-03-23 Thread Alex Merry
> On March 23, 2014, 2:32 p.m., David Faure wrote: > > src/kded.cpp, line 778 > > > > > > To be honest I don't like this very much, the variable bCheckSycoca > > suddenly changes meaning, from being the default

Re: Review Request 116991: kded: Use a consistent configuration file name

2014-03-23 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116991/#review53817 --- This review has been submitted with commit 097ec91cbeed7889b2

Re: Review Request 116991: kded: Use a consistent configuration file name

2014-03-23 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116991/ --- (Updated March 23, 2014, 2:50 p.m.) Status -- This change has been m

Review Request 116995: Rename the kconfig_compiler_kf5 target to kconfig_compiler

2014-03-23 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116995/ --- Review request for KDE Frameworks. Repository: kconfig Description

Re: Review Request 116994: Use KPluginLoader::findPlugin and QLibrary instead of KLibrary

2014-03-23 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116994/ --- (Updated March 23, 2014, 2:53 p.m.) Status -- This change has been m

Re: Review Request 116994: Use KPluginLoader::findPlugin and QLibrary instead of KLibrary

2014-03-23 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116994/#review53819 --- This review has been submitted with commit 264d930073aa57fb15

Re: LXR

2014-03-23 Thread Alex Merry
On 20/03/14 08:13, David Faure wrote: > On Thursday 20 March 2014 00:28:44 Alex Merry wrote: >> LXR says the only >> users are a couple of projects that haven't even made it onto >> projects.kde.org. > > Talking about LXR... I just finished setting up http://lxrnew.kde.org/ident > Can you use it

Review Request 116997: Cleanup KDE 4 references in various comments and dox

2014-03-23 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116997/ --- Review request for KDE Frameworks. Repository: kio Description ---

Review Request 116999: kparts: Remove/resolve old porting comments and TODOs

2014-03-23 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116999/ --- Review request for KDE Frameworks. Repository: kparts Description -

Review Request 117000: Rename kmimetypefactory.h to kmimetypefactory_p.h

2014-03-23 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117000/ --- Review request for KDE Frameworks. Repository: kservice Description ---

Re: LXR

2014-03-23 Thread Alex Merry
On 23/03/14 14:55, Alex Merry wrote: > On 20/03/14 08:13, David Faure wrote: >> On Thursday 20 March 2014 00:28:44 Alex Merry wrote: >>> LXR says the only >>> users are a couple of projects that haven't even made it onto >>> projects.kde.org. >> >> Talking about LXR... I just finished setting up h

Re: Review Request 116984: Fix configuring of kde5init_win32lib_dummy.cpp.in

2014-03-23 Thread Alexander Richardson
> On March 22, 2014, 11:21 p.m., Nicolás Alvarez wrote: > > I can't test this because the kservice framework (dep of kinit) doesn't > > compile on Windows. > > Alex Merry wrote: > Yeah... I was operating on the basis of "this is probably less broken > than before". kwrapper_win.cpp also h

Review Request 117003: Remove kde3 compatibility code for "DocPath" in desktop files

2014-03-23 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117003/ --- Review request for KDE Frameworks. Repository: kconfig Description

Review Request 117004: Remove out-of-date design docs

2014-03-23 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117004/ --- Review request for KDE Frameworks and Christoph Feck. Repository: kiconth

Review Request 117005: Remove KDE3 KParts compatibility code

2014-03-23 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117005/ --- Review request for KDE Frameworks and David Faure. Repository: kservice

Review Request 117006: Remove kde3 compatibility code and comments

2014-03-23 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117006/ --- Review request for KDE Frameworks and David Faure. Repository: kio Desc

Cleanup tasks

2014-03-23 Thread Alex Merry
http://community.kde.org/Frameworks/Epics/KF5.0_Release_Preparation/KDE4_References lists a bunch of kde4 references that should be cleaned up. Any row that contains things that aren't review requests is up for grabs (including the ones that say "in progress"). Just put your email address in the

Re: Review Request 117005: Remove KDE3 KParts compatibility code

2014-03-23 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117005/#review53829 --- Ship it! Ship It! - David Faure On March 23, 2014, 6:19 p.

Re: Review Request 117006: Remove kde3 compatibility code and comments

2014-03-23 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117006/#review53830 --- Ship it! Ship It! - David Faure On March 23, 2014, 6:25 p.

Re: Review Request 116927: Fix kdeinit module lookup

2014-03-23 Thread Hrvoje Senjan
> On March 21, 2014, 4:10 p.m., Hrvoje Senjan wrote: > > this seems to broke kded modules loading here: > > Cannot load library /usr/lib64/libkdeinit5_kio_file: > > (/usr/lib64/libkdeinit5_kio_file.so: cannot open shared object file: No > > such file or directory) > > Hrvoje Senjan wrote: >

Re: Review Request 116966: Reorder private variables of KLineEditPrivate to avoid padding

2014-03-23 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116966/#review53833 --- Ship it! Ship It! - David Faure On March 21, 2014, 9:58 p.

Re: LXR

2014-03-23 Thread David Faure
On Sunday 23 March 2014 17:33:46 Alex Merry wrote: > On 23/03/14 14:55, Alex Merry wrote: > > On 20/03/14 08:13, David Faure wrote: > >> On Thursday 20 March 2014 00:28:44 Alex Merry wrote: > >>> LXR says the only > >>> > >>> users are a couple of projects that haven't even made it onto > >>> pro

Re: Review Request 116936: Use QLibrary instead of KLibrary

2014-03-23 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116936/#review53834 --- Ship it! src/html/kopenssl.cpp

Re: Review Request 116937: Use QLibrary instead of KLibrary in KOpenSSL

2014-03-23 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116937/#review53835 --- Ship it! Ship It! - David Faure On March 20, 2014, 8:50 p.

Re: Review Request 116930: Fix "device not open" warning messages at build time

2014-03-23 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116930/ --- (Updated March 23, 2014, 8:12 p.m.) Review request for KDE Frameworks and

Re: Review Request 116957: Replace fake MIME type all/allfiles with application/octet-stream

2014-03-23 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116957/#review53838 --- Ship it! Ship It! - David Faure On March 21, 2014, 5:05 p.

Re: Review Request 116958: Update comment referencing fake MIME types

2014-03-23 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116958/#review53839 --- Hmm clearly the whole thing can be removed if there are no mor

Re: Review Request 116962: Clean up KDE4 references in kconfig

2014-03-23 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116962/#review53841 --- Ship it! - David Faure On March 21, 2014, 6:15 p.m., Alex M

Re: Review Request 117000: Rename kmimetypefactory.h to kmimetypefactory_p.h

2014-03-23 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117000/#review53850 --- Ship it! Ship It! - David Faure On March 23, 2014, 4:45 p.

Re: Review Request 116461: KConfigSkeleton: avoid calling reparseConfiguration() immediately after creation.

2014-03-23 Thread Matthew Dawson
> On Feb. 28, 2014, 3:41 p.m., Matthew Dawson wrote: > > While I'm fine with the idea behind this optimization, I worry that this > > implementation could create situations were a configuration change is not > > picked up by the system. For instance, what happens if the user doesn't > > immed

Re: Review Request 116967: Fix doc in KUrlPixmapProvider

2014-03-23 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116967/#review53854 --- Ship it! Ship It! - David Faure On March 21, 2014, 10:20 p

Re: Review Request 116959: Remove KDE 4 references from kcmutils

2014-03-23 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116959/#review53855 --- Ship it! with one fix first src/kcmultidialog.cpp

Re: Review Request 116968: Fix doc in KToolBarLabelAction

2014-03-23 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116968/#review53856 --- Ship it! Ship It! - David Faure On March 21, 2014, 10:27 p

Re: Review Request 116969: Remove private reset() and move the implementation to the public reset() in KHistoryComboBox

2014-03-23 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116969/#review53857 --- I don't really get the point of this change? (it's mostly a TO

Re: Review Request 116970: Remove wish in KComboBox

2014-03-23 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116970/#review53858 --- Ship it! Ship It! - David Faure On March 21, 2014, 11:06 p

Re: Review Request 116971: Remove eventFilter and wheelEvent, apparently not needed anymore in KComboBox

2014-03-23 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116971/#review53859 --- Ship it! Ship It! - David Faure On March 21, 2014, 11:16 p

Re: Review Request 116993: Use KPluginLoader::findPlugin and QLibrary instead of KLibrary

2014-03-23 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116993/#review53860 --- Ship it! Ship It! - David Faure On March 23, 2014, 2:18 p.

Re: Review Request 116845: Make readConfig() non-virtual anymore, it's not useful. Remove unnecessary debug output Add KCoreConfigSkeleton::read() which doesn't call reparseConfiguration.

2014-03-23 Thread Matthew Dawson
> On March 16, 2014, 11:10 p.m., Matthew Dawson wrote: > > src/core/kcoreconfigskeleton.h, line 1055 > > > > > > I can't find any instances (lxr.kde.org returns way too many results to > > thoroughly check) whe

Re: Review Request 116845: Make readConfig() non-virtual anymore, it's not useful. Remove unnecessary debug output Add KCoreConfigSkeleton::read() which doesn't call reparseConfiguration.

2014-03-23 Thread Matthew Dawson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116845/#review53862 --- Ship it! Everything seems fine for this to go in as is. The

Re: Review Request 116845: Make readConfig() non-virtual anymore, it's not useful. Remove unnecessary debug output Add KCoreConfigSkeleton::read() which doesn't call reparseConfiguration.

2014-03-23 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116845/ --- (Updated March 23, 2014, 10 p.m.) Status -- This change has been mar

Re: Review Request 116845: Make readConfig() non-virtual anymore, it's not useful. Remove unnecessary debug output Add KCoreConfigSkeleton::read() which doesn't call reparseConfiguration.

2014-03-23 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116845/#review53864 --- This review has been submitted with commit c1980dbc51c9aa2770

Re: Review Request 116461: KConfigSkeleton: avoid calling reparseConfiguration() immediately after creation.

2014-03-23 Thread David Faure
> On Feb. 28, 2014, 8:41 p.m., Matthew Dawson wrote: > > While I'm fine with the idea behind this optimization, I worry that this > > implementation could create situations were a configuration change is not > > picked up by the system. For instance, what happens if the user doesn't > > immed

Re: Review Request 116995: Rename the kconfig_compiler_kf5 target to kconfig_compiler

2014-03-23 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116995/#review53869 --- Ship it! Ship It! - David Faure On March 23, 2014, 2:52 p.

Re: Review Request 116971: Remove eventFilter and wheelEvent, apparently not needed anymore in KComboBox

2014-03-23 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116971/#review53871 --- This review has been submitted with commit 5efd23a2aa5ff510e7

Re: Review Request 116971: Remove eventFilter and wheelEvent, apparently not needed anymore in KComboBox

2014-03-23 Thread David Gil Oliva
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116971/ --- (Updated March 23, 2014, 11 p.m.) Status -- This change has been mar

Re: Review Request 116970: Remove wish in KComboBox

2014-03-23 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116970/#review53872 --- This review has been submitted with commit 03d7d5aaeebaccba46

Re: Review Request 116970: Remove wish in KComboBox

2014-03-23 Thread David Gil Oliva
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116970/ --- (Updated March 23, 2014, 11:03 p.m.) Status -- This change has been

Re: Review Request 116966: Reorder private variables of KLineEditPrivate to avoid padding

2014-03-23 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116966/#review53873 --- This review has been submitted with commit 229f334352e40071f7

Re: Review Request 116966: Reorder private variables of KLineEditPrivate to avoid padding

2014-03-23 Thread David Gil Oliva
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116966/ --- (Updated March 23, 2014, 11:04 p.m.) Status -- This change has been

Re: Review Request 116967: Fix doc in KUrlPixmapProvider

2014-03-23 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116967/#review53874 --- This review has been submitted with commit 601a4d3b520bef8f0e

Re: Review Request 116967: Fix doc in KUrlPixmapProvider

2014-03-23 Thread David Gil Oliva
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116967/ --- (Updated March 23, 2014, 11:08 p.m.) Status -- This change has been

Re: Review Request 116968: Fix doc in KToolBarLabelAction

2014-03-23 Thread David Gil Oliva
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116968/ --- (Updated March 23, 2014, 11:10 p.m.) Status -- This change has been

Re: Review Request 116968: Fix doc in KToolBarLabelAction

2014-03-23 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116968/#review53875 --- This review has been submitted with commit a7a2af528fab6d412b

Review Request 117010: Finish renames in KCoreConfigSkeleton, and stop doing extra loads as well.

2014-03-23 Thread Matthew Dawson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117010/ --- Review request for KDE Frameworks and David Faure. Repository: kconfig

Re: Review Request 117010: Finish renames in KCoreConfigSkeleton, and stop doing extra loads as well.

2014-03-23 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117010/#review53876 --- Ah, the old usrReadConfig still exists, OK, that solves my wor

Review Request 117011: Use bin/../share on Windows as a workaround

2014-03-23 Thread Andrius da Costa Ribas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117011/ --- Review request for KDE Frameworks and kdewin. Repository: kdoctools Des

Re: Review Request 116866: Use std::isnan on compilers that support it (fixes MinGW on Windows)

2014-03-23 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116866/#review53877 --- src/colors/kcolorutils.cpp

Re: Review Request 117011: Use bin/../share on Windows as a workaround

2014-03-23 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117011/#review53878 --- So what should happen so that we didn't need the workaround?

Re: Review Request 117011: Use bin/../share on Windows as a workaround

2014-03-23 Thread Alexander Richardson
> On March 24, 2014, 12:51 a.m., Aleix Pol Gonzalez wrote: > > So what should happen so that we didn't need the workaround? QStandardPaths would have to look in %KDEROOT%\share and not just C:\ProgramData. - Alexander --- This is an au

Re: Review Request 117011: Use bin/../share on Windows as a workaround

2014-03-23 Thread Luigi Toscano
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117011/#review53880 --- Please add kdewin too. Given the outcome of the other RR, I'm

Re: Review Request 117010: Finish renames in KCoreConfigSkeleton, and stop doing extra loads as well.

2014-03-23 Thread Alexander Richardson
> On March 24, 2014, 12:22 a.m., David Faure wrote: > > src/core/kcoreconfigskeleton.cpp, line 1112 > > > > > > Won't this break with MSVC? Shouldn't break MSVC, it will just give a unknown pragma warning. Neve

Re: Review Request 117011: Use bin/../share on Windows as a workaround

2014-03-23 Thread Aleix Pol Gonzalez
> On March 23, 2014, 11:51 p.m., Aleix Pol Gonzalez wrote: > > So what should happen so that we didn't need the workaround? > > Alexander Richardson wrote: > QStandardPaths would have to look in %KDEROOT%\share and not just > C:\ProgramData. So why aren't we adding this in Qt? Or even, why

Re: Review Request 117004: Remove out-of-date design docs

2014-03-23 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117004/#review53884 --- Ship it! Ship It! - Christoph Feck On March 23, 2014, 5:47

Review Request 117012: Place KJsEmbed camelcase header under ${INCLUDE_INSTALL_DIR}/KJsEmbed/kjsembed

2014-03-23 Thread Andrius da Costa Ribas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117012/ --- Review request for KDE Frameworks and kdewin. Repository: kjsembed Desc

Build failed in Jenkins: krunner_master_qt5 #37

2014-03-23 Thread KDE CI System
See Changes: [scripty] SVN_SILENT made messages (.desktop file) -- Started by remote host 127.0.0.1 with note: Triggered by commit Building remotely on LinuxSlave - 1 (PACKAGER LINBUILDER) in workspa

Jenkins build became unstable: kde4support_master_qt5 #85

2014-03-23 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Problems found by the CI system

2014-03-23 Thread Ben Cooksley
Hi all, It seems lately that people have been breaking builds and not fixing the results, and some builds are extremely unreliable. It would be appreciated if these could be fixed. Frameworks folks, when pushing binary incompatible changes, please ensure you push them to the frameworks in the cor