D11941: Make it possible for KTextEditor to build on Android NDK's gcc 4.9

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. If that stuff is not around, why not, better than no compilation. Thanks for taking care! REPOSITORY R39 KTextEditor BRANCH master REVISION DETAIL

D11924: Add "SkipSwitcher" to API

sharvey added a comment. Thanks, @graesslin. I enjoyed this challenge. I removed the `[WIP]` tag from the title. REPOSITORY R278 KWindowSystem BRANCH skip-switcher (branched from master) REVISION DETAIL https://phabricator.kde.org/D11924 To: sharvey, hein, graesslin Cc: ngraham,

D11924: Add "SkipSwitcher" to API

sharvey retitled this revision from "[WIP] Add "SkipSwitcher" to API" to "Add "SkipSwitcher" to API". REPOSITORY R278 KWindowSystem BRANCH skip-switcher (branched from master) REVISION DETAIL https://phabricator.kde.org/D11924 To: sharvey, hein, graesslin Cc: ngraham, graesslin, apol,

D11924: [WIP] Add "SkipSwitcher" to API

graesslin accepted this revision. This revision is now accepted and ready to land. REPOSITORY R278 KWindowSystem BRANCH skip-switcher (branched from master) REVISION DETAIL https://phabricator.kde.org/D11924 To: sharvey, hein, graesslin Cc: ngraham, graesslin, apol, #frameworks, michaelh

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 - Build # 95 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.9/95/ Project: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 Date of build: Thu, 05 Apr 2018 03:28:43 + Build duration: 13 min and counting

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 120 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/120/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 Date of build: Thu, 05 Apr 2018 03:28:43 + Build duration: 10 min and counting JUnit

D11941: Make it possible for KTextEditor to build on Android NDK's gcc 4.9

apol added a comment. Proof F5789511: Screenshot_20180327-200943.png REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D11941 To: apol, #frameworks Cc: michaelh, kevinapavew, ngraham, demsking, cullmann, sars, dhaumann

D11941: Make it possible for KTextEditor to build on Android NDK's gcc 4.9

apol created this revision. apol added a reviewer: Frameworks. Restricted Application added projects: Kate, Frameworks. apol requested review of this revision. REVISION SUMMARY log2 and std::rename aren't available there. REPOSITORY R39 KTextEditor BRANCH master REVISION DETAIL

KDE CI: Frameworks kio kf5-qt5 WindowsMSVCQt5.10 - Build # 56 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20WindowsMSVCQt5.10/56/ Project: Frameworks kio kf5-qt5 WindowsMSVCQt5.10 Date of build: Thu, 05 Apr 2018 00:10:52 + Build duration: 18 min and counting

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 206 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/206/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Thu, 05 Apr 2018 00:10:52 + Build duration: 18 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 55 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/55/ Project: Frameworks kio kf5-qt5 SUSEQt5.9 Date of build: Thu, 05 Apr 2018 00:10:52 + Build duration: 10 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 183 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/183/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.9 Date of build: Wed, 04 Apr 2018 23:13:57 + Build duration: 20 min and counting JUnit Tests Name:

D11745: databasesanitizer: Use flags for filtering

bruns added inline comments. INLINE COMMENTS > databasesanitizer.h:41 > +IgnoreUnavailable = 2, > +IgnoreMounted = IgnoreAvailable << 1, > +IgnoreUnmounted = IgnoreUnavailable << 1 Is this correct? IgnoreMounted = (1 << 1) = 2 == IgnoreUnavailable? REPOSITORY R293

D11753: baloodb: Add clean command

bruns added inline comments. INLINE COMMENTS > michaelh wrote in databasesanitizer.cpp:333 > I did that before, but decided on `--dry-run` to simulate the process as > close as possible. > Also, compared to the time it takes to collect the data, removing the docs is > completely neglectible.

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 54 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/54/ Project: Frameworks kio kf5-qt5 SUSEQt5.9 Date of build: Wed, 04 Apr 2018 23:13:57 + Build duration: 14 min and counting JUnit Tests Name: (root)

D11767: Remove Recently Saved This Month and Recently Saved Last Month entries by default

rkflx added a comment. In D11767#240162 , @ngraham wrote: > That was before I got some formal acceptance. I probably should have ended with "if nobody formally accepts by then", which was the intention. This patch had been open for a week...

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 205 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/205/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Wed, 04 Apr 2018 23:13:57 + Build duration: 8 min 15 sec and counting JUnit Tests Name:

D11767: Remove Recently Saved This Month and Recently Saved Last Month entries by default

ngraham added a comment. That was before I got some formal acceptance. I probably should have ended with "if nobody formally accepts by then", which was the intention. This patch had been open for a week... REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D11767 To:

D11767: Remove Recently Saved This Month and Recently Saved Last Month entries by default

rkflx added a comment. In D11767#238868 , @ngraham wrote: > Okay, unless I hear any impassioned pleas in favor of these entries, I will commit this patch on Saturday, April 7th. Huh? REPOSITORY R241 KIO REVISION DETAIL

D11767: Remove Recently Saved This Month and Recently Saved Last Month entries by default

This revision was automatically updated to reflect the committed changes. Closed by commit R241:7e1d2fb84546: Remove Recently Saved This Month and Recently Saved Last Month entries by… (authored by ngraham). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D11767?vs=30798=31340#toc

D11767: Remove Recently Saved This Month and Recently Saved Last Month entries by default

ngraham added a comment. Thanks folks. REPOSITORY R241 KIO BRANCH remove-recently-saved-this-month-and-last-month (branched from master) REVISION DETAIL https://phabricator.kde.org/D11767 To: ngraham, #dolphin, #gwenview, #frameworks, #vdg, davidedmundson Cc: davidedmundson,

D11891: Fix crashes in NotifyByAudio when closing applications

aacid added a comment. In D11891#239437 , @rjvbb wrote: > This is about better and more concise English. The queued connection is the indirect explanation why the patch is necessary, and thus comes after the direct explanation (the fact that

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 53 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/53/ Project: Frameworks kio kf5-qt5 SUSEQt5.9 Date of build: Wed, 04 Apr 2018 22:20:27 + Build duration: 24 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 204 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/204/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Wed, 04 Apr 2018 22:20:27 + Build duration: 12 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks kio kf5-qt5 WindowsMSVCQt5.10 - Build # 54 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20WindowsMSVCQt5.10/54/ Project: Frameworks kio kf5-qt5 WindowsMSVCQt5.10 Date of build: Wed, 04 Apr 2018 22:20:27 + Build duration: 11 min and counting CONSOLE OUTPUT

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 182 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/182/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.9 Date of build: Wed, 04 Apr 2018 22:20:27 + Build duration: 8 min 36 sec and counting JUnit Tests Name:

D11734: Have KIO build for Android

This revision was automatically updated to reflect the committed changes. Closed by commit R241:a486fd6b2776: Have KIO build for Android (authored by apol). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11734?vs=31305=31335 REVISION DETAIL

D11888: Handle adjacent special characters correctly

bruns marked 8 inline comments as done. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D11888 To: bruns, #baloo, michaelh Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, alexeymin

D11907: advancedqueryparsertest: Add optimization test

bruns added a comment. Although this is probably a useful addition (haven't checked which cases the existing unit test already cover), it does not cover the changes in D11826 . The code in

D11924: [WIP] Add "SkipSwitcher" to API

sharvey marked 3 inline comments as done. REPOSITORY R278 KWindowSystem REVISION DETAIL https://phabricator.kde.org/D11924 To: sharvey, hein, graesslin Cc: ngraham, graesslin, apol, #frameworks, michaelh

D11924: [WIP] Add "SkipSwitcher" to API

sharvey updated this revision to Diff 31330. sharvey added a comment. - Add `_KDE` prefix to SkipSwitcher state; correct enum REPOSITORY R278 KWindowSystem CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11924?vs=31307=31330 BRANCH skip-switcher (branched from master) REVISION

D11924: [WIP] Add "SkipSwitcher" to API

sharvey added a subscriber: ngraham. REPOSITORY R278 KWindowSystem REVISION DETAIL https://phabricator.kde.org/D11924 To: sharvey, hein, graesslin Cc: ngraham, graesslin, apol, #frameworks, michaelh

D11924: [WIP] Add "SkipSwitcher" to API

sharvey marked an inline comment as done. REPOSITORY R278 KWindowSystem REVISION DETAIL https://phabricator.kde.org/D11924 To: sharvey, hein, graesslin Cc: graesslin, apol, #frameworks, michaelh, ngraham

D11907: advancedqueryparsertest: Add optimization test

bruns added inline comments. INLINE COMMENTS > advancedqueryparsertest.cpp:228 > +const QString nofail; > +QString phrase; > +phrase = QStringLiteral("a AND b AND c AND d"); better use a different name, phrase has a special meaning, i.e. Baloo:EngineQuery:Phrase REPOSITORY R293

D11924: [WIP] Add "SkipSwitcher" to API

sharvey added a comment. In D11924#240057 , @graesslin wrote: > In D11924#240045 , @graesslin wrote: > > > I'm not sure whether we can add elements to the states. > > An

D11734: Have KIO build for Android

aacid accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D11734 To: apol, #frameworks, aacid Cc: aacid, michaelh, ngraham

D10937: Retouching of Screen Layout Selection OSD Icons

ngraham added a comment. In D10937#240070 , @pstefan wrote: > I am glad you like them :) > > I will hand in the updated diff tomorrow. The color fix script somehow ate my icons and I have to restore them from a backup. You can

D10937: Retouching of Screen Layout Selection OSD Icons

abetts added a comment. I don't have any objections. Good work! +1 REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D10937 To: pstefan, #breeze, ngraham Cc: emateli, abetts, mart, ngraham, #frameworks, davidc, michaelh, crozbo, firef, alexeymin, skadinna,

D10937: Retouching of Screen Layout Selection OSD Icons

pstefan added a comment. I am glad you like them :) I will hand in the updated diff tomorrow. The color fix script somehow ate my icons and I have to restore them from a backup. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D10937 To: pstefan, #breeze,

D11924: [WIP] Add "SkipSwitcher" to API

graesslin added a comment. In D11924#240045 , @graesslin wrote: > I'm not sure whether we can add elements to the states. Just checked: An implementation MAY add new atoms to this list. Implementations without extensions MUST

D11924: [WIP] Add "SkipSwitcher" to API

graesslin requested changes to this revision. graesslin added a comment. This revision now requires changes to proceed. I'm not sure whether we can add elements to the states. INLINE COMMENTS > netwininfotestwm.cpp:432 > const QByteArray skipTaskbar = >

D11811: avoid Asan runtime error: shift exponent -1 is negative

This revision was automatically updated to reflect the committed changes. Closed by commit R39:3e8bbe0ad838: avoid Asan runtime error: shift exponent -1 is negative (authored by jtamate). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11811?vs=31271=31312

D10937: Retouching of Screen Layout Selection OSD Icons

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Heh, I don't think anyone is ever going to want to use 16x16 versions of these in the first place, so I can live with that. These icons look fantastic. Big +1 from me. Any other

D11925: [WIP] Add "SkipSwitcher" to API

sharvey marked 5 inline comments as done. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D11925 To: sharvey, hein, graesslin Cc: graesslin, #frameworks, michaelh, ngraham

D11925: [WIP] Add "SkipSwitcher" to API

sharvey updated this revision to Diff 31311. sharvey marked an inline comment as done. sharvey added a comment. - Correct & update version numbers in XML entries REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11925?vs=31308=31311 BRANCH skip-switcher

D11652: Don't show the background if Button.flat

apol updated this revision to Diff 31309. apol added a comment. Now both Button {flat: true} and ToolButton look the same REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11652?vs=30414=31309 BRANCH master REVISION DETAIL

D11776: Make use of upstream CMake infrastructure to detect the compiler toolchain

This revision was automatically updated to reflect the committed changes. Closed by commit R240:731ba7036eff: Make use of upstream CMake infrastructure to detect the compiler toolchain (authored by apol). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE

D11925: [WIP] Add "SkipSwitcher" to API

sharvey marked 2 inline comments as done. sharvey added inline comments. INLINE COMMENTS > graesslin wrote in plasmawindowmodel.h:110 > I normally update those just before pushing to the next frameworks release > number. Sorry. Was busy uploading before seeing your reply. Will gladly change

D11925: [WIP] Add "SkipSwitcher" to API

sharvey updated this revision to Diff 31308. sharvey added a comment. - Add `@since 5.45` tag to SkipSwitcher doxygen comments REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11925?vs=31296=31308 BRANCH skip-switcher (branched from master) REVISION

D11924: [WIP] Add "SkipSwitcher" to API

sharvey marked an inline comment as done. REPOSITORY R278 KWindowSystem REVISION DETAIL https://phabricator.kde.org/D11924 To: sharvey, hein Cc: apol, #frameworks, michaelh, ngraham

D11924: [WIP] Add "SkipSwitcher" to API

sharvey updated this revision to Diff 31307. sharvey added a comment. - Add `@since 5.45` to SkipSwitcher doxygen comments REPOSITORY R278 KWindowSystem CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11924?vs=31294=31307 BRANCH skip-switcher (branched from master) REVISION

D11925: [WIP] Add "SkipSwitcher" to API

graesslin requested changes to this revision. graesslin added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > sharvey wrote in plasmawindowmodel.h:110 > Correct version number? 5.45? I normally update those just before pushing to the next frameworks release

D11683: Make it possible to request a plugin configuration module programatically

This revision was automatically updated to reflect the committed changes. Closed by commit R295:0a3c90c89bdb: Make it possible to request a plugin configuration module programatically (authored by apol). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D11683?vs=30512=31306#toc REPOSITORY

D11734: Have KIO build for Android

apol updated this revision to Diff 31305. apol added a comment. Include comment saying that method won't work on Android REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11734?vs=30676=31305 BRANCH master REVISION DETAIL https://phabricator.kde.org/D11734

D11924: [WIP] Add "SkipSwitcher" to API

sharvey added a comment. In D11924#239922 , @apol wrote: > 5.44 was just released, so I'd assume it's 5.45 (or we can fix change it later if it takes us longer to merge). I took a minute to think it through and came to the conclusion of

D11924: [WIP] Add "SkipSwitcher" to API

apol added a comment. 5.44 was just released, so I'd assume it's 5.45 (or we can fix change it later if it takes us longer to merge). REPOSITORY R278 KWindowSystem REVISION DETAIL https://phabricator.kde.org/D11924 To: sharvey, hein Cc: apol, #frameworks, michaelh, ngraham

D11924: [WIP] Add "SkipSwitcher" to API

sharvey added inline comments. INLINE COMMENTS > apol wrote in netwm_def.h:492 > add `@since 5.45`? Will it be `5.45` for KWayland as well? There were `@since` tags in what I duplicated, but I wasn't certain which version. REPOSITORY R278 KWindowSystem REVISION DETAIL

D11924: [WIP] Add "SkipSwitcher" to API

apol added inline comments. INLINE COMMENTS > netwm_def.h:492 > /** > + indicates that a window should not be included on a switcher. > +**/ add `@since 5.45`? REPOSITORY R278 KWindowSystem REVISION DETAIL https://phabricator.kde.org/D11924 To: sharvey, hein

D10937: Retouching of Screen Layout Selection OSD Icons

pstefan added a comment. Latest revision: F5787871: pls_assess.png I moved the window a bit up while maintaining the alignment, as requested. I had to remove the stand of the projector screen tho. Originally I "cheated" and moved the stand

D11925: [WIP] Add "SkipSwitcher" to API

sharvey added inline comments. INLINE COMMENTS > plasmawindowmodel.h:110 > +/** > + * @since 5.?? > + */ Correct version number? 5.45? > plasmashell_interface.h:144 > + * in a window switcher > + * @since 5.?? > + **/ Version 5.45? REPOSITORY R127

D11767: Remove Recently Saved This Month and Recently Saved Last Month entries by default

michaelh added a comment. > Let me announce that I'm willing to take all the heat from any potential issues, so feel free to offer formal acceptance, folks! :-) Can I have this as a signature? > It comes from gerrit that most of us use for Qt. >

D11925: [WIP] Add "SkipSwitcher" to API

sharvey edited the summary of this revision. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D11925 To: sharvey, hein Cc: #frameworks, michaelh, ngraham

D11924: [WIP] Add "SkipSwitcher" to API

sharvey edited the summary of this revision. REPOSITORY R278 KWindowSystem REVISION DETAIL https://phabricator.kde.org/D11924 To: sharvey, hein Cc: #frameworks, michaelh, ngraham

D11767: Remove Recently Saved This Month and Recently Saved Last Month entries by default

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. > Is there social convention I miss? It comes from gerrit that most of us use for Qt. https://gerrit-review.googlesource.com/Documentation/config-labels.html

D11925: [WIP] Add "SkipSwitcher" to API

sharvey added a comment. F5787709: kwayland-test-exception.txt KWayland test results / exception report REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D11925 To: sharvey, hein Cc: #frameworks, michaelh, ngraham

D11767: Remove Recently Saved This Month and Recently Saved Last Month entries by default

ngraham added a comment. In general, people offer a +1 without formally accepting when they generally and vaguely approve, but not enough to: - Care that much about it - Want to put their formal stamp of approval on it for the purpose of blame if it breaks or proves unpopular Let

D11925: [WIP] Add "SkipSwitcher" to API

sharvey added a comment. NOTE: This is a junior job and a work in progress! Following discussion in BUG 375921 , it was decided to add `SkipSwitcher` to the API. This is my first submission to the KWin/KWayland/KWindowSystem group, and @hein

D11925: [WIP] Add "SkipSwitcher" to API

sharvey created this revision. sharvey added a reviewer: hein. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. sharvey requested review of this revision. REVISION SUMMARY Adding "SkipSwitcher" to API, as a result of discussion in BUG

D11924: [WIP] Add "SkipSwitcher" to API

sharvey added a comment. NOTE: This is a junior job and a work in progress! After discussion in BUG 375921 , it was decided to add `SkipSwitcher` to the KWin API. It's a junior job and my first submission to the KWin/KWayland/KWindowSystem

D11924: [WIP] Add "SkipSwitcher" to API

sharvey created this revision. sharvey added a reviewer: hein. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. sharvey requested review of this revision. REVISION SUMMARY Adding "SkipSwitcher" to API, stemming from discussion in BUG

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 119 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/119/ Project: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 Date of build: Wed, 04 Apr 2018 12:39:38 + Build duration: 13 min and counting JUnit

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 - Build # 94 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.9/94/ Project: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 Date of build: Wed, 04 Apr 2018 12:39:38 + Build duration: 9 min 11 sec and counting

D11922: Wallpaper templates: set background color to ensure contrast to sample text content

This revision was automatically updated to reflect the committed changes. Closed by commit R242:682dd4a142fa: Wallpaper templates: set background color to ensure contrast to sample text… (authored by kossebau). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D11922: Wallpaper templates: set background color to ensure contrast to sample text content

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH improvetemplateswithbackground REVISION DETAIL https://phabricator.kde.org/D11922 To: kossebau, #plasma, mart Cc: #frameworks, michaelh, ngraham

D11882: autotests: Use built executable instead of installed

michaelh retitled this revision from "extractortest: Use built executable instead of installed" to "autotests: Use built executable instead of installed". REPOSITORY R824 Baloo Widgets REVISION DETAIL https://phabricator.kde.org/D11882 To: michaelh, elvisangelaccio, #baloo, #frameworks Cc:

D11922: Wallpaper templates: set background color to ensure contrast to sample text content

kossebau created this revision. kossebau added reviewers: Plasma, mart. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. kossebau requested review of this revision. REVISION SUMMARY To avoid black text on black background and thus

D11882: extractortest: Use built executable instead of installed

michaelh added a comment. In D11882#239638 , @alexeymin wrote: > Code looks fine, but I did not test if it actually works. ;) It's a little hard to see the effect of this, because the installed extractor and the freshly built have to

D11882: extractortest: Use built executable instead of installed

michaelh marked 3 inline comments as done. REPOSITORY R824 Baloo Widgets REVISION DETAIL https://phabricator.kde.org/D11882 To: michaelh, elvisangelaccio, #baloo, #frameworks Cc: alexeymin, ashaposhnikov, astippich, spoorun

D11882: extractortest: Use built executable instead of installed

michaelh updated this revision to Diff 31289. michaelh added a comment. - Move excess space to line 58 REPOSITORY R824 Baloo Widgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11882?vs=31267=31289 BRANCH testexe (branched from master) REVISION DETAIL

D11767: Remove Recently Saved This Month and Recently Saved Last Month entries by default

michaelh added a comment. Why is sum(+1) == +3 but noone accepted this? Is there social convention I miss? (It's scaring me off from simply accepting this.) +1 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D11767 To: ngraham, #dolphin, #gwenview, #frameworks, #vdg

D11882: extractortest: Use built executable instead of installed

alexeymin added a comment. Code looks fine, but I did not test if it actually works. ;) INLINE COMMENTS > filemetadatawidgettest.cpp:58 > +const auto extractorPath = QDir( > QStringLiteral("%1/baloo_filemetadata_temp_extractor").arg(QFINDTESTDATA("../src"))).absolutePath(); > + >

D11811: avoid Asan runtime error: shift exponent -1 is negative

mwolff accepted this revision. mwolff added a comment. This revision is now accepted and ready to land. thanks REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D11811 To: jtamate, #kate, #frameworks, mwolff Cc: mwolff, brauch, michaelh, kevinapavew, ngraham,

D11811: avoid Asan runtime error: shift exponent -1 is negative

jtamate updated this revision to Diff 31271. jtamate added a comment. Implemented mwolf solution. REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11811?vs=30952=31271 REVISION DETAIL https://phabricator.kde.org/D11811 AFFECTED FILES

D11882: extractortest: Use built executable instead of installed

michaelh added a dependent revision: D11913: Change property selection to opt-in. REPOSITORY R824 Baloo Widgets REVISION DETAIL https://phabricator.kde.org/D11882 To: michaelh, elvisangelaccio, #baloo, #frameworks Cc: alexeymin, ashaposhnikov, astippich, spoorun

D11882: extractortest: Use built executable instead of installed

michaelh updated this revision to Diff 31267. michaelh added a comment. - Use list separator REPOSITORY R824 Baloo Widgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11882?vs=31265=31267 BRANCH testexe (branched from master) REVISION DETAIL

D11882: extractortest: Use built executable instead of installed

michaelh added inline comments. INLINE COMMENTS > alexeymin wrote in filemetadatawidgettest.cpp:60 > Should probably use `QDir::listSeparator()` instead of this `#ifdef` logic Great! Thanks. REPOSITORY R824 Baloo Widgets REVISION DETAIL https://phabricator.kde.org/D11882 To: michaelh,

D11882: extractortest: Use built executable instead of installed

alexeymin added inline comments. INLINE COMMENTS > filemetadatawidgettest.cpp:60 > +qputenv("PATH", qPrintable(QStringLiteral("%1;%2").arg(np).arg(op))); > +#endif > +const auto extractorPath = QDir( >

D11882: extractortest: Use built executable instead of installed

michaelh updated this revision to Diff 31265. michaelh added a comment. - Add our extractor to PATH REPOSITORY R824 Baloo Widgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11882?vs=31145=31265 BRANCH testexe (branched from master) REVISION DETAIL

KDE CI: Frameworks breeze-icons kf5-qt5 SUSEQt5.9 - Build # 16 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.9/16/ Project: Frameworks breeze-icons kf5-qt5 SUSEQt5.9 Date of build: Wed, 04 Apr 2018 08:58:37 + Build duration: 9 min 9 sec and counting JUnit Tests

KDE CI: Frameworks breeze-icons kf5-qt5 FreeBSDQt5.9 - Build # 68 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20FreeBSDQt5.9/68/ Project: Frameworks breeze-icons kf5-qt5 FreeBSDQt5.9 Date of build: Wed, 04 Apr 2018 08:58:37 + Build duration: 3 min 48 sec and counting JUnit

KDE CI: Frameworks breeze-icons kf5-qt5 SUSEQt5.10 - Build # 72 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.10/72/ Project: Frameworks breeze-icons kf5-qt5 SUSEQt5.10 Date of build: Wed, 04 Apr 2018 08:58:37 + Build duration: 3 min 31 sec and counting JUnit

D11888: Handle adjacent special characters correctly

michaelh added inline comments. INLINE COMMENTS > bruns wrote in advancedqueryparser.cpp:69 > > I don't understand. token is QString. Why not instead of switch > > (token.at(0).toLatin1()) > > > > switch (token) { > > case '>'`: comparator = Term::Greater; break; > > case '>='`:

KDE CI: Frameworks kinit kf5-qt5 SUSEQt5.10 - Build # 19 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kinit%20kf5-qt5%20SUSEQt5.10/19/ Project: Frameworks kinit kf5-qt5 SUSEQt5.10 Date of build: Wed, 04 Apr 2018 08:02:37 + Build duration: 10 min and counting JUnit Tests Name: (root)

D11822: Make the word/char count a global preference

cullmann accepted this revision. cullmann added a comment. Yeah, makes sense. Thanks for the contribution. REPOSITORY R39 KTextEditor BRANCH patch-1 REVISION DETAIL https://phabricator.kde.org/D11822 To: wsdfhjxc, #ktexteditor, #kate, mwolff, cullmann Cc: mwolff, dhaumann,