KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 80 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/80/ Project: Frameworks kio kf5-qt5 SUSEQt5.9 Date of build: Tue, 24 Apr 2018 03:26:39 + Build duration: 10 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 231 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/231/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Tue, 24 Apr 2018 03:26:39 + Build duration: 8 min 8 sec and counting JUnit Tests Name:

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 209 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/209/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.9 Date of build: Tue, 24 Apr 2018 03:26:39 + Build duration: 5 min 45 sec and counting JUnit Tests Name:

D12311: Align lock icon with bold message text; reduce overall size of dialog

bruns added a comment. In D12311#252212 , @stikonas wrote: > In D12311#252165 , @bruns wrote: > > > Resizing:

D12320: add ability to read embedded cover files

bruns added a comment. In D12320#252547 , @mgallien wrote: > In D12320#249998 , @astippich wrote: > > > In D12320#249982 , @michaelh wrote: > > > > >

D12156: implement reading of rating tag

bruns added a comment. In D12156#252575 , @mgallien wrote: > In D12156#249994 , @astippich wrote: > > > In D12156#249977 , @michaelh wrote: > > > > >

D10078: Add separate lib KF5::DBusRunner

kossebau added inline comments. INLINE COMMENTS > davidedmundson wrote in abstractrunner_p.h:46 > This undermines the advantages of my changes. > Its not object oriented anymore. I tried to reason in the update message why I think after having tried that API that some other OO approach feels

D10078: Add separate lib KF5::DBusRunner

davidedmundson requested changes to this revision. davidedmundson added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > abstractrunner_p.h:46 > + > +void cancelMatching(const RunnerContext::Ptr ); > +void finishMatching(const RunnerContext::Ptr ); This

D10078: Add separate lib KF5::DBusRunner

kossebau updated this revision to Diff 32916. kossebau added a comment. Updating with proposed further massaging of the API - changed some class/method names to closely follow KRunner terms: (RunnerContext, query) - moved RunnerContext into separate header (for one per class) -

D12156: implement reading of rating tag

mgallien requested changes to this revision. mgallien added a comment. This revision now requires changes to proceed. In D12156#249994 , @astippich wrote: > In D12156#249977 , @michaelh wrote: > >

D12477: Add unit test to see that :/ files can work

kossebau added a comment. It passes only by pure chance as NotepadPart uses QFile, which understands such an url. So the value of that new autptest is questionable, as this is not testing any API promise. For `ReadOnlyPart::localFilePath()` it says: "Returns the local file path

D12320: add ability to read embedded cover files

mgallien added a comment. In D12320#249998 , @astippich wrote: > In D12320#249982 , @michaelh wrote: > > > -2 > > https://cgit.kde.org/ffmpegthumbs.git/ should be useable, not sure though. >

D12477: Add unit test to see that :/ files can work

svuorela created this revision. svuorela added reviewers: dfaure, kossebau, Frameworks. Restricted Application added a project: Frameworks. svuorela requested review of this revision. REVISION SUMMARY I wasn't sure if :/foo stuff would work, so I tried writing a unit test to help me. Let's

D12321: Hide file preview when icon is too small

rkflx added a comment. In D12321#252421 , @markg wrote: > I've not tried this patch nor the svg patch. Maybe you should, to get a feel for how nice this works! > My comment was based on what i see in an icon folder right in front of

D11925: Add "SkipSwitcher" to API

sharvey marked 3 inline comments as done. sharvey added a comment. Changes made. KWayland compiles fine now. Thank you. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D11925 To: sharvey, hein, graesslin Cc: davidedmundson, #plasma, graesslin, #frameworks, michaelh,

D11925: Add "SkipSwitcher" to API

sharvey updated this revision to Diff 32906. sharvey added a comment. - Update interface version number; move setSkipSwitcherCallback to end of struct REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11925?vs=31311=32906 BRANCH arcpatch-D11925 REVISION

D11925: Add "SkipSwitcher" to API

graesslin added a comment. There is one more file which need changes. In src/client/registry.cpp you need to increase the version numbers of the two changed protocols. Adding a new request can be really cumbersome. INLINE COMMENTS > plasmashell_interface.cpp:53 > > const quint32

D10078: Add separate lib KF5::DBusRunner

kossebau commandeered this revision. kossebau edited reviewers, added: davidedmundson; removed: kossebau. REPOSITORY R308 KRunner REVISION DETAIL https://phabricator.kde.org/D10078 To: kossebau, broulik, davidedmundson Cc: bruns, michaelh, ngraham, #frameworks

D12321: Hide file preview when icon is too small

ngraham added a comment. In D12321#252421 , @markg wrote: > My comment was based on what i see in an icon folder right in front of me at this very moment. > 16x16 icons are scaled to whatever the zoom level is (which is fine imho). These

D12321: Hide file preview when icon is too small

markg added a comment. In D12321#252393 , @rkflx wrote: > In D12321#252374 , @markg wrote: > > > The blown up way of looking at it (resized version) does not give you an accurate representation of

Re: [kcoreaddons] src/lib: Revert "Warning--"

Sorry for the noise, saw that the patch was fixed and committed again. Gah...

Re: [kcoreaddons] src/lib: Revert "Warning--"

Hi Ben, Is it possible to have cgit.kde.org show commit hashes in the 'log' tab (for example [1])? As for the Laurent's patch, it looks quite sane, so I guess the failed compilation for other platforms should be investigated further (I've put Laurent in the TO: field because of this). Cheers,

D12321: Hide file preview when icon is too small

rkflx added a comment. In D12321#252374 , @markg wrote: > The blown up way of looking at it (resized version) does not give you an accurate representation of how it will look like in the native size. Have you actually tried the patch.

D12321: Hide file preview when icon is too small

rkflx added a comment. In D12321#252372 , @markg wrote: > You said: > > > This automatic logic is already there. You are simply objecting to not allowing previews for small icons. Yes, we will remove this possibility which was there before.

D12321: Hide file preview when icon is too small

markg added a comment. In D12321#252366 , @ngraham wrote: > In D12321#252365 , @markg wrote: > > > > Browse... grid view... small size... previews... icons... so you want to be able to do this? >

D12321: Hide file preview when icon is too small

markg added a comment. In D12321#252369 , @rkflx wrote: > In D12321#252337 , @markg wrote: > > > In those cases where you just browse through a gazillion icons (nothing with an icon picker or

D12306: Improve grid icon layout in filepicker dialog

rkflx retitled this revision from "Filepicker dialog proper grid icon layout" to "Improve grid icon layout in filepicker dialog". REPOSITORY R241 KIO BRANCH grid_layout (branched from master) REVISION DETAIL https://phabricator.kde.org/D12306 To: anemeth, #frameworks, #vdg, ngraham,

D12321: Hide file preview when icon is too small

rkflx added a comment. In D12321#252337 , @markg wrote: > In those cases where you just browse through a gazillion icons (nothing with an icon picker or selecting icons, i didn't say any of that) becomes impossible in your future patch. >

D12321: Hide file preview when icon is too small

ngraham added a comment. In D12321#252365 , @markg wrote: > > Browse... grid view... small size... previews... icons... so you want to be able to do this? > > > > F5819296: Small, not useful.png >

D12321: Hide file preview when icon is too small

markg added a comment. In D12321#252346 , @ngraham wrote: > In D12321#252337 , @markg wrote: > > > In D12321#252299 , @rkflx wrote: > > > > > > Then

D12321: Hide file preview when icon is too small

ngraham added a comment. In D12321#252337 , @markg wrote: > In D12321#252299 , @rkflx wrote: > > > > Then you make it impossible (ultimately, not with this patch though) to for instance browse

D12321: Hide file preview when icon is too small

markg added a comment. In D12321#252299 , @rkflx wrote: > > Then you make it impossible (ultimately, not with this patch though) to for instance browse through folders with small icons (say icon sets). > > We have an explicit icon chooser

D12420: Make the warning text for deletion operations emphasize its permanency and irreversibility

ngraham marked an inline comment as done. ngraham added inline comments. INLINE COMMENTS > elvisangelaccio wrote in jobuidelegate.cpp:229 > Please use semantic markup and the `` tag instead of `\n`, see > https://api.kde.org/frameworks/ki18n/html/prg_guide.html#kuit_markup Couldn't get ``

D12420: Make the warning text for deletion operations emphasize its permanency and irreversibility

ngraham edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12420 To: ngraham, #frameworks, #dolphin, elvisangelaccio Cc: michaelh, bruns

D12420: Make the warning text for deletion operations emphasize its permanency and irreversibility

ngraham updated this revision to Diff 32885. ngraham added a comment. Use semantic markup tags REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12420?vs=32748=32885 BRANCH more-serious-delete-text (branched from master) REVISION DETAIL

D12321: Hide file preview when icon is too small

ngraham added a comment. Sorry Mark, I can respect your opinion, but I just don't see the practical impact. First of all, SVG previews for icons didn't even work at all until yesterday, when Alex fixed it in D12389: Filepicker reads thumbs preview from Dolphin settings

D12321: Hide file preview when icon is too small

anemeth added a comment. In D12321#252299 , @rkflx wrote: > Also, as you may have noticed, the file dialog does not show previews of SVGs for any size, making your point moot. Actually with D12389

D12321: Hide file preview when icon is too small

rkflx added a comment. > simply set the icon size large enough (38px for me) To add to that: The icon //will// be shown at its native size, the "icon size" in this case is only about the grid spacing! REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12321 To:

D12321: Hide file preview when icon is too small

rkflx added a comment. > Then you make it impossible (ultimately, not with this patch though) to for instance browse through folders with small icons (say icon sets). We have an explicit icon chooser dialog for this task, using the file dialog is not the recommended way for apps to

D12321: Hide file preview when icon is too small

markg added a comment. In D12321#252285 , @rkflx wrote: > In D12321#252283 , @markg wrote: > > > In D12321#252282 , @rkflx wrote: > > > > > In

D12321: Hide file preview when icon is too small

rkflx added a comment. In D12321#252283 , @markg wrote: > In D12321#252282 , @rkflx wrote: > > > In D12321#252281 , @markg wrote: > > > > > I agree but

D12321: Hide file preview when icon is too small

markg added a comment. In D12321#252282 , @rkflx wrote: > In D12321#252281 , @markg wrote: > > > I agree but not for a button that the user controls. > > > We already disable options where they

D12321: Hide file preview when icon is too small

rkflx added a comment. In D12321#252281 , @markg wrote: > I agree but not for a button that the user controls. We already disable options where they do not make sense, see the Icon position setting which is only available in select view

D12321: Hide file preview when icon is too small

markg added a comment. In D12321#252264 , @rkflx wrote: > In D12321#252261 , @markg wrote: > > > That is unexpected behavior. > > > I disagree, adapting the interface dynamically is good

D12321: Hide file preview when icon is too small

rkflx added a comment. @markg One more thing: This patch is a prerequisite for D12321: Hide file preview when icon is too small , because otherwise for small icons the previews would also be turned on by default, which we don't want obviously (even you

D12321: Hide file preview when icon is too small

rkflx added a comment. In D12321#252261 , @markg wrote: > That is unexpected behavior. I disagree, adapting the interface dynamically is good design. > A tri-state would prevent that. > For the record, if it becomes a tri-state i

D12321: Hide file preview when icon is too small

markg added a comment. In D12321#252259 , @anemeth wrote: > In D12321#252238 , @markg wrote: > > > You are overwriting a setting that the user had explicitly set (show preview). That will result in

D12321: Hide file preview when icon is too small

rkflx added a comment. In D12321#252258 , @anemeth wrote: > In D12321#252245 , @rkflx wrote: > > > That's simply a bug with the patch: Enable previews, set small icon set, click Cancel, reopen

D12321: Hide file preview when icon is too small

anemeth added a comment. In D12321#252238 , @markg wrote: > You are overwriting a setting that the user had explicitly set (show preview). That will result in a "huh, why is the preview off all of a sudden?" responses which will lead to bug

D12321: Hide file preview when icon is too small

anemeth added a comment. In D12321#252245 , @rkflx wrote: > That's simply a bug with the patch: Enable previews, set small icon set, click Cancel, reopen dialog, set large icon size. Previews should still be enabled, but they are not. I

D11470: SQL: various improvements and fix if/case/loop/end detection with SQL (Oracle)

rkflx added a comment. Sorry for chiming in, but in light of the focus goal T7116: Streamlined onboarding of new contributors it's important to fix rough edges in our infrastructure, too: In D11470#252163 ,

D12328: Enable preview by default in the filepicker dialog

rkflx added a comment. In D12328#250028 , @anemeth wrote: > Rebase on D12321 While the dependency tree is now looking good, the rebase did not work out correctly. While it might look correct on your

D12321: Hide file preview when icon is too small

rkflx added a comment. In D12321#252238 , @markg wrote: > That looks really fancy! :) > Yet i have to give it a -1.. > > You are overwriting a setting that the user had explicitly set (show preview). That will result in a "huh, why is the

D12321: Hide file preview when icon is too small

markg requested changes to this revision. markg added a comment. This revision now requires changes to proceed. That looks really fancy! :) Yet i have to give it a -1.. You are overwriting a setting that the user had explicitly set (show preview). That will result in a "huh, why is the

D12321: Hide file preview when icon is too small

anemeth updated this revision to Diff 32872. anemeth added a comment. Change tooltip when preview button is disabled/enabled. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12321?vs=32602=32872 BRANCH conditional_preview (branched from master) REVISION

D12311: Align lock icon with bold message text; reduce overall size of dialog

stikonas added a comment. In D12311#252165 , @bruns wrote: > Resizing: http://storaged.org/doc/udisks2-api/latest/gdbus-org.freedesktop.UDisks2.Partition.html#gdbus-method-org-freedesktop-UDisks2-Partition.Resize Does not work well yet,

D12371: fix always reproducible crash

jtamate added a comment. > One solution is to call printDebug(), which will output lots of information including the contents of directoryData(). I have some questions: Is a KCoreDirLister able to handle more than one directory? The same KCoreDirLister pointer is holding smb:// and

KDE CI: Frameworks frameworkintegration kf5-qt5 FreeBSDQt5.9 - Build # 20 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20frameworkintegration%20kf5-qt5%20FreeBSDQt5.9/20/ Project: Frameworks frameworkintegration kf5-qt5 FreeBSDQt5.9 Date of build: Mon, 23 Apr 2018 07:00:38 + Build duration: 51 sec and counting