D20148: Allow line end context switches in empty lines

nibags closed this revision. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D20148 To: nibags, #framework_syntax_highlighting, cullmann, dhaumann, vkrause Cc: kwrite-devel, kde-frameworks-devel, gennad, domson, michaelh, ngraham, bruns, demsking, cullmann,

D19517: DocumentPrivate: Add option "Enable Auto Reload" to ModOnHdPrompt

cullmann accepted this revision. cullmann added a comment. The menu is now ok and the feature still works for me. And yes, the view still jumps a bit. :P Funny enough for me it failed during testing more because of missing file notifications, should not have tried it on NFS. REVISION

D20148: Allow line end context switches in empty lines

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Ok for me, thanks! REPOSITORY R216 Syntax Highlighting BRANCH fix-line-continue REVISION DETAIL https://phabricator.kde.org/D20148 To: nibags, #framework_syntax_highlighting,

D20148: Allow line end context switches in empty lines

nibags updated this revision to Diff 55253. nibags added a comment. - Loop proposal I propose this combination of loops. Any detail don't hesitate to say (or commit)! REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20148?vs=55161=55253

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 80 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/80/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Tue, 02 Apr 2019 00:34:08 + Build duration: 55 min and counting JUnit Tests Name: projectroot

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 79 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/79/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Mon, 01 Apr 2019 23:32:53 + Build duration: 1 hr 0 min and counting JUnit Tests Name: projectroot

D20193: Depends on D20191

apol updated this revision to Diff 55250. apol added a comment. description REPOSITORY R273 KGuiAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20193?vs=55249=55250 BRANCH wayland_keystate REVISION DETAIL https://phabricator.kde.org/D20193 AFFECTED FILES

D20193: Depends on D20191

apol created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. apol requested review of this revision. REPOSITORY R273 KGuiAddons BRANCH wayland_keystate REVISION DETAIL https://phabricator.kde.org/D20193 AFFECTED FILES

D20191: Proof of concept of a wayland protocol to allow the keystate dataengine to work

apol added a dependent revision: D20192: Implement the keystate protocol. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D20191 To: apol, #kwin Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20191: Proof of concept of a wayland protocol to allow the keystate dataengine to work

apol created this revision. apol added a reviewer: KWin. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. apol requested review of this revision. TEST PLAN Tested with both the lock screen and the keyboard indicator plasmoid REPOSITORY R127 KWayland

D20162: Replace QDateTime::to_Time_t/from_Time_t with to/fromSecsSinceEpoch

This revision was automatically updated to reflect the committed changes. Closed by commit R241:e4a244d0460e: Replace QDateTime::to_Time_t/from_Time_t with to/fromSecsSinceEpoch (authored by bruns). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D20164: Simplify timestamp truncation in tests, use currentSecsSinceEpoch()

This revision was automatically updated to reflect the committed changes. Closed by commit R241:647171a56bb1: Simplify timestamp truncation in tests, use currentSecsSinceEpoch() (authored by bruns). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D20163: Replace currentDateTimeUtc().toTime_t() with currentSecsSinceEpoch()

This revision was automatically updated to reflect the committed changes. Closed by commit R241:38db255da55b: Replace currentDateTimeUtc().toTime_t() with currentSecsSinceEpoch() (authored by bruns). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 45 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/45/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 01 Apr 2019 23:13:22 + Build duration: 10 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 53 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/53/ Project: kf5-qt5 SUSEQt5.10 Date of build: Mon, 01 Apr 2019 23:13:22 + Build duration: 11 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 57 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/57/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Mon, 01 Apr 2019 23:13:22 + Build duration: 4 min 49 sec and counting JUnit Tests

D20095: Reduce the importance of some debug information so actual warnings can be seen.

This revision was automatically updated to reflect the committed changes. Closed by commit R242:4f132316c561: Reduce the importance of some debug information so actual warnings can be seen. (authored by apol). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D20181: Add Binary Data units (bits, kilobytes, kibibytes ... yottabytes)

apol added a comment. In D20181#441918 , @JJRcop wrote: > In D20181#441887 , @aacid wrote: > > > Can we use https://api.kde.org/frameworks/kcoreaddons/html/classKFormat.html instead of doing this

D20166: Keep desktoptheme SVG files uncompressed in repo, install svgz

ndavis added a comment. In D20166#441863 , @kossebau wrote: > IMHO the SVG files in the repo may contain comments and metadatas, for further work on them. Like source code also has all the oomments and metadata. > Only the deployed graphics

D20181: Add Binary Data units (bits, kilobytes, kibibytes ... yottabytes)

JJRcop added a comment. In D20181#441887 , @aacid wrote: > Can we use https://api.kde.org/frameworks/kcoreaddons/html/classKFormat.html instead of doing this again? I think that's out of scope for this patch. It should be done in

D20181: Add Binary Data units (bits, kilobytes, kibibytes ... yottabytes)

aacid added a comment. Can we use https://api.kde.org/frameworks/kcoreaddons/html/classKFormat.html instead of doing this again? REVISION DETAIL https://phabricator.kde.org/D20181 To: JJRcop, broulik, #plasma, ngraham Cc: aacid, ngraham, kde-frameworks-devel, michaelh, bruns

D20166: Keep desktoptheme SVG files uncompressed in repo, install svgz

bruns added a comment. In D20166#441854 , @ndavis wrote: > In D20166#441807 , @ngraham wrote: > > > Strictly speaking, there's no need to optimize the SVGs as a part of this, so maybe, yeah, let's

D20166: Keep desktoptheme SVG files uncompressed in repo, install svgz

kossebau retitled this revision from "Keep desktoptheme SVG files uncompressed in repo, install (stripped) svgz" to "Keep desktoptheme SVG files uncompressed in repo, install svgz". kossebau edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL

D20166: Keep desktoptheme SVG files uncompressed in repo, install (stripped) svgz

kossebau added a comment. In D20166#441854 , @ndavis wrote: > In D20166#441807 , @ngraham wrote: > > > Strictly speaking, there's no need to optimize the SVGs as a part of this, so maybe, yeah,

D20166: Keep desktoptheme SVG files uncompressed in repo, install (stripped) svgz

kossebau updated this revision to Diff 55231. kossebau added a comment. Remove stripping feature REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20166?vs=55191=55231 BRANCH uncompressedsvginrepo REVISION DETAIL

D20166: Keep desktoptheme SVG files uncompressed in repo, install (stripped) svgz

ndavis added a comment. In D20166#441807 , @ngraham wrote: > Strictly speaking, there's no need to optimize the SVGs as a part of this, so maybe, yeah, let's split that out into a separate feature (and one that the Breeze Icons repo would

D20181: Add Binary Data units (bits, kilobytes, kibibytes ... yottabytes)

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Thanks, this looks good to me and works great! @broulik? REVISION DETAIL https://phabricator.kde.org/D20181 To: JJRcop, broulik, #plasma, ngraham Cc: ngraham, kde-frameworks-devel,

D20181: Add Binary Data units (bits, kilobytes, kibibytes ... yottabytes)

JJRcop updated this revision to Diff 55227. JJRcop added a comment. Update @since from 5.57 to 5.58 CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20181?vs=55218=55227 REVISION DETAIL https://phabricator.kde.org/D20181 AFFECTED FILES README.md src/CMakeLists.txt

D20166: Keep desktoptheme SVG files uncompressed in repo, install (stripped) svgz

ngraham added a comment. Strictly speaking, there's no need to optimize the SVGs as a part of this, so maybe, yeah, let's split that out into a separate feature (and one that the Breeze Icons repo would ultimately be interested in as well). REPOSITORY R242 Plasma Framework (Library)

D20095: Reduce the importance of some debug information so actual warnings can be seen.

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. +1, these are definitely unnecessarily noisy. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D20095 To: apol, #plasma,

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 56 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/56/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Mon, 01 Apr 2019 19:10:29 + Build duration: 21 min and counting JUnit Tests Name:

D20181: Add Binary Data units (bits, kilobytes, kibibytes ... yottabytes)

ngraham added reviewers: broulik, Plasma, ngraham. ngraham added a comment. Thanks very much for this, it looks great! This will land in 5.58 not 5.57 since we don't typically commit patches with string changes in the last two weeks before frameworks tagging (which happens in five days, see

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 44 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/44/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 01 Apr 2019 19:10:29 + Build duration: 11 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 52 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/52/ Project: kf5-qt5 SUSEQt5.10 Date of build: Mon, 01 Apr 2019 19:10:28 + Build duration: 3 min 43 sec and counting BUILD ARTIFACTS

D20095: Reduce the importance of some debug information so actual warnings can be seen.

apol updated this revision to Diff 55223. apol added a comment. remove warning fix REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20095?vs=54992=55223 BRANCH master REVISION DETAIL https://phabricator.kde.org/D20095 AFFECTED FILES

D20166: Keep desktoptheme SVG files uncompressed in repo, install (stripped) svgz

kossebau added a comment. In D20166#441733 , @GB_2 wrote: > In D20166#441715 , @ndavis wrote: > > > Be careful that you are not stripping stylesheets when you use SVG Cleaner. `scour` is less

D20181: Add Binary Data units (bits, kilobytes, kibibytes ... yottabytes)

JJRcop retitled this revision from "Adds Binary Data units (bits, kilobytes, kibibytes ... yottabytes)" to "Add Binary Data units (bits, kilobytes, kibibytes ... yottabytes)". REPOSITORY R292 KUnitConversion REVISION DETAIL https://phabricator.kde.org/D20181 To: JJRcop Cc:

D20063: Sublime Merge Icon.

ngraham added a comment. Thanks so much @otavva! If you've found this process enjoyable and rewarding, there are plenty more icons needed! :) See

D20181: Adds Binary Data units (bits, kilobytes, kibibytes ... yottabytes)

JJRcop created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. JJRcop requested review of this revision. REVISION SUMMARY New data category BinaryDataCategory featuring bits and bytes, both SI units and powers of two, from normal bits all the

D20166: Keep desktoptheme SVG files uncompressed in repo, install (stripped) svgz

GB_2 added a comment. In D20166#441715 , @ndavis wrote: > Be careful that you are not stripping stylesheets when you use SVG Cleaner. `scour` is less effective than SVG Cleaner, but it doesn't strip stylesheets and it's available in more

D20166: Keep desktoptheme SVG files uncompressed in repo, install (stripped) svgz

ndavis added a comment. Be careful that you are not stripping stylesheets when you use SVG Cleaner. `scour` is less effective than SVG Cleaner, but it doesn't strip stylesheets and it's available in more distros. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL

D20172: use plasma icon as icon for plasma notification category

This revision was automatically updated to reflect the committed changes. Closed by commit R252:8ce99b1637ef: use plasma icon as icon for plasma notification category (authored by sitter). REPOSITORY R252 Framework Integration CHANGES SINCE LAST UPDATE

D20176: make start-here-kde also available start-here-kde-plasma

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R266 Breeze Icons BRANCH master REVISION DETAIL https://phabricator.kde.org/D20176 To: sitter, ngraham Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D20166: Keep desktoptheme SVG files uncompressed in repo, install (stripped) svgz

kossebau added a comment. In D20166#441653 , @ngraham wrote: > Strong +1 on the idea. Shouldn't we put these `Find.cmake` files in ECM though? The Breeze icons repo could definitely benefit from `FindSVGCleaner` to automatically post-process

D20176: make start-here-kde also available start-here-kde-plasma

broulik added a comment. Imho when we did the rebranding we should have added a `start-here-plasma` icon and switch to that everywhere rather than blatantly changing the `start-here-kde` icon +1 REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D20176 To: sitter

D20166: Keep desktoptheme SVG files uncompressed in repo, install (stripped) svgz

ngraham added a comment. Strong +1 on the idea. Shouldn't we put these `Find.cmake` files in ECM though? The Breeze icons repo could definitely benefit from `FindSVGCleaner` to automatically post-process the SVGs for example. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL

D20176: make start-here-kde also available start-here-kde-plasma

sitter created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY the latter offers a less ambiguous name when we want to refer to something plasma specific. a recent example is D20172

D20172: use plasma icon as icon for plasma notification category

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. > Oh, on a related note, I actually do wonder if we should symlink start-here-kde in breeze to start-here-kde-plasma and use that instead to differentiate? As per the spec

D20172: use plasma icon as icon for plasma notification category

sitter added a comment. Oh, on a related note, I actually do wonder if we should symlink start-here-kde in breeze to start-here-kde-plasma and use that instead to differentiate? As per the spec on !breeze icon themes start-here-kde-plasma would fall back to start-here-kde if the plasma icon

D20172: use plasma icon as icon for plasma notification category

sitter retitled this revision from "use the plasma icon as plasma icon" to "use plasma icon as icon for plasma notification category". REPOSITORY R252 Framework Integration REVISION DETAIL https://phabricator.kde.org/D20172 To: sitter, broulik Cc: kde-frameworks-devel, michaelh, ngraham,

D20172: use the plasma icon as plasma icon

sitter added a comment. before F6742443: Screenshot_20190401_173503.png after F6742444: Screenshot_20190401_173529.png REPOSITORY R252 Framework Integration REVISION DETAIL

D20172: use the plasma icon as plasma icon

sitter created this revision. sitter added a reviewer: broulik. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY kde is the kde logo, start-here-kde is our app menu icon which is the plasma icon

D19517: DocumentPrivate: Add option "Enable Auto Reload" to ModOnHdPrompt

loh.tar added a comment. As you see, not only the menu is changed, so I update this diff for your approval. > I think this works well enough to be added. Harr, I found it now not good enough and spend some more time for this. Looks now nicely to me. The view still jumps slightly

D20169: Add profile support interface for TerminalInterface

mschiller added a reviewer: hindenburg. mschiller removed a subscriber: kde-frameworks-devel. REPOSITORY R306 KParts REVISION DETAIL https://phabricator.kde.org/D20169 To: mschiller, hindenburg Cc: michaelh, ngraham, bruns, kde-frameworks-devel

D20169: Add profile support interface for TerminalInterface

mschiller created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mschiller requested review of this revision. REVISION SUMMARY This enables handling profiles for the active konsolepart and has to be implemented by konsole. REPOSITORY

D19517: DocumentPrivate: Add option "Enable Auto Reload" to ModOnHdPrompt

loh.tar updated this revision to Diff 55199. loh.tar added a comment. - Ensure the view jumps not back when user scrolls around - Don't reload while user scrolls - Fix missing connect to auto reload slot when enabled by modOnHdHandler - Change menu F6742373: 1554131807.png

D20166: Keep desktoptheme SVG files uncompressed in repo, install (stripped) svgz

kossebau added a comment. While the main purpose of this patch is to have SVG files in the repo, the processing to optimize runtime load is an interesting side-effect. If you are curious about some numbers, here the install size estimated with `du -chb` for the respective subfolders

D20158: Allow to set urgency for notifications

vkrause added a comment. Yep, code looks good to me too, so +1 on this :) REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D20158 To: broulik, #plasma, #frameworks, vkrause, ogoffart, mck182 Cc: mlaurent, kde-frameworks-devel, michaelh, ngraham, bruns

D20158: Allow to set urgency for notifications

broulik added a comment. So, in essence you're fine with adding the enum as it is, and then have some mapping in the Android code? :) REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D20158 To: broulik, #plasma, #frameworks, vkrause, ogoffart, mck182 Cc:

D20149: Fix compilation

bruns added a comment. Although s_magic **decays** to a char*, it **is not** a char*. char[n] is a type distinct from char* From e.g. man strlen char string[32] = "hello, world"; char *ptr = string; sizeof (string) ⇒ 32 sizeof (ptr) ⇒ 4 /* (on a

D20166: Keep desktoptheme SVG files uncompressed in repo, install (stripped) svgz

kossebau updated this revision to Diff 55191. kossebau added a comment. Fix some naming inconsistencies one only sees when looking at a patch through another viewer (like the phabricator review page :)) REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D20164: Simplify timestamp truncation in tests, use currentSecsSinceEpoch()

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH submit REVISION DETAIL https://phabricator.kde.org/D20164 To: bruns, #frameworks, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20162: Replace QDateTime::to_Time_t/from_Time_t with to/fromSecsSinceEpoch

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH submit REVISION DETAIL https://phabricator.kde.org/D20162 To: bruns, #frameworks, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20163: Replace currentDateTimeUtc().toTime_t() with currentSecsSinceEpoch()

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH submit REVISION DETAIL https://phabricator.kde.org/D20163 To: bruns, #frameworks, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20166: Keep desktoptheme SVG files uncompressed in repo, install (stripped) svgz

kossebau added inline comments. INLINE COMMENTS > fvogt wrote in CMakeLists.txt:15 > You could make this optional and set the `STRIP_DESKTOPTHEME_SVG` default > depending on whether it's found. Personally I favour the buildsystem not to randomly do what it can given the current system state,

D20166: Keep desktoptheme SVG files uncompressed in repo, install (stripped) svgz

fvogt added a comment. I'm very much in favor of this, but don't know anything about the cmake magic involved, so can't really say much about that. INLINE COMMENTS > CMakeLists.txt:15 > +set_package_properties(svgcleaner PROPERTIES > +TYPE REQUIRED > +) You could make this

Heads-up: EXCLUDE_FROM_ALL behaviour change in CMake >= 3.14

Hi, Short notice: the EXCLUDE_FROM_ALL behaviour changed in CMake >= 3.14.0 when used with add_subdirectories(). EXCLUDE_FROM_ALL now also affects all the targets inside the directory.[1][2] e.g: add_subdirectory(foo EXCLUDE_FROM_ALL) Before: Targets defined in this directory are not built

D20166: Keep desktoptheme SVG files uncompressed in repo, install (stripped) svgz

kossebau added a comment. SVGZ -> SVG conversion of all files not included in this uploaded patch, to keep it reviewable. Locally do this: Store a file `svgztosvg.sh` with this content in `src/desktoptheme`: #!/bin/sh SVGZ=$1 if [ ! -f "$SVGZ" ]; then

D20149: Fix compilation

apol added inline comments. INLINE COMMENTS > ora.cpp:21 > static constexpr char s_magic[] = "image/openraster"; > -static constexpr int s_magic_size = strlen(s_magic); > +static constexpr int s_magic_size = sizeof(s_magic) - 1; // -1 to remove the > last \0 > Won't sizeof give the

D20166: Keep desktoptheme SVG files uncompressed in repo, install (stripped) svgz

kossebau created this revision. kossebau added reviewers: Plasma, VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY The SVG format being based on plain text, storing the SVG in the repository

D20164: Simplify timestamp truncation in tests, use currentSecsSinceEpoch()

bruns created this revision. bruns added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY Instead of creating a full resolution timestamp and converting it to second

D20163: Replace currentDateTimeUtc().toTime_t() with currentSecsSinceEpoch()

bruns created this revision. bruns added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY toTime_t() is obsolete since Qt 5.8, and currentSecsSinceEpoch() is faster.

D20158: Allow to set urgency for notifications

vkrause added a comment. I was looking at https://developer.android.com/training/notify-user/channels#importance which also has IMPORTANCE_LOW mapped to "medium". But yes, it's basically just about finding a suitable mapping, even if we don't cover every possible level on Android.

D20162: Replace QDateTime::to_Time_t/from_Time_t with to/fromSecsSinceEpoch

bruns created this revision. bruns added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY QDateTime::toSecsSinceEpoch obsoletes to_Time_t, likewise for from_Time_t. Both

KDE CI: Frameworks » kservice » kf5-qt5 FreeBSDQt5.12 - Build # 18 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20FreeBSDQt5.12/18/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Mon, 01 Apr 2019 10:33:09 + Build duration: 56 min and counting JUnit Tests Name:

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 55 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/55/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Mon, 01 Apr 2019 10:02:32 + Build duration: 1 hr 21 min and counting JUnit Tests

D20158: Allow to set urgency for notifications

broulik added a comment. In D20158#441322 , @vkrause wrote: > Nicely fits with the Android backend too, although that has one extra level (low, medium, high, urgent). I found the following enums in `NotificationManager`: -

D20096: Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

meven updated this revision to Diff 55183. meven marked an inline comment as done. meven added a comment. Fix position of default in switch statement REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20096?vs=55182=55183 BRANCH creation-date REVISION DETAIL

D20096: Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

meven marked an inline comment as done. meven added inline comments. INLINE COMMENTS > bruns wrote in file.cpp:932 > statx.stx_size is __u64, and readlink uses (unsigned) size_t for the buffer > size. Let me know if I have handled this correctly. REPOSITORY R241 KIO REVISION DETAIL

D20096: Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

meven updated this revision to Diff 55182. meven added a comment. Add AT_SYMLINK_NOFOLLOW flag to statx call matching lstat behavior, use size_t type for readlink parameter, avoid a warning correct signedness of statx struct accessors REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D20047: Add X-GNOME-UsesNotifications as recognized key

This revision was automatically updated to reflect the committed changes. Closed by commit R309:1c783fd26c91: Add X-GNOME-UsesNotifications as recognized key (authored by broulik). REPOSITORY R309 KService CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20047?vs=54789=55180 REVISION

D20065: [KCModuleLoader] Pass args to created KQuickAddons::ConfigModule

This revision was automatically updated to reflect the committed changes. Closed by commit R295:dc3dd35d36c4: [KCModuleLoader] Pass args to created KQuickAddons::ConfigModule (authored by broulik). REPOSITORY R295 KCMUtils CHANGES SINCE LAST UPDATE

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 54 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/54/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Mon, 01 Apr 2019 07:48:44 + Build duration: 2 hr 13 min and counting JUnit Tests

D20158: Allow to set urgency for notifications

vkrause added a comment. Nicely fits with the Android backend too, although that has one extra level (low, medium, high, urgent). REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D20158 To: broulik, #plasma, #frameworks, vkrause, ogoffart, mck182 Cc:

D20158: Allow to set urgency for notifications

broulik created this revision. broulik added reviewers: Plasma, Frameworks, vkrause, ogoffart, mck182. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY This lets the application set an urgency hint

D20039: [KConfig] Add Notify capability for revertToDefault

This revision was automatically updated to reflect the committed changes. Closed by commit R237:cad4889e490f: Add Notify capability to revertToDefault (authored by broulik). REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20039?vs=54765=55167 REVISION DETAIL

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 51 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/51/ Project: kf5-qt5 SUSEQt5.10 Date of build: Mon, 01 Apr 2019 08:12:52 + Build duration: 4 min 36 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 43 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/43/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 01 Apr 2019 08:12:52 + Build duration: 4 min 15 sec and counting BUILD ARTIFACTS

D20070: [PlasmaComponents3 ComboBox] Fix textColor

This revision was automatically updated to reflect the committed changes. Closed by commit R242:d868804a7fe4: [PlasmaComponents3 ComboBox] Fix textColor (authored by broulik). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 42 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/42/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 01 Apr 2019 07:48:44 + Build duration: 7 min 57 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 50 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/50/ Project: kf5-qt5 SUSEQt5.10 Date of build: Mon, 01 Apr 2019 07:48:44 + Build duration: 6 min 18 sec and counting BUILD ARTIFACTS

D14724: autotests: don't fail if an unrelated window shows up.

dfaure closed this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D14724 To: dfaure, hein, drosca, broulik, davidedmundson, jtamate Cc: jtamate, kde-frameworks-devel, #plasma, michaelh, ngraham, bruns

D14724: autotests: don't fail if an unrelated window shows up.

jtamate accepted this revision. jtamate added a comment. This revision is now accepted and ready to land. As I don't have enough contiguous free time even to test it again, feel free to commit. You can add a comment to remember that it doesn't fix all the cases but is an improvement over