KDE CI: Frameworks » kdelibs4support » kf5-qt5 FreeBSDQt5.12 - Build # 29 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20FreeBSDQt5.12/29/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sat, 25 May 2019 03:22:32 + Build duration: 1 hr 32 min and counting JUnit Tests Name:

D21388: KCompressionDevice: Remove bIgnoreData

apol added a comment. How hard would it be to test this? I like how the code ends up being much simpler. REPOSITORY R243 KArchive REVISION DETAIL https://phabricator.kde.org/D21388 To: aacid Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D21388: KCompressionDevice: Remove bIgnoreData

aacid created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. aacid requested review of this revision. REVISION SUMMARY bIgnoreData was used in ::seek to say, we don't really care much about the next readData call because we know it's coming

D21369: [WIP] Add AbstractContact properties for KContact::PhoneNumber objects

sredman added a comment. In D21369#469389 , @apol wrote: > Seems like a clear layer break to spill KContacts over KPeople :P. > Let's discuss it at the sprint? Or earlier. Let's discuss it? ^^' Sounds good REPOSITORY R307 KPeople RE

D21378: Make Breeze Light/Dark use more system colors

lavender added a comment. In D21378#469640 , @filipf wrote: > In D21378#469611 , @ndavis wrote: > > > In D21378#469607 , @filipf wrote: > > > > > So I h

D21378: Make Breeze Light/Dark use more system colors

filipf added a comment. In D21378#469611 , @ndavis wrote: > In D21378#469607 , @filipf wrote: > > > So I have a light widget color scheme, but I want to be using a dark Plasma theme. My color scheme

D21381: use org.freedesktop.appstream-glib package to validate appstream data

bcooksley added a comment. Aleix is correct, Flatpak commands are not possible within the CI environment (as Docker is heavily locked down, and the containerisation and other isolation measures that Flatpak tries to take are locked out as a consequence) Not to mention that Flatpak is Linux

D21381: use org.freedesktop.appstream-glib package to validate appstream data

apol requested changes to this revision. apol added a comment. This revision now requires changes to proceed. How about we test against both? And maybe it should be using `appstream-util validate` instead of forcing it through flatpak? It will make it easier to be able to run it in bui

D21317: Manipulate bytes instead of characters

thiago added a comment. As for truncating UTF-8 multibyte sequences in the middle, when you convert back using QFile::decodeName, it'll be nonsensical. But I don't think it really matters since you're truncating and using the display string anyway, so you're already losing data. This wasn't

D21356: Port to ECMAddQmlModule, add plugins.qmltypes files

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. LGTM. REPOSITORY R296 KDeclarative BRANCH porttoECMInstallQmlModules REVISION DETAIL https://phabricator.kde.org/D21356 To: kossebau, #plasma, apol Cc: apol, kde-frameworks-devel, micha

D21378: Make Breeze Light/Dark use more system colors

ndavis added a comment. In D21378#469607 , @filipf wrote: > So I have a light widget color scheme, but I want to be using a dark Plasma theme. My color scheme is a bit funky and when I use Breeze Dark it doesn't respect my colors. So this is a g

D21378: Make Breeze Light/Dark use more system colors

ndavis added a comment. In D21378#469525 , @lavender wrote: > In D21378#469517 , @mart wrote: > > > the idea is kinda nice and with some schemes it will work just perfect... > > however i think it

D21378: Make Breeze Light/Dark use more system colors

filipf accepted this revision. filipf added a comment. This revision is now accepted and ready to land. So I have a light widget color scheme, but I want to be using a dark Plasma theme. My color scheme is a bit funky and when I use Breeze Dark it doesn't respect my colors. So this is a good

D21317: Manipulate bytes instead of characters

thiago added a comment. I cringe a little when you apply QFile to a URL, but this is probably safe enough. LGTM REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D21317 To: chinmoyr, bruns, dfaure, thiago Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D21354: Port to new connect syntax

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R432:95df6fa38a45: Port to new connect syntax (authored by ngraham). REPOSITORY R432 File Sharing (Samba) integration CH

D21354: Port to new connect syntax

ngraham added a comment. In D21354#469531 , @bruns wrote: > LGTM > > currently, GCC thows some "0 for nullptr" and "missing override" warnings, are you going to address these (new SR)? > > Also, Qt recommends deriving from Q**Styled**Item

D21354: Port to new connect syntax

bruns added a comment. LGTM currently, GCC thows some "0 for nullptr" and "missing override" warnings, are you going to address these (new SR)? Also, Qt recommends deriving from Q**Styled**ItemDelegate REPOSITORY R432 File Sharing (Samba) integration REVISION DETAIL https://pha

D21354: Port to new connect syntax

ngraham updated this revision to Diff 58607. ngraham added a comment. Rebase REPOSITORY R432 File Sharing (Samba) integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21354?vs=58605&id=58607 BRANCH port-to-new-connect-symtax (branched from master) REVISION DETAIL https

D21378: Make Breeze Light/Dark use more system colors

lavender added a comment. In D21378#469517 , @mart wrote: > the idea is kinda nice and with some schemes it will work just perfect... > however i think it risks a lot of having loss in contrast on certain color schems with your patch try for i

D21354: Port to new connect syntax

ngraham updated this revision to Diff 58605. ngraham marked an inline comment as done. ngraham added a comment. Don't double-connect REPOSITORY R432 File Sharing (Samba) integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21354?vs=58568&id=58605 BRANCH port-to-new-connec

D21378: Make Breeze Light/Dark use more system colors

mart added a comment. the idea is kinda nice and with some schemes it will work just perfect... however i think it risks a lot of having loss in contrast on certain color schems with your patch try for instance breezedark and the honeycomb system theme, the current task highlight would prob

D21378: Make Breeze Light/Dark use more system colors

ngraham edited the summary of this revision. ngraham added a task: T8755: Use colors from the system colorscheme for the Task Manager's accent color in Breeze Light/Dark desktop themes. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D21378 To: ndavis,

D21378: Make Breeze Light/Dark use more system colors

ngraham added a reviewer: mart. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D21378 To: ndavis, #vdg, #plasma, mart Cc: lavender, kde-frameworks-devel, michaelh, ngraham, bruns

D21381: use org.freedesktop.appstream-glib package to validate appstream data

ngraham added a reviewer: apol. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D21381 To: mgallien, aacid, yurchor, apol Cc: kde-frameworks-devel, kde-buildsystem, bencreasy, michaelh, ngraham, bruns

D21313: Create specific directory for kdebugsettings categories file

kossebau added inline comments. INLINE COMMENTS > KDEInstallDirs.cmake:131 > # autostart files (``CONFDIR/autostart``) [``AUTOSTART_INSTALL_DIR``] > +# ``DEBUGCATEGORIESDIR`` > +# kdebugsettings categories files directory > (``DATAROOTDIR/debug-categories5``) Since 5.59.0 Might `LOGGIN

D21379: [UDev Backend] Narrow subsystems queried for cameras

broulik added a comment. Okay, so we can just filter for "usb" then since we don't monitor "block" and "scsi_generic" > This definitely needs some documentation Agreed REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D21379 To: broulik, #frameworks, davidedmun

D21379: [UDev Backend] Narrow subsystems queried for cameras

bruns added a comment. sd[a-z] is subsystem "block" sg[0-9] is susbsystem "scsi_generic" none of the ID_GPHOTO2==1 devices is a tty or dvb device INLINE COMMENTS > udevqtclient.h:53 > DeviceList devicesBySubsystem(const QString &subsystem); > +DeviceList devicesBySubsystemsAnd

D21313: Create specific directory for kdebugsettings categories file

mlaurent updated this revision to Diff 58604. mlaurent added a comment. Oops indeed I forgot to readd KXMLGUI_INSTALL_DIR Thanks for pointing me it :) REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21313?vs=58454&id=58604 BRANCH add_spec

D21368: Add syntax definition for the Common Intermediate Language

This revision was automatically updated to reflect the committed changes. Closed by commit R216:70a9e380e3b2: Add syntax definition for the Common Intermediate Language (authored by vkrause). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21368?vs=

D21380: show static word wrap marker always if requested

This revision was automatically updated to reflect the committed changes. Closed by commit R39:24fd3ca01d89: show static word wrap marker always if requested (authored by cullmann). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21380?vs=58594&id=58602 REV

D21355: Fix qmldir files

This revision was automatically updated to reflect the committed changes. Closed by commit R296:d644659eed56: Fix qmldir files (authored by kossebau). REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21355?vs=58520&id=58601 REVISION DETAIL https://phabric

D21379: [UDev Backend] Narrow subsystems queried for cameras

broulik added a comment. Thanks, @bruns but what does this mean for this patch? :D REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D21379 To: broulik, #frameworks, davidedmundson, bruns Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D21380: show static word wrap marker always if requested

arrowd accepted this revision. This revision is now accepted and ready to land. REPOSITORY R39 KTextEditor BRANCH master REVISION DETAIL https://phabricator.kde.org/D21380 To: cullmann, #ktexteditor, #frameworks, arrowd Cc: kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, br

D21344: Port to ECMAddQmlModule

kossebau updated this revision to Diff 58597. kossebau added a comment. udate to latest master REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21344?vs=58492&id=58597 BRANCH porttoECMInstallQmlModules REVISION DETAIL https://phabrica

D21356: Port to ECMAddQmlModule, add plugins.qmltypes files

kossebau updated this revision to Diff 58596. kossebau added a comment. update to latest master REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21356?vs=58521&id=58596 BRANCH porttoECMInstallQmlModules REVISION DETAIL https://phabricator.kde.org/D

D21381: use org.freedesktop.appstream-glib package to validate appstream data

mgallien created this revision. mgallien added reviewers: aacid, yurchor. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. mgallien requested review of this revision. REVISION SUMMARY should help having the same validation than the

D21380: show static word wrap marker always if requested

cullmann added reviewers: KTextEditor, Frameworks. cullmann added a comment. I think this is reasonable, if one enables this, it should be shown, people can disable it, if it doesn't look nice for their font (or alter the font). REPOSITORY R39 KTextEditor REVISION DETAIL https://phabrica

D21380: show static word wrap marker always if requested

cullmann created this revision. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. cullmann requested review of this revision. REVISION SUMMARY don't check for fixed pitch font, as this seems to be not properly attributed to all kind of fonts

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 103 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/103/ Project: kf5-qt5 SUSEQt5.12 Date of build: Fri, 24 May 2019 13:09:15 + Build duration: 8 min 19 sec and counting BUILD ARTIFACTS abi-

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 110 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/110/ Project: kf5-qt5 SUSEQt5.10 Date of build: Fri, 24 May 2019 13:09:15 + Build duration: 8 min 40 sec and counting BUILD ARTIFACTS abi-

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 113 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/113/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Fri, 24 May 2019 13:09:15 + Build duration: 3 min 34 sec and counting JUnit Tests Na

D21350: plasmacore: fix qmldir, ToolTip.qml no longer part of module

This revision was automatically updated to reflect the committed changes. Closed by commit R242:e99f653113ec: plasmacore: fix qmldir, ToolTip.qml no longer part of module (authored by kossebau). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/

D21379: [UDev Backend] Narrow subsystems queried for cameras

bruns added a comment. libgphoto2.rules lists the following devices (USB VID:PID): - 1403:0001 Sitronix Digital Photo Frame which apparently shows up as a generic mass storage (sd[a-z]), but actually is something completely different, see https://github.com/gphoto/libgphoto2/tree/m

D21350: plasmacore: fix qmldir, ToolTip.qml no longer part of module

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH cleancoreqmldir REVISION DETAIL https://phabricator.kde.org/D21350 To: kossebau, #plasma, mart Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21355: Fix qmldir files

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R296 KDeclarative BRANCH improveqmldirs REVISION DETAIL https://phabricator.kde.org/D21355 To: kossebau, #plasma, davidedmundson, mart Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21328: Add qml import for KItemModels

kossebau added inline comments. INLINE COMMENTS > CMakeLists.txt:12 > + > +install(TARGETS itemmodelsplugin DESTINATION > ${KDE_INSTALL_QMLDIR}/org/kde/kitemmodels) > +install(FILES qmldir DESTINATION ${KDE_INSTALL_QMLDIR}/org/kde/kitemmodels) With the macros of ECMAddQmlModule proposed in D209

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 110 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/110/ Project: kf5-qt5 SUSEQt5.12 Date of build: Fri, 24 May 2019 11:30:25 + Build duration: 21 min and counting BUILD ARTIFACTS acc/KF5KIO-5.59.0.xmllog

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 120 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/120/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Fri, 24 May 2019 11:30:25 + Build duration: 7 min 26 sec and counting JUnit Tests Name: projectro

D21379: [UDev Backend] Narrow subsystems queried for cameras

apol added a comment. +1 LGTM REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D21379 To: broulik, #frameworks, davidedmundson, bruns Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D21369: [WIP] Add AbstractContact properties for KContact::PhoneNumber objects

apol added a comment. Seems like a clear layer break to spill KContacts over KPeople :P. Let's discuss it at the sprint? INLINE COMMENTS > persondata.h:123 > + > +/** Returns an arbritrary phone number of the contact */ > +KContacts::PhoneNumber::List allPhoneNumbers() const; wrong

D21317: Manipulate bytes instead of characters

dfaure added a comment. +1 from me, but if Thiago can take a look (about the issue of truncating in the middle of a multi-bytes utf8 characters) that'd be even better. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D21317 To: chinmoyr, bruns, dfaure, thiago Cc: ngraham,

D21379: [UDev Backend] Narrow subsystems queried for cameras

broulik created this revision. broulik added reviewers: Frameworks, davidedmundson, bruns. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY It currently scans all UDev devices, including processors, f

D21354: Port to new connect syntax

bruns added inline comments. INLINE COMMENTS > sambausershareplugin.cpp:130 > +connect(propertiesUi.sambaNameEdit, &QLineEdit::textChanged, > +this, &SambaUserSharePlugin::checkShareName); > +connect(propertiesUi.sambaAllowGuestChk, &QCheckBox::toggled, I meant - do `setDirty

D21378: Make Breeze Light/Dark use more system colors

lavender added a comment. Tested and it looks good to me REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D21378 To: ndavis, #vdg, #plasma Cc: lavender, kde-frameworks-devel, michaelh, ngraham, bruns

D21313: Create specific directory for kdebugsettings categories file

cgiboudeaux added a comment. In D21313#469311 , @mlaurent wrote: > Ping ? You didn't add "KXMLGUI_INSTALL_DIR)" back to where it belongs afaics. If noone has a better suggestion, we'll go for debug-categories5 REPOSITORY R240 Extra