KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 206 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/206/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Wed, 27 Nov 2019 07:46:30 + Build duration: 8 min 31 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 205 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/205/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Wed, 27 Nov 2019 07:19:45 + Build duration: 9 min 57 sec and counting JUnit Tests Name:

D25561: Remove unused signal we can use directly "signal(const QUrl&)

mlaurent added reviewers: dfaure, kossebau. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D25561 To: mlaurent, dfaure, kossebau Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25561: Remove unused signal we can use directly "signal(const QUrl&)

mlaurent created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mlaurent requested review of this revision. REVISION SUMMARY We create overload signal but we can use it with argument direcly TEST PLAN build REPOSITORY R236

D25390: KateModeManager::updateFileType(): validate modes and reload menu of the status bar

nibags added a comment. Now the object KateModeMenuList is obtained from the object KateStatusBar. I don't know if you prefer this way REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D25390 To: nibags, #ktexteditor, cullmann, dhaumann Cc: kwrite-devel,

D25545: Rename signal for avoiding overload signal

mlaurent updated this revision to Diff 70394. mlaurent added a comment. Fix indent REPOSITORY R246 Sonnet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25545?vs=70393=70394 BRANCH deprecated_overload_signal (branched from master) REVISION DETAIL

D25545: Rename signal for avoiding overload signal

mlaurent updated this revision to Diff 70393. mlaurent added a comment. Add apidox options REPOSITORY R246 Sonnet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25545?vs=70347=70393 BRANCH deprecated_overload_signal (branched from master) REVISION DETAIL

D25390: KateModeManager::updateFileType(): validate modes and reload menu of the status bar

nibags updated this revision to Diff 70392. nibags added a comment. - Get the KateMenuList objects using KateGlobal REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25390?vs=69971=70392 BRANCH verify-katefiletypes REVISION DETAIL

D25530: Sonnet: Add locales that are missing in QLocale

waqar added a comment. > Sorry but i don't think this is an acceptable solution, With all due respect, the end user doesn't give a crap whether it was a problem in QLocale, or whether it needed to be done in many places in KDE code and that nobody did it. The end user opens the menu,

D25493: EBN kmoretools cleanup transport protocol

jhayes added a comment. No I don't have commitcommit access. REPOSITORY R304 KNewStuff BRANCH ebn-cleanup (branched from master) REVISION DETAIL https://phabricator.kde.org/D25493 To: jhayes, dhaumann Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25515: Only extract lyrics when the plain text flag is set

bruns added a comment. The dolphin temp extractor uses `KFileMetaData::ExtractionResult::ExtractMetaData` explicitly. Though in general I agree (and "PlainText" should be better named "FullText"). REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D25515 To:

D25516: Remove unrequired private declarations for taglibextractor

bruns requested changes to this revision. bruns added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > taglibextractor.cpp:105 > > -void TagLibExtractor::readGenericProperties(const TagLib::PropertyMap > , ExtractionResult* result) > +void

D25545: Rename signal for avoiding overload signal

kossebau added a comment. In D25545#568090 , @dfaure wrote: > Looks good to me. Friedrich, what did we conclude about deprecating signals? From https://phabricator.kde.org/D24466#547023 & ff. I took with me that deprecating signals like

D25517: Add an option to extract binary data and add front cover property

bruns requested changes to this revision. bruns added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > extractionresult.h:61 > + */ > +ExtractBinaryData = 4, > +ExtractEverythingIncludingBinary = (ExtractEverything | > ExtractBinaryData),

D25233: [kded] Port plugin metadata to JSON

This revision was automatically updated to reflect the committed changes. Closed by commit R363:0a54612c21a0: [kded] Port plugin metadata to JSON (authored by nicolasfella). REPOSITORY R363 Print Manager CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25233?vs=69521=70383 REVISION

D25545: Rename signal for avoiding overload signal

dfaure added a reviewer: kossebau. REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D25545 To: mlaurent, dfaure, kossebau Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25545: Rename signal for avoiding overload signal

dfaure added a comment. Looks good to me. Friedrich, what did we conclude about deprecating signals? REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D25545 To: mlaurent, dfaure, kossebau Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25233: [kded] Port plugin metadata to JSON

dfaure accepted this revision as: dfaure. dfaure added a comment. This revision is now accepted and ready to land. Thanks! REPOSITORY R363 Print Manager BRANCH json REVISION DETAIL https://phabricator.kde.org/D25233 To: nicolasfella, #frameworks, dantti, #kf6, dfaure Cc: dfaure,

D25491: Remove kdeinit dependency from kded.

dfaure closed this revision. REPOSITORY R297 KDED REVISION DETAIL https://phabricator.kde.org/D25491 To: dfaure, mart, cordlandwehr, vkrause Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25493: EBN kmoretools cleanup transport protocol

dhaumann added a comment. @jhayes Do you have commit access, or shall I commit this for you? REPOSITORY R304 KNewStuff BRANCH ebn-cleanup (branched from master) REVISION DETAIL https://phabricator.kde.org/D25493 To: jhayes, dhaumann Cc: kde-frameworks-devel, LeGast00n, GB_2,

D23457: Port regex search to QRegularExpression

dhaumann added a comment. Any news here? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D23457 To: ahmadsamir, #ktexteditor, dhaumann, cullmann Cc: kde-frameworks-devel, kwrite-devel, LeGast00n, GB_2, domson, michaelh, ngraham, bruns, demsking, cullmann, sars,

D24982: Small improvements in some XML files

dhaumann added a comment. I think we should decide what to do with this patch, as over time it will get merge conflicts. In general, I hoped we can have some sort of auto detection to disable captures in a smart way. If this is not possible, maybe we should accept this patch?

D24349: More fixes to compile without implicit conversion from ASCII/ByteArray

dfaure added inline comments. INLINE COMMENTS > kfileplacesmodel.cpp:280 > KFilePlacesItem::createSystemBookmark(d->bookmarkManager, > - I18NC_NOOP("KFile System > Bookmarks", "Home"), > + >

D24349: More fixes to compile without implicit conversion from ASCII/ByteArray

ahmadsamir added inline comments. INLINE COMMENTS > yurchor wrote in kfileplacesmodel.cpp:275 > This does not work. Our translation system cannot extract from something like > > I18NC_NOOP(fsBookmarks, QStringLiteral("Desktop")) > > all the strings below with I18NC_NOOP should be left as is.

D24349: More fixes to compile without implicit conversion from ASCII/ByteArray

ahmadsamir updated this revision to Diff 70379. ahmadsamir marked 5 inline comments as done. ahmadsamir added a comment. - Keep I18NC_NOOP working - QLatin1String where appropriate - Rename mProtocolToStr() to protocolName(), and make it private (only used in slavebase) REPOSITORY R241

D24349: More fixes to compile without implicit conversion from ASCII/ByteArray

dfaure added inline comments. INLINE COMMENTS > yurchor wrote in kfileplacesmodel.cpp:275 > This does not work. Our translation system cannot extract from something like > > I18NC_NOOP(fsBookmarks, QStringLiteral("Desktop")) > > all the strings below with I18NC_NOOP should be left as is.

D25530: Sonnet: Add locales that are missing in QLocale

aacid added a comment. In D25530#567561 , @waqar wrote: > In D25530#567472 , @aacid wrote: > > > Any reason we particularly need this here instead of improving Qt? > > > Improving Qt is

D24349: More fixes to compile without implicit conversion from ASCII/ByteArray

yurchor added inline comments. INLINE COMMENTS > dfaure wrote in kfileplacesmodel.cpp:275 > This is more commonly written as "static const" This does not work. Our translation system cannot extract from something like I18NC_NOOP(fsBookmarks, QStringLiteral("Desktop")) all the strings below

D24349: More fixes to compile without implicit conversion from ASCII/ByteArray

dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > ahmadsamir wrote in slavebase.h:979 > A B C, nothing changed inside make it const, D E F. Yep ;) Hmm, also it's in the middle of member variables, better

D25550: Mark KInit as porting aid

davidedmundson added a comment. > Is this ignoring the 20% speed boost i get on one of my laptops? Rather, the speed boost you don't get as nearly no-one is using it properly. The relevant task does explicitly say to chase up on Albert's stats, so lets finish doing that. REPOSITORY

D25550: Mark KInit as porting aid

aacid added a comment. Is this ignoring the 20% speed boost i get on one of my laptops? I feel like that's really a bad idea REPOSITORY R303 KInit REVISION DETAIL https://phabricator.kde.org/D25550 To: nicolasfella, #frameworks Cc: aacid, davidedmundson, kde-frameworks-devel,

Re: KInit - Current state and benchmarks

El dimarts, 26 de novembre de 2019, a les 8:56:54 CET, Milian Wolff va escriure: > On Montag, 25. November 2019 22:57:11 CET Albert Astals Cid wrote: > > El dissabte, 23 de novembre de 2019, a les 11:47:40 CET, Milian Wolff va > escriure: > > > On Mittwoch, 19. Juni 2019 19:57:56 CET Albert

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 WindowsMSVCQt5.13 - Build # 67 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20WindowsMSVCQt5.13/67/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Tue, 26 Nov 2019 18:19:10 + Build duration: 5 min 32 sec and counting JUnit

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 SUSEQt5.13 - Build # 86 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20SUSEQt5.13/86/ Project: kf5-qt5 SUSEQt5.13 Date of build: Tue, 26 Nov 2019 18:19:10 + Build duration: 5 min 52 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 SUSEQt5.12 - Build # 190 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20SUSEQt5.12/190/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 26 Nov 2019 18:19:10 + Build duration: 3 min 55 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 FreeBSDQt5.13 - Build # 83 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20FreeBSDQt5.13/83/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Tue, 26 Nov 2019 18:19:10 + Build duration: 2 min 46 sec and counting JUnit Tests

D25503: JavaScript: move keywords from TypeScript and other improvements

This revision was automatically updated to reflect the committed changes. Closed by commit R216:9c64fb507253: JavaScript: move keywords from TypeScript and other improvements (authored by nibags, committed by cullmann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE

D25555: deprecate kregexpeditorinterface

This revision was automatically updated to reflect the committed changes. Closed by commit R310:1b2d198b6984: deprecate kregexpeditorinterface (authored by nicolasfella). REPOSITORY R310 KTextWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2?vs=70370=70372 REVISION

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 FreeBSDQt5.13 - Build # 82 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20FreeBSDQt5.13/82/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Tue, 26 Nov 2019 18:04:08 + Build duration: 12 min and counting JUnit Tests Name:

D25555: deprecate kregexpeditorinterface

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Thanks! REPOSITORY R310 KTextWidgets BRANCH regexped REVISION DETAIL https://phabricator.kde.org/D2 To: nicolasfella, #frameworks, cullmann Cc: kde-frameworks-devel,

D25555: deprecate kregexpeditorinterface

nicolasfella added a reviewer: cullmann. REPOSITORY R310 KTextWidgets REVISION DETAIL https://phabricator.kde.org/D2 To: nicolasfella, #frameworks, cullmann Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25555: deprecate kregexpeditorinterface

nicolasfella added a task: T12159: KTextWidgets: Remove plugin system. REPOSITORY R310 KTextWidgets REVISION DETAIL https://phabricator.kde.org/D2 To: nicolasfella, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25390: KateModeManager::updateFileType(): validate modes and reload menu of the status bar

cullmann requested changes to this revision. cullmann added a comment. This revision now requires changes to proceed. I like the overall effect, but I don't like the new static registry. We already have some registry in KateGlobal for all views, we would just need to allow to access the

D25555: deprecate kregexpeditorinterface

nicolasfella edited the summary of this revision. nicolasfella added a reviewer: Frameworks. REPOSITORY R310 KTextWidgets REVISION DETAIL https://phabricator.kde.org/D2 To: nicolasfella, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 WindowsMSVCQt5.13 - Build # 66 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20WindowsMSVCQt5.13/66/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Tue, 26 Nov 2019 18:04:08 + Build duration: 7 min 1 sec and counting JUnit

D25555: deprecate kregexpeditorinterface

nicolasfella created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REPOSITORY R310 KTextWidgets BRANCH regexped REVISION DETAIL https://phabricator.kde.org/D2 AFFECTED FILES

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 SUSEQt5.13 - Build # 85 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20SUSEQt5.13/85/ Project: kf5-qt5 SUSEQt5.13 Date of build: Tue, 26 Nov 2019 18:04:08 + Build duration: 6 min 3 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 SUSEQt5.12 - Build # 189 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20SUSEQt5.12/189/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 26 Nov 2019 18:04:08 + Build duration: 3 min 42 sec and counting BUILD ARTIFACTS

D25503: JavaScript: move keywords from TypeScript and other improvements

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Nice improvements! Thanks a lot. REPOSITORY R216 Syntax Highlighting BRANCH improve-javascript REVISION DETAIL https://phabricator.kde.org/D25503 To: nibags, cullmann,

D25538: [kfinddialog] Remove usage of kregexpeditor plugin system

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Ok ,=) REPOSITORY R310 KTextWidgets BRANCH noplug REVISION DETAIL https://phabricator.kde.org/D25538 To: nicolasfella, #frameworks, cullmann Cc: cullmann, kde-frameworks-devel,

D25538: [kfinddialog] Remove usage of kregexpeditor plugin system

This revision was automatically updated to reflect the committed changes. Closed by commit R310:3ba71ffb3865: [kfinddialog] Remove usage of kregexpeditor plugin system (authored by nicolasfella). REPOSITORY R310 KTextWidgets CHANGES SINCE LAST UPDATE

D25552: Deprecate top-level UserIcon method, no longer used

vkrause added a task: T11654: Deprecate SmallIcon/DesktopIcon/BarIcon/UserIcon/MainBarIcon and KDE::icon in favor of KIconLoader or QIcon API. REPOSITORY R302 KIconThemes REVISION DETAIL https://phabricator.kde.org/D25552 To: vkrause Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh,

D25538: [kfinddialog] Remove usage of kregexpeditor plugin system

nicolasfella added a comment. > Beside that, should the header not get a deprecation attribute to ensure nobody new picks that up? yes, one step at a time :) REPOSITORY R310 KTextWidgets REVISION DETAIL https://phabricator.kde.org/D25538 To: nicolasfella, #frameworks, cullmann Cc:

D25538: [kfinddialog] Remove usage of kregexpeditor plugin system

nicolasfella updated this revision to Diff 70365. nicolasfella added a comment. - [kfinddialog] Remove usage of kregexpeditor plugin system - Remove desktop file REPOSITORY R310 KTextWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25538?vs=70326=70365 BRANCH noplug

D25552: Deprecate top-level UserIcon method, no longer used

vkrause created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REPOSITORY R302 KIconThemes BRANCH master REVISION DETAIL https://phabricator.kde.org/D25552 AFFECTED FILES src/CMakeLists.txt

D25550: Mark KInit as porting aid

nicolasfella added a comment. Done with D25491 REPOSITORY R303 KInit REVISION DETAIL https://phabricator.kde.org/D25550 To: nicolasfella, #frameworks Cc: davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25538: [kfinddialog] Remove usage of kregexpeditor plugin system

cullmann requested changes to this revision. cullmann added a comment. This revision now requires changes to proceed. Looks good in principle. Could we not at least remove install( FILES kregexpeditor/kregexpeditor.desktop DESTINATION ${KDE_INSTALL_KSERVICETYPES5DIR} ) too?

D25550: Mark KInit as porting aid

davidedmundson added a comment. We shouldn't before porting kded REPOSITORY R303 KInit REVISION DETAIL https://phabricator.kde.org/D25550 To: nicolasfella, #frameworks Cc: davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25551: Mark KXmlRpcClient as porting aid

nicolasfella added reviewers: Frameworks, dvratil. REPOSITORY R312 KXmlRpcClient REVISION DETAIL https://phabricator.kde.org/D25551 To: nicolasfella, #frameworks, dvratil Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25551: Mark KXmlRpcClient as porting aid

nicolasfella created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY Execute T12157 REPOSITORY R312 KXmlRpcClient BRANCH portaid

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 204 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/204/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Tue, 26 Nov 2019 17:35:37 + Build duration: 7 min 13 sec and counting JUnit Tests Name:

D25548: [kcookiejar] Remove unneeded KService linkage

This revision was automatically updated to reflect the committed changes. Closed by commit R241:a215767ba692: [kcookiejar] Remove unneeded KService linkage (authored by nicolasfella). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25548?vs=70358=70362 REVISION

D25550: Mark KInit as porting aid

nicolasfella created this revision. nicolasfella added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY First step towards T12140

D25548: [kcookiejar] Remove unneeded KService linkage

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH cookiejar REVISION DETAIL https://phabricator.kde.org/D25548 To: nicolasfella, #frameworks, davidedmundson Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham,

D25311: Add KColumnHeadersProxyModel

kossebau added inline comments. INLINE COMMENTS > kcolumnheadersmodel.cpp:22 > + > +class KColumnHeadersModel::Private > +{ Instead of using a nested class Private, consider using a non-nested KColumnHeadersModelPrivate class. Otherwise you want to tag this class to not inherit the symbol

D25311: Add KColumnHeadersProxyModel

ahiemstra updated this revision to Diff 70359. ahiemstra added a comment. - Change to using QAbstractListModel as base REPOSITORY R275 KItemModels CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25311?vs=69807=70359 BRANCH columnheadersmodel REVISION DETAIL

D25015: Update breeze theme shadows

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. This results in the corners of the System Tray popup no longer looking rounded. Current: F7785383: Rounded.png With patch:

D25548: [kcookiejar] Remove unneeded KService linkage

nicolasfella added a reviewer: Frameworks. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25548 To: nicolasfella, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25548: [kcookiejar] Remove unneeded KService linkage

nicolasfella created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. TEST PLAN builds REPOSITORY R241 KIO BRANCH cookiejar REVISION DETAIL https://phabricator.kde.org/D25548 AFFECTED

D25106: Also allow invoking session restoration logic when apps are manually launched

ngraham closed this revision. ngraham added a comment. Phew! REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D25106 To: ngraham, davidedmundson, #frameworks, dfaure, vkrause Cc: winterz, lbeltrame, mlaurent, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham,

D25106: Also allow invoking session restoration logic when apps are manually launched

winterz added a comment. yay! REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D25106 To: ngraham, davidedmundson, #frameworks, dfaure, vkrause Cc: winterz, lbeltrame, mlaurent, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25546: Deprecate KRecursiveFilterProxyModel

kossebau added a comment. Looks good, besides nitpicks :) INLINE COMMENTS > krecursivefilterproxymodel.cpp:22 > > +#if KITEMMODELS_ENABLE_DEPRECATED_SINCE(5, 65) > #include This should be KITEMMODELS_BUILD_DEPRECATED_SINCE (BUILD., not ENABLE) > krecursivefilterproxymodel.h:28 > >

D25106: Also allow invoking session restoration logic when apps are manually launched

mlaurent added a comment. I updated kconfig and now it's ok. I can't see the "2 kontact" bug. Thanks REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D25106 To: ngraham, davidedmundson, #frameworks, dfaure, vkrause Cc: lbeltrame, mlaurent, kde-frameworks-devel,

D25530: Sonnet: Add locales that are missing in QLocale

waqar added inline comments. INLINE COMMENTS > aspotashev wrote in loader.cpp:255 > There may be different consistent approaches to capitalization: > > 1. Use the spelling like if the language name comes in the middle of a > sentence. This implies all-lowercase spelling for many Cyrillic-based

D25106: Also allow invoking session restoration logic when apps are manually launched

ngraham added a comment. Oops, sorry. D25219 was just reviewed and has landed now; can you folks verify whether the problem in Kontact is fixed now? REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D25106 To: ngraham,

D25219: Only create a session config when actually restoring a session

This revision was automatically updated to reflect the committed changes. Closed by commit R237:23d4f14601fd: Only create a session config when actually restoring a session (authored by ngraham). REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE

D25520: GridViewKCM expose a property to disable the GridView in a KCM without disabling the whole KCM

crossi abandoned this revision. crossi added a comment. No longer need since 866d3f45b84e REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D25520 To: crossi, #plasma, ervin, bport, mart,

D25546: Deprecate KRecursiveFilterProxyModel

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R275 KItemModels BRANCH deprecate (branched from master) REVISION DETAIL https://phabricator.kde.org/D25546 To: davidre, kossebau, dfaure, davidedmundson Cc: kde-frameworks-devel,

D25546: Deprecate KRecursiveFilterProxyModel

davidre added reviewers: kossebau, dfaure. davidre added a project: KF6. REPOSITORY R275 KItemModels REVISION DETAIL https://phabricator.kde.org/D25546 To: davidre, kossebau, dfaure Cc: kde-frameworks-devel, LeGast00n, davidre, GB_2, michaelh, ahmadsamir, ngraham, bruns, kpiwowarski,

D25546: Deprecate KRecursiveFilterProxyModel

davidre added a task: T12269: Remove KRecursiveFilterProxyModel. REPOSITORY R275 KItemModels REVISION DETAIL https://phabricator.kde.org/D25546 To: davidre, kossebau, dfaure Cc: kde-frameworks-devel, LeGast00n, davidre, GB_2, michaelh, ahmadsamir, ngraham, bruns, kpiwowarski,

D25546: Deprecate KRecursiveFilterProxyModel

davidre created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidre requested review of this revision. REVISION SUMMARY It is not needed since Qt 5.10 REPOSITORY R275 KItemModels BRANCH deprecate (branched from master) REVISION

D25530: Sonnet: Add locales that are missing in QLocale

aspotashev added inline comments. INLINE COMMENTS > waqar wrote in loader.cpp:255 > I used wikipedia and the description files provided with the dictionaries for > this information. It may not be correct however. If you know the language or > the rules, please feel free to correct me and I

D25545: Rename signal for avoiding overload signal

mlaurent added a reviewer: dfaure. REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D25545 To: mlaurent, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25545: Rename signal for avoiding overload signal

mlaurent created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mlaurent requested review of this revision. REVISION SUMMARY New signal for replacing done(const QString &) TEST PLAN build REPOSITORY R246 Sonnet BRANCH

D25272: Turn KNewStuffQuick::CommentsModel into a SortFilterProxy for reviews

This revision was automatically updated to reflect the committed changes. Closed by commit R304:9d1ae1544808: Turn KNewStuffQuick::CommentsModel into a SortFilterProxy for reviews (authored by leinir). REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE

D25440: Set a proper agent string for Attica requests

leinir added inline comments. INLINE COMMENTS > davidedmundson wrote in provider.cpp:1632 > string.arg(foo, bar) > > not > > string.arg(foo).arg(bar) > > otherwise we explode if foo contains the string "%1" Oh dear, yes, quite - thanks :) Old habits die hard, got a few places that'll want

D25440: Set a proper agent string for Attica requests

leinir updated this revision to Diff 70345. leinir marked 2 inline comments as done. leinir added a comment. - Correct some string wrangling mistakes (thanks @davidedmundson) REPOSITORY R235 Attica CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25440?vs=70110=70345 BRANCH

D25440: Set a proper agent string for Attica requests

davidedmundson added inline comments. INLINE COMMENTS > provider.cpp:1632 > +if (QCoreApplication::instance()) { > +agentHeader = > QString::fromLocal8Bit("%1/%2").arg(QCoreApplication::instance()->applicationName()).arg(QCoreApplication::instance()->applicationVersion()); > +}

D25272: Turn KNewStuffQuick::CommentsModel into a SortFilterProxy for reviews

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R304 KNewStuff BRANCH allow-filtering-comments-by-rating-state (branched from master) REVISION DETAIL https://phabricator.kde.org/D25272 To: leinir, #plasma, #knewstuff, #frameworks,

D25440: Set a proper agent string for Attica requests

leinir added a comment. Ping? If this (and the partner over at D25441 ) could get under way sooner rather than later, it would help a bunch with some bottleneck analysis... REPOSITORY R235 Attica REVISION DETAIL https://phabricator.kde.org/D25440

D25272: Turn KNewStuffQuick::CommentsModel into a SortFilterProxy for reviews

leinir added a comment. Ping? REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D25272 To: leinir, #plasma, #knewstuff, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » extra-cmake-modules » kf5-qt5 SUSEQt5.13 - Build # 41 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/extra-cmake-modules/job/kf5-qt5%20SUSEQt5.13/41/ Project: kf5-qt5 SUSEQt5.13 Date of build: Tue, 26 Nov 2019 11:54:59 + Build duration: 6 min 26 sec and counting JUnit Tests Name:

KDE CI: Frameworks » extra-cmake-modules » kf5-qt5 SUSEQt5.12 - Build # 75 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/extra-cmake-modules/job/kf5-qt5%20SUSEQt5.12/75/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 26 Nov 2019 11:54:59 + Build duration: 3 min 1 sec and counting JUnit Tests Name:

D25107: Add install dir for systemd units

This revision was automatically updated to reflect the committed changes. Closed by commit R240:be2beb96a3b8: Fix typo (authored by davidedmundson). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D25107?vs=70307=70340#toc REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE

D25520: GridViewKCM expose a property to disable the GridView in a KCM without disabling the whole KCM

mart requested changes to this revision. mart added a comment. This revision now requires changes to proceed. test with kirigami master and let's reevaluate later if this is still needed REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D25520 To: crossi, #plasma,

D25520: GridViewKCM expose a property to disable the GridView in a KCM without disabling the whole KCM

mart added a comment. now Kirigami.WheelHandler doesn't scroll disabled views anymore. This may be enough to not require this (just view.enabled: false), perhaps scrollbars and background could update their look as well on the style side. REPOSITORY R296 KDeclarative REVISION DETAIL

D25520: GridViewKCM expose a property to disable the GridView in a KCM without disabling the whole KCM

ervin added a comment. In D25520#567651 , @broulik wrote: > Alternatively we could fix the scroll view container taking into account the `scroll` enabled, so that `view.enabled` does the right thing You mean the other way around right?

D25520: GridViewKCM expose a property to disable the GridView in a KCM without disabling the whole KCM

davidedmundson added a comment. Yeah, but we clearly have at least one reason to break the encapsulation. I can imagine a need to externally force scroll position. I'm not forcing my version either, just wanted it considered @notmart I think you have final call? >

D25520: GridViewKCM expose a property to disable the GridView in a KCM without disabling the whole KCM

broulik added a comment. Alternatively we could fix the scroll view container taking into account the `scroll` enabled, so that `view.enabled` does the right thing REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D25520 To: crossi, #plasma, ervin, bport, mart,

D25520: GridViewKCM expose a property to disable the GridView in a KCM without disabling the whole KCM

ervin added a comment. In D25520#567644 , @davidedmundson wrote: > Throwing out an alternative suggestion > > readonly property alias gridContainer: scroll > > > (and then your code calling gridContainer.enabled = whatever) > >

  1   2   >