D27247: Unify the look of all icons containing  (no sign)

mthw added a comment. @ndavis I've set my name, do I need to "arc diff" again or something else? REPOSITORY R266 Breeze Icons BRANCH master REVISION DETAIL https://phabricator.kde.org/D27247 To: mthw, #vdg, #plasma, ngraham, ndavis Cc: ndavis, ngraham, kde-frameworks-devel,

D27247: Unify the look of all icons containing  (no sign)

ndavis added a comment. You need to set your full name as your git user name. Otherwise, the system won't let me land it. REPOSITORY R266 Breeze Icons BRANCH master REVISION DETAIL https://phabricator.kde.org/D27247 To: mthw, #vdg, #plasma, ngraham, ndavis Cc: ndavis, ngraham,

D27247: Unify the look of all icons containing  (no sign)

mthw added a comment. Since you accepted, can you also commit this, please? REPOSITORY R266 Breeze Icons BRANCH master REVISION DETAIL https://phabricator.kde.org/D27247 To: mthw, #vdg, #plasma, ngraham, ndavis Cc: ndavis, ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2,

D27269: Use ecm_qt_install_logging_categories over manual categories file

ahmadsamir added a reviewer: dfaure. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D27269 To: kossebau, #build_system, #frameworks, broulik, mlaurent, dfaure Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27268: Fixed handling of relative paths by KUrlNavigator

ahmadsamir added reviewers: dfaure, elvisangelaccio. ahmadsamir added a comment. I am curious, why would you remove the already present part of the path? when I make the url navigator editable the text cursor is already at the end of the path, so I can just start typing the name of a

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.13 - Build # 304 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/304/ Project: kf5-qt5 SUSEQt5.13 Date of build: Tue, 11 Feb 2020 04:48:20 + Build duration: 21 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 296 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/296/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Tue, 11 Feb 2020 04:48:20 + Build duration: 16 min and counting JUnit Tests Name: projectroot

D27272: Add status icons: data-error, data-warning, data-information

kossebau added a comment. Icons look like this, 16x16 & 22x22 : F8096704: Screenshot_20200211_050115.png REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D27272 To: kossebau, #vdg, ndavis Cc: #kdevelop, ngraham, davidre,

D27272: Add status icons: data-error, data-warning, data-information

kossebau updated this revision to Diff 75429. kossebau added a comment. missing bottom aligning of warning symbol for 22 REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27272?vs=75428=75429 BRANCH adddatastatusicons REVISION DETAIL

D27272: Add status icons: data-error, data-warning, data-information

kossebau updated this revision to Diff 75428. kossebau added a comment. Add own data-* icons, done to best what sleeplessness and community.kde.org guides allowed me to twist together. Color-adaption works. Hardcoded #ff for the !,i,X symbols should possible see some fix, but

KDE CI: Frameworks » kcalendarcore » kf5-qt5 WindowsMSVCQt5.14 - Build # 7 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kcalendarcore/job/kf5-qt5%20WindowsMSVCQt5.14/7/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Tue, 11 Feb 2020 01:33:28 + Build duration: 27 min and counting JUnit Tests Name:

KDE CI: Frameworks » kcoreaddons » kf5-qt5 AndroidQt5.13 - Build # 109 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20AndroidQt5.13/109/ Project: kf5-qt5 AndroidQt5.13 Date of build: Tue, 11 Feb 2020 01:52:07 + Build duration: 1 min 14 sec and counting

KDE CI: Frameworks » kcontacts » kf5-qt5 WindowsMSVCQt5.14 - Build # 7 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcontacts/job/kf5-qt5%20WindowsMSVCQt5.14/7/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Tue, 11 Feb 2020 01:33:26 + Build duration: 2 min 5 sec and counting JUnit Tests

KDE CI: Frameworks » extra-cmake-modules » kf5-qt5 SUSEQt5.13 - Build # 61 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/extra-cmake-modules/job/kf5-qt5%20SUSEQt5.13/61/ Project: kf5-qt5 SUSEQt5.13 Date of build: Tue, 11 Feb 2020 01:16:44 + Build duration: 6 min 21 sec and counting JUnit Tests Name:

KDE CI: Frameworks » extra-cmake-modules » kf5-qt5 SUSEQt5.12 - Build # 95 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/extra-cmake-modules/job/kf5-qt5%20SUSEQt5.12/95/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 11 Feb 2020 01:16:44 + Build duration: 3 min 47 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.13 - Build # 303 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/303/ Project: kf5-qt5 SUSEQt5.13 Date of build: Tue, 11 Feb 2020 01:08:24 + Build duration: 12 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kcalendarcore » kf5-qt5 WindowsMSVCQt5.14 - Build # 6 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kcalendarcore/job/kf5-qt5%20WindowsMSVCQt5.14/6/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Tue, 11 Feb 2020 01:19:09 + Build duration: 1 min 44 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks » kcontacts » kf5-qt5 WindowsMSVCQt5.14 - Build # 6 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kcontacts/job/kf5-qt5%20WindowsMSVCQt5.14/6/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Tue, 11 Feb 2020 01:19:08 + Build duration: 46 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 295 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/295/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Tue, 11 Feb 2020 01:08:24 + Build duration: 5 min 43 sec and counting JUnit Tests Name:

D27269: Use ecm_qt_install_logging_categories over manual categories file

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R241:f385d5716762: Use ecm_qt_install_logging_categories over manual categories file (authored by kossebau). CHANGED PRIOR

D27178: Use ecm_qt_install_logging_categories over manual categories file

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R246:19cd6b195279: Use ecm_qt_install_logging_categories over manual categories file (authored by kossebau). CHANGED PRIOR

KDE CI: Frameworks » kcalendarcore » kf5-qt5 FreeBSDQt5.13 - Build # 51 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcalendarcore/job/kf5-qt5%20FreeBSDQt5.13/51/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Tue, 11 Feb 2020 01:01:59 + Build duration: 2 min 20 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kcalendarcore » kf5-qt5 WindowsMSVCQt5.14 - Build # 5 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kcalendarcore/job/kf5-qt5%20WindowsMSVCQt5.14/5/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Tue, 11 Feb 2020 01:01:59 + Build duration: 1 min 0 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.12 - Build # 160 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.12/160/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 11 Feb 2020 00:44:59 + Build duration: 5 min 37 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kcontacts » kf5-qt5 WindowsMSVCQt5.14 - Build # 5 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kcontacts/job/kf5-qt5%20WindowsMSVCQt5.14/5/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Tue, 11 Feb 2020 00:46:49 + Build duration: 28 sec and counting CONSOLE OUTPUT

D27270: Use ecm_qt_install_logging_categories over manual categories files

This revision was automatically updated to reflect the committed changes. Closed by commit R174:473ec03799d6: Use ecm_qt_install_logging_categories over manual categories files (authored by kossebau). REPOSITORY R174 KContacts CHANGES SINCE LAST UPDATE

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.13 - Build # 107 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.13/107/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Tue, 11 Feb 2020 00:44:59 + Build duration: 2 min 13 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kcoreaddons » kf5-qt5 AndroidQt5.13 - Build # 108 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20AndroidQt5.13/108/ Project: kf5-qt5 AndroidQt5.13 Date of build: Tue, 11 Feb 2020 00:44:59 + Build duration: 55 sec and counting CONSOLE OUTPUT

D27151: Use ecm_qt_install_logging_categories over manual categories file

This revision was automatically updated to reflect the committed changes. Closed by commit R244:fcb1eff1c610: Use ecm_qt_install_logging_categories over manual categories file (authored by kossebau). REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE

KDE CI: Frameworks » extra-cmake-modules » kf5-qt5 SUSEQt5.13 - Build # 60 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/extra-cmake-modules/job/kf5-qt5%20SUSEQt5.13/60/ Project: kf5-qt5 SUSEQt5.13 Date of build: Mon, 10 Feb 2020 23:22:29 + Build duration: 6 min 5 sec and counting JUnit Tests Name:

KDE CI: Frameworks » extra-cmake-modules » kf5-qt5 SUSEQt5.12 - Build # 94 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/extra-cmake-modules/job/kf5-qt5%20SUSEQt5.12/94/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 10 Feb 2020 23:22:29 + Build duration: 5 min 14 sec and counting JUnit Tests Name:

D27150: Add ecm_qt_install_logging_categories & ecm_qt_export_logging_category

This revision was automatically updated to reflect the committed changes. Closed by commit R240:86041b6d8634: Add ecm_qt_install_logging_categories ecm_qt_export_logging_category (authored by kossebau). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D27150?vs=75312=75421#toc REPOSITORY

D27291: install smb as both smb:// and cifs://

feverfew added a comment. In D27291#609358 , @dfaure wrote: > feverfew: you're probably looking at master while this is a patch for the 19.12 branch. > See https://phabricator.kde.org/D26358 which happened in master. > > I guess that

D27291: install smb as both smb:// and cifs://

dfaure added a comment. feverfew: you're probably looking at master while this is a patch for the 19.12 branch. See https://phabricator.kde.org/D26358 which happened in master. I guess that makes this commit ok for 19.12, but it has to be redone differently in master. REPOSITORY

D27291: install smb as both smb:// and cifs://

dfaure added a comment. Both are supported, but indeed json is preferred over installed .protocol files. You can use protocoltojson (from kio) to do the conversion. This is all technically unrelated to this commit, except that the nice cmake hack to generate two files isn't even

Re: Frameworks 5.67 re-spin request

On lundi 10 février 2020 15:32:11 CET Nate Graham wrote: > Hello frameworks packagers, > I hate to have to make this request, bug could we get Frameworks 5.67 > re-spun to include these two commits: > > https://cgit.kde.org/kirigami.git/commit/?id=f695cde36a6829b8b92b2fd82deff16 > d9385fcb9 > >

D27291: install smb as both smb:// and cifs://

feverfew added a comment. I'm a bit confused here, isn't the protocol file now a JSON file? I'm looking at the repo and it appears to be the case, so I'm not seeing how this diff is seeing this as a rename? REPOSITORY R320 KIO Extras BRANCH bug327295 REVISION DETAIL

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

ndavis added a comment. I think rather than adjusting hardcoded opacity in the SVGs, we need to make configurable plasmashell opacity a reality. Then, if we want to do an effect like what Nate described, we could have a way to automatically adjust the global plasmashell opacity. REPOSITORY

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

niccolove added a comment. - Breeze panel and dialog being different when using a dark theme - Avoiding controls to be used in ViewBackground areas / using Background Breeze color without it looking gray I have no idea how these could be fixed without just using a color file-d theme

D27247: Unify the look of all icons containing  (no sign)

ndavis accepted this revision. REPOSITORY R266 Breeze Icons BRANCH master REVISION DETAIL https://phabricator.kde.org/D27247 To: mthw, #vdg, #plasma, ngraham, ndavis Cc: ndavis, ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

D27247: Unify the look of all icons containing  (no sign)

ngraham accepted this revision. ngraham added a subscriber: ndavis. ngraham added a comment. This revision is now accepted and ready to land. LGTM! @ndavis does this look okay to you? And what do you think about that lonely 24px `audio-volume-muted` icon in the actions folder? Once this

D27247: Unify the look of all icons containing  (no sign)

mthw updated this revision to Diff 75406. mthw added a comment. Fixed REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27247?vs=75389=75406 BRANCH master REVISION DETAIL https://phabricator.kde.org/D27247 AFFECTED FILES

D27221: Make PC3 ToolButton use SmallMedium icon size by default, to match other versions

ngraham removed a dependent revision: D27222: [applets/taskmanager] increase size of tooltip playback ToolButton sizes. REPOSITORY R242 Plasma Framework (Library) BRANCH fix-pc3-toolbutton-sizing (branched from master) REVISION DETAIL https://phabricator.kde.org/D27221 To: ngraham,

D27247: Unify the look of all icons containing  (no sign)

ngraham added a comment. Just found a 24px version of `audio-volume-muted` in the actions folder that either needs the same change, or needs to be deleted. Almost done! REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D27247 To: mthw, #vdg, #plasma, ngraham Cc:

D27297: KGuiAddons: Convert license headers to SPDX statements

This revision was automatically updated to reflect the committed changes. Closed by commit R273:9cdefdd60fb0: KGuiAddons: Convert license headers to SPDX statements (authored by cordlandwehr). REPOSITORY R273 KGuiAddons CHANGES SINCE LAST UPDATE

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

ngraham added a comment. One thing I notice other platforms do is to make the panel more opaque when there's a maximized window up against it. That resolves the issue of a translucent panel reflecting the wallpaper color in a way that's jarringly different from pop-ups that appear on top

D27141: Drop Policykit backend

This revision was automatically updated to reflect the committed changes. Closed by commit R283:4d241b3f4f54: Drop Policykit backend (authored by davidedmundson). REPOSITORY R283 KAuth CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27141?vs=74953=75400 REVISION DETAIL

D27272: Add status icons: data-error, data-warning, data-information

kossebau added a subscriber: KDevelop. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D27272 To: kossebau, #vdg, ndavis Cc: #kdevelop, ngraham, davidre, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

D27272: Add status icons: data-error, data-warning, data-information

kossebau added a comment. Thanks for feedback, sounds good, so we are 2 already. Now curious about more opinions. Though when I said "crude hacking" I really meant it ;) So sadly nothing to seriously upload. This need some qualified icon drawing person do get the proper roundings,

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.13 - Build # 163 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.13/163/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Mon, 10 Feb 2020 18:17:56 + Build duration: 3 min 37 sec and counting JUnit Tests

D27299: Vertically center tooltip icon/image

This revision was automatically updated to reflect the committed changes. Closed by commit R242:9d27675c3b4e: Vertically center tooltip icon/image (authored by ngraham). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27299?vs=75394=75398

D27299: Vertically center tooltip icon/image

ngraham added inline comments. INLINE COMMENTS > ndavis wrote in DefaultToolTip.qml:57 > Do you actually need Qt.AlignHCenter? Isn't there some margin setting that > decides how the text is placed relative to the icon? Text isn't involved here; setting both vertical and horizontal alignment

D27288: [policy-gen] Fix the code to actually captured the correct capture group

ahmadsamir edited the test plan for this revision. ahmadsamir added a reviewer: apol. REPOSITORY R283 KAuth REVISION DETAIL https://phabricator.kde.org/D27288 To: ahmadsamir, #frameworks, dfaure, apol Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27299: Vertically center tooltip icon/image

ndavis added inline comments. INLINE COMMENTS > DefaultToolTip.qml:57 > visible: toolTip != null && toolTip.image != "" > -Layout.alignment: Qt.AlignTop > +Layout.alignment: Qt.AlignHCenter | Qt.AlignVCenter > } Do you actually need Qt.AlignHCenter?

D27299: Vertically center tooltip icon/image

ndavis accepted this revision. REPOSITORY R242 Plasma Framework (Library) BRANCH vertically-center-tooltip-icon (branched from master) REVISION DETAIL https://phabricator.kde.org/D27299 To: ngraham, #vdg, #plasma, filipf, ndavis Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2,

D27299: Vertically center tooltip icon/image

filipf accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH vertically-center-tooltip-icon (branched from master) REVISION DETAIL https://phabricator.kde.org/D27299 To: ngraham, #vdg, #plasma, filipf Cc:

D27299: Vertically center tooltip icon/image

ngraham created this revision. ngraham added reviewers: VDG, Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ngraham requested review of this revision. REVISION SUMMARY Right now the widget tooltip's icon/image is top-aligned, which in practice

D27297: KGuiAddons: Convert license headers to SPDX statements

cgiboudeaux accepted this revision. cgiboudeaux added a comment. This revision is now accepted and ready to land. LGTM REPOSITORY R273 KGuiAddons BRANCH spdx REVISION DETAIL https://phabricator.kde.org/D27297 To: cordlandwehr, cgiboudeaux Cc: cgiboudeaux, kde-frameworks-devel,

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.13 - Build # 162 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.13/162/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Mon, 10 Feb 2020 17:43:11 + Build duration: 2 min 20 sec and counting JUnit Tests

D27297: KGuiAddons: Convert license headers to SPDX statements

cordlandwehr created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. cordlandwehr requested review of this revision. REVISION SUMMARY Convert license statements to SPDX and add license text files in LICENSES folder as required by the REUSE

D27297: KGuiAddons: Convert license headers to SPDX statements

cordlandwehr added a task: T11550: Add SPDX License markers. REPOSITORY R273 KGuiAddons REVISION DETAIL https://phabricator.kde.org/D27297 To: cordlandwehr Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27292: set the share comment as UDS_COMMENT for the UI to display

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R320 KIO Extras BRANCH bug105086 REVISION DETAIL https://phabricator.kde.org/D27292 To: sitter, ngraham Cc: broulik, kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n,

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

niccolove edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27122 To: niccolove, ndavis, ngraham, cblack Cc: cblack, ndavis, filipf, ngraham, davidedmundson, kde-frameworks-devel, manueljlin, Orage, LeGast00n,

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

niccolove edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27122 To: niccolove, ndavis, ngraham, cblack Cc: cblack, ndavis, filipf, ngraham, davidedmundson, kde-frameworks-devel, manueljlin, Orage, LeGast00n,

D27296: [PlasmaComponents]Clean up ListItem code

gvgeo created this revision. gvgeo added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. gvgeo requested review of this revision. REVISION SUMMARY Removed two unused lines. Removed old comments. Minor style changes to comments. TEST

D27292: set the share comment as UDS_COMMENT for the UI to display

sitter added a comment. We talked about this on telegram and what Kai is thinking of may be the mime comment. Upon review UDS_COMMENT (or KFileItem::comment()) seems to simply not be modeled in dolphin. The model has a Comment column but as far as I can tell the data for that column is

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

filipf added a comment. Right, I also noticed the color-aware theme now has somewhat more pronounced discrepancy between the panel and the popups when dark color schemes are used. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27122 To:

D27247: Unify the look of all icons containing  (no sign)

mthw updated this revision to Diff 75389. mthw added a comment. Changes to "font-disable" and "mail-mark-junk" are now included too. REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27247?vs=75334=75389 BRANCH master REVISION DETAIL

D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

ndavis added a comment. In D27122#608443 , @niccolove wrote: > Using Background for panels would break the visual integration with dialogs, so I would avoid doing that. > > Regarding panel popups / dialogs; I'm already working on the

D27272: Add status icons: data-error, data-warning, data-information

ngraham added a comment. Those don't look too bad. :) Wanna submit them? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D27272 To: kossebau, #vdg, ndavis Cc: ngraham, davidre, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

D27247: Unify the look of all icons containing  (no sign)

ngraham added a comment. sure, good idea! REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D27247 To: mthw, #vdg, #plasma, ngraham Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

D27292: set the share comment as UDS_COMMENT for the UI to display

broulik added a comment. The comment will be shown in the status bar when hovering a file. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D27292 To: sitter, ngraham Cc: broulik, kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, cblack,

D27295: smb: support more advanced hidden file flag

sitter created this revision. sitter added a reviewer: ngraham. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY smb attaches different meaning to the +x flags of files to represent

D27294: fix free space calculation

sitter created this revision. sitter added a reviewer: ngraham. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY - collapse statvfs call, there's no purpose in manually opening the

D27293: smb: do not map uid and gid

sitter created this revision. sitter added a reviewer: ngraham. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY libsmbc returns the uid/gid of the process, not of the file, the data

D27292: set the share comment as UDS_COMMENT for the UI to display

sitter created this revision. sitter added a reviewer: ngraham. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY currently this seems to not really have any visibility through

D27272: Add status icons: data-error, data-warning, data-information

kossebau added a comment. To give an example what I would expect proper Breeze status icons to look like, get an idea of me doing crude hacking to turn the emblem variants into something matching the style guide for status icons: adding in-icon margins & removing the explicit contrast

D27291: install smb as both smb:// and cifs://

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R320 KIO Extras BRANCH bug327295 REVISION DETAIL https://phabricator.kde.org/D27291 To: sitter, dfaure, ngraham Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n,

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.13 - Build # 160 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.13/160/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Mon, 10 Feb 2020 15:50:20 + Build duration: 2 min 48 sec and counting JUnit Tests

D27215: add vvave icon

ndavis accepted this revision. REPOSITORY R266 Breeze Icons BRANCH vvave (branched from master) REVISION DETAIL https://phabricator.kde.org/D27215 To: mbruchert, #vdg, camiloh, ndavis Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27200: Make the attached property a simple QObject

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R242:68a273aef6c1: Make the attached property a simple QObject (authored by mart). CHANGED PRIOR TO COMMIT

Re: License Clarification for kguiaddons/tests/openurltest.cpp

Hi Andreas, I'm happy with it having whatever license is more appropriate within the framework. You suggestion makes sense to me. Aleix On Sat, Feb 8, 2020 at 4:43 PM Andreas Cord-Landwehr wrote: > > Hi Aleix, > > I found the file kguiaddons/tests/openurltest.cpp with an ambiguous license >

D27291: install smb as both smb:// and cifs://

sitter created this revision. sitter added a reviewer: dfaure. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY the latter while not IANA registered is apparently used in places. to

D27247: Unify the look of all icons containing  (no sign)

mthw added a comment. I also made adjustments to "font-disable" and "mail-mark-junk", do you want me to include them? After that all icons containing  will be the same. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D27247 To: mthw, #vdg, #plasma, ngraham Cc:

Frameworks 5.67 re-spin request

Hello frameworks packagers, I hate to have to make this request, bug could we get Frameworks 5.67 re-spun to include these two commits: https://cgit.kde.org/kirigami.git/commit/?id=f695cde36a6829b8b92b2fd82deff16d9385fcb9

D27285: Add left/right indent fill (as opposed to left-only), extend indent lines to broken lines

eudoxos added a comment. Note: extra space (right fill) is not computed correctly if tabs are used for line indentation. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D27285 To: eudoxos, #vdg Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack,

D26118: Port QRegExp to QRegularExpression

ahmadsamir added a comment. In D26118#608935 , @broulik wrote: > This appears to have broken policy file generation. The polkit files I now get have > > Neues Plymouth-Design installieren > > > Note the "Name" in the `xml:lang`

D27288: [policy-gen] Fix the code to actually captured the correct capture group

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, dfaure. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY This was a mistake in porting form QRegExp::capturedTexts() to QRegularExpression; capturedTexts(1) translates

D27065: Fix inverted logic in IOKitStorage::isRemovable

rjvbb added a comment. > This is a MacBook Pro Retina, 13-inch, Mid 2014 with macOS 10.15.2 with only this one disk. It's clearly not supposed to get removed, imo :) Indeed. The icon shown is for internal disks. Thanks for drawing attention to this, I'm going to have to look into

D27284: [polkit-1] Simplify Polkit1Backend action exists lookup

This revision was automatically updated to reflect the committed changes. Closed by commit R283:3a7a57c33453: [polkit-1] Simplify Polkit1Backend action exists lookup (authored by davidedmundson). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D27284?vs=75357=75363#toc REPOSITORY R283

D27283: [polkit-1] Return an error status in actionStatus if there is an error

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R283:d80fdb8966a0: [polkit-1] Return an error status in actionStatus if there is an error (authored by davidedmundson).

D27285: Add left/right indent fill (as opposed to left-only), extend indent lines to broken lines

eudoxos added a comment. This is an example with right fill of 3 characters, left fill off, with indentation lines (note that they spend all visual lines of the dynamically wrapped line). F8095407: image.png REPOSITORY R39 KTextEditor REVISION

D27285: Add left/right indent fill (as opposed to left-only), extend indent lines to broken lines

eudoxos created this revision. eudoxos added a reviewer: VDG. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. eudoxos requested review of this revision. REVISION SUMMARY The configuration UI is somewhat clumsy, some better arrangement

D26118: Port QRegExp to QRegularExpression

broulik added a comment. This appears to have broken policy file generation. The polkit files I now get have Neues Plymouth-Design installieren Note the "Name" in the `xml:lang` REPOSITORY R283 KAuth REVISION DETAIL https://phabricator.kde.org/D26118 To: ahmadsamir,

D27284: [polkit-1] Simplify Polkit1Backend action exists lookup

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R283 KAuth BRANCH kauth_fixup REVISION DETAIL https://phabricator.kde.org/D27284 To: davidedmundson, broulik Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27065: Fix inverted logic in IOKitStorage::isRemovable

mwolff added a comment. In D27065#608920 , @rjvbb wrote: > How do you connect? The Mac OS has a built-in VNC server but it has to be activated. Once it is you should be able to connect using any VNC client (possibly using ssh tunnelling?).

D27065: Fix inverted logic in IOKitStorage::isRemovable

rjvbb added a comment. How do you connect? The Mac OS has a built-in VNC server but it has to be activated. Once it is you should be able to connect using any VNC client (possibly using ssh tunnelling?). You can configure the Finder to show every connected volume on the desktop, IIRC

D27272: Add status icons: data-error, data-warning, data-information

kossebau added a comment. Simply linking the emblem icons is in any case a first cheap shot. So far I am hoping for someone fluent with icon designing who could take a look at the at the rules for status icons ( https://hig.kde.org/style/icons/action_status.html ) and give the Breeze-style

D27272: Add status icons: data-error, data-warning, data-information

kossebau added a comment. Like @davidre said. Abusing emblem icons would be a not-nice hack, those icons serve a different purpose and thus also follow different rules (e.g. being able to be painted on top of complex backgrounds). We want to use icons whose names and type are semantically

D27283: [polkit-1] Return an error status in actionStatus if there is an error

davidedmundson added a dependent revision: D27284: [polkit-1] Simplify Polkit1Backend action exists lookup. REPOSITORY R283 KAuth REVISION DETAIL https://phabricator.kde.org/D27283 To: davidedmundson Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

  1   2   >