Review Request 116982: Remove KDE 4 refs in khtml

2014-03-22 Thread Alex Merry
/dom_docimpl.h 83691165437edae603ab4d23d2c844cb0b9391ad Diff: https://git.reviewboard.kde.org/r/116982/diff/ Testing --- Builds, installs, autotests pass. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https

Re: Review Request 116894: Clean up comments that reference kde4

2014-03-21 Thread Alex Merry
f106d254e015fc4eccf12fb4437ec221fb64ba1b src/sycoca/ksycocatype.h 54276a6bc04d8a48be8c4022250453e4c9993279 Diff: https://git.reviewboard.kde.org/r/116894/diff/ Testing --- Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https

Re: Review Request 116894: Clean up comments that reference kde4

2014-03-21 Thread Alex Merry
f106d254e015fc4eccf12fb4437ec221fb64ba1b src/sycoca/ksycocatype.h 54276a6bc04d8a48be8c4022250453e4c9993279 Diff: https://git.reviewboard.kde.org/r/116894/diff/ Testing --- Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https

Re: Review Request 116894: Clean up comments that reference kde4

2014-03-21 Thread Alex Merry
f106d254e015fc4eccf12fb4437ec221fb64ba1b src/sycoca/ksycocatype.h 54276a6bc04d8a48be8c4022250453e4c9993279 Diff: https://git.reviewboard.kde.org/r/116894/diff/ Testing --- Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https

Review Request 116952: Make sure non-prefixed desktop files win when looking up by name

2014-03-21 Thread Alex Merry
--- Tested using the new test app. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 116952: Make sure non-prefixed desktop files win when looking up by name

2014-03-21 Thread Alex Merry
tests/findservice.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/116952/diff/ Testing --- Tested using the new test app. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org

Re: Review Request 116873: Replace GPL proctitle code with BSD-licensed code from OpenSSH

2014-03-21 Thread Alex Merry
: https://git.reviewboard.kde.org/r/116873/diff/ Testing --- Tested on Linux only. I put a 20-second sleep in before the exec call, so that I could see the process title of the fork. Tested as-is, and with the prctl() call commented out. Thanks, Alex Merry

Re: Review Request 116935: Remove use of KLibrary in KLauncher

2014-03-21 Thread Alex Merry
to see details of leaked memory ==20134== ==20134== For counts of detected and suppressed errors, rerun with: -v ==20134== ERROR SUMMARY: 0 errors from 0 contexts (suppressed: 1 from 1) Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde

Re: Review Request 116934: Use KPluginLoader to find kioslaves

2014-03-21 Thread Alex Merry
-devel/kioslavetestJ32621.slave-socket ) and the copy was successful. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 116938: Remove defunct plugin-loading code, and deprecate KLibrary

2014-03-21 Thread Alex Merry
/plugin/kpluginloader.cpp 53d6bc2aa8d8f91f296943ad8831ff6aaab6b3e6 src/plugin/klibrary.h 78f0701e01b0a24e8895127640ce575e09d93d7c src/plugin/klibrary.cpp c77ec32dbb1cbd1ccd6342a082012d2c82575fb8 Diff: https://git.reviewboard.kde.org/r/116938/diff/ Testing --- Thanks, Alex Merry

Review Request 116955: Remove KDE 4 refs from Doxyfile.global

2014-03-21 Thread Alex Merry
://git.reviewboard.kde.org/r/116955/diff/ Testing --- Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 116959: Remove KDE 4 references from kcmutils

2014-03-21 Thread Alex Merry
c58b68ccb1716493d0537fbfe5a89733ff72e22b src/kcmultidialog.cpp cc0c8d8228ad03e1b4de62152bf7bc7ecdc1f5ee Diff: https://git.reviewboard.kde.org/r/116959/diff/ Testing --- Compiles, installs. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org

Review Request 116960: @since KDE 4.1 - @since 4.1

2014-03-21 Thread Alex Merry
c7c46b587c23f342d1c0bc959164fdc95277609e Diff: https://git.reviewboard.kde.org/r/116960/diff/ Testing --- Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 116962: Clean up KDE4 references in kconfig

2014-03-21 Thread Alex Merry
ea0419f6acf572f3c9a48bb77704b2d7d71e4ad4 src/kconf_update/kconf_update.cpp f8ba16d1c27029b480f19d5580b3edca9ac98bd0 src/kconfig_compiler/CMakeLists.txt 71f2609d870cd00eae3d98c0f3a07504d5973ff0 Diff: https://git.reviewboard.kde.org/r/116962/diff/ Testing --- Thanks, Alex Merry

Re: Review Request 116960: @since KDE 4.1 - @since 4.1

2014-03-21 Thread Alex Merry
/kcompletionbox.cpp 92e87b39c17cab96afb395bc77fabef95992c80b src/klineedit.h c7c46b587c23f342d1c0bc959164fdc95277609e Diff: https://git.reviewboard.kde.org/r/116960/diff/ Testing --- Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde

Re: Review Request 116913: Remove KParts::ComponentFactory

2014-03-20 Thread Alex Merry
/kparts/componentfactory.h 8fba1c667144e47f6645c7830c459a1dbb0a926e Diff: https://git.reviewboard.kde.org/r/116913/diff/ Testing --- Built and installed. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https

Review Request 116920: Move the autostart and wrapper docs into a docs/ subdirectory

2014-03-20 Thread Alex Merry
--- Move the autostart and wrapper docs into a docs/ subdirectory Diffs - README.autostart README.wrapper Diff: https://git.reviewboard.kde.org/r/116920/diff/ Testing --- Thanks, Alex Merry ___ Kde-frameworks-devel mailing list

Re: Review Request 116920: Move the autostart and wrapper docs into a docs/ subdirectory

2014-03-20 Thread Alex Merry
, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 116927: Fix kdeinit module lookup

2014-03-20 Thread Alex Merry
as it did previously. klauncher process then has [kdeinit] in its process title in `ps xu`. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 116928: Default to not launching kded

2014-03-20 Thread Alex Merry
not launch kded5, while `kdeinit5 --kded` does. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 116928: Default to not launching kded

2014-03-20 Thread Alex Merry
, 2014, 3:04 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116928/ --- (Updated March 20, 2014, 3:04 p.m

Re: Review Request 116928: Default to not launching kded

2014-03-20 Thread Alex Merry
/ Testing --- Builds, installs. `kdeinit5` does not launch kded5, while `kdeinit5 --kded` does. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 116927: Fix kdeinit module lookup

2014-03-20 Thread Alex Merry
libkdeinit5_klauncher, rather than /home/kf5-devel/kf5/bin/klauncher as it did previously. klauncher process then has [kdeinit] in its process title in `ps xu`. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https

Re: Review Request 116914: Remove KLibLoader::createInstance methods

2014-03-20 Thread Alex Merry
/kdecore/klibloader.cpp b9d0625025445f7c200608be06433bd19ec6ead0 Diff: https://git.reviewboard.kde.org/r/116914/diff/ Testing --- Builds, compiles, tests pass. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org

Re: Review Request 116928: Default to not launching kded

2014-03-20 Thread Alex Merry
Diff: https://git.reviewboard.kde.org/r/116928/diff/ Testing --- Builds, installs. `kdeinit5` does not launch kded5, while `kdeinit5 --kded` does. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https

Re: Review Request 116914: Remove KLibLoader::createInstance methods

2014-03-20 Thread Alex Merry
/klibloader.h 07d0c1c4bd4747b394745d9b7af0765874c4d6e3 src/kdecore/klibloader.cpp b9d0625025445f7c200608be06433bd19ec6ead0 Diff: https://git.reviewboard.kde.org/r/116914/diff/ Testing --- Builds, compiles, tests pass. Thanks, Alex Merry ___ Kde

Review Request 116934: Use KPluginLoader to find kioslaves

2014-03-20 Thread Alex Merry
and suppressed errors, rerun with: -v ==20134== ERROR SUMMARY: 0 errors from 0 contexts (suppressed: 1 from 1) Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 116935: Remove use of KLibrary in KLauncher

2014-03-20 Thread Alex Merry
== For counts of detected and suppressed errors, rerun with: -v ==20134== ERROR SUMMARY: 0 errors from 0 contexts (suppressed: 1 from 1) Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman

Re: Review Request 116934: Use KPluginLoader to find kioslaves

2014-03-20 Thread Alex Merry
) and the copy was successful. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 116936: Use QLibrary instead of KLibrary

2014-03-20 Thread Alex Merry
src/rendering/break_lines.cpp bc4542c7ea1031d75531b6028f3044fe15672009 Diff: https://git.reviewboard.kde.org/r/116936/diff/ Testing --- ./tests/testkhtml 'https://git.reviewboard.kde.org' Thanks, Alex Merry ___ Kde-frameworks-devel mailing

Review Request 116937: Use QLibrary instead of KLibrary in KOpenSSL

2014-03-20 Thread Alex Merry
--- Use QLibrary instead of KLibrary in KOpenSSL Diffs - src/kssl/kopenssl.cpp 43125ae90cb4e375cb93a011acbf584adc334f0a Diff: https://git.reviewboard.kde.org/r/116937/diff/ Testing --- Thanks, Alex Merry ___ Kde-frameworks-devel

Re: Review Request 116927: Fix kdeinit module lookup

2014-03-20 Thread Alex Merry
kdeinit5, which reported that it was launching libkdeinit5_klauncher, rather than /home/kf5-devel/kf5/bin/klauncher as it did previously. klauncher process then has [kdeinit] in its process title in `ps xu`. Thanks, Alex Merry ___ Kde-frameworks-devel

Review Request 116894: Clean up comments that reference kde4

2014-03-19 Thread Alex Merry
: https://git.reviewboard.kde.org/r/116894/diff/ Testing --- Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 116895: Break ksycoca binary compatibility

2014-03-19 Thread Alex Merry
: https://git.reviewboard.kde.org/r/116895/diff/ Testing --- Builds, tests pass. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 116895: Break ksycoca binary compatibility

2014-03-19 Thread Alex Merry
874ec66ea5ba8d50bfb82441644ba94295b2361a src/sycoca/ksycoca.cpp 6c67bb4f07f3f80aa2821fb5efe702259f1163b3 Diff: https://git.reviewboard.kde.org/r/116895/diff/ Testing --- Builds, tests pass. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde

KLibrary: what is it good for?

2014-03-19 Thread Alex Merry
While trying to clean up KDE 4 references in KService, I've been looking at KLibrary. This basically does two things: it has a factory() method that has been deprecated since before kdelibs 4.0.0, and it does some extra lookup magic. KLibrary::factory() is used by KPluginLoader for compatibility

Re: KLibrary: what is it good for?

2014-03-19 Thread Alex Merry
On 19/03/14 14:29, Alex Merry wrote: While trying to clean up KDE 4 references in KService, I've been looking at KLibrary. This basically does two things: it has a factory() method that has been deprecated since before kdelibs 4.0.0, and it does some extra lookup magic. KLibrary::factory

Review Request 116912: Remove KSocks and KSocksSocketDevice

2014-03-19 Thread Alex Merry
://git.reviewboard.kde.org/r/116912/diff/ Testing --- Built, installed, ran tests. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 116913: Remove KParts::ComponentFactory

2014-03-19 Thread Alex Merry
://git.reviewboard.kde.org/r/116913/diff/ Testing --- Built and installed. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 116912: Remove KSocks and KSocksSocketDevice

2014-03-19 Thread Alex Merry
/kdecore/k3sockssocketdevice.cpp dae2f75fbafbd4f1d91fb8503669220f6bf7475e Diff: https://git.reviewboard.kde.org/r/116912/diff/ Testing (updated) --- Built, installed. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel

Review Request 116914: Remove KLibLoader::createInstance methods

2014-03-19 Thread Alex Merry
b9d0625025445f7c200608be06433bd19ec6ead0 Diff: https://git.reviewboard.kde.org/r/116914/diff/ Testing --- Builds, compiles, tests pass. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks

Re: Review Request 116866: Use std::isnan on compilers that support it (fixes MinGW on Windows)

2014-03-18 Thread Alex Merry
/116866/#comment37507 Either this line should be removed from here, or it should be added to kcolorutils.cpp (otherwise you're testing in one environment and using it in another). - Alex Merry On March 18, 2014, 3:18 a.m., Michael Hansen wrote

Review Request 116873: Replace GPL proctitle code with BSD-licensed code from OpenSSH

2014-03-18 Thread Alex Merry
--- Tested on Linux only. I put a 20-second sleep in before the exec call, so that I could see the process title of the fork. Tested as-is, and with the prctl() call commented out. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde

Review Request 116876: Add default emoticons theme to kemoticons

2014-03-18 Thread Alex Merry
/wilted_rose.png PRE-CREATION themes/Glass/wink.png PRE-CREATION Diff: https://git.reviewboard.kde.org/r/116876/diff/ Testing --- Builds, installs, tests pass without skipping (both before and after installation). Thanks, Alex Merry ___ Kde

Re: Review Request 116866: Use std::isnan on compilers that support it (fixes MinGW on Windows)

2014-03-18 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116866/#review53347 --- Ship it! Ship It! - Alex Merry On March 18, 2014, 5:25

Re: Review Request 116830: Replace use of QPA headers with optional dep on QX11Extras.

2014-03-17 Thread Alex Merry
approval for the extra dependency, although my view is that QX11Extras is a perfectly reasonable optional dependency for any framework (and the same would be true of the windows equivalent). - Alex Merry On March 16, 2014, 9:32 a.m., David Faure wrote

Re: how to write kded module in framework 5

2014-03-17 Thread Alex Merry
On 15/03/14 22:55, Shivam Makkar wrote: Hello fellow developers ! :) I am noob in kde and hacking keyboard module these days ! I tried to instantiate object of class keyboardDaemon and I got this error : In file included from

KDNSSD repository renames

2014-03-17 Thread Alex Merry
Just to warn you that the kdnssd module in kdenetwork has been renamed to zeroconf-ioslave (since that's what it is), and the kdnssd-framework module in frameworks has been renamed to kdnssd. Given that only scripty and I have made commits to what is now zeroconf-ioslave since it was in svn, this

Re: Default emoticons theme

2014-03-17 Thread Alex Merry
On 15/03/14 19:04, Aleix Pol wrote: I do agree that having an emoticons set together with kemoticons can be very helpful and simplify the usage of the module. Also, it doesn't really make sense to use kf5 or kde4. It's not something linked to the library version, so it can be a theme name. I

Re: Releasing Deprecated modules and Tier 4 Definition

2014-03-17 Thread Alex Merry
On 17/03/14 15:25, Aurélien Gâteau wrote: On Sat, Mar 15, 2014, at 8:59, Kevin Ottens wrote: 1) Split Tier 4 in a Tier 4 and a Tier Deprecated :) Currently we can consider Tier 4 as badly defined. It contains both parts with no API (apidox, frameworkintegration, kfileaudiopreview) mainly for

Re: Review Request 116653: Create ECMFindModuleHelpers module for common find-module code

2014-03-17 Thread Alex Merry
-workspace. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Releasing Deprecated modules and Tier 4 Definition

2014-03-17 Thread Alex Merry
On 17/03/14 17:15, Kevin Ottens wrote: Now, the last point... What else do we want to move from KDE Frameworks to KDE Porting Aids? Aleix and Aaron proposed the following content for KDE Porting Aids: * kde4support (obvious); * khtml (planned for a long time); * kjs (because of khtml

Re: how to write kded module in framework 5

2014-03-17 Thread Alex Merry
On 17/03/14 19:35, Shivam Makkar wrote: also I want to know how can i start kded5 when I run command kded5 or kdeinit5 i get kded5(16341)/(default) QXcbSessionManager::QXcbSessionManager: Qt: Session management error: networkIdsList argument is NULL Hmm... you might want to try

Re: Review Request 116866: Use std::isnan on compilers that support it (fixes MinGW on Windows)

2014-03-17 Thread Alex Merry
for the presence of these functions, rather than using Q_CC_ defines. See KJS for examples of these tests. - Alex Merry On March 17, 2014, 8:53 p.m., Michael Hansen wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: KItemModels, Solid KJS licenses

2014-03-17 Thread Alex Merry
On 17/03/14 21:53, šumski wrote: On Wednesday 19 of February 2014 21:18:31 šumski wrote: Hi all, i've started pushing Frameworks to openSUSE Factory (i.e. next openSUSE release), and our legal review found some issues[1][2][3] with mentioned frameworks licenses. ... Next one, kinit[1]:

Re: Releasing Deprecated modules and Tier 4 Definition

2014-03-17 Thread Alex Merry
On 17/03/14 18:50, Treeve Jelbert wrote: On Monday 17 March 2014 18:15:09 Kevin Ottens wrote: Now, the last point... What else do we want to move from KDE Frameworks to KDE Porting Aids? Aleix and Aaron proposed the following content for KDE Porting Aids: * kde4support (obvious); * khtml

Re: Review Request 116087: remove usage of strlcpy

2014-03-16 Thread Alex Merry
On March 16, 2014, 9:12 a.m., David Faure wrote: src/kcrash.cpp, line 56 https://git.reviewboard.kde.org/r/116087/diff/3/?file=254139#file254139line56 I just realized that this requires qpa-private headers, which is a problem (breaks compat when upgrading Qt, too). See k-f-d

Default emoticons theme

2014-03-15 Thread Alex Merry
Currently, kde-runtime installs an emoticons theme called kf5, and the kemoticons framework looks for a theme called kde4 by default. I suggest that either: - the kde-runtime theme moves to the Oxygen repo, gets renamed to oxygen, and kemoticons selects this by default, or - it moves to

Review Request 116799: Remove KDE4 branch conditional from kf5i18nuic.cmake

2014-03-14 Thread Alex Merry
Diff: https://git.reviewboard.kde.org/r/116799/diff/ Testing --- Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 116087: remove usage of strlcpy

2014-03-14 Thread Alex Merry
will be created, and so the startupid won't go away. - Alex Merry On March 14, 2014, 12:38 p.m., Alexander Richardson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116087

Re: Review Request 116799: Remove KDE4 branch conditional from kf5i18nuic.cmake

2014-03-14 Thread Alex Merry
ac557edad1e3c3990e412743eeb8dad1365c71f9 cmake/kf5i18nuic.cmake efcd0ae1d51b5629c88cf22064a0a6ba9b9b67ff Diff: https://git.reviewboard.kde.org/r/116799/diff/ Testing --- Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel

Re: Review Request 116747: Clean up KCompletionBox

2014-03-14 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116747/#review52953 --- Ship it! Ship It! - Alex Merry On March 14, 2014, 8:46

Re: Review Request 116747: Clean up KCompletionBox

2014-03-13 Thread Alex Merry
/116747/#comment37230 Is this comment definitely no longer relevant? It looks like it refers to the sendPostedEvents() call that's still there. - Alex Merry On March 12, 2014, 10:57 p.m., David Gil Oliva wrote

Re: Review Request 116766: Use a desktop file we might find for testing KServiceActions

2014-03-13 Thread Alex Merry
. - Alex --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116766/#review52874 --- On March 12, 2014, 3:47 p.m., Alex Merry wrote

Re: Review Request 116766: Use a desktop file we might find for testing KServiceActions

2014-03-13 Thread Alex Merry
that might actually be installed instead. Diffs - autotests/kservicetest.h aa1c691c75c9e5b6903bcbf6e2dc95809ee1ce21 autotests/kservicetest.cpp 711fb9b649e580ad474b0cdecd26dcdbfdc302a2 Diff: https://git.reviewboard.kde.org/r/116766/diff/ Testing --- Thanks, Alex Merry

Re: Review Request 116760: Remove kcookiescfg update scripts

2014-03-13 Thread Alex Merry
/ Testing --- Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 116760: Remove kcookiescfg update scripts

2014-03-13 Thread Alex Merry
. To reply, visit: https://git.reviewboard.kde.org/r/116760/#review52831 --- On March 12, 2014, 3:44 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit

Re: KF5 Update Meeting Minutes 2014-w11

2014-03-12 Thread Alex Merry
On 12/03/14 07:56, Kevin Ottens wrote: Hello, On Tuesday 11 March 2014 22:19:06 David Gil Oliva wrote: 2014-03-11 16:33 GMT+01:00 Kevin Ottens er...@kde.org: Why is that? Are we in a hurry? Is the work in all the frameworks so advanced that we can advance the tagging? It just a question

Re: Review Request 116747: Clean up KCompletionBox

2014-03-12 Thread Alex Merry
, if it's required for some reason. Also there's a typo in the method name. David Gil Oliva wrote: Alex Merry inlined deprecated methods in https://git.reviewboard.kde.org/r/116012 , so I thought that it was the way to go... Well, there's a balance to be struck: putting them

Re: Review Request 116756: Remove Class Members link. It's broken and not useful.

2014-03-12 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116756/#review52741 --- Ship it! Ship It! - Alex Merry On March 12, 2014, 9:26

Re: Review Request 116747: Clean up KCompletionBox

2014-03-12 Thread Alex Merry
/kcompletionbox.h https://git.reviewboard.kde.org/r/116747/#comment37196 If you change the parameter name, you have to change the docs to match src/kcompletionbox.h https://git.reviewboard.kde.org/r/116747/#comment37195 KCOMPLETION_NO_DEPRECATED - Alex Merry On March 11, 2014, 10:32 p.m

Review Request 116758: Remove kcfg preprocessing script

2014-03-12 Thread Alex Merry
--- Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 116759: Update kde4 references in comments and apidox

2014-03-12 Thread Alex Merry
://git.reviewboard.kde.org/r/116759/diff/ Testing --- Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 116761: Remove KServiceGroup::baseGroup, deprecated since kdelibs 4.3.0

2014-03-12 Thread Alex Merry
--- Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 116747: Clean up KCompletionBox

2014-03-12 Thread Alex Merry
, if it's required for some reason. Also there's a typo in the method name. David Gil Oliva wrote: Alex Merry inlined deprecated methods in https://git.reviewboard.kde.org/r/116012 , so I thought that it was the way to go... Alex Merry wrote: Well, there's a balance

Review Request 116762: Remove new in kde4 comment

2014-03-12 Thread Alex Merry
--- Remove new in kde4 comment Diffs - src/services/kservicetypeprofile.cpp 908e76599c553a48ea509695f1d8b83be98fee1a Diff: https://git.reviewboard.kde.org/r/116762/diff/ Testing --- Thanks, Alex Merry ___ Kde-frameworks-devel

Review Request 116766: Use a desktop file we might find for testing KServiceActions

2014-03-12 Thread Alex Merry
aa1c691c75c9e5b6903bcbf6e2dc95809ee1ce21 autotests/kservicetest.cpp 711fb9b649e580ad474b0cdecd26dcdbfdc302a2 Diff: https://git.reviewboard.kde.org/r/116766/diff/ Testing --- Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org

Re: Review Request 116762: Remove new in kde4 comment

2014-03-12 Thread Alex Merry
--- Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 116735: Split autotests into their own directory

2014-03-12 Thread Alex Merry
/CMakeLists.txt 14bcf85fe128874ae396d5dba1263dd378baf9cd tests/knewstuffauthortest.cpp tests/knewstuffentrytest.cpp tests/testTranslatable.cpp Diff: https://git.reviewboard.kde.org/r/116735/diff/ Testing --- Thanks, Alex Merry ___ Kde

Re: Review Request 116761: Remove KServiceGroup::baseGroup, deprecated since kdelibs 4.3.0

2014-03-12 Thread Alex Merry
6dec66997737e6617c13a6def5e06835beb6ce72 Diff: https://git.reviewboard.kde.org/r/116761/diff/ Testing --- Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 116767: Clean up CMake code from pre-splitting

2014-03-12 Thread Alex Merry
--- Configures, builds and installs. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 116760: Remove kcookiescfg update scripts

2014-03-12 Thread Alex Merry
2bb4cc232b7011d38033da10bb312a12215cb29d src/ioslaves/http/kcookiejar/kcookiescfg.pl 7fef01d5c208a00987b3594411ce06799457 src/ioslaves/http/kcookiejar/kcookiescfg.upd 745f545090875d5d24e1e6bb397af9926704350f Diff: https://git.reviewboard.kde.org/r/116760/diff/ Testing --- Thanks, Alex Merry

Re: Review Request 116766: Use a desktop file we might find for testing KServiceActions

2014-03-12 Thread Alex Merry
- autotests/kservicetest.h aa1c691c75c9e5b6903bcbf6e2dc95809ee1ce21 autotests/kservicetest.cpp 711fb9b649e580ad474b0cdecd26dcdbfdc302a2 Diff: https://git.reviewboard.kde.org/r/116766/diff/ Testing --- Thanks, Alex Merry ___ Kde

Re: Review Request 116725: Remove out-of-date README

2014-03-12 Thread Alex Merry
://git.reviewboard.kde.org/r/116725/diff/ Testing --- Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 116726: Remove unused CMakeLists.txt file

2014-03-12 Thread Alex Merry
/116726/diff/ Testing --- Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 116727: Remove obsolete code

2014-03-12 Thread Alex Merry
: https://git.reviewboard.kde.org/r/116727/diff/ Testing --- Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 116728: Remove no-longer-needed magic variable

2014-03-12 Thread Alex Merry
- src/kjs/CMakeLists.txt 491cf52ea7d3d8a6b138fb328fdfdeec61f6740a Diff: https://git.reviewboard.kde.org/r/116728/diff/ Testing --- Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org

Re: Review Request 116759: Update kde4 references in comments and apidox

2014-03-12 Thread Alex Merry
6ed9c4c91efdf18eca0575b4b29ff4cda3d5882c src/widgets/thumbcreator.h 384099d04bb696df3d0eea9ff5e07b52a495f4c5 Diff: https://git.reviewboard.kde.org/r/116759/diff/ Testing --- Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https

Re: Review Request 116735: Split autotests into their own directory

2014-03-12 Thread Alex Merry
/ Testing --- Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 116767: Clean up CMake code from pre-splitting

2014-03-12 Thread Alex Merry
4d08bb97a569488849504e04078a71995a1fc53b Diff: https://git.reviewboard.kde.org/r/116767/diff/ Testing --- Configures, builds and installs. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org

Re: Review Request 116768: Make our css more future-proof

2014-03-12 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116768/#review52830 --- Ship it! Ship It! - Alex Merry On March 12, 2014, 3:49

Re: Review Request 116025: Add documentation about writing find modules

2014-03-11 Thread Alex Merry
PRE-CREATION Diff: https://git.reviewboard.kde.org/r/116025/diff/ Testing --- Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 116653: Create ECMFindModuleHelpers module for common find-module code

2014-03-11 Thread Alex Merry
various configurations with a test CMakeLists.txt file, including with various include files missing. Configured and built kwindowsystem and kde-workspace. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https

Re: Review Request 116713: Remove FindOpenEXR.cmake

2014-03-11 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116713/#review52640 --- Ship it! Ship It! - Alex Merry On March 11, 2014, 1:55

Review Request 116723: Update cmake code in apidox to reflect new macro names

2014-03-11 Thread Alex Merry
. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 116724: Replace comment that refers to removed code

2014-03-11 Thread Alex Merry
Description --- Replace comment that refers to removed code Diffs - src/kdeclarative.cpp c074efb89a35f22cdc1ae7823749555623957755 Diff: https://git.reviewboard.kde.org/r/116724/diff/ Testing --- Thanks, Alex Merry ___ Kde-frameworks-devel

Review Request 116725: Remove out-of-date README

2014-03-11 Thread Alex Merry
Description --- Remove out-of-date README All the information that is still applicable can be found in README.md. Diffs - src/README cbf079488d9961a718201373fd4bb3483b2f3bf8 Diff: https://git.reviewboard.kde.org/r/116725/diff/ Testing --- Thanks, Alex Merry

Review Request 116726: Remove unused CMakeLists.txt file

2014-03-11 Thread Alex Merry
. Repository: khtml Description --- Remove unused CMakeLists.txt file Diffs - tests/pics/CMakeLists.txt 3d2f8d5286205336f1ea6f31714c226b0d7a142f Diff: https://git.reviewboard.kde.org/r/116726/diff/ Testing --- Thanks, Alex Merry

Review Request 116727: Remove obsolete code

2014-03-11 Thread Alex Merry
--- Remove obsolete code This code had #if 0 around it through all of KDE 4, so it clearly wasn't that important. Diffs - src/kdeinit/kinit.cpp c1010dd7f8980ae8b4b456a41d9094a16aca62a6 Diff: https://git.reviewboard.kde.org/r/116727/diff/ Testing --- Thanks, Alex Merry

Review Request 116728: Remove no-longer-needed magic variable

2014-03-11 Thread Alex Merry
://git.reviewboard.kde.org/r/116728/diff/ Testing --- Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

<    3   4   5   6   7   8   9   10   11   12   >