D14397: Support libcanberra for audio notification

broulik abandoned this revision. broulik added a comment. > I haven't checked, but I'd appreciate if that could also be done through a cmake option. In packaging systems like MacPorts and HB it's perfectly possible to have libcanberra and/or pulseaudio installed for Gnome apps that cannot do

D14397: Support libcanberra for audio notification

broulik added a comment. > Currently, libcanberra is tested on Linux only. I restored the Phonon option for when canberra isn't available on the platform. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D14397 To: broulik, #frameworks, dfaure, davidedmund

D14397: Support libcanberra for audio notification

broulik added a comment. > phonon works just fine That's not true. If it worked fine, this patch would not exist, as I would not have apps freeze for seconds on teardown of Phonon objects, or latencies beyond all comparison REPOSITORY R289 KNotifications REVISION DETAIL https://pha

D14397: Support libcanberra for audio notification

broulik updated this revision to Diff 38512. broulik retitled this revision from "Port audio notification to libcanberra" to "Support libcanberra for audio notification". broulik edited the test plan for this revision. broulik added a comment. - Keep Phonon as fallback when libcanberra isn't p

D14395: [KSambaShare] Check file that's changed before reloading

broulik added a comment. Unlikely REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14395 To: broulik, #frameworks, dfaure Cc: ngraham, lbeltrame, kde-frameworks-devel, michaelh, bruns

D14395: [KSambaShare] Check file that's changed before reloading

This revision was automatically updated to reflect the committed changes. Closed by commit R241:a9b4eded78e8: [KSambaShare] Check file that's changed before reloading (authored by broulik). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14395?vs=38479&id=38508 RE

D14237: Make Konqi look good in HiDPI

broulik added a comment. > If the increased image memory is payed only when the dialog is shown i don't see it as a problem tbh. Well, it's compiled into `.qrc` and potentially shipped for bundled applications? The RAM will be shared, I guess? I don't really know how this qt resource st

D14397: Port audio notification to libcanberra

broulik added a comment. > Does libcanberra (still) require pulseaudio or can it work with different backends? According to its website "It comes with several backends (ALSA, PulseAudio, OSS, GStreamer, null)" REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.

D14397: Port audio notification to libcanberra

broulik created this revision. broulik added reviewers: Frameworks, dfaure, davidedmundson, sitter, drosca, kfunk, rjvbb. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMAR

D14395: [KSambaShare] Check file that's changed before reloading

broulik created this revision. broulik added reviewers: Frameworks, dfaure. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY We use the `KDirWatch` singleton so we migh

D14360: Remove custom icon selection for trash

broulik added a comment. If the URL of the places item is of scheme `trash` (Scheme is the part before the colon, e.g. `file`, `http`, …), then it should hide it, yes. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14360 To: shubham, ngraham, broulik Cc: kde-frameworks

D14360: Remove custom icon selection for trash

broulik added a comment. Thanks a lot for your patch! I think it is cleaner if the button is setup but then hidden: m_iconButton->setVisible(url.toString() != QLatin1String("trash:/")); Curiously, Dolphin overwrites the icon whenever `url.protocol() == "trash` whereas `KFilePl

D14308: [Exe Thumbnailer] Improve icon selection algorithm

broulik updated this revision to Diff 38296. broulik added a comment. - Include `` just in case REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14308?vs=38271&id=38296 REVISION DETAIL https://phabricator.kde.org/D14308 AFFECTED FILES thumbnail/icout

D14308: [Exe Thumbnailer] Improve icon selection algorithm

broulik added a comment. > Sounds like we should put this in a Framework and re-use it instead of copy-pasting it here. It's a five line function, not gonna go through the hoops of finding a framework where this might fit.. INLINE COMMENTS > ngraham wrote in icoutils_common.cpp:33 > Wh

D14308: [Exe Thumbnailer] Improve icon selection algorithm

broulik created this revision. broulik added reviewers: Frameworks, dfaure, ngraham, pali, vonreth, antlarr. broulik requested review of this revision. REVISION SUMMARY Prefer downsampling over upscaling TEST PLAN Dolphin requested 128px thumbnail here. Wine executables have 32, 48, and 256

D14009: [Plasma PluginLoader] Cache plugins during startup

This revision was automatically updated to reflect the committed changes. Closed by commit R242:af01c2e95370: [Plasma PluginLoader] Cache plugins during startup (authored by broulik). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14009?vs=3

D13782: RFC: Ignore NTFS hidden flag for root volume

broulik added a comment. Ping REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D13782 To: broulik, dfaure, ngraham, yurikoles, bruns Cc: oysteins, wbauer, kde-frameworks-devel, michaelh, ngraham, bruns

D14290: [KWidgetJobTracker] Show "Open Destination" etc buttons only if destination is valid

broulik created this revision. broulik added a reviewer: dfaure. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY It checks whether the file is not in `TEMP` but it doe

D13990: Honor BUILD_TESTING

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R308 KRunner REVISION DETAIL https://phabricator.kde.org/D13990 To: arojas, broulik Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14045: [Containment] Don't load containment actions with plasma/containment_actions KIOSK restriction

This revision was automatically updated to reflect the committed changes. Closed by commit R242:0351ea74b24e: [Containment] Don't load containment actions with plasma/containment_actions… (authored by broulik). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phab

D14009: [Plasma PluginLoader] Cache plugins during startup

broulik added inline comments. INLINE COMMENTS > davidedmundson wrote in pluginloader.cpp:195 > Seems the wrong approach we know the ID, there's no point iterating in the > first place. > > https://api.kde.org/frameworks/kcoreaddons/html/classKPluginLoader.html#a3a69c4f1826926a2145f14770b8b5010

D14161: [KStyle] Use dialog-question for question icon

broulik created this revision. broulik added reviewers: dfaure, ngraham, rkflx. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY This was changed in `KMessageBox` in 9b

D14160: [KMessageBox] Call style for icon

broulik created this revision. broulik added reviewers: dfaure, kfunk. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY `QMessageBox::standardIcon` is deprecated. Also,

D14158: Avoid a kio-mtp crash when trying to add a blocked device to the device cache

broulik added a comment. Should this show an error to the user? I could also imagine this interfering with thumbnail generation when viewing the device REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D14158 To: jtamate, #frameworks Cc: broulik

D14043: [KFilePlacesModel] Support pretty baloosearch URLs

This revision was automatically updated to reflect the committed changes. Closed by commit R241:3523ba575b39: [KFilePlacesModel] Support pretty baloosearch URLs (authored by broulik). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14043?vs=37553&id=37858 REVISION

D14042: Support special URLs for finding files of a certain type

This revision was automatically updated to reflect the committed changes. Closed by commit R293:d02597aa9406: Support special URLs for finding files of a certain type (authored by broulik). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14042?vs=37552&id=37857

D12520: [PasteJob] Emit KDirNotify on paste

broulik added a comment. Ping REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12520 To: broulik, #frameworks Cc: elvisangelaccio, kde-frameworks-devel, michaelh, ngraham, bruns

D14045: [Containment] Don't load containment actions with plasma/containment_actions KIOSK restriction

broulik edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D14045 To: broulik, #plasma, mart, sitter Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14045: [Containment] Don't load containment actions with plasma/containment_actions KIOSK restriction

broulik created this revision. broulik added reviewers: Plasma, mart, sitter. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY Allows disabling all containment actions,

D14042: Support special URLs for finding files of a certain type

broulik added a dependent revision: D14043: [KFilePlacesModel] Support pretty baloosearch URLs. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D14042 To: broulik, #frameworks, bruns, dfaure, renatoo, franckarrecot, hein, ngraham Cc: kde-frameworks-devel, #baloo, ashaposhn

D14043: [KFilePlacesModel] Support pretty baloosearch URLs

broulik edited the test plan for this revision. broulik added a dependency: D14042: Support special URLs for finding files of a certain type. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14043 To: broulik, #frameworks, bruns, dfaure, renatoo, franckarrecot, ngraham, hein

D14042: Support special URLs for finding files of a certain type

broulik added reviewers: hein, ngraham. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D14042 To: broulik, #frameworks, bruns, dfaure, renatoo, franckarrecot, hein, ngraham Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abra

D14043: [KFilePlacesModel] Support pretty baloosearch URLs

broulik created this revision. broulik added reviewers: Frameworks, bruns, dfaure, renatoo, franckarrecot, ngraham, hein. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMAR

D14042: Support special URLs for finding files of a certain type

broulik created this revision. broulik added reviewers: Frameworks, bruns, dfaure, renatoo, franckarrecot. Restricted Application added projects: Frameworks, Baloo. Restricted Application added subscribers: Baloo, kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY

D13752: Build solidautoeject only on FreeBSD

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R120:edd5e889f583: Build solidautoeject only on FreeBSD (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES

D14009: [Plasma PluginLoader] Cache plugins during startup

broulik updated this revision to Diff 37473. broulik added a comment. - Move code REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14009?vs=37470&id=37473 REVISION DETAIL https://phabricator.kde.org/D14009 AFFECTED FILES src/plasma/pl

D14009: [Plasma PluginLoader] Cache plugins during startup

broulik created this revision. broulik added reviewers: Plasma, davidedmundson, mart. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY Similar to KPackage's cache this

D14000: qqc2-desktop-style: basic support for QGuiApplication-based apps (WIP/PoC)

broulik added a comment. Why, or who, is setting this environment variable? Plasma-integration sets `QQuickStyle` depending on whether there is a `QApplication` or not, so this makes no sense. REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org

D14001: Replace Gitorious web shortcut by GitLab

This revision was automatically updated to reflect the committed changes. Closed by commit R241:777bf25b6a46: Replace Gitorious web shortcut by GitLab (authored by broulik). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14001?vs=37443&id=37444 REVISION DETAIL

D14001: Replace Gitorious web shortcut by GitLab

broulik created this revision. broulik added reviewers: Frameworks, dfaure. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY Gitorious has been shut down TEST PLAN S

D13782: RFC: Ignore NTFS hidden flag for root volume

broulik updated this revision to Diff 37229. broulik added a comment. Also check for `DT_UNKNOWN` REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13782?vs=36838&id=37229 REVISION DETAIL https://phabricator.kde.org/D13782 AFFECTED FILES src/ioslaves/file/fi

D13899: KMessageWidget: use theme instead of hardcoded colours

broulik added a comment. I like the idea INLINE COMMENTS > kmessagewidget.cpp:172 > QColor bgBaseColor; > +const QPalette palette = QGuiApplication::palette(); > Not using the widget's palette was intentional for Konsole or something I recall? > kmessagewidget.cpp:176 > +//

D13752: Build solidautoeject only on FreeBSD

broulik added a comment. ping REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D13752 To: broulik, #plasma, #frameworks, adridg, davidedmundson, dfaure, fvogt, ervin Cc: anthonyfieroni, mart, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jen

D13808: Fix KMainWindow saving incorrect widget settings

broulik added inline comments. INLINE COMMENTS > dfaure wrote in kmainwindow_unittest.cpp:278 > Or rather `QVERIFY(mw->m_dock->isVisible())`, that's what QVERIFY is for ;-) :D Right, I got distracted by the `==` REPOSITORY R263 KXmlGui BRANCH fix-window-state-save REVISION DETAIL https:

D13808: Fix KMainWindow saving incorrect widget settings

broulik added inline comments. INLINE COMMENTS > kmainwindow_unittest.cpp:265 > +NativeMainWindow *mw = new NativeMainWindow(); > +connect(mw, &QObject::destroyed, [&](QObject *){ el.exit(); }); // > quit event loop when window's gone > + connect(mw, &QObject::destroyed, &el, &Q

D13895: Fix off by one error in Cache::clear

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R159 KActivities Statistics BRANCH master REVISION DETAIL https://phabricator.kde.org/D13895 To: davidedmundson, broulik Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13782: RFC: Ignore NTFS hidden flag for root volume

broulik added a reviewer: bruns. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D13782 To: broulik, dfaure, ngraham, yurikoles, bruns Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13884: [KMessageWidget] Update stylesheet when palette changes

broulik closed this revision. broulik added a comment. https://cgit.kde.org/kwidgetsaddons.git/commit/?id=ea282678c937e0e376b391560c585e835528870f REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D13884 To: broulik, #frameworks, rjvbb, ngraham, cfeck Cc: kde-fr

D13884: [KMessageWidget] Update stylesheet when palette changes

broulik added inline comments. INLINE COMMENTS > rjvbb wrote in kmessagewidget.cpp:57 > Nitpick: shouldn't this be called `setStyleSheet` or something similar that > indicates a bit better that it defines the stylesheet itself? It doesn't take any arguments, so I explicitly did not call it `set

D13884: [KMessageWidget] Update stylesheet when palette changes

broulik updated this revision to Diff 37144. broulik added a comment. - Juggle it around a bit REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13884?vs=37143&id=37144 REVISION DETAIL https://phabricator.kde.org/D13884 AFFECTED FILES src/kmessage

D13884: [KMessageWidget] Update stylesheet when palette changes

broulik edited the test plan for this revision. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D13884 To: broulik, #frameworks, rjvbb, ngraham, cfeck Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13884: [KMessageWidget] Update stylesheet when palette changes

broulik edited the summary of this revision. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D13884 To: broulik, #frameworks, rjvbb, ngraham, cfeck Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13884: [KMessageWidget] Update stylesheet when palette changes

broulik created this revision. broulik added reviewers: Frameworks, rjvbb, ngraham, cfeck. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY The colors are hardcoded rig

D13869: [solid] Notify when interface to mounted fs is lost

broulik added a comment. Sure, but the device isn't "removed", so emitting a remove signal for something that is still there, is wrong, isn't it? Perhaps we could signal a removal if the device lost *all* its interfaces? But it probably doesn't in the unmount case. REPOSITORY R245 Solid

D13869: [solid] Notify when interface to mounted fs is lost

broulik added a comment. I don't think this is the right approach, technically the device isn't gone but filtered by the client (`KFilePlacesModel` and Device Notifier use a predicate to show only matching devices). This probably needs some "device changed" signal, or even cooler, in `Soli

D13848: Fix device label with unknown size

This revision was automatically updated to reflect the committed changes. Closed by commit R245:cc7760bd33e4: Fix device label with unknown size (authored by broulik). REPOSITORY R245 Solid CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13848?vs=37063&id=37111 REVISION DETAIL http

D13867: [KMessageWidget] Pass widget to standardIcon()

broulik created this revision. broulik added reviewers: Frameworks, cfeck, ngraham. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY This way the style knows what widge

D13752: Build solidautoeject only on FreeBSD

broulik updated this revision to Diff 37098. broulik retitled this revision from "Kill solidautoeject" to "Build solidautoeject only on FreeBSD". broulik edited the summary of this revision. broulik edited the test plan for this revision. broulik added a comment. - Keep it around for FreeBSD

D13848: Fix device label with unknown size

broulik added a comment. I have seen it do that for e.g. a Floppy that is not "present" (I fixed that independently from this patch to show "Floppy" again). I guess whenever an external media isn't present, like an SD card in a reader or so. REPOSITORY R245 Solid REVISION DETAIL https:/

D13124: Add Share action to Dolphin context menu

broulik added a comment. Check out `KFileItemActions::addServiceActionsTo` REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator.kde.org/D13124 To: nicolasfella, apol Cc: markg, broulik, kde-frameworks-devel, elvisangelaccio, ngraham, apol, kfm-devel, #dolphin, michaelh, s

D13848: Fix device label with unknown size

broulik created this revision. broulik added a reviewer: davidedmundson. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY `size_str` can never actually become empty as

D13797: Only add actual documents to Recent Documents

broulik added a comment. -1 I thought we agreed to fix the `recentdocuments:/` KIO REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D13797 To: ngraham, #dolphin, #frameworks, broulik Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13777: KMessageWidget : revert to using highlight colour for Information style (WIP)

broulik added a comment. -1 The upper two in second revision look quite bad. Another idea would have been to have the widget style alter the appearance like it already does for things like `KTitleWidget` REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org

D13782: RFC: Ignore NTFS hidden flag for root volume

broulik updated this revision to Diff 36838. broulik added a comment. Only check for folders, a file cannot be a mount, saves querying mount points for hidden files REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13782?vs=36837&id=36838 REVISION DETAIL https

D13782: RFC: Ignore NTFS hidden flag for root volume

broulik created this revision. broulik added reviewers: dfaure, ngraham, yurikoles. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY Those are always hidden as far as N

D13757: Move parsing .desktop file for folder Comment to file KIO

broulik retitled this revision from "Move parsing .desktop file for Comment to file KIO" to "Move parsing .desktop file for folder Comment to file KIO". REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D13757 To: broulik, dfaure, lbeltrame Cc: kde-frameworks-devel, michaelh,

D13757: Move parsing .desktop file for Comment to file KIO

broulik created this revision. broulik added reviewers: dfaure, lbeltrame. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY This avoids blocking when the folder is on a

D13752: Kill solidautoeject

broulik added a comment. > It's not clear to me what this revision is trying to change (in terms of user-visible behavior) or how to test the change I think you could test it by disabling the "Drive Ejector" module in "Background Services" (kded settings) in System Settings. If pressing

Re: text search balloon background colour

Hi, > Has the background colour used for text search balloons ("Continuing search > from top" , for instance) been changed recently? it was adjusted to more closely resemble the Breeze visual style. The colors are unfortunately hardcoded as KWidgetAddons as a Tier 1 framework cannot depend on

D13597: Use a correct emblem icon for readonly files and folders

broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. Neither icon is in the naming specification but since this is meant as an overlay, `emblem` makes more sense. REPOSITORY R241 KIO BRANCH use-emblem-icon-for-readonly-items (branched

D13695: Make sure KLineEdit::clearButtonClicked is emitted

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R284 KCompletion BRANCH master REVISION DETAIL https://phabricator.kde.org/D13695 To: aacid, broulik Cc: davidedmundson, kde-frameworks-devel, broulik, michaelh, ngraham, bruns

D13718: Support choosing .ico files in custom icon file chooser

broulik added a comment. I think if you pass a completely custom icon to it an absolute path will be looked up and as a result this (unintentionally) works REPOSITORY R302 KIconThemes REVISION DETAIL https://phabricator.kde.org/D13718 To: ngraham, #frameworks, cfeck Cc: broulik, kde-fra

D13752: Kill solidautoeject

broulik edited the summary of this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D13752 To: broulik, #plasma, #frameworks, adridg, davidedmundson, dfaure, fvogt, ervin Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg

D13752: Kill solidautoeject

broulik created this revision. broulik added reviewers: Plasma, Frameworks, adridg, davidedmundson, dfaure, fvogt, ervin. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Solid's

D13541: Port solid from Qt5::Widgets to Qt5::Gui

broulik accepted this revision. REPOSITORY R245 Solid BRANCH gui-instead-of-widgets REVISION DETAIL https://phabricator.kde.org/D13541 To: graesslin, #frameworks, dhaumann, apol, broulik Cc: dhaumann, kde-frameworks-devel, michaelh, ngraham, bruns

D13398: [KFileItem] Check most local URL for whether it's shared

This revision was automatically updated to reflect the committed changes. Closed by commit R241:a44fa03029c8: [KFileItem] Check most local URL for whether it's shared (authored by broulik). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13398?vs=35734&id=35736 RE

D13398: [KFileItem] Check most local URL for whether it's shared

broulik created this revision. broulik added reviewers: gregormi, dfaure. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY `desktop:/` KIO rewrites the URL but it is st

D13034: Add mechanism to notify other clients of config changes over DBus

broulik accepted this revision. broulik added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > zzag wrote in kconfigwatcher.cpp:82 > Won't this detach? no, `parts` is `const` REPOSITORY R237 KConfig BRANCH master REVISION DETAIL https://phabricator.kde

D13358: Add new class that is a model of numbers between two values

broulik added a comment. Just saw I forgot to submit those comments yesterday INLINE COMMENTS > knumbermodeltest.cpp:26 > +QCOMPARE(m.rowCount(), 3); > +QCOMPARE(m.data(m.index(0, 0), Qt::DisplayRole), QVariant("3")); > +QCOMPARE(m.data(m.index(1, 0), Qt::DisplayRole),

D6313: Support Icon Scale from Icon naming specification 0.13

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R302:20f7137145f6: Support Icon Scale from Icon naming specification 0.13 (authored by broulik). CHANGED PRIOR TO COMMIT

D12520: [PasteJob] Emit KDirNotify on paste

broulik added inline comments. INLINE COMMENTS > elvisangelaccio wrote in paste.cpp:125 > Missing `this` as the receiver argument? This is a `static` so there's no `this` and we also just access `job` and then call another `static` method REPOSITORY R241 KIO REVISION DETAIL https://phabr

D13315: Detect mime type of local files based on their contents

broulik added inline comments. INLINE COMMENTS > apol wrote in kfileitem.cpp:730 > I'm not sure that makes sense. The fact that it's a local url doesn't mean it > will be fast to read. > FUSE appears as local urls and it's slow. That and also (broken) NFS mounts. We have that in quite a few pla

D13215: Update sizes before generating frame svg background

broulik added a comment. +1 Doesn't make a difference in Oxygen's rounded corners on panels but doesn't make it worse either. Please also profile whether it causes any needless recalculations on Plasma startup REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabr

D12520: [PasteJob] Emit KDirNotify on paste

broulik added a comment. Restricted Application added a subscriber: kde-frameworks-devel. Ping REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12520 To: broulik, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D6313: Support Icon Scale from Icon naming specification 0.13

broulik updated this revision to Diff 35318. broulik added a comment. … REPOSITORY R302 KIconThemes CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6313?vs=35317&id=35318 REVISION DETAIL https://phabricator.kde.org/D6313 AFFECTED FILES src/kiconengine.cpp src/kiconengine.h

D6313: Support Icon Scale from Icon naming specification 0.13

broulik updated this revision to Diff 35317. broulik added a comment. - Fix rebase REPOSITORY R302 KIconThemes CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6313?vs=34781&id=35317 REVISION DETAIL https://phabricator.kde.org/D6313 AFFECTED FILES src/kiconengine.cpp src/kic

D12895: WIP: Add KFileItemActionsPlugin

broulik abandoned this revision. broulik added a comment. Superseded by D13124 REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator.kde.org/D12895 To: broulik, #plasma, #vdg, apol Cc: nicolasfella, elvisangelaccio, abetts, ngraham, kde-

D13215: Update sizes before generating frame svg background

broulik added a comment. Wow. I wasted hours in FrameSvg trying to find this. Does this also fix the panel mask in non-composited mode, e.g. round corners with Oxygen? (Quickly browsing the bug numbers suggests it does \o/) REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL http

D13043: Properly sanitize input

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R275 KItemModels BRANCH master REVISION DETAIL https://phabricator.kde.org/D13043 To: apol, #frameworks, broulik Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D13124: [RFC] Add Share action to Dolphin context menu

broulik added a comment. Have you seen D12895 ? REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator.kde.org/D13124 To: nicolasfella, #dolphin, apol, elvisangelaccio Cc: broulik, kde-frameworks-devel, elvisangelaccio, ngraham, apol, kfm-

D3837: [Calendar] Optimize Backend

broulik abandoned this revision. Restricted Application edited subscribers, added: kde-frameworks-devel; removed: Frameworks. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D3837 To: broulik, #plasma, davidedmundson Cc: kde-frameworks-devel, davidedmu

D3838: [Calendar] Optimize day delegate

broulik abandoned this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D3838 To: broulik, #plasma, mart Cc: kde-frameworks-dev

D11511: [KPropertiesDialog] Support X-KDE-Protocols

This revision was automatically updated to reflect the committed changes. Closed by commit R241:047f5fe92117: [KPropertiesDialog] Support X-KDE-Protocols (authored by broulik). Restricted Application added a subscriber: kde-frameworks-devel. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE http

D6313: Support Icon Scale from Icon naming specification 0.13

broulik updated this revision to Diff 34781. broulik added a comment. … REPOSITORY R302 KIconThemes CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6313?vs=34780&id=34781 REVISION DETAIL https://phabricator.kde.org/D6313 AFFECTED FILES src/kiconengine.cpp src/kiconengine.h

D6313: Support Icon Scale from Icon naming specification 0.13

broulik updated this revision to Diff 34780. broulik added a comment. - Remove accidental cruft REPOSITORY R302 KIconThemes CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6313?vs=34779&id=34780 REVISION DETAIL https://phabricator.kde.org/D6313 AFFECTED FILES src/kiconengine.

D6313: Support Icon Scale from Icon naming specification 0.13

broulik updated this revision to Diff 34779. broulik added a comment. - Rename to `loadIcon` with `scale` to `loadScaledIcon` to avoid ambiguous overload REPOSITORY R302 KIconThemes CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6313?vs=31197&id=34779 REVISION DETAIL https://p

D13083: Respect custom directory icons in iconNameForURL()

broulik added a reviewer: dfaure. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D13083 To: ngraham, #frameworks, apol, broulik, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13082: Make iconFromDirectoryFile() and iconFromDesktopFile() public in KIOCore

broulik added a reviewer: dfaure. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D13082 To: ngraham, #frameworks, apol, dfaure Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D13083: Respect custom directory icons in iconNameForURL()

broulik added a comment. This still has the issue of blocking if the contents is an unavailable nfs share of some sort. INLINE COMMENTS > global.cpp:377 > +// Check to see if the folder has a custom icon > +QString customIcon = iconFromDirectoryFile(url.toLocalFile()); > +

D13082: Make iconFromDirectoryFile() and iconFromDesktopFile() public in KIOCore

broulik added a comment. Imho fine in principle, but: `QFileInfo` stats internally and `KDesktopFile` actually reads file contents. I don't see how you came to the conclusion this doesn't stat. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D13082 To: ngraham, #framew

<    7   8   9   10   11   12   13   14   15   16   >