D8207: Use https for KDE urls

kfunk created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Make sure links in dialogs point to https:// urls REPOSITORY R244 KCoreAddons BRANCH master REVISION DETAIL

Adding build info attribute to KAboutData to improve bug report data?

h would be sent over to bugs.kde.org. Regards, Kevin -- Kevin Funk | kf...@kde.org | http://kfunk.org signature.asc Description: This is a digitally signed message part.

D7884: - Increase size of trailing mark

kfunk added a comment. In https://phabricator.kde.org/D7884#147087, @sars wrote: > I think "spaceWidth() / 2" goes a little bit too far. I agree. The 'before' screenshot looks better in my eyes. The trailing mark indicator is supposed to be a *subtle* hint, not something causing

D7884: - Increase size of trailing mark

kfunk added a comment. Screenshots please, for changes like this. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D7884 To: helio, mwolff, kfunk Cc: #frameworks, cullmann, sars, dhaumann

D7840: Fix trailing space visualization for RTL lines.

kfunk added a comment. Indeed, thanks for those fixes. /me can see a nice blog post coming a long...? :) REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D7840 To: safaalfulaij, #ktexteditor, cullmann Cc: cullmann, kfunk, #frameworks, sars, dhaumann

D7840: Fix trailing space visualization for RTL lines.

kfunk added a comment. Could you add before/after screenshots for this? I think this could also help non-RTL users understand what you're fixing. Would be super helpful for me at least :) REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D7840 To:

D7033: Port ki18n from QtScript to QtQml

kfunk added a comment. Could someone fluent in QtScript/QtQML review this so we can merge it? INLINE COMMENTS > ktranscript.cpp:96 > // Interface functions. > -Q_INVOKABLE QScriptValue load(); // actually has variable length > argument list > -Q_INVOKABLE QScriptValue

D7033: Port ki18n from QtScript to QtQml

kfunk added a comment. Just wanted to add this: Really great work! -- I wanted to raise this issue earlier on the KF5 mailing list: ki18n was the last major framework that depended on the deprecated QtScript. Nice to see it being ported! <3 Can't really review this code either, though.

D7478: Escape hyphen in rest.xml regular expressions

kfunk added a comment. In https://phabricator.kde.org/D7478#138855, @alexeymin wrote: > Is it a fix for bug https://bugs.kde.org/show_bug.cgi?id=383632 ? I think so. FWIW: Here's another upstream report, filed by Heiko himself: https://bugs.exim.org/show_bug.cgi?id=2158

D7463: Really rate-limit INF_PROCESSED_SIZE messages

This revision was automatically updated to reflect the committed changes. Closed by commit R241:801f58e7e76a: Really rate-limit INF_PROCESSED_SIZE messages (authored by kfunk). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7463?vs=18535=18541 REVISION DETAIL

D7463: Really rate-limit INF_PROCESSED_SIZE messages

kfunk created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Fixing an ancient porting bug which popped up when porting from Qt4 to Qt5. FIXED-IN: 5.38 BUG: 383843 REPOSITORY R241 KIO BRANCH

D7459: Use config.h more

This revision was automatically updated to reflect the committed changes. Closed by commit R39:0ee0be681108: Use config.h more (authored by kfunk). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7459?vs=18526=18529 REVISION DETAIL

D7459: Use config.h more

kfunk created this revision. Restricted Application added subscribers: Frameworks, kwrite-devel. Restricted Application added a project: Frameworks. REVISION SUMMARY This also fixes an issue with regards to HAVE_FDATASYNC: src/buffer/katesecuretextbuffer.cpp:157:5: warning:

D7443: Fix compilation on windows with editorconfig-c-core available

This revision was automatically updated to reflect the committed changes. Closed by commit R39:ab503ec944fe: Fix compilation on windows with editorconfig-c-core available (authored by kfunk). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE

D7458: Show icons in icon border context menu

kfunk added a comment. Other than that the patch looks sensible to me. INLINE COMMENTS > kateviewhelpers.cpp:2253 > +dMA = > selectDefaultMark.addAction(m_doc->markDescription(markType)); > +} else { > +mA = markMenu.addAction(icon, >

D7198: Set CMAKE_*_OUTPUT_DIRECTORY to run tests without installing.

kfunk accepted this revision. kfunk added a comment. I like the initiative, +1 REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D7198 To: dfaure, cgiboudeaux, kfunk Cc: kfunk, #frameworks, #build_system

D7213: Use ecm_add_test and benefit from BUILD_TESTING awareness

kfunk accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D7213 To: asturmlechner, #frameworks, kfunk Cc: kfunk

D7187: RFC: Make ECMAddTests respect BUILD_TESTING

This revision was automatically updated to reflect the committed changes. Closed by commit R240:b99d2d2c5ded: RFC: Make ECMAddTests respect BUILD_TESTING (authored by kfunk). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D7187?vs=17835=17858#toc REPOSITORY R240 Extra CMake Modules

D7187: RFC: Make ECMAddTests respect BUILD_TESTING

kfunk added a comment. In https://phabricator.kde.org/D7187#133497, @kossebau wrote: > +1 as well. Please also add a note in the API dox what BUILD_TESTING will do on this macro, so this is not magic behaviour and people can plan with this (like making sure to not set

D7187: RFC: Make ECMAddTests respect BUILD_TESTING

kfunk added a comment. Guys... no one gave me an "Accepted' yet :) REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D7187 To: kfunk Cc: vkrause, elvisangelaccio, asturmlechner, apol, #frameworks, #build_system

D7136: Don't use find_file for finding files in our own source dir

kfunk accepted this revision. REPOSITORY R311 KWallet BRANCH master REVISION DETAIL https://phabricator.kde.org/D7136 To: vkrause, #frameworks, kfunk Cc: apol, kfunk

D7187: RFC: Make ECMAddTests respect BUILD_TESTING

kfunk added a comment. In https://phabricator.kde.org/D7187#133358, @elvisangelaccio wrote: > In `ecm_mark_as_test` (which is used in `ecm_add_test`) we already disable the target if `BUILD_TESTING` is false, why is that not enough? Good question. I didn't explain that in the

D7187: RFC: Make ECMAddTests respect BUILD_TESTING

kfunk updated this revision to Diff 17835. kfunk added a comment. Fix typo. "no-top" is something else. REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7187?vs=17830=17835 BRANCH master REVISION DETAIL https://phabricator.kde.org/D7187

D7187: RFC: Make ECMAddTests respect BUILD_TESTING

kfunk added a comment. It's not possible to easily disable tests at the moment, is it? I might be missing something. Anyhow, this patch tries to make it easy to build KDevelop without tests; trying to avoid hacky approaches like those being done in Gentoo:

D7187: RFC: Make ECMAddTests respect BUILD_TESTING

kfunk updated this revision to Diff 17830. kfunk added a comment. Remove unrelated hunks REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7187?vs=17829=17830 BRANCH master REVISION DETAIL https://phabricator.kde.org/D7187 AFFECTED FILES

D7187: RFC: Make ECMAddTests respect BUILD_TESTING

kfunk created this revision. Restricted Application added projects: Frameworks, Build System. Restricted Application added subscribers: Build System, Frameworks. REVISION SUMMARY Use-case: Make building unit tests optional, by just following the CMake BUILD_TESTING option. The usual

D7156: Qt5DBus is only required with HAVE_XSCREENSAVER

kfunk accepted this revision. This revision is now accepted and ready to land. REPOSITORY R274 KIdleTime BRANCH master REVISION DETAIL https://phabricator.kde.org/D7156 To: asturmlechner, #frameworks, kfunk Cc: #frameworks

D7136: Don't use find_file for finding files in our own source dir

kfunk accepted this revision. kfunk added a comment. This revision is now accepted and ready to land. I don't see why `find_file` would be needed here, yep. REPOSITORY R311 KWallet BRANCH master REVISION DETAIL https://phabricator.kde.org/D7136 To: vkrause, #frameworks, kfunk Cc:

D6820: Add QValidator to KTimeCombobox

kfunk added inline comments. INLINE COMMENTS > ktimecombobox.cpp:33 > +public: > +KTimeValidator(QString timeFormat, QObject *parent = Q_NULLPTR); > +KTimeValidator(QString timeFormat, QTime min, QTime max, QObject *parent > = Q_NULLPTR); Here and below: `nullptr` can be used directly

D7103: Allow to build KSyntaxHighlighter without Qt5Gui

kfunk accepted this revision. kfunk added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > CMakeLists.txt:3 > +if(TARGET Qt5::Gui) > +add_subdirectory(lib) > +add_subdirectory(cli) Too bad it needs QtGui. Just b/c it uses `QColor` as far as I can

D7102: Add cross-compilation support for the highlighting indexer

kfunk accepted this revision. kfunk added a comment. This revision is now accepted and ready to land. TIL you can use `IMPORTED` on `add_executable`... LGTM REPOSITORY R216 Syntax Highlighting BRANCH hl-cross-compile REVISION DETAIL https://phabricator.kde.org/D7102 To: vkrause,

D7011: Extract KPasswordLineEdit class

kfunk added inline comments. INLINE COMMENTS > cfeck wrote in kpasswordlineedit.cpp:30 > That's fishy. I just checked a single class (KColumnResizer), and it has just > "class KColumnResizerPrivate" (no namespace, no QObject), and still has a > Q_PRIVATE_SLOT in its KColumnResizer class. +1.

D6782: Remove unused init() declaration from K_PLUGIN_FACTORY_DECLARATION_WITH_BASEFACTORY_SKEL

kfunk accepted this revision. This revision is now accepted and ready to land. REPOSITORY R244 KCoreAddons BRANCH removeUnusedFactoryInitDeclaration REVISION DETAIL https://phabricator.kde.org/D6782 To: kossebau, #frameworks, kfunk

D5338: Add syntax highlighting file for Doxyfile

kfunk abandoned this revision. kfunk added a comment. Note: Abandoning this Diff in favor of the one from @emaurer REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D5338 To: kfunk, dhaumann, kwrite-devel, vkrause Cc: turbov, emaurer, #frameworks

D6840: Add KF6 TODO for missing argument namespace in slot signature

kfunk accepted this revision. kfunk added a comment. This revision is now accepted and ready to land. LGTM Other KF6-related notes in KF5 look the same. REPOSITORY R39 KTextEditor BRANCH addkf6todo REVISION DETAIL https://phabricator.kde.org/D6840 To: kossebau, #kate, kfunk Cc:

D6817: Fix crash based on "random" destruction order

kfunk accepted this revision. kfunk added a comment. This revision is now accepted and ready to land. I can't reproduce the crash even without this patch anymore :\ I can't reproduce it *with* this patch either. The patch makes sense given my backtrace in the bug report => ship it!

D6762: ECM: KDECompilerSettings LINKER_FLAGS on Cygwin

kfunk accepted this revision. This revision is now accepted and ready to land. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D6762 To: winterz, skelly, #build_system, #windows, kfunk Cc: nalvarez, #frameworks, #build_system

Re: Review Request 130177: Fix 'Deprecated hint for KUrl::path() is wrong on Windows'

> On July 12, 2017, 9:11 a.m., Kevin Funk wrote: > > src/kdecore/kurl.h, line 437 > > <https://git.reviewboard.kde.org/r/130177/diff/1/?file=497118#file497118line437> > > > > Maybe it's also worth pointing people to > > `QUrl::toDisplayString(QUrl::Pre

D6674: use an initializer list instead of calling insert a million times

kfunk accepted this revision. kfunk added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > kaboutdata.cpp:352 > // Use normalized keywords, by the algorithm below. > -static QHash ldict; > -if

Re: Review Request 130177: Fix 'Deprecated hint for KUrl::path() is wrong on Windows'

g used `KUrl::path()` before. I've fixed `QUrl::toDisplayString(QUrl::PreferLocalFile | ...)` in Qt 5.6 to do what one would expect from it... - Kevin Funk On July 12, 2017, 6:10 a.m., Ralf Habacker

D6473: Crash when replacing new lines with spaces

kfunk added a comment. Could you add a test in e.g. autotests/src/searchbar_test.cpp? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D6473 To: jsalatas, #ktexteditor Cc: kfunk, ltoscano, kwrite-devel, #frameworks

D6535: Use mutually exclusive group in Default Mark Type

This revision was automatically updated to reflect the committed changes. Closed by commit R39:98aec940ec0b: Use mutually exclusive group in Default Mark Type (authored by kfunk). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6535?vs=16285=16417 REVISION

D6547: Fix build with Qt 5.9.1 and clang

kfunk accepted this revision. This revision is now accepted and ready to land. REPOSITORY R249 KI18n BRANCH master REVISION DETAIL https://phabricator.kde.org/D6547 To: elvisangelaccio, #frameworks, kfunk

D6535: Use mutually exclusive group in Default Mark Type

kfunk updated this revision to Diff 16285. kfunk added a comment. Fix logic. Sorry, must have been asleep here... :\ REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6535?vs=16284=16285 BRANCH master REVISION DETAIL https://phabricator.kde.org/D6535

D6535: Use mutually exclusive group in Default Mark Type

kfunk updated this revision to Diff 16284. kfunk added a comment. Simplify code, address concerns REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6535?vs=16265=16284 BRANCH master REVISION DETAIL https://phabricator.kde.org/D6535 AFFECTED FILES

D6535: Use mutually exclusive group in Default Mark Type

kfunk edited the summary of this revision. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D6535 To: kfunk Cc: kwrite-devel, #frameworks

D6535: Use mutually exclusive group in Default Mark Type

kfunk updated this revision to Diff 16265. kfunk added a comment. Polish commit message REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6535?vs=16264=16265 BRANCH master REVISION DETAIL https://phabricator.kde.org/D6535 AFFECTED FILES

D6535: Use mutually exclusive group in Default Mark Type

kfunk created this revision. Restricted Application added subscribers: Frameworks, kwrite-devel. Restricted Application added a project: Frameworks. REVISION SUMMARY Before: Set Default Mark Type: [ ] Bookmark [X] Breakpoint After: Set Default Mark Type: ( )

Re: KTitleWidget and the native Mac style

st wanted to add my 2c and connect people. Cheers, Kevin > I'll > submit a patch for review that adds a runtime check of the widget style in > use but if anyone has a better idea I wouldn't mind hearing it and avoiding > unnecessary work. > > R. -- Kevin Funk | kf...@kde.org | http://kfunk.org signature.asc Description: This is a digitally signed message part.

D5037: KTextEditor: prevent accidental zooming

kfunk added a comment. A couple of minor issues I spotted while looking briefly over the patch. INLINE COMMENTS > kateviewinternal.cpp:76 > + > +bool detectZoomingEvent(QWheelEvent *e, Qt::KeyboardModifiers > modifier=Qt::ControlModifier) > +{ Style: Use ` = ` >

D6220: CMake: Fix CMP0058 warning when using Ninja

This revision was automatically updated to reflect the committed changes. Closed by commit R216:c70eb8b15640: CMake: Fix CMP0058 warning when using Ninja (authored by kfunk). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6220?vs=15437=15726

D6220: CMake: Fix CMP0058 warning when using Ninja

kfunk added reviewers: vkrause, dhaumann. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D6220 To: kfunk, vkrause, dhaumann Cc: #frameworks

D6253: Use FindInotify.cmake to decide wheter inotify is available.

kfunk accepted this revision. This revision is now accepted and ready to land. REPOSITORY R244 KCoreAddons BRANCH master REVISION DETAIL https://phabricator.kde.org/D6253 To: tcberner, #freebsd, dfaure, kfunk Cc: #frameworks

D6249: FindQHelpGenerator: avoid picking up Qt4 version

kfunk accepted this revision. This revision is now accepted and ready to land. REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D6249 To: palimaka, #frameworks, kossebau, kfunk Cc: alexeymin, asturmlechner, #build_system

D6220: CMake: Fix CMP0058 warning when using Ninja

kfunk updated this revision to Diff 15437. kfunk added a comment. Polishing REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6220?vs=15436=15437 BRANCH master REVISION DETAIL https://phabricator.kde.org/D6220 AFFECTED FILES

D6220: CMake: Fix CMP0058 warning when using Ninja

kfunk created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY CMake Warning (dev): Policy CMP0058 is not set: Ninja requires custom command byproducts to be explicit. Run "cmake

D6086: Left-click mini-map to jump to clicked area

kfunk added a comment. Works perfectly fine for me now, great! I don't see anything wrong with it now from a behavioral point of view. @dhaumann Maybe you want to check once more? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D6086 To: sars, #ktexteditor,

D6086: Left-click mini-map to jump to clicked area

kfunk added a comment. There are a couple of problems with the new behavior -- though I can't tell precisely when they're caused. And not sure they're new or not either. Things I'm seeing while mini map is enabled, only in some documents though: - When the slider is position at the

D6102: KUrlRequester: Set NOTIFY signal to textChanged() for text property.

kfunk added a comment. +1 from my side -- Please wait for another +1 from another person. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D6102 To: arrowdodger, #frameworks Cc: kfunk

D6101: Work-around MSVC2017 compiler bug

This revision was automatically updated to reflect the committed changes. Closed by commit R279:5973954f0b90: Work-around MSVC2017 compiler bug (authored by kfunk). REPOSITORY R279 ThreadWeaver CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6101?vs=15173=15184 REVISION DETAIL

D6101: Work-around MSVC2017 compiler bug

kfunk added reviewers: arrowdodger, bcooksley. REPOSITORY R279 ThreadWeaver REVISION DETAIL https://phabricator.kde.org/D6101 To: kfunk, arrowdodger, bcooksley Cc: #frameworks

D6101: Work-around MSVC2017 compiler bug

kfunk created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Also see: https://www.mail-archive.com/kde-windows@kde.org/msg07448.html Error: C:\JenkinsWS\workspace\Frameworks threadweaver

D6073: Don't enable strict iterators on MSVC

kfunk added subscribers: arrowdodger, kfunk. kfunk requested changes to this revision. kfunk added a comment. This revision now requires changes to proceed. I don't think we should do that. Compilation only breaks on MSVC2017, which is fairly new. And according to some test compilations by

D6086: Left-click mini-map to jump to clicked area

kfunk accepted this revision. kfunk added a comment. This revision is now accepted and ready to land. +1 on the behavior change, this is a much desired change :) INLINE COMMENTS > kateviewhelpers.cpp:204 > +if (m_leftMouseDown) { > +int newVal =

D6054: Use explicit flag values or explicit constructor instead of nullptr

kfunk accepted this revision. This revision is now accepted and ready to land. REPOSITORY R278 KWindowSystem BRANCH nonullptrforflagsplease REVISION DETAIL https://phabricator.kde.org/D6054 To: kossebau, #plasma, graesslin, kfunk Cc: plasma-devel, #frameworks, ZrenBot, spstarr,

D6053: Use explicit flag values or explicit constructor instead of nullptr

kfunk accepted this revision. kfunk added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > cfeck wrote in kfontrequester.cpp:187 > Does removing the default value mean the flags would be now uninitialized? No, `QFontDialog::FontDialogOptions` is a `QFlags<>`

D5865: Add missing KDE_ENABLE_NAMED_OPERATORS function

kfunk added a comment. In https://phabricator.kde.org/D5865#112766, @rjvbb wrote: > KDE is FOSS not bound to Microsoft by any corporate buy-in or whatever, right? What non-sense is this? Please stay on topic. There's a benefit we make sure KDE software is compiling under MSVC

D5865: Add missing KDE_ENABLE_NAMED_OPERATORS function

kfunk requested changes to this revision. kfunk added a comment. This revision now requires changes to proceed. Can't go in as-is, as it breaks compilation on MSVC 2015. But interesting to see that `/Za` is actually problematic. Which proves my point: Just don't use named operators in

D5865: Add missing KDE_ENABLE_NAMED_OPERATORS function

kfunk added a comment. LGTM in general. I'll hope to find some time to test on Window, wouldn't want this to be merged before that. INLINE COMMENTS > KDECompilerSettings.cmake:226 > +if (MSVC) > +if (${MSVC_VERSION} GREATER 1900) > +# /permissive- became the

D5784: Add support for FreeBSD in FSUtils::getDirectoryFileSystem().

kfunk added a comment. Okay, then maybe support for the current FreeBSD version is not implemented? I have no idea about FreeBSD, to be honest. But it looks like using this API, and implementing the proper support in `QStorageInfo` internals would be the appropriate place. Anyhow, if

D5784: Add support for FreeBSD in FSUtils::getDirectoryFileSystem().

kfunk added a comment. What about http://doc.qt.io/qt-5/qstorageinfo.html#fileSystemType? REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D5784 To: tcberner, #freebsd Cc: kfunk, #frameworks

D5766: Change default pkgconfig install path for FreeBSD

kfunk accepted this revision. kfunk added a comment. This revision is now accepted and ready to land. Well, for me that looks good now REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D5766 To: tcberner, #freebsd, apol, kfunk Cc: kfunk,

D5766: Change default pkgconfig install path for FreeBSD

kfunk requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D5766 To: tcberner, #freebsd, apol, kfunk Cc: kfunk, #frameworks, #build_system

D5766: Change default pkgconfig install path for FreeBSD

kfunk added inline comments. INLINE COMMENTS > ECMGeneratePkgConfigFile.cmake:172 >if(EGPF_INSTALL) > -set(ECM_PKGCONFIG_INSTALL_DIR "${EGPF_LIB_INSTALL_DIR}/pkgconfig" CACHE > PATH "The directory where pkgconfig will be installed to.") > +if(NOT CMAKE_SYSTEM_NAME matches "FreeBSD")

D5489: Sanitizers: Don't use GCC-like flags for e.g. MSVC

This revision was automatically updated to reflect the committed changes. Closed by commit R240:c56cf46b4beb: Sanitizers: Don't use GCC-like flags for e.g. MSVC (authored by kfunk). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE

Re: Threadweaver compilation failure: Windows

20 16:03 GMT+05:00 Ben Cooksley <bcooks...@kde.org>: > > Okay. Could you try building with these arguments to CMake and see what > > happens? > > > > -DCMAKE_BUILD_TYPE=Debug -DECM_ENABLE_SANITIZERS='address' > > -DBUILD_TESTING=ON -- Kevin Funk | kf...@kde.org

D5506: Don't even try to create icons with empty sizes

kfunk added inline comments. INLINE COMMENTS > kiconengine.cpp:87 > > -if (!size.isValid()) { > +if (!size.isValid() || size.height() == 0 || size.width() == 0) { > return QPixmap(); `size.isEmpty()`? REPOSITORY R302 KIconThemes REVISION DETAIL

D5489: Sanitizers: Don't use GCC-like flags for e.g. MSVC

kfunk added reviewers: aacid, bcooksley. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D5489 To: kfunk, aacid, bcooksley Cc: #frameworks, #build_system

D5489: Sanitizers: Don't use GCC-like flags for e.g. MSVC

kfunk created this revision. Restricted Application added projects: Frameworks, Build System. Restricted Application added subscribers: Build System, Frameworks. REVISION SUMMARY Fixes compiler warnings such as: cl : Command line warning D9002 : ignoring unknown option

D5430: KDECompilerSettings: Pass -Wvla & -Wdate-time

This revision was automatically updated to reflect the committed changes. Closed by commit R240:0348332744d2: KDECompilerSettings: Pass -Wvla & -Wdate-time (authored by kfunk). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5430?vs=13476=13554

Re: Threadweaver compilation failure: Windows

= 0; -auto initializeImage = [=, ] (const QFileInfo& file) { +auto initializeImage = [=, ] (const QFileInfo& file) -> Image { auto const out = QFileInfo(outputDirectory, file.fileName()).absoluteFilePath(); return Image(file.absoluteFilePath(), out, this, counter++);

D5456: KDoctools: build on Mac with docbook from homebrew

kfunk added a comment. It's a "fix it, then ship it" like acceptance. REPOSITORY R238 KDocTools REVISION DETAIL https://phabricator.kde.org/D5456 To: winterz, ltoscano, kfunk Cc: kfunk, #frameworks, #documentation, skadinna

D5413: makes KArchive be optional and do not build extractors needing it

kfunk requested changes to this revision. kfunk added a comment. This revision now requires changes to proceed. +1 REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D5413 To: mgallien, kfunk Cc: kfunk, heikobecker, dfaure, #frameworks

D5430: KDECompilerSettings: Pass -Wvla & -Wdate-time

kfunk updated this revision to Diff 13476. kfunk added a comment. Address mpyne's concerns REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5430?vs=13396=13476 BRANCH master REVISION DETAIL https://phabricator.kde.org/D5430 AFFECTED FILES

D5456: KDoctools: build on Mac with docbook from homebrew

kfunk accepted this revision. kfunk added a comment. This revision is now accepted and ready to land. I'd say: Add a comment that this is for OS X/homebrew then it's okay as-is. REPOSITORY R238 KDocTools REVISION DETAIL https://phabricator.kde.org/D5456 To: winterz, ltoscano, kfunk Cc:

D5443: fix duplicated symbols compilation error with mingw on Windows

kfunk accepted this revision. This revision is now accepted and ready to land. REPOSITORY R286 KFileMetaData BRANCH windows_fix REVISION DETAIL https://phabricator.kde.org/D5443 To: mgallien, kfunk, #windows Cc: #frameworks

Re: Continuous Integration on Windows

under both MinGW & MSVC. Cheers, Kevin > Thanks in advance for your help > > Best regards > > -- > Matthieu Gallien -- Kevin Funk | kf...@kde.org | http://kfunk.org signature.asc Description: This is a digitally signed message part.

D5430: KDECompilerSettings: Pass -Wvla & -Wdate-time

kfunk added a comment. For -Wdate-time: https://lxr.kde.org/search?_filestring=&_string=__DATE__ https://lxr.kde.org/search?_filestring=&_string=__TIME__ -> Only around ~10 locations affected, mainly Krita/Digikam/Amarok stuff. The use of __DATE__ & __TIME__ should just be avoided.

D5430: KDECompilerSettings: Pass -Wvla & -Wdate-time

kfunk edited the summary of this revision. kfunk edited the test plan for this revision. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D5430 To: kfunk Cc: #frameworks, #build_system

D5430: KDECompilerSettings: Pass -Wvla & -Wdate-time

kfunk created this revision. Restricted Application added projects: Frameworks, Build System. Restricted Application added subscribers: Build System, Frameworks. REVISION SUMMARY -Wvla: Warn because it's non-standard feature, not supported by MSVC to date -Wdate-time: Warn because using

D5338: Add syntax highlighting file for Doxyfile

kfunk added a comment. In https://phabricator.kde.org/D5338#101466, @emaurer wrote: > In https://phabricator.kde.org/D5338#100575, @kfunk wrote: > > > In https://phabricator.kde.org/D5338#100509, @dhaumann wrote: > > > > > Oh, and see this:

D5392: Fix build with Qt 5.9

kfunk accepted this revision. This revision is now accepted and ready to land. REPOSITORY R313 KHtml BRANCH master REVISION DETAIL https://phabricator.kde.org/D5392 To: apol, #frameworks, kfunk Cc: mpyne, ltoscano, #frameworks

D5379: Fix compilation under AppleClang

This revision was automatically updated to reflect the committed changes. Closed by commit R240:3d1d436da60a: Fix compilation under AppleClang (authored by kfunk). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5379?vs=13284=13289 REVISION DETAIL

D5379: Fix compilation under AppleClang

kfunk added a comment. In https://phabricator.kde.org/D5379#100960, @rjvbb wrote: > LGTM. > > Is this related to the compiler features issue in one of Qt's cmake modules? No, it's related to CMake starting to treat AppleClang & Clang differently since 3.0 REPOSITORY R240

D5379: Fix compilation under AppleClang

kfunk added a reviewer: rjvbb. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D5379 To: kfunk, rjvbb Cc: #frameworks, #build_system

D5379: Fix compilation under AppleClang

kfunk created this revision. Restricted Application added projects: Frameworks, Build System. Restricted Application added subscribers: Build System, Frameworks. REVISION SUMMARY Broken since we started to treat Clang and AppleClang differently (with the switch to CMake 3.0) FIXED-IN:

D5338: Add syntax highlighting file for Doxyfile

kfunk added a comment. In https://phabricator.kde.org/D5338#100509, @dhaumann wrote: > Oh, and see this: https://github.com/KDE/syntax-highlighting/pull/5 What the... Created at almost the exact same time? :) REPOSITORY R216 Syntax Highlighting BRANCH master REVISION DETAIL

D5338: Add syntax highlighting file for Doxyfile

kfunk edited the summary of this revision. kfunk added reviewers: vkrause, dhaumann, kwrite-devel. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D5338 To: kfunk, vkrause, dhaumann, kwrite-devel Cc: #frameworks

D5338: Add syntax highlighting file for Doxyfile

kfunk created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REPOSITORY R216 Syntax Highlighting BRANCH master REVISION DETAIL https://phabricator.kde.org/D5338 AFFECTED FILES data/syntax/doxyfile.xml To: kfunk

D5302: Use -Wno-gnu-zero-variadic-macro-arguments more

This revision was automatically updated to reflect the committed changes. Closed by commit R240:c20a9f69e8e2: Use -Wno-gnu-zero-variadic-macro-arguments more (authored by kfunk). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5302?vs=13096=13113

<    1   2   3   4   5   6   >