D5766: Change default pkgconfig install path for FreeBSD

kfunk requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D5766 To: tcberner, #freebsd, apol, kfunk Cc: kfunk, #frameworks, #build_system

D5766: Change default pkgconfig install path for FreeBSD

kfunk accepted this revision. kfunk added a comment. This revision is now accepted and ready to land. Well, for me that looks good now REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D5766 To: tcberner, #freebsd, apol, kfunk Cc: kfunk, #fr

D5784: Add support for FreeBSD in FSUtils::getDirectoryFileSystem().

kfunk added a comment. What about http://doc.qt.io/qt-5/qstorageinfo.html#fileSystemType? REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D5784 To: tcberner, #freebsd Cc: kfunk, #frameworks

D5784: Add support for FreeBSD in FSUtils::getDirectoryFileSystem().

kfunk added a comment. Okay, then maybe support for the current FreeBSD version is not implemented? I have no idea about FreeBSD, to be honest. But it looks like using this API, and implementing the proper support in `QStorageInfo` internals would be the appropriate place. Anyhow, if Qt

D5865: Add missing KDE_ENABLE_NAMED_OPERATORS function

kfunk added a comment. LGTM in general. I'll hope to find some time to test on Window, wouldn't want this to be merged before that. INLINE COMMENTS > KDECompilerSettings.cmake:226 > +if (MSVC) > +if (${MSVC_VERSION} GREATER 1900) > +# /permissive- became the preferred

D5865: Add missing KDE_ENABLE_NAMED_OPERATORS function

kfunk requested changes to this revision. kfunk added a comment. This revision now requires changes to proceed. Can't go in as-is, as it breaks compilation on MSVC 2015. But interesting to see that `/Za` is actually problematic. Which proves my point: Just don't use named operators in cod

D5865: Add missing KDE_ENABLE_NAMED_OPERATORS function

kfunk added a comment. In https://phabricator.kde.org/D5865#112766, @rjvbb wrote: > KDE is FOSS not bound to Microsoft by any corporate buy-in or whatever, right? What non-sense is this? Please stay on topic. There's a benefit we make sure KDE software is compiling under MSVC giv

D6053: Use explicit flag values or explicit constructor instead of nullptr

kfunk accepted this revision. kfunk added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > cfeck wrote in kfontrequester.cpp:187 > Does removing the default value mean the flags would be now uninitialized? No, `QFontDialog::FontDialogOptions` is a `QFlags<>` wh

D6054: Use explicit flag values or explicit constructor instead of nullptr

kfunk accepted this revision. This revision is now accepted and ready to land. REPOSITORY R278 KWindowSystem BRANCH nonullptrforflagsplease REVISION DETAIL https://phabricator.kde.org/D6054 To: kossebau, #plasma, graesslin, kfunk Cc: plasma-devel, #frameworks, ZrenBot, spstarr, progwolff,

D6086: Left-click mini-map to jump to clicked area

kfunk accepted this revision. kfunk added a comment. This revision is now accepted and ready to land. +1 on the behavior change, this is a much desired change :) INLINE COMMENTS > kateviewhelpers.cpp:204 > +if (m_leftMouseDown) { > +int newVal = ((e->pos().y()-m_mapGroveRe

D6073: Don't enable strict iterators on MSVC

kfunk added subscribers: arrowdodger, kfunk. kfunk requested changes to this revision. kfunk added a comment. This revision now requires changes to proceed. I don't think we should do that. Compilation only breaks on MSVC2017, which is fairly new. And according to some test compilations by @ar

D6101: Work-around MSVC2017 compiler bug

kfunk created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Also see: https://www.mail-archive.com/kde-windows@kde.org/msg07448.html Error: C:\JenkinsWS\workspace\Frameworks threadweaver kf5-

D6101: Work-around MSVC2017 compiler bug

kfunk added reviewers: arrowdodger, bcooksley. REPOSITORY R279 ThreadWeaver REVISION DETAIL https://phabricator.kde.org/D6101 To: kfunk, arrowdodger, bcooksley Cc: #frameworks

D6101: Work-around MSVC2017 compiler bug

This revision was automatically updated to reflect the committed changes. Closed by commit R279:5973954f0b90: Work-around MSVC2017 compiler bug (authored by kfunk). REPOSITORY R279 ThreadWeaver CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6101?vs=15173&id=15184 REVISION DETAIL h

D6102: KUrlRequester: Set NOTIFY signal to textChanged() for text property.

kfunk added a comment. +1 from my side -- Please wait for another +1 from another person. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D6102 To: arrowdodger, #frameworks Cc: kfunk

D6086: Left-click mini-map to jump to clicked area

kfunk added a comment. There are a couple of problems with the new behavior -- though I can't tell precisely when they're caused. And not sure they're new or not either. Things I'm seeing while mini map is enabled, only in some documents though: - When the slider is position at the b

D6086: Left-click mini-map to jump to clicked area

kfunk added a comment. Works perfectly fine for me now, great! I don't see anything wrong with it now from a behavioral point of view. @dhaumann Maybe you want to check once more? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D6086 To: sars, #ktexteditor, #

D6220: CMake: Fix CMP0058 warning when using Ninja

kfunk created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY CMake Warning (dev): Policy CMP0058 is not set: Ninja requires custom command byproducts to be explicit. Run "cmake --help-polic

D6220: CMake: Fix CMP0058 warning when using Ninja

kfunk updated this revision to Diff 15437. kfunk added a comment. Polishing REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6220?vs=15436&id=15437 BRANCH master REVISION DETAIL https://phabricator.kde.org/D6220 AFFECTED FILES data/CMakeL

D6249: FindQHelpGenerator: avoid picking up Qt4 version

kfunk accepted this revision. This revision is now accepted and ready to land. REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D6249 To: palimaka, #frameworks, kossebau, kfunk Cc: alexeymin, asturmlechner, #build_system

D6253: Use FindInotify.cmake to decide wheter inotify is available.

kfunk accepted this revision. This revision is now accepted and ready to land. REPOSITORY R244 KCoreAddons BRANCH master REVISION DETAIL https://phabricator.kde.org/D6253 To: tcberner, #freebsd, dfaure, kfunk Cc: #frameworks

D6220: CMake: Fix CMP0058 warning when using Ninja

kfunk added reviewers: vkrause, dhaumann. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D6220 To: kfunk, vkrause, dhaumann Cc: #frameworks

D6220: CMake: Fix CMP0058 warning when using Ninja

This revision was automatically updated to reflect the committed changes. Closed by commit R216:c70eb8b15640: CMake: Fix CMP0058 warning when using Ninja (authored by kfunk). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6220?vs=15437&id=15726 RE

D5037: KTextEditor: prevent accidental zooming

kfunk added a comment. A couple of minor issues I spotted while looking briefly over the patch. INLINE COMMENTS > kateviewinternal.cpp:76 > + > +bool detectZoomingEvent(QWheelEvent *e, Qt::KeyboardModifiers > modifier=Qt::ControlModifier) > +{ Style: Use ` = ` > kateviewinternal.cp

Re: KTitleWidget and the native Mac style

I've no incentive for getting this fixed, just wanted to add my 2c and connect people. Cheers, Kevin > I'll > submit a patch for review that adds a runtime check of the widget style in > use but if anyone has a better idea I wouldn't mind hearing it and avoiding > unnecessary work. > > R. -- Kevin Funk | kf...@kde.org | http://kfunk.org signature.asc Description: This is a digitally signed message part.

D6535: Use mutually exclusive group in Default Mark Type

kfunk created this revision. Restricted Application added subscribers: Frameworks, kwrite-devel. Restricted Application added a project: Frameworks. REVISION SUMMARY Before: Set Default Mark Type: [ ] Bookmark [X] Breakpoint After: Set Default Mark Type: ( ) Bookmark

D6535: Use mutually exclusive group in Default Mark Type

kfunk updated this revision to Diff 16265. kfunk added a comment. Polish commit message REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6535?vs=16264&id=16265 BRANCH master REVISION DETAIL https://phabricator.kde.org/D6535 AFFECTED FILES src/view

D6535: Use mutually exclusive group in Default Mark Type

kfunk edited the summary of this revision. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D6535 To: kfunk Cc: kwrite-devel, #frameworks

D6535: Use mutually exclusive group in Default Mark Type

kfunk updated this revision to Diff 16284. kfunk added a comment. Simplify code, address concerns REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6535?vs=16265&id=16284 BRANCH master REVISION DETAIL https://phabricator.kde.org/D6535 AFFECTED FILES

D6535: Use mutually exclusive group in Default Mark Type

kfunk updated this revision to Diff 16285. kfunk added a comment. Fix logic. Sorry, must have been asleep here... :\ REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6535?vs=16284&id=16285 BRANCH master REVISION DETAIL https://phabricator.kde.org/D65

D6547: Fix build with Qt 5.9.1 and clang

kfunk accepted this revision. This revision is now accepted and ready to land. REPOSITORY R249 KI18n BRANCH master REVISION DETAIL https://phabricator.kde.org/D6547 To: elvisangelaccio, #frameworks, kfunk

D6535: Use mutually exclusive group in Default Mark Type

This revision was automatically updated to reflect the committed changes. Closed by commit R39:98aec940ec0b: Use mutually exclusive group in Default Mark Type (authored by kfunk). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6535?vs=16285&id=16417 REVISI

D6473: Crash when replacing new lines with spaces

kfunk added a comment. Could you add a test in e.g. autotests/src/searchbar_test.cpp? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D6473 To: jsalatas, #ktexteditor Cc: kfunk, ltoscano, kwrite-devel, #frameworks

Re: Review Request 130177: Fix 'Deprecated hint for KUrl::path() is wrong on Windows'

want when having used `KUrl::path()` before. I've fixed `QUrl::toDisplayString(QUrl::PreferLocalFile | ...)` in Qt 5.6 to do what one would expect from it... - Kevin Funk On July 12, 2017, 6:10 a.m., Ralf Habacker wrote: > >

D6674: use an initializer list instead of calling insert a million times

kfunk accepted this revision. kfunk added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > kaboutdata.cpp:352 > // Use normalized keywords, by the algorithm below. > -static QHash ldict; > -if (ldict.isEmpty()) { > -ldict.insert("gpl", KAbou

Re: Review Request 130177: Fix 'Deprecated hint for KUrl::path() is wrong on Windows'

> On July 12, 2017, 9:11 a.m., Kevin Funk wrote: > > src/kdecore/kurl.h, line 437 > > <https://git.reviewboard.kde.org/r/130177/diff/1/?file=497118#file497118line437> > > > > Maybe it's also worth pointing people to > > `QUrl::toDisplayString(QUrl

D6762: ECM: KDECompilerSettings LINKER_FLAGS on Cygwin

kfunk accepted this revision. This revision is now accepted and ready to land. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D6762 To: winterz, skelly, #build_system, #windows, kfunk Cc: nalvarez, #frameworks, #build_system

D6817: Fix crash based on "random" destruction order

kfunk accepted this revision. kfunk added a comment. This revision is now accepted and ready to land. I can't reproduce the crash even without this patch anymore :\ I can't reproduce it *with* this patch either. The patch makes sense given my backtrace in the bug report => ship it! REPOS

D6840: Add KF6 TODO for missing argument namespace in slot signature

kfunk accepted this revision. kfunk added a comment. This revision is now accepted and ready to land. LGTM Other KF6-related notes in KF5 look the same. REPOSITORY R39 KTextEditor BRANCH addkf6todo REVISION DETAIL https://phabricator.kde.org/D6840 To: kossebau, #kate, kfunk Cc: k

D5338: Add syntax highlighting file for Doxyfile

kfunk abandoned this revision. kfunk added a comment. Note: Abandoning this Diff in favor of the one from @emaurer REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D5338 To: kfunk, dhaumann, kwrite-devel, vkrause Cc: turbov, emaurer, #frameworks

D6782: Remove unused init() declaration from K_PLUGIN_FACTORY_DECLARATION_WITH_BASEFACTORY_SKEL

kfunk accepted this revision. This revision is now accepted and ready to land. REPOSITORY R244 KCoreAddons BRANCH removeUnusedFactoryInitDeclaration REVISION DETAIL https://phabricator.kde.org/D6782 To: kossebau, #frameworks, kfunk

D7011: Extract KPasswordLineEdit class

kfunk added inline comments. INLINE COMMENTS > cfeck wrote in kpasswordlineedit.cpp:30 > That's fishy. I just checked a single class (KColumnResizer), and it has just > "class KColumnResizerPrivate" (no namespace, no QObject), and still has a > Q_PRIVATE_SLOT in its KColumnResizer class. +1. D

D7102: Add cross-compilation support for the highlighting indexer

kfunk accepted this revision. kfunk added a comment. This revision is now accepted and ready to land. TIL you can use `IMPORTED` on `add_executable`... LGTM REPOSITORY R216 Syntax Highlighting BRANCH hl-cross-compile REVISION DETAIL https://phabricator.kde.org/D7102 To: vkrause,

D7103: Allow to build KSyntaxHighlighter without Qt5Gui

kfunk accepted this revision. kfunk added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > CMakeLists.txt:3 > +if(TARGET Qt5::Gui) > +add_subdirectory(lib) > +add_subdirectory(cli) Too bad it needs QtGui. Just b/c it uses `QColor` as far as I can see...

D6820: Add QValidator to KTimeCombobox

kfunk added inline comments. INLINE COMMENTS > ktimecombobox.cpp:33 > +public: > +KTimeValidator(QString timeFormat, QObject *parent = Q_NULLPTR); > +KTimeValidator(QString timeFormat, QTime min, QTime max, QObject *parent > = Q_NULLPTR); Here and below: `nullptr` can be used directly i

D7136: Don't use find_file for finding files in our own source dir

kfunk accepted this revision. kfunk added a comment. This revision is now accepted and ready to land. I don't see why `find_file` would be needed here, yep. REPOSITORY R311 KWallet BRANCH master REVISION DETAIL https://phabricator.kde.org/D7136 To: vkrause, #frameworks, kfunk Cc: kfun

D7156: Qt5DBus is only required with HAVE_XSCREENSAVER

kfunk accepted this revision. This revision is now accepted and ready to land. REPOSITORY R274 KIdleTime BRANCH master REVISION DETAIL https://phabricator.kde.org/D7156 To: asturmlechner, #frameworks, kfunk Cc: #frameworks

D7187: RFC: Make ECMAddTests respect BUILD_TESTING

kfunk created this revision. Restricted Application added projects: Frameworks, Build System. Restricted Application added subscribers: Build System, Frameworks. REVISION SUMMARY Use-case: Make building unit tests optional, by just following the CMake BUILD_TESTING option. The usual appro

D7187: RFC: Make ECMAddTests respect BUILD_TESTING

kfunk updated this revision to Diff 17830. kfunk added a comment. Remove unrelated hunks REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7187?vs=17829&id=17830 BRANCH master REVISION DETAIL https://phabricator.kde.org/D7187 AFFECTED FILES

D7187: RFC: Make ECMAddTests respect BUILD_TESTING

kfunk added a comment. It's not possible to easily disable tests at the moment, is it? I might be missing something. Anyhow, this patch tries to make it easy to build KDevelop without tests; trying to avoid hacky approaches like those being done in Gentoo: https://bugs.gentoo.org/

D7187: RFC: Make ECMAddTests respect BUILD_TESTING

kfunk updated this revision to Diff 17835. kfunk added a comment. Fix typo. "no-top" is something else. REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7187?vs=17830&id=17835 BRANCH master REVISION DETAIL https://phabricator.kde.org/D7187

D7187: RFC: Make ECMAddTests respect BUILD_TESTING

kfunk added a comment. In https://phabricator.kde.org/D7187#133358, @elvisangelaccio wrote: > In `ecm_mark_as_test` (which is used in `ecm_add_test`) we already disable the target if `BUILD_TESTING` is false, why is that not enough? Good question. I didn't explain that in the comm

D7136: Don't use find_file for finding files in our own source dir

kfunk accepted this revision. REPOSITORY R311 KWallet BRANCH master REVISION DETAIL https://phabricator.kde.org/D7136 To: vkrause, #frameworks, kfunk Cc: apol, kfunk

D7187: RFC: Make ECMAddTests respect BUILD_TESTING

kfunk added a comment. Guys... no one gave me an "Accepted' yet :) REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D7187 To: kfunk Cc: vkrause, elvisangelaccio, asturmlechner, apol, #frameworks, #build_system

D7187: RFC: Make ECMAddTests respect BUILD_TESTING

kfunk added a comment. In https://phabricator.kde.org/D7187#133497, @kossebau wrote: > +1 as well. Please also add a note in the API dox what BUILD_TESTING will do on this macro, so this is not magic behaviour and people can plan with this (like making sure to not set `target_link_librar

D7187: RFC: Make ECMAddTests respect BUILD_TESTING

This revision was automatically updated to reflect the committed changes. Closed by commit R240:b99d2d2c5ded: RFC: Make ECMAddTests respect BUILD_TESTING (authored by kfunk). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D7187?vs=17835&id=17858#toc REPOSITORY R240 Extra CMake Modules

D7213: Use ecm_add_test and benefit from BUILD_TESTING awareness

kfunk accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D7213 To: asturmlechner, #frameworks, kfunk Cc: kfunk

D7198: Set CMAKE_*_OUTPUT_DIRECTORY to run tests without installing.

kfunk accepted this revision. kfunk added a comment. I like the initiative, +1 REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D7198 To: dfaure, cgiboudeaux, kfunk Cc: kfunk, #frameworks, #build_system

D7458: Show icons in icon border context menu

kfunk added a comment. Other than that the patch looks sensible to me. INLINE COMMENTS > kateviewhelpers.cpp:2253 > +dMA = > selectDefaultMark.addAction(m_doc->markDescription(markType)); > +} else { > +mA = markMenu.addAction(icon, > m_doc->markD

D7443: Fix compilation on windows with editorconfig-c-core available

This revision was automatically updated to reflect the committed changes. Closed by commit R39:ab503ec944fe: Fix compilation on windows with editorconfig-c-core available (authored by kfunk). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7443?vs=18463&id=1

D7459: Use config.h more

kfunk created this revision. Restricted Application added subscribers: Frameworks, kwrite-devel. Restricted Application added a project: Frameworks. REVISION SUMMARY This also fixes an issue with regards to HAVE_FDATASYNC: src/buffer/katesecuretextbuffer.cpp:157:5: warning: 'HAVE_FDATASY

D7459: Use config.h more

This revision was automatically updated to reflect the committed changes. Closed by commit R39:0ee0be681108: Use config.h more (authored by kfunk). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7459?vs=18526&id=18529 REVISION DETAIL https://phabricator.k

D7463: Really rate-limit INF_PROCESSED_SIZE messages

kfunk created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Fixing an ancient porting bug which popped up when porting from Qt4 to Qt5. FIXED-IN: 5.38 BUG: 383843 REPOSITORY R241 KIO BRANCH

D7463: Really rate-limit INF_PROCESSED_SIZE messages

This revision was automatically updated to reflect the committed changes. Closed by commit R241:801f58e7e76a: Really rate-limit INF_PROCESSED_SIZE messages (authored by kfunk). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7463?vs=18535&id=18541 REVISION DETAIL

D7478: Escape hyphen in rest.xml regular expressions

kfunk added a comment. In https://phabricator.kde.org/D7478#138855, @alexeymin wrote: > Is it a fix for bug https://bugs.kde.org/show_bug.cgi?id=383632 ? I think so. FWIW: Here's another upstream report, filed by Heiko himself: https://bugs.exim.org/show_bug.cgi?id=2158 REP

D7033: Port ki18n from QtScript to QtQml

kfunk added a comment. Just wanted to add this: Really great work! -- I wanted to raise this issue earlier on the KF5 mailing list: ki18n was the last major framework that depended on the deprecated QtScript. Nice to see it being ported! <3 Can't really review this code either, though. I

D7033: Port ki18n from QtScript to QtQml

kfunk added a comment. Could someone fluent in QtScript/QtQML review this so we can merge it? INLINE COMMENTS > ktranscript.cpp:96 > // Interface functions. > -Q_INVOKABLE QScriptValue load(); // actually has variable length > argument list > -Q_INVOKABLE QScriptValue setcall(co

D7840: Fix trailing space visualization for RTL lines.

kfunk added a comment. Could you add before/after screenshots for this? I think this could also help non-RTL users understand what you're fixing. Would be super helpful for me at least :) REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D7840 To: safaalfulaij,

D7840: Fix trailing space visualization for RTL lines.

kfunk added a comment. Indeed, thanks for those fixes. /me can see a nice blog post coming a long...? :) REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D7840 To: safaalfulaij, #ktexteditor, cullmann Cc: cullmann, kfunk, #frameworks, sars, dhaumann

D7884: - Increase size of trailing mark

kfunk added a comment. Screenshots please, for changes like this. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D7884 To: helio, mwolff, kfunk Cc: #frameworks, cullmann, sars, dhaumann

D7884: - Increase size of trailing mark

kfunk added a comment. In https://phabricator.kde.org/D7884#147087, @sars wrote: > I think "spaceWidth() / 2" goes a little bit too far. I agree. The 'before' screenshot looks better in my eyes. The trailing mark indicator is supposed to be a *subtle* hint, not something causing e

Adding build info attribute to KAboutData to improve bug report data?

nsible, one could add more content to the build info attribute which would be sent over to bugs.kde.org. Regards, Kevin -- Kevin Funk | kf...@kde.org | http://kfunk.org signature.asc Description: This is a digitally signed message part.

D8207: Use https for KDE urls

kfunk created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Make sure links in dialogs point to https:// urls REPOSITORY R244 KCoreAddons BRANCH master REVISION DETAIL https://phabricator.kde.or

D8209: Use https for KDE urls

kfunk created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REPOSITORY R263 KXmlGui BRANCH master REVISION DETAIL https://phabricator.kde.org/D8209 AFFECTED FILES make_kdepackages_updated.py src/kaboutapplicat

D8207: Use https for KDE urls

This revision was automatically updated to reflect the committed changes. Closed by commit R244:3cc8b8f5ad26: Use https for KDE urls (authored by kfunk). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D8207?vs=20491&id=20502#toc REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE ht

D8207: Use https for KDE urls

kfunk added a comment. In https://phabricator.kde.org/D8207#153510, @mpyne wrote: > I support the idea, but I think there's a few more spots where we can convert http:// to https://. I ran `ag --only-matching --no-heading 'http:.*k.*\.org'` in the kcoreaddons source directory, with the

D8209: Use https for KDE urls

This revision was automatically updated to reflect the committed changes. Closed by commit R263:1ee609564a8f: Use https for KDE urls (authored by kfunk). REPOSITORY R263 KXmlGui CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8209?vs=20493&id=20504 REVISION DETAIL https://phabricato

D8264: Fix build of breeze-icons on the Android CI

kfunk requested changes to this revision. kfunk added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > CMakeLists.txt:23 > +if (CMAKE_CROSSCOMPILING) > +set(GENERATE_ICONS_DEFAULT OFF) > +else() Better: `GENERATE_ICONS_DEFAULT` -> `BINARY_ICONS_RESOURCE_OPTIO

D8264: Fix build of breeze-icons on the Android CI

kfunk accepted this revision. kfunk added a comment. This revision is now accepted and ready to land. That comment could be a bit more verbose and better placed (i.e. move it next to `set(BINARY_ICONS_RESOURCE_OPTION_DEFAULT OFF)` and make it something along "When cross-compiling qrcAlias wou

D8296: Use Ctrl+, as the standard shortcut for "Configure "

kfunk added a comment. In KDevelop, this is also a really important shortcut for navigating through the source. `Ctrl+,` for jumping to definition, `Ctrl+.` for jumping to declaration. /me wonders if one really needs a shortcut for configuring shortcuts at all. https://lxr.kde.org/sear

Re: concise instructions how to use sub...@bugs.kde.org?

traight-forward and sustainable variant? I thought this is working in general? Why do we need diverge again (i.e. introducing a tool where no-one is familiar with) instead of completing existing work? Thanks, Kevin > Thank, > René -- Kevin Funk | kf...@kde.org | http://kfunk.org signa

Re: Adding build info attribute to KAboutData to improve bug report data?

On Sunday, 8 October 2017 19:45:00 CEST Kevin Funk wrote: > Heya, > > The KDevelop team is currently discussing a patch which adds git-describe > like information to the version string in KAboutData: > https://phabricator.kde.org/D8158 > (don't bother readi

D8314: Fix deprecation warning

kfunk created this revision. Restricted Application added projects: Kate, Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Warning: /home/kfunk/devel/src/kf5/ktexteditor/src/dialogs/katedialogs.cpp:1455:11: warning: 'runUrl' is deprecated [-Wdeprecat

D8315: CMake cleanup: Don't hardcode -std=c++0x

kfunk created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY This is both set by ECM & Qt5 CMake config files REPOSITORY R279 ThreadWeaver BRANCH master REVISION DETAIL https://phabricator.kde.or

FYI: Added .arcconfig files to all frameworks

Heya, just pushed an .arcconfig file to all framework repositories. There were still lots of frameworks without them. Example commit: https://cgit.kde.org/qqc2-desktop-style.git/commit/? id=146e370704938e6cab6278a5e203f3ef2cf93946 Regards, Kevin -- Kevin Funk | kf...@kde.org | http

D8315: CMake cleanup: Don't hardcode -std=c++0x

This revision was automatically updated to reflect the committed changes. Closed by commit R279:265b9f9f3120: CMake cleanup: Don't hardcode -std=c++0x (authored by kfunk). REPOSITORY R279 ThreadWeaver CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8315?vs=20814&id=20840 REVISION DET

D8314: Fix deprecation warning

This revision was automatically updated to reflect the committed changes. Closed by commit R39:68d42865076e: Fix deprecation warning (authored by kfunk). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8314?vs=20813&id=20841 REVISION DETAIL https://phabric

Re: Adding build info attribute to KAboutData to improve bug report data?

On Monday, 16 October 2017 07:10:29 CEST Luca Beltrame wrote: > Il giorno Sun, 08 Oct 2017 19:45:00 +0200 > > Kevin Funk ha scritto: > > Heya, > > > > The KDevelop team is currently discussing a patch which adds > > > > git-describe like informat

Re: What removes protocoltojson with make install in kio?

e directories -- install into a different prefix. Regards, Kevin > and protocoltojson is indeed gone from the bin folder. > Running find . -iname "protocoltojson" > only gives me the build folder for it, the binary is actually gone... > > Am i doing anything wrong? >

D7401: Solid/Mac : fleshing out the skeleton IOKit backend (WIP)

kfunk requested changes to this revision. kfunk added a comment. This revision now requires changes to proceed. This definitely needs another revision. Please fix the outstanding issues. INLINE COMMENTS > iokitblock.h:43 > + > +virtual int deviceMajor() const; > +virtual int deviceMin

D7401: Solid/Mac : fleshing out the skeleton IOKit backend (WIP)

kfunk added inline comments. INLINE COMMENTS > iokitopticaldrive.cpp:27 > + > +#ifdef EJECT_USING_DISKARBITRATION > +// for QCFType: Where's that defined via the build system? REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D7401 To: rjvbb, #frameworks, kfunk Cc: kfunk,

D7401: Solid/Mac : fleshing out the skeleton IOKit backend (WIP)

kfunk requested changes to this revision. kfunk added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > iokitdevice.cpp:307 > +default: > +vendor = QString(); > +break; Why not `return` here as well? For consistency. You can end the function w

D8437: KWidgetsAddons : more compact password dialog

kfunk requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D8437 To: rjvbb, #frameworks, kfunk Cc: cfeck, ngraham

D8437: KWidgetsAddons : more compact password dialog

kfunk accepted this revision. kfunk added a comment. This revision is now accepted and ready to land. Looks like it :) REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D8437 To: rjvbb, #frameworks, kfunk, ngraham Cc: cfeck, ngraham

D8544: KTextEditor : avoiding QML crashes

kfunk added inline comments. INLINE COMMENTS > kateglobal.cpp:104 > +// disable the QML JIT compiler as a protection against an unknown bug > +// in Qt's V4 engine which can provoke a crash in certain of our scripts. > +qputenv("QV4_FORCE_INTERPRETER", QByteArrayLiteral("1")); Please

D8577: Fix: Missing dependencies for ktexeditor autotests

kfunk added a comment. In https://phabricator.kde.org/D8577#164815, @cullmann wrote: > Could you just remove the problematic includes and try to compile without the dependency, IMHO I see no use of QtScript stuff. Done with: https://phabricator.kde.org/R39:631b1447c97f1d81de2e81d

D11193: Sonnet : use current hunspell API

kfunk added a comment. Please see concerns on https://phabricator.kde.org/R246:0a96acf251baa5c9dd042d093ab2bf8fcee10502 REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D11193 To: rjvbb, #frameworks, dfaure, mlaurent, vkrause Cc: kfunk, kde-frameworks-devel, michaelh,

D14987: hunspell: Restore build with hunspell <=v1.5.0

kfunk created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kfunk requested review of this revision. REVISION SUMMARY Commit 0a96acf251baa5c9dd042d093ab2bf8fcee10502

D14987: hunspell: Restore build with hunspell <=v1.5.0

kfunk added reviewers: rjvbb, dfaure, mlaurent. REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D14987 To: kfunk, rjvbb, dfaure, mlaurent Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14987: hunspell: Restore build with hunspell <=v1.5.0

kfunk added inline comments. INLINE COMMENTS > dfaure wrote in hunspelldict.cpp:130 > lst.reserve(nbWord); Note: That's just old/copied code. Unlikely to be called on recent distros anyway. REPOSITORY R246 Sonnet BRANCH master REVISION DETAIL https://phabricator.kde.org/D14987 To: kfu

<    1   2   3   4   5   6   >