sebas requested changes to this revision.
sebas added a comment.
This revision now requires changes to proceed.
I second that the icon should be made red, this mitigates the visibility
issue and makes it consistent with the disconnected ethernet icon. @andreask,
can you make this change?
REP
sebas added a comment.
Restricted Application edited projects, added Plasma on Wayland; removed Plasma.
Dingdong?
REPOSITORY
R127 KWayland
BRANCH
supported-transformations
REVISION DETAIL
https://phabricator.kde.org/D8652
To: graesslin, #frameworks, #kwin, #plasma, sebas, davidedmunds
sebas accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R290 KPackage
BRANCH
packagefix
REVISION DETAIL
https://phabricator.kde.org/D9335
To: mart, #plasma, sebas
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg,
sebas accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R242 Plasma Framework (Library)
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D9108
To: apol, #plasma, #frameworks, sebas
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, je
sebas accepted this revision.
sebas added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> outputdevice.h:244
> + * @returns The transformations supported on this OutputDevice
> + * @since 5.XX
> + * @see supportedTransformationAdded
5.40 I guess :)
sebas added a comment.
FWIW, I tested it, it fixes kwin crashing when adding a setApplied() call on
the OutputConfiguration, and it also means the applied signal arrives.
REPOSITORY
R127 KWayland
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D7898
To: davidedmundson, #pla
sebas accepted this revision.
sebas added a comment.
This revision is now accepted and ready to land.
Yes, the initial idea was to send applied() to all connected resources. That
is not s_allResources, so your patch is correct. The resources that are
actually bound are not currently tracked.
sebas accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R127 KWayland
BRANCH
send-leave-pointer-surface
REVISION DETAIL
https://phabricator.kde.org/D6754
To: graesslin, #plasma, #frameworks, sebas
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-moha
On dinsdag 11 juli 2017 13:41:17 CEST Harald Sitter wrote:
> I was wondering if anyone had an opinion on extending kaboutlicense
> with a ::spdxId() instance method returning the license's spdx id [1].
>
> Use case at hand is kpackagetool, which maps X-KDE-PluginInfo-License
> of (e.g.) plasma app
On dinsdag 4 juli 2017 17:55:01 CEST René J.V. Bertin wrote:
> Me neither for myself, I'm happy with how my QtCurve theme looks but I'm
> also trying to improve the way KDE software looks using the native style.
The frame in my understanding is old weight, and can go (do check with the VDG
though
ry for the noise!
> On ds., jul. 1, 2017 at 9:02, Sebastian Kügler
> wrote:
>
> On vrijdag 30 juni 2017 23:16:49 CEST Albert Astals Cid wrote:
> > What happened to the "no new strings after the first two weeks" rule?
>
> Kirigami doesn't have any tra
On vrijdag 30 juni 2017 23:16:49 CEST Albert Astals Cid wrote:
> What happened to the "no new strings after the first two weeks" rule?
Kirigami doesn't have any translatable strings.
--
sebas
http://www.kde.org | http://vizZzion.org
On dinsdag 20 juni 2017 16:10:59 CEST René J.V. Bertin wrote:
> So where do those icons come from, and why are some applications immune?
> Pointers highly appreciated!
A screenshot says more than a thousand words... :)
--
sebas
http://www.kde.org | http://vizZzion.org
sebas added a comment.
I like this, and I'll likely need it in my kscreen OSD code aswell
(positioning there is unreliable, and my best guess is that this is the exact
same problem @mart is trying to solve here).
+1
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https:/
sebas closed this revision.
sebas added a comment.
Issue has been fixed elsewhere, otherwise code is submitted.
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D5747
To: sebas, #plasma, hein, graesslin
Cc: apol, davidedmundson, plasma-devel, #frameworks, ZrenBot, sps
sebas abandoned this revision.
sebas added a comment.
Okay, thanks David.
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D5872
To: sebas, #plasma, hein, davidedmundson
Cc: graesslin, bshah, davidedmundson, plasma-devel, #frameworks, ZrenBot,
spstarr, progwolff, les
sebas added a comment.
Possibly, in this case, I disagree. The pid is initially unknown set to in
the client, and can change afterwards. In reality, the pid of the window
doesn't change, but it can still be set after being initially 0. In fact, it
has to be.
In the end, I don't care muc
sebas requested review of this revision.
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D5872
To: sebas, #plasma, hein, davidedmundson
Cc: bshah, davidedmundson, plasma-devel, #frameworks, ZrenBot, spstarr,
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, el
sebas added a comment.
What's d581?
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D5872
To: sebas, #plasma, hein, davidedmundson
Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, spstarr, progwolff,
lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, se
sebas created this revision.
Restricted Application added projects: Plasma on Wayland, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
REVISION SUMMARY
Eike removed this, but I'm not sure why. All other roles trigger
datachanged, so I don't see why pid shouldn't
This revision was automatically updated to reflect the committed changes.
Closed by commit R127:0b4d8a7fc1df: add pid to plasma window management
protocol (authored by sebas).
REPOSITORY
R127 KWayland
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5747?vs=14442&id=14463
REVISION DET
sebas updated this revision to Diff 14442.
sebas added a comment.
Restricted Application edited projects, added Plasma on Wayland; removed Plasma.
- Update docs: the pid is just set, but doesn't logically change
- ws--
REPOSITORY
R127 KWayland
CHANGES SINCE LAST UPDATE
https://phabricat
sebas updated this revision to Diff 14418.
sebas added a comment.
Restricted Application edited projects, added Plasma; removed Plasma on Wayland.
- Drop pid change handling in the model code
- Extend model test
--Eike on sebas' box
REPOSITORY
R127 KWayland
CHANGES SINCE LAST UPDATE
sebas updated this revision to Diff 14410.
sebas added a comment.
Restricted Application edited projects, added Plasma on Wayland; removed Plasma.
- also test default
REPOSITORY
R127 KWayland
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5747?vs=14407&id=14410
BRANCH
sebas/pro
sebas updated this revision to Diff 14407.
sebas marked 3 inline comments as done.
sebas added a comment.
Restricted Application edited projects, added Plasma; removed Plasma on Wayland.
Address review comments
- Minor corrections in docs
- Use uint for the pid
- uint32 for pids instea
sebas added a comment.
Adding it to https://phabricator.kde.org/D5747 for merge simplicity. @hein
please abandon.
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D5812
To: hein, #plasma, sebas, graesslin
Cc: plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, le
sebas created this revision.
Restricted Application added projects: Plasma on Wayland, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
REVISION SUMMARY
This patch adds a pid event to the plasma window management protocol. It
allows the compositor to tell allow a
sebas accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R242 Plasma Framework (Library)
BRANCH
phab/useplasmatheme
REVISION DETAIL
https://phabricator.kde.org/D5721
To: mart, #plasma, sebas
Cc: plasma-devel, #frameworks, spstarr, progwolff, Zren, lesliezh
sebas accepted this revision.
sebas added a comment.
This revision is now accepted and ready to land.
Almost good, you can add the signalspy and then ship it from my side.
INLINE COMMENTS
> iconitemtest.cpp:526
> +
> +item->setProperty("roundToIconSize", false);
> +
Might as well check f
sebas added a comment.
I like it. If kbroulik is happy, consider that a +1 from me, too.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D4831
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: davidedmundson, #pla
sebas requested changes to this revision.
sebas added a comment.
This revision now requires changes to proceed.
I think a problem with using roundToIconSize as isolated property is that it
really isn't. It has intended effects on the sizing of the item, but the
current version of the patch do
sebas accepted this revision.
sebas added a reviewer: sebas.
This revision is now accepted and ready to land.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D4572
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: bro
On Saturday, February 11, 2017 7:24:11 AM UTC Martin Gräßlin wrote:
> What I don't like in general is that this is all happening as $user.
> Thus any malicious program running as $user can also just change the
> list of trusted Exec= values.
>
> So my suggestion is: let's use polkit.
>
> The list
...
- Sebastian Kügler
On Feb. 26, 2015, 7:44 p.m., Alex Richardson wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.
nd project-specific board with just the relevant tasks, for example.
--
sebas
Sebastian Kügler•http://vizZzion.org•http://www.kde.org
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129607/#review101330
---
Ship it!
Ship It!
- Sebastian Kügler
On Dec. 7, 2016
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129588/#review101296
---
Ship it!
Ship It!
- Sebastian Kügler
On Nov. 29, 2016
ation you're introducing
with this patch: The version number is now on the screen two times when you
open the versions tab, and also, why have a versions tab, when the version is
already displayed.
- Sebastian Kügler
On Dec. 3, 2016, 12:51 p.m., Jean-Baptiste Mard
, so it doesn't exactly hide the error.
Diffs
-
kde-modules/KDETemplateMacro.cmake 796c3f1
Diff: https://git.reviewboard.kde.org/r/126226/diff/
Testing
---
Installed templates/ from plasma-framework, this patch makes them work in
kapptemplate.
Thanks,
Sebastian Kügler
marked as submitted.
Review request for KDE Frameworks.
Changes
---
Submitted with commit 04389b36653b2d0df8a3ac2fc62bafa1b86e by Sebastian
Kügler to branch master.
Repository: frameworkintegration
Description
---
The new appstream kpackage handler needs to link Qt DBus, but
Description
---
The new appstream kpackage handler needs to link Qt DBus, but the find package
call is missing.
Diffs
-
CMakeLists.txt e97e698
Diff: https://git.reviewboard.kde.org/r/129598/diff/
Testing
---
Builds and works on my machine
Thanks,
Sebastian Kügler
sebas accepted this revision.
sebas added a reviewer: sebas.
This revision is now accepted and ready to land.
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D3314
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: apol, #frameworks, sebas
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129118/#review99839
---
Ship it!
Ship It!
- Sebastian Kügler
On Oct. 7, 2016
!
- Sebastian Kügler
On Aug. 23, 2016, 2:43 p.m., Marco Martin wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128641/#review98253
---
Ship it!
Ship It!
- Sebastian Kügler
On Aug. 9, 2016
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128640/#review98252
---
Ship it!
Ship It!
- Sebastian Kügler
On Aug. 9, 2016
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128594/#review98138
---
Ship it!
Ship It!
- Sebastian Kügler
On Aug. 3, 2016
> On July 18, 2016, 12:05 p.m., Sebastian Kügler wrote:
> > Please don't ship it, yet.
> >
> >
> > I find the UI illogical. There's a groupbox grouping the checksum buttons,
> > but then you can input the checksum above, so essentially, the
> On July 18, 2016, 12:05 p.m., Sebastian Kügler wrote:
> > Please don't ship it, yet.
> >
> >
> > I find the UI illogical. There's a groupbox grouping the checksum buttons,
> > but then you can input the checksum above, so essentially, the
> On July 18, 2016, 12:05 p.m., Sebastian Kügler wrote:
> > Please don't ship it, yet.
> >
> >
> > I find the UI illogical. There's a groupbox grouping the checksum buttons,
> > but then you can input the checksum above, so essentially, the
> On July 18, 2016, 12:05 p.m., Sebastian Kügler wrote:
> > Please don't ship it, yet.
> >
> >
> > I find the UI illogical. There's a groupbox grouping the checksum buttons,
> > but then you can input the checksum above, so essentially, the
> On July 18, 2016, 12:05 p.m., Sebastian Kügler wrote:
> > Please don't ship it, yet.
> >
> >
> > I find the UI illogical. There's a groupbox grouping the checksum buttons,
> > but then you can input the checksum above, so essentially, the
> On July 18, 2016, 12:05 p.m., Sebastian Kügler wrote:
> > Please don't ship it, yet.
> >
> >
> > I find the UI illogical. There's a groupbox grouping the checksum buttons,
> > but then you can input the checksum above, so essentially, the
> On July 18, 2016, 12:05 p.m., Sebastian Kügler wrote:
> > Please don't ship it, yet.
> >
> >
> > I find the UI illogical. There's a groupbox grouping the checksum buttons,
> > but then you can input the checksum above, so essentially, the
ot providing any semantic value.
A usability reviewer should have a look.
- Sebastian Kügler
On July 16, 2016, 12:35 p.m., Elvis Angelaccio wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> htt
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128085/#review96263
---
Ship it!
- Sebastian Kügler
On June 3, 2016, 12:15 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127870/#review95815
---
Ship it!
ping :)
- Sebastian Kügler
On May 8, 2016, 4
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127842/#review95200
---
Ship it!
Ship It!
- Sebastian Kügler
On May 5, 2016, 9
> On May 2, 2016, 1:17 p.m., Sebastian Kügler wrote:
> > src/kiconloader.cpp, line 869
> > <https://git.reviewboard.kde.org/r/127779/diff/9/?file=461529#file461529line869>
> >
> > Where does this one get deleted?
>
> Marco Martin wrote:
> it&#
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127819/#review95139
---
Ship it!
Ship It!
- Sebastian Kügler
On May 3, 2016, 6
> On May 2, 2016, 1:09 p.m., Sebastian Kügler wrote:
> > Okay, let's try this in master and see if it's going to cause problems.
>
> Kai Uwe Broulik wrote:
> Beware this is frameworks and the next frameworks release will be
> upcoming Saturday
>
> Marc
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127810/#review95079
---
Ship it!
- Sebastian Kügler
On May 1, 2016, 8:32 p.m
pp (line 292)
<https://git.reviewboard.kde.org/r/127779/#comment64523>
text (lower case), perhaps @see the colors that are available?
src/kiconloader.cpp (line 869)
<https://git.reviewboard.kde.org/r/127779/#comment64525>
Where does this one get deleted?
- Sebastian Kügler
it's going to cause problems.
- Sebastian Kügler
On April 29, 2016, 9:25 a.m., Marco Martin wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.review
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127602/#review94373
---
Ship it!
Ship It!
- Sebastian Kügler
On April 7, 2016
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127405/#review93652
---
Ship it!
Ship It!
- Sebastian Kügler
On March 17, 2016
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127418/#review93685
---
Ship it!
Ship It!
- Sebastian Kügler
On March 18, 2016
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127345/#review93447
---
Ship it!
Ship It!
- Sebastian Kügler
On March 12, 2016
this approach, the code is fine and good to go.
src/plasma/private/packages.cpp (line 46)
<https://git.reviewboard.kde.org/r/127345/#comment63705>
I'd just go for test.qml or perhaps even autotest.qml
- Sebastian Kügler
On March 12, 2016, 12:29 a.m., Aleix Pol Gon
src/plasmaquick/appletquickitem.h (line 129)
<https://git.reviewboard.kde.org/r/127345/#comment63682>
teh mistake!
src/plasmaquick/appletquickitem.cpp (line 652)
<https://git.reviewboard.kde.org/r/127345/#comment63683>
{ } also for single lines
- Sebastian Kügler
On Ma
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127090/#review92744
---
Ship it!
Ship It!
- Sebastian Kügler
On Feb. 16, 2016
7;d be good enough IMO to break out of
the loop after like 8 icons.
- Sebastian Kügler
On Jan. 21, 2016, 2:26 p.m., David Rosca wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.revie
> On Jan. 21, 2016, 11:10 a.m., Sebastian Kügler wrote:
> > src/qmlcontrols/draganddrop/DeclarativeDragArea.cpp, line 390
> > <https://git.reviewboard.kde.org/r/126804/diff/1/?file=434496#file434496line390>
> >
> > Q_FOREACH and const&
>
> David R
> On Jan. 21, 2016, 11:10 a.m., Sebastian Kügler wrote:
> > src/qmlcontrols/draganddrop/DeclarativeDragArea.cpp, line 395
> > <https://git.reviewboard.kde.org/r/126804/diff/1/?file=434496#file434496line395>
> >
> > DPI-dependent, could be shared with
> On Jan. 21, 2016, 11:10 a.m., Sebastian Kügler wrote:
> > src/qmlcontrols/draganddrop/DeclarativeDragArea.cpp, line 311
> > <https://git.reviewboard.kde.org/r/126804/diff/1/?file=434496#file434496line311>
> >
> > So this means that we either pass a
git.reviewboard.kde.org/r/126804/#comment62476>
Q_FOREACH and const&
src/qmlcontrols/draganddrop/DeclarativeDragArea.cpp (line 321)
<https://git.reviewboard.kde.org/r/126804/#comment62477>
DPI-dependent, could be shared with the above
- Sebastian Kügler
On Ja
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126806/#review91340
---
Ship it!
Ship It!
- Sebastian Kügler
On Jan. 18, 2016
't think it's a problem having non-optimized svgs in git, but we
> should provide users whatever is easier to execute when we release.
>
> Sebastian Kügler wrote:
> If we run this only on releases, it means that typically no developer
> uses the final result of the ic
> On Jan. 14, 2016, 12:22 p.m., andreas kainz wrote:
> > I have no problems to optimzie the svg files BUT my problem with the svg
> > files is that they become more complex all the time last time the
> > stylesheet, now optimization,
> >
> > I love scripts BUT it would be awesome for us t
> On Jan. 14, 2016, 10:27 a.m., Marco Martin wrote:
> > does the svg stuff still workk?
> > this script goes well together the others i have (only in plasma-framework
> > atm) to remove the hardcoded colors inkscape likes to put even when an
> > element is using the stylesheet and the one to re
On Wednesday, January 13, 2016 12:33:36 AM David Faure wrote:
> The question is: this would only depend on KIOCore and QImage. Shall I put
> it in KIOWidgets or shall I create a new KIOGui library, for QML apps to
> avoid the QWidget dependency ?
I'd use this in the angelfish (experimental) webbro
> On Jan. 11, 2016, 12:38 p.m., Sebastian Kügler wrote:
> > autotests/coronatest.cpp, line 215
> > <https://git.reviewboard.kde.org/r/126672/diff/1/?file=429035#file429035line215>
> >
> > Do we really not want the C++11 for here? If we don't, I'd p
ant to pass by ref here?
src/declarativeimports/core/corebindingsplugin.cpp (line 77)
<https://git.reviewboard.kde.org/r/126672/#comment62097>
QString()?
src/declarativeimports/core/units.cpp (line 36)
<https://git.reviewboard.kde.org/r/126672/#comment62098>
What's the
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126632/#review90879
---
+1 from me, too.
- Sebastian Kügler
On Jan. 5, 2016, 11:16
> On Jan. 7, 2016, 3:31 p.m., Sebastian Kügler wrote:
> > src/kpackage/packageloader.cpp, line 190
> > <https://git.reviewboard.kde.org/r/126660/diff/1/?file=428735#file428735line190>
> >
> > What does the category have to do with this? We should only be goin
(But also can't judge if it's
obviously right.)
Given the possible impact, I'd say go for it.
- Sebastian Kügler
On Dec. 23, 2015, 10:46 p.m., Ralf Habacker wrote:
>
> ---
> This is an automatically generated e-m
The kpart.desktop file that KTextEditor was looking for is in
> /share/kservicetypes5/.
>
> I added AppLocalData to get the path which is normally
> "/bin/" for KDE aplications. I could also live with
> KDE_INSTALL_FULL_KSERVICETYPES5DIR, but generally I would try to avoid
> absolute pat
> On Jan. 3, 2016, 3:22 p.m., Alex Richardson wrote:
> > According to the documentation AppLocalDataLocation is the following:
> > "C:/Users//AppData/Local/", "C:/ProgramData/",
> > "", "/data"
> >
> > In which directory are the desktop files? Unfortunately I can't check as my
> > Windows mac
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126348/#review90302
---
Ship it!
Ship It!
- Sebastian Kügler
On Dec. 15, 2015, 3
good to have documented. (Is that
even English?) But then, where?
- Sebastian Kügler
On Dec. 22, 2015, 2:14 p.m., David Edmundson wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126418/#review89816
---
Ship it!
Ship It!
- Sebastian Kügler
On Dec. 18, 2015, 6
ce he maintains knotifications.
- Sebastian Kügler
On Dec. 15, 2015, 7:44 p.m., René J.V. Bertin wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard
> On Dec. 14, 2015, 9:50 p.m., Sebastian Kügler wrote:
> > src/kpackage/private/packagejobthread.cpp, line 189
> > <https://git.reviewboard.kde.org/r/126348/diff/1/?file=422766#file422766line189>
> >
> > Why this change?
>
> Aleix Pol Gonzalez wrote:
aggressive.
src/lib/plugin/kpluginmetadata.cpp (line 68)
<https://git.reviewboard.kde.org/r/126366/#comment61279>
I don't like the assert here. It may be third party data, and we're
crashing the application then?
- Sebastian Kügler
On Dec. 15, 2015, 3:04 p.m., Aleix Po
he additionally include in
its user).
src/kpackage/private/packages.cpp (line 57)
<https://git.reviewboard.kde.org/r/126348/#comment61257>
Fix spelling of "Fuck" and make it a fatal error? ;)
- Sebastian Kügler
On Dec. 14, 2015, 5:11 p.m., Aleix Pol Gonzalez wrote:
iewer. (If no one steps up
within a week or so, please ship it.)
src/lib/kaboutdata.cpp (line 823)
<https://git.reviewboard.kde.org/r/126343/#comment61232>
Unrelated, but doesn't match what we define as "KDE" anymore.
- Sebastian Kügler
On Dec. 14, 2015, 11:45 a
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126320/#review89469
---
Ship it!
What Alex says, and ship it. :)
- Sebastian Kügler
On Friday, December 11, 2015 08:09:25 PM René J. V. Bertin wrote:
> And I see there is the platform-specific issue with the tray menu's title
> item:
>
> titleAction = m->addSection(qApp->windowIcon(), title);
>
> will only add a separator on platforms that don't support texted separators
> (bas
On Friday, December 11, 2015 12:19:51 PM René J.V. Bertin wrote:
> Does KF5 provide any classes above Qt's for putting up and controlling an
> icon (with/out menu) in the "system tray"? If so, is there a simple test
> app I can try?
>
> Reason I'm asking: kwalletmanager5 isn't showing a systray in
102)
<https://git.reviewboard.kde.org/r/126246/#comment61112>
ws (just because RB makes it totally red)
autotests/packagestructuretest.cpp (line 108)
<https://git.reviewboard.kde.org/r/126246/#comment61113>
seems unnecessary?
- Sebastian Kügler
On Dec. 4, 2015, 6:23
1 - 100 of 467 matches
Mail list logo
