D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

feverfew created this revision. feverfew added reviewers: fvogt, chinmoyr. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. feverfew requested review of this revision. TEST PLAN Make sure kded module is installed and loaded. Use dolphin and observe that when

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

davidedmundson added a comment. How does kio-fuse know when to unmount? INLINE COMMENTS > krun.cpp:529 > +// Lets try a KIOFuse mount instead. > +QDBusInterface > kiofused(QStringLiteral("org.kde.kded5"), > +

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

feverfew updated this revision to Diff 68931. feverfew added a comment. - Switch from KDED module to DBus service REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23384?vs=64440&id=68931 BRANCH KDEDModule (branched from master) REVISION DETAIL https://phabr

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

feverfew updated this revision to Diff 69201. feverfew added a comment. Don't use KIOFuse with mtp/gdrive REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23384?vs=68931&id=69201 BRANCH KDEDModule (branched from master) REVISION DETAIL https://phabricator.k

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

feverfew edited the summary of this revision. feverfew edited the test plan for this revision. feverfew edited reviewers, added: davidedmundson, dfaure, ngraham; removed: chinmoyr. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D23384 To: feverfew, fvogt, davidedmundson, df

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

feverfew added a comment. @dfaure Just to give you a bit of context. KIOFuse is about to enter KDE Review, but at the same time, KIOFuse is most useful when integrated to KIO via this patch. So we'd like to get this reviewed early to save a bit of effort; instead of getting it passed KDE Rev

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

sitter added inline comments. INLINE COMMENTS > desktopexecparser.cpp:314 > +org::kde::KIOFuse kiofuse_iface(QStringLiteral("org.kde.KIOFuse"), > +QStringLiteral("/org/kde/KIOFuse"), > +QDBusConnection::sessionBus()); align argu

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

feverfew updated this revision to Diff 69769. feverfew added a comment. - Align function arguments - Remove hack - Get rid of iterator REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23384?vs=69201&id=69769 BRANCH KDEDModule (branched from master) REVISI

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

feverfew updated this revision to Diff 69774. feverfew added a comment. - Get rid of unnecessary copying of URLs - Switch to interface generated at compile time - Delete unused interfaces - Merge branch 'master' into arcpatch-D23384 - remove kiofuseinterface from build REPOSITORY R24

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

feverfew marked 8 inline comments as done. feverfew added inline comments. INLINE COMMENTS > sitter wrote in desktopexecparser.cpp:317 > There's nothing wrong with this. But wouldn't using > `QHash, QUrl>` make for easier to read code all in > all since you don't have to mess with pairs? > > A

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

feverfew updated this revision to Diff 69788. feverfew added a comment. - Align arguments REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23384?vs=69774&id=69788 BRANCH arcpatch-D23384 REVISION DETAIL https://phabricator.kde.org/D23384 AFFECTED FILES sr

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

sitter added a comment. some style complaints. Looks great other than that 👍 INLINE COMMENTS > krun.cpp:583 > +const QUrl url = urls[i]; > +if (KIO::DesktopExecParser::isProtocolInSupportedList(url, > appSupportedProtocols)) > +continue; Coding style

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

feverfew added inline comments. INLINE COMMENTS > sitter wrote in krun.cpp:583 > Coding style says we use curly braces even for single-line if statements I > think. Yep you're right, will fix in a mo. > sitter wrote in krun.cpp:598 > What I meant is you should literally iterate using > > fo

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

sitter added inline comments. INLINE COMMENTS > feverfew wrote in krun.cpp:598 > Yes, but note later I need to then change the values in the `QList` outside > of the for loop, hence why I store the index in a struct associated with the > reply. How would I do that easily with a range based for

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

feverfew added inline comments. INLINE COMMENTS > sitter wrote in krun.cpp:598 > So did the old code though. See old line 584. > > It's iterating by-reference, so you can simply assign to it via > > https://doc.qt.io/qt-5/qurl.html#operator-eq-1 > > to change the content of the QUrl object (no

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

sitter added inline comments. INLINE COMMENTS > feverfew wrote in krun.cpp:598 > That's within the same loop though? > > I explicitly want to change the QUrl in that list, so that I can simply > return the same list without having to do a copy of it all. > > I can't get this to work. I need to

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

feverfew edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D23384 To: feverfew, fvogt, davidedmundson, dfaure, ngraham Cc: sitter, davidedmundson, kde-frameworks-devel, ngraham, LeGast00n, GB_2, michaelh, bruns

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

ngraham edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D23384 To: feverfew, fvogt, davidedmundson, dfaure, ngraham Cc: sitter, davidedmundson, kde-frameworks-devel, ngraham, LeGast00n, GB_2, michaelh, bruns

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. I tested this today with a variety of files on a Windows Samba share with fairly slow 6 Mb/sec bandwidth and it's almost perfect for all files and use cases. However I ran into

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

fvogt added a comment. **Issue #1:** That happens because the .desktop file sets `X-KDE-Protocols=ftp,http,https,mms,rtmp,rtsp,sftp,smb`: https://code.videolan.org/videolan/vlc/blob/master/share/vlc.desktop.in#L124 **Issue #2:** The only explanation I have for that is that tot

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

ngraham added a comment. In D23384#569645 , @fvogt wrote: > **Issue #1:** > > That happens because the .desktop file sets `X-KDE-Protocols=ftp,http,https,mms,rtmp,rtsp,sftp,smb`: > https://code.videolan.org/videolan/vlc/blob/master/share/

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

feverfew added a comment. In D23384#569926 , @ngraham wrote: > In D23384#569645 , @fvogt wrote: > > > **Issue #1:** > > > > That happens because the .desktop file sets `X-KDE-Protocols=ftp,http,h

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

ngraham added a comment. In D23384#569929 , @feverfew wrote: > This isn't reaching KIOFuse at all. I believe this is related to this bug and that you've also blogged about: > https://bugs.kde.org/show_bug.cgi?id=330192 > https://pointiestst

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

ngraham added a comment. I just found that Totem has a "Show Containing Folder" feature. If I use it, it shows me that the video file is in fact being opened from the FUSE mount path! So that's good. But it still insists on downloading the whole thing locally before it starts to play it. Whe

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

This revision was not accepted when it landed; it landed in state "Needs Revision". This revision was automatically updated to reflect the committed changes. Closed by commit R241:92c2886c3714: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use… (authored by feverfew).

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

feverfew updated this revision to Diff 70661. feverfew added a comment. - Get rid of unnecessary copying of URLs - Switch to interface generated at compile time - Delete unused interfaces - Merge branch 'master' into arcpatch-D23384 - remove kiofuseinterface from build - Align argumen

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

feverfew reopened this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D23384 To: feverfew, fvogt, davidedmundson, dfaure, ngraham Cc: sitter, davidedmundson, kde-frameworks-devel, ngraham, LeGast00n, GB_2, michaelh, bruns

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

fvogt added a comment. Unfortunately the `kio-fuse -d` output is incomplete, probably because Qt was too smart and logged to the journal instead... It's visible that there are multiple processes reading the file, maybe thumbnailing is in progress? Can you try with thumbnails in dolphin di

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

feverfew added a comment. In D23384#570016 , @ngraham wrote: > In D23384#569929 , @feverfew wrote: > > > This isn't reaching KIOFuse at all. I believe this is related to this bug and that you've als

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

dfaure added a comment. @ngraham AFAIK gnome has a trick where a fuse mount is created, its path is passed to the application being started, and the application, if it supports gvfs, re-translates that into a URL and uses that instead if it makes more sense. This way "dumb" apps get a local

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

ngraham added a comment. In D23384#570118 , @fvogt wrote: > Please try both of the following: Done. Here are the log files: F7793378: kio-fuse.log F7793379: strace output.log

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

ngraham added a comment. In D23384#570119 , @feverfew wrote: > In D23384#570016 , @ngraham wrote: > > > In D23384#569929 , @feverfew wrote: > > > > > T

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

ngraham added a comment. In D23384#570125 , @dfaure wrote: > @ngraham AFAIK gnome has a trick where a fuse mount is created, its path is passed to the application being started, and the application, if it supports gvfs, re-translates that into a

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

feverfew added a comment. In D23384#570349 , @ngraham wrote: > In D23384#570125 , @dfaure wrote: > > > @ngraham AFAIK gnome has a trick where a fuse mount is created, its path is passed to the applic

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

feverfew added a comment. In D23384#570347 , @ngraham wrote: > In D23384#570119 , @feverfew wrote: > > > In D23384#570016 , @ngraham wrote: > > > > > I

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

broulik added a comment. It appears to open everything remote through kiofuse. - Click a text file in `sftp://foo/bar` will kiofuse it and then open it in Kate - Clicking a http link in my chat app now kiofuses it and then has the browser desperately try to open `/run/user/1000/kio-fus

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

fvogt added a comment. > Clicking a http link in my chat app now kiofuses it and then has the browser desperately try to open /run/user/1000/kio-fuse-bla/http/kde.org/ - it only gets the first character in the file, so I usually just see < for a HTML page Ignoring the elephant in the ro

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

fvogt added a comment. In D23384#570331 , @ngraham wrote: > In D23384#570118 , @fvogt wrote: > > > Please try both of the following: > > > Done. Here are the log files: > > F7793378: kio-fus

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

ngraham added a comment. In D23384#570735 , @fvogt wrote: > > Clicking a http link in my chat app now kiofuses it and then has the browser desperately try to open /run/user/1000/kio-fuse-bla/http/kde.org/ - it only gets the first character in th

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

fvogt added a comment. In D23384#570830 , @ngraham wrote: > In D23384#570735 , @fvogt wrote: > > > > Clicking a http link in my chat app now kiofuses it and then has the browser desperately try to op

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

ngraham added a comment. @feverfew thanks for rebasing https://invent.kde.org/kde/kio-fuse/merge_requests/2. I've tested it and confirmed that it fixes case #2! We can continue that portion of the view in the comments there. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.o

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

feverfew updated this revision to Diff 70773. feverfew added a comment. Check for password instead of authority REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23384?vs=70661&id=70773 BRANCH arcpatch-D23384 REVISION DETAIL https://phabricator.kde.org/D2338

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

ngraham added a comment. This latest change made Totem work, but broke VLC and SMplayer for my password-protected Samba share. See the comment I left on https://invent.kde.org/kde/kio-fuse/merge_requests/2#note_19607. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D2338

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

feverfew updated this revision to Diff 70799. feverfew added a comment. Chek for userInfo instead of just password REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23384?vs=70773&id=70799 BRANCH arcpatch-D23384 REVISION DETAIL https://phabricator.kde.org/D2

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

ngraham added a comment. I'm afraid that even with that change, the issue is still present. I honestly don't think it would be the worst thing in the world if we always handed the kio-fuse paths to apps that don't use ioslaves. My impression is that the few apps that have implemented their o

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

fvogt added a comment. In D23384#571276 , @ngraham wrote: > I'm afraid that even with that change, the issue is still present. I honestly don't think it would be the worst thing in the world if we always handed the kio-fuse paths to apps that do

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

sitter added a comment. I haven't read everything in great detail... but... Quick braindump of musing I did elsewhere: as far as credential hand-over is concerned this is likely a problem that needs a workaround for now as there is no clear cut solution that I am aware of. It may be wort

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

feverfew updated this revision to Diff 70823. feverfew added a comment. Convert KIO URLs to KIOFuse URL is app is not KIO-enabled. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23384?vs=70799&id=70823 BRANCH arcpatch-D23384 REVISION DETAIL https://phabri

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

feverfew added a comment. In D23384#571358 , @fvogt wrote: > In D23384#571276 , @ngraham wrote: > > > I'm afraid that even with that change, the issue is still present. I honestly don't think it wou

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

ngraham added a comment. With the latest version of this patch, now every file always gets downloaded through kioexec on my password-protected Samba share; nothing ever gets the kio-fuse path. In fact the share never gets mounted at all when I try to open something on the share in a non-KDE

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

feverfew updated this revision to Diff 70830. feverfew added a comment. ignore scheme handler REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23384?vs=70823&id=70830 BRANCH arcpatch-D23384 REVISION DETAIL https://phabricator.kde.org/D23384 AFFECTED FILES

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

ngraham added a comment. Okay, that fixed it for the case of opening files in non-KDE apps on my Samba share. Now they open from the FUSE path--all of them! So this is good. However now kioexec downloads http URLs opened from other apps instead of just passing them off to the browser. :(

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

feverfew added a comment. So before this patch we had the following behaviour: 1. If app is KIO-enabled, pass URLs unchanged. 2. else for each URL, if app claims to support the protocol pass the original URL, otherwise change the URL to the corresponding KIOExec path. This causes a

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

ngraham added a comment. Thanks for that very clear and understandable synopsis. I'll let others figure out the best path forward. :) REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D23384 To: feverfew, fvogt, davidedmundson, dfaure, ngraham Cc: broulik, sitter, davidedm

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

feverfew updated this revision to Diff 70866. feverfew added a comment. don't send http(s) to kioexec REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23384?vs=70830&id=70866 BRANCH arcpatch-D23384 REVISION DETAIL https://phabricator.kde.org/D23384 AFFECTE

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

feverfew edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D23384 To: feverfew, fvogt, davidedmundson, dfaure, ngraham Cc: broulik, sitter, davidedmundson, kde-frameworks-devel, ngraham, LeGast00n, GB_2, michaelh, bruns

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. All issues are fixed now for me! It works perfectly!🎉🎉 REPOSITORY R241 KIO BRANCH arcpatch-D23384 REVISION DETAIL https://phabricator.kde.org/D23384 To: feverfew, fvogt, davidedmu

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. OK, please give me a day or two to review this, it shouldn't go in before Saturday anyway so we have one month of testing in git before release REPOSITORY R241 KIO REVISION DET

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

davidedmundson added a comment. If something is ready for full code review, can we remove "WIP:" from the title. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D23384 To: feverfew, fvogt, davidedmundson, dfaure, ngraham Cc: alexde, broulik, sitter, davidedmundson, kde-f

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

broulik added a comment. Can you please move the DBus XML file in a common location REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D23384 To: feverfew, fvogt, davidedmundson, dfaure, ngraham Cc: alexde, broulik, sitter, davidedmundson, kde-frameworks-devel, ngraham, LeG

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

ngraham added a comment. I just tested writing today, for files opened in 3rd-party apps that get the FUSE mount path. Results: - Gedit: everything works - Blender: everything works - Inkscape: though the file is very small, the save operation is somewhat slow, but everything works

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

fvogt added a comment. In D23384#572198 , @ngraham wrote: > I just tested writing today, for files opened in 3rd-party apps that get the FUSE mount path. Results: > ... Was that with or without the KIO::open merge request? REPOSITORY

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

ngraham added a comment. In D23384#572199 , @fvogt wrote: > Was that with or without the KIO::open merge request? With. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D23384 To: feverfew, fvogt, davidedmundson, dfau

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

feverfew added a comment. Issues with KIOFuse itself should be opened up as an issue, or as a reply to the MR that is being tested; this differential only concerns communication between the KIOFuse mount and KIO itself. In particular, if you could test writing with both master and FileJo

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

ngraham added a comment. Anyway I guess this patch itself is fine now and the remaining issues are elsewhere. :) REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D23384 To: feverfew, fvogt, davidedmundson, dfaure, ngraham Cc: alexde, broulik, sitter, davidedmundson, kde-f

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

ngraham added a comment. Sure, I'll file bugs in https://bugs.kde.org/describecomponents.cgi?product=kiofuse. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D23384 To: feverfew, fvogt, davidedmundson, dfaure, ngraham Cc: alexde, broulik, sitter, davidedmundson, kde-fram

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

ngraham added a comment. In fact both issues I found seem to be caused by !2. See https://invent.kde.org/kde/kio-fuse/merge_requests/2#note_19771. We can continue the discussion there. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D23384 To: feverfew, fvogt, davidedmu

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

dfaure added a comment. Why does KRun duplicate all of the (new) code from DesktopExecParser, when DesktopExecParser is actually a helper class for KRun? I would expect it to have solved all this already, unless I'm missing something about the various code paths. The code you changed in k

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

broulik added inline comments. INLINE COMMENTS > dfaure wrote in desktopexecparser.cpp:356 > This blocks. > > I don't mind much myself, but I know some people had a mandate to remove as > many blocking calls as possible from KRun and related code. Or was that only > avoiding blocking I/O becau

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

feverfew added a comment. Thanks for the reviews everyone! I'll update the diff and respond to the comments no later than Tuesday REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D23384 To: feverfew, fvogt, davidedmundson, dfaure, ngraham Cc: alexde, broulik, sitter, davi

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

dfaure added a comment. In D23384#571455 , @sitter wrote: > The opposite extreme is to always pass when X-KDE-Protocols is set and assume that the applications are actually working correctly (e.g. vlc ought to talk to kiod/KPasswdServerClient to

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

feverfew added a comment. In D23384#572363 , @dfaure wrote: > Why does KRun duplicate all of the (new) code from DesktopExecParser, when DesktopExecParser is actually a helper class for KRun? > I would expect it to have solved all this already

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

feverfew added inline comments. INLINE COMMENTS > dfaure wrote in desktopexecparser.cpp:323 > Could we have a kill switch for KIOFuse if it fails to work properly in some > release? > > E.g. some `export KIO_FUSE=0` or `export KIO_FUSE_DISABLE=1`. > Or a KConfig entry (use `KSharedConfig::openC

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

feverfew updated this revision to Diff 71423. feverfew added a comment. - Merge branch 'master' into arcpatch-D23384 - Address comments - Remove unnecessary mount requests in krun - Only use KIOFuse if password is empty REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricat

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

feverfew added a comment. On further looking, it seems like git grep doesn't really tell the full picture. It seems like `resultingArguments` is called before `resolveURLs` is, so I've simplified the diff as requested. INLINE COMMENTS > feverfew wrote in desktopexecparser.cpp:331 > From wha

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

feverfew marked 9 inline comments as done. feverfew added a comment. The current patch should be tested with latest kio-fuse master, as the blacklisting has been moved there to keep this patch clean. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D23384 To: feverfew, fv

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. For SMB shares I guess what can happen is that the URL doesn't have a username in it, but it still needs a password? IIRC there was no username in "old" samba (W95

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

feverfew added a comment. In D23384#577174 , @dfaure wrote: > For SMB shares I guess what can happen is that the URL doesn't have a username in it, but it still needs a password? IIRC there was no username in "old" samba (W95

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

feverfew updated this revision to Diff 71543. feverfew added a comment. - fix code style REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23384?vs=71423&id=71543 BRANCH arcpatch-D23384 REVISION DETAIL https://phabricator.kde.org/D23384 AFFECTED FILES src